31995 2009-11-30 12:58:17 -0800 [bzt] Generate pass messages for style-queue 2009-11-30 16:07:54 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric oldest_to_newest 167396 0 abarth 2009-11-30 12:58:17 -0800 As requested on webkit-dev. 167397 1 44037 abarth 2009-11-30 13:01:02 -0800 Created attachment 44037 Patch 167398 2 abarth 2009-11-30 13:05:27 -0800 style-queue ran check-webkit-style on attachment 44037 without any errors. 167452 3 44037 eric 2009-11-30 15:53:04 -0800 Comment on attachment 44037 Patch Where is the unit test? :) Otherwise LGTM... Would really like a test though. :) 167455 4 44037 abarth 2009-11-30 15:57:53 -0800 Comment on attachment 44037 Patch Yeah, testing is next on my list. I went a little hack-and-slash at the end to get the bot to a working state. 167458 5 44037 commit-queue 2009-11-30 16:07:49 -0800 Comment on attachment 44037 Patch Clearing flags on attachment: 44037 Committed r51518: <http://trac.webkit.org/changeset/51518> 167459 6 commit-queue 2009-11-30 16:07:54 -0800 All reviewed patches have been landed. Closing bug. 44037 2009-11-30 13:01:02 -0800 2009-11-30 16:07:49 -0800 Patch bug-31995-20091130130101.patch text/plain 4340 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAyNmQ0NWNhLi43NTI5NzNmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTEt MzAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbYnp0XSBHZW5lcmF0ZSBwYXNzIG1lc3NhZ2Vz IGZvciBzdHlsZS1xdWV1ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzE5OTUKKworICAgICAgICBXaXRoIHRoaXMgY2hhbmdlLCB0aGUgc3R5bGUtcXVl dWUgcG9zdHMgInBhc3MiIG1lc3NhZ2VzIHRvIGJ1Z3MgYXMKKyAgICAgICAgd2VsbC4gIEFsc28s IGFkZGVkIG1vcmUgaW5mb3JtYXRpb24gdG8gdGhlIHN0YXRlIHN0b3JlIHcuci50LiBwYXNzaW5n CisgICAgICAgIGFuZCBmYWlsaW5nLgorCisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL2NvbW1h bmRzL3F1ZXVlcy5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvcGF0Y2hjb2xsZWN0aW9u LnB5OgorCiAyMDA5LTExLTMwICBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgIDxndXN0YXZvLm5vcm9u aGFAY29sbGFib3JhLmNvLnVrPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEZyYXNlci4K ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5CmluZGV4 IDU2MDc3YzMuLmRmNTZlZjYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxl cy9jb21tYW5kcy9xdWV1ZXMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2Nv bW1hbmRzL3F1ZXVlcy5weQpAQCAtMTkwLDcgKzE5MCw2IEBAIGNsYXNzIEFic3RyYWN0VHJ5UXVl dWUoQWJzdHJhY3RRdWV1ZSwgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRlbGVnYXRlLCBMYW5k aW5nCiAKICAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgcGF0Y2gsIG1lc3Nh Z2UpOgogICAgICAgICBsb2cobWVzc2FnZSkKLSAgICAgICAgc2VsZi5fcGF0Y2hlcy5kb25lKHBh dGNoKQogCiAgICAgIyBMYW5kaW5nU2VxdWVuY2VFcnJvckhhbmRsZXIgbWV0aG9kcwogCkBAIC0y MDksOCArMjA4LDE0IEBAIGNsYXNzIFN0eWxlUXVldWUoQWJzdHJhY3RUcnlRdWV1ZSk6CiAgICAg ICAgIHJldHVybiAoVHJ1ZSwgIkNoZWNraW5nIHN0eWxlIGZvciBwYXRjaCAlcyBvbiBidWcgJXMu IiAlIChwYXRjaFsiaWQiXSwgcGF0Y2hbImJ1Z19pZCJdKSwgcGF0Y2gpCiAKICAgICBkZWYgcHJv Y2Vzc193b3JrX2l0ZW0oc2VsZiwgcGF0Y2gpOgotICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90 b29sKFsiY2hlY2stc3R5bGUiLCAiLS1mb3JjZS1jbGVhbiIsICItLW5vbi1pbnRlcmFjdGl2ZSIs ICItLXBhcmVudC1jb21tYW5kPXN0eWxlLXF1ZXVlIiwgcGF0Y2hbImlkIl1dKQotICAgICAgICBz ZWxmLl9wYXRjaGVzLmRvbmUocGF0Y2gpCisgICAgICAgIHRyeToKKyAgICAgICAgICAgIHNlbGYu cnVuX2J1Z3ppbGxhX3Rvb2woWyJjaGVjay1zdHlsZSIsICItLWZvcmNlLWNsZWFuIiwgIi0tbm9u LWludGVyYWN0aXZlIiwgIi0tcGFyZW50LWNvbW1hbmQ9c3R5bGUtcXVldWUiLCBwYXRjaFsiaWQi XV0pCisgICAgICAgICAgICBtZXNzYWdlID0gIiVzIHJhbiBjaGVjay13ZWJraXQtc3R5bGUgb24g YXR0YWNobWVudCAlcyB3aXRob3V0IGFueSBlcnJvcnMuIiAlIChzZWxmLm5hbWUsIHBhdGNoWyJp ZCJdKQorICAgICAgICAgICAgc2VsZi50b29sLmJ1Z3MucG9zdF9jb21tZW50X3RvX2J1ZyhwYXRj aFsiYnVnX2lkIl0sIG1lc3NhZ2UsIGNjPXNlbGYud2F0Y2hlcnMpCisgICAgICAgICAgICBzZWxm Ll9wYXRjaGVzLmRpZF9wYXNzKHBhdGNoKQorICAgICAgICBleGNlcHQgU2NyaXB0RXJyb3IsIGU6 CisgICAgICAgICAgICBzZWxmLl9wYXRjaGVzLmRpZF9mYWlsKHBhdGNoKQorICAgICAgICAgICAg cmFpc2UgZQogCiAgICAgQGNsYXNzbWV0aG9kCiAgICAgZGVmIGhhbmRsZV9zY3JpcHRfZXJyb3Io Y2xzLCB0b29sLCBwYXRjaCwgc2NyaXB0X2Vycm9yKToKQEAgLTIyMCw5ICsyMjUsNyBAQCBjbGFz cyBTdHlsZVF1ZXVlKEFic3RyYWN0VHJ5UXVldWUpOgogICAgICAgICAjIEZJWE1FOiBXZSBzaG91 bGRuJ3QgbmVlZCB0byB1c2UgYSByZWdleHAgaGVyZS4gIFNjcmlwdEVycm9yIHNob3VsZAogICAg ICAgICAjICAgICAgICBoYXZlIGEgYmV0dGVyIEFQSS4KICAgICAgICAgaWYgcmUuc2VhcmNoKCJj aGVjay13ZWJraXQtc3R5bGUiLCBjb21tYW5kKToKLSAgICAgICAgICAgIG1lc3NhZ2UgPSAiQXR0 YWNobWVudCAlcyBkaWQgbm90IHBhc3MgJXM6XG5cbiVzIiAlIChwYXRjaFsiaWQiXSwgY2xzLm5h bWUsIHNjcmlwdF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KG91dHB1dF9saW1pdD1Ob25lKSkK LSAgICAgICAgICAgICMgTG9jYWwtb25seSBsb2dnaW5nIGhlbHBmdWwgZm9yIGRldmVsb3BtZW50 OgotICAgICAgICAgICAgIyBsb2coIioqIEJFR0lOIEJVRyBQT1NUICoqXG4lcyoqIEVORCBCVUcg UE9TVCAqKiIgJSBtZXNzYWdlKQorICAgICAgICAgICAgbWVzc2FnZSA9ICJBdHRhY2htZW50ICVz IGRpZCBub3QgcGFzcyAlczpcblxuJXMiICUgKHBhdGNoWyJpZCJdLCBjbHMubmFtZSwgc2NyaXB0 X2Vycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQob3V0cHV0X2xpbWl0PTUqMTAyNCkpCiAgICAgICAg ICAgICB0b29sLmJ1Z3MucG9zdF9jb21tZW50X3RvX2J1ZyhwYXRjaFsiYnVnX2lkIl0sIG1lc3Nh Z2UsIGNjPWNscy53YXRjaGVycykKIAogCkBAIC0yNDYsNCArMjQ5LDQgQEAgY2xhc3MgQnVpbGRR dWV1ZShBYnN0cmFjdFRyeVF1ZXVlKToKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxm LCBwYXRjaCk6CiAgICAgICAgIHNlbGYucnVuX2J1Z3ppbGxhX3Rvb2woWyJidWlsZC1hdHRhY2ht ZW50Iiwgc2VsZi5wb3J0LmZsYWcoKSwgIi0tZm9yY2UtY2xlYW4iLCAiLS1xdWlldCIsICItLW5v bi1pbnRlcmFjdGl2ZSIsICItLXBhcmVudC1jb21tYW5kPWJ1aWxkLXF1ZXVlIiwgIi0tbm8tdXBk YXRlIiwgcGF0Y2hbImlkIl1dKQotICAgICAgICBzZWxmLl9wYXRjaGVzLmRvbmUocGF0Y2gpCisg ICAgICAgIHNlbGYuX3BhdGNoZXMuZGlkX3Bhc3MocGF0Y2gpCmRpZmYgLS1naXQgYS9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvcGF0Y2hjb2xsZWN0aW9uLnB5IGIvV2ViS2l0VG9vbHMvU2Ny aXB0cy9tb2R1bGVzL3BhdGNoY29sbGVjdGlvbi5weQppbmRleCAxYTc3NGJhLi5jZWVkNTgxIDEw MDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvcGF0Y2hjb2xsZWN0aW9uLnB5 CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9wYXRjaGNvbGxlY3Rpb24ucHkKQEAg LTcxLDggKzcxLDkgQEAgY2xhc3MgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRlbGVnYXRlOgog CiAKIGNsYXNzIFBlcnNpc3RlbnRQYXRjaENvbGxlY3Rpb246Ci0gICAgX2luaXRpYWxfc3RhdHVz ID0gIkF0dGVtcHRlZCIKLSAgICBfdGVybWluYWxfc3RhdHVzID0gIkRvbmUiCisgICAgX2luaXRp YWxfc3RhdHVzID0gIlBlbmRpbmciCisgICAgX3Bhc3Nfc3RhdHVzID0gIlBhc3MiCisgICAgX2Zh aWxfc3RhdHVzID0gIkZhaWwiCiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIGRlbGVnYXRlKToKICAg ICAgICAgc2VsZi5fZGVsZWdhdGUgPSBkZWxlZ2F0ZQogICAgICAgICBzZWxmLl9uYW1lID0gc2Vs Zi5fZGVsZWdhdGUuY29sbGVjdGlvbl9uYW1lKCkKQEAgLTk1LDUgKzk2LDggQEAgY2xhc3MgUGVy c2lzdGVudFBhdGNoQ29sbGVjdGlvbjoKICAgICAgICAgICAgIGlmIG5vdCBzdGF0dXM6CiAgICAg ICAgICAgICAgICAgcmV0dXJuIHBhdGNoX2lkCiAKLSAgICBkZWYgZG9uZShzZWxmLCBwYXRjaCk6 Ci0gICAgICAgIHNlbGYuX3N0YXR1cy51cGRhdGVfc3RhdHVzKHNlbGYuX25hbWUsIHNlbGYuX3Rl cm1pbmFsX3N0YXR1cywgcGF0Y2gpCisgICAgZGVmIGRpZF9wYXNzKHNlbGYsIHBhdGNoKToKKyAg ICAgICAgc2VsZi5fc3RhdHVzLnVwZGF0ZV9zdGF0dXMoc2VsZi5fbmFtZSwgc2VsZi5fcGFzc19z dGF0dXMsIHBhdGNoKQorCisgICAgZGVmIGRpZF9mYWlsKHNlbGYsIHBhdGNoKToKKyAgICAgICAg c2VsZi5fc3RhdHVzLnVwZGF0ZV9zdGF0dXMoc2VsZi5fbmFtZSwgc2VsZi5fZmFpbF9zdGF0dXMs IHBhdGNoKQo=