31993 2009-11-30 12:27:29 -0800 http://webkit.org/coding/coding-style.html should mention check-webkit-style 2014-08-27 06:11:12 -0700 1 1 1 Unclassified WebKit WebKit Website 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric llango.u-szeged abarth cjerdonek commit-queue hamaji levin llango.u-szeged Szanka.Peter oldest_to_newest 167339 0 eric 2009-11-30 12:27:29 -0800 http://webkit.org/coding/coding-style.html should mention check-webkit-style We now have this nice tool for checking some of the rules of WebKit style. Our style page should mention the tool and explain its use. 954937 1 218051 Szanka.Peter 2013-11-29 03:57:18 -0800 Created attachment 218051 Patch 968330 2 Szanka.Peter 2014-01-15 08:51:11 -0800 ping 990361 3 llango.u-szeged 2014-03-14 02:32:02 -0700 (In reply to comment #1) > Created an attachment (id=218051) [details] > Patch I think we need a more detailed description of it's usage. 1030038 4 218051 darin 2014-08-19 09:22:04 -0700 Comment on attachment 218051 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=218051&action=review > Websites/webkit.org/coding/contributing.html:94 > +<p>Your patch will be automatically checked for style compliance before uploading if you use webkit-patch upload. This mention of webkit-patch upload here is not formatted the way the other mentions in this document are. > Websites/webkit.org/coding/contributing.html:95 > +You can do it manually with the check-webkit-style script and will be checked always after uploading by <a href="http://trac.webkit.org/wiki/EWS">EWS</a>. Grammar mistake here. It says: You can do it and will be checked I would write something more like this: You can check style manually by running the Tools/Scripts/check-webkit-style script. Style will also be checked on each patch after it is uploaded by the <a href="http://trac.webkit.org/wiki/EWS">WebKit Early Warning System</a>. It’s a little strange to have a link to the wiki from this page. Normally we don’t do that. 1031635 5 237220 llango.u-szeged 2014-08-27 05:28:54 -0700 Created attachment 237220 Patch for landing 1031641 6 237220 commit-queue 2014-08-27 06:11:07 -0700 Comment on attachment 237220 Patch for landing Clearing flags on attachment: 237220 Committed r173003: <http://trac.webkit.org/changeset/173003> 1031642 7 commit-queue 2014-08-27 06:11:12 -0700 All reviewed patches have been landed. Closing bug. 218051 2013-11-29 03:57:18 -0800 2014-08-27 05:28:43 -0700 Patch bug-31993-20131129125717.patch text/plain 1844 Szanka.Peter U3VidmVyc2lvbiBSZXZpc2lvbjogMTU5ODY4CmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IDIwZWM2 ZTFhZGNhYjEzNTMyYmFkNmYwYjIxYzViZWFhZGQ4OGEyM2MuLjBjZWE2YTQ1N2NlODBiZDljZDU4 MGE5YmRkY2Y1N2FjMzJmOWJkZDAgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQg QEAKKzIwMTMtMTEtMjkgIFBldGVyIFN6YW5rYSAgPGg4NjgwNjRAc3R1ZC51LXN6ZWdlZC5odT4K KworICAgICAgICBodHRwOi8vd2Via2l0Lm9yZy9jb2RpbmcvY29kaW5nLXN0eWxlLmh0bWwgc2hv dWxkIG1lbnRpb24gY2hlY2std2Via2l0LXN0eWxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE5OTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIGNvZGluZy9jb250cmlidXRpbmcuaHRtbDoKKworICAg ICAgICBFeHRlbmQgdGhlIGRlc2NyaXB0aW9uIG9mIGNvZGUgc3R5bGUgZ3VpZGVsaW5lcyB3aXRo IGNoZWNrLXdlYmtpdC1zdHlsZSBpbiB0aGUgY29udHJpYnV0aW5nLmh0bWwuCisKIDIwMTMtMTAt MjkgIEJldGggRGFraW4gIDxiZGFraW5AYXBwbGUuY29tPgogCiAgICAgICAgIEp1c3QgdXBkYXRp bmcgdGhlIHNhbXBsZSBjb2RlIGZvciB0aGlzIHBvdGVudGlhbCBibG9nIHBvc3QuCmRpZmYgLS1n aXQgYS9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGluZy9jb250cmlidXRpbmcuaHRtbCBiL1dlYnNp dGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1dGluZy5odG1sCmluZGV4IDU4MmU1OGY4ODE2 NDY0YmQxMzg3MWM3NGM4MGExNDI0Yjg2OTY3ZjcuLjMwNmUyZThiYjdkMWM3NTFjZmY2MzEzNzkz M2JmMGVkNjc4N2NmMTIgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2Nv bnRyaWJ1dGluZy5odG1sCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvY29kaW5nL2NvbnRyaWJ1 dGluZy5odG1sCkBAIC05MSw4ICs5MSw5IEBAIElmIHlvdSBhcmUgbW9kaWZ5aW5nIHN1Y2ggY29k ZSwgaXQgaXMgZ2VuZXJhbGx5IGJlc3QgdG8gY2xlYW4gaXQgdXAKIHRvIGNvbXBseSB3aXRoIHRo ZSBjdXJyZW50IGd1aWRlbGluZXMuIEFuIGV4Y2VwdGlvbiBpcyBsZWdhY3kgY29tcG9uZW50cywK IHdoaWNoIHNob3VsZCBub3QgYmUgY2xlYW5lZCB1cC48L3A+CiAKLTxwPllvdXIgcGF0Y2ggd2ls bCBiZSBhdXRvbWF0aWNhbGx5IGNoZWNrZWQgZm9yIHN0eWxlIGNvbXBsaWFuY2Ugd2hlbiB5b3UK LXVwbG9hZCBpdCB0byB0aGUgYnVnIHRyYWNrZXIuPC9wPgorPHA+WW91ciBwYXRjaCB3aWxsIGJl IGF1dG9tYXRpY2FsbHkgY2hlY2tlZCBmb3Igc3R5bGUgY29tcGxpYW5jZSBiZWZvcmUgdXBsb2Fk aW5nIGlmIHlvdSB1c2Ugd2Via2l0LXBhdGNoIHVwbG9hZC4KK1lvdSBjYW4gZG8gaXQgbWFudWFs bHkgd2l0aCB0aGUgY2hlY2std2Via2l0LXN0eWxlIHNjcmlwdCBhbmQgd2lsbCBiZSBjaGVja2Vk IGFsd2F5cyBhZnRlciB1cGxvYWRpbmcgYnkgPGEgaHJlZj0iaHR0cDovL3RyYWMud2Via2l0Lm9y Zy93aWtpL0VXUyI+RVdTPC9hPi4KKzwvcD4KIAogPGgzPlJlZ3Jlc3Npb24gdGVzdHM8L2gzPgog PHA+T25jZSB5b3UgaGF2ZSBtYWRlIHlvdXIgY2hhbmdlcywgeW91IG5lZWQgdG8gcnVuIHRoZSBy ZWdyZXNzaW9uIHRlc3RzLCB3aGljaCBpcyBkb25lIHZpYSB0aGUgPGNvZGU+cnVuLXdlYmtpdC10 ZXN0czwvY29kZT4gc2NyaXB0Lgo= 237220 2014-08-27 05:28:54 -0700 2014-08-27 06:11:07 -0700 Patch for landing bug-31993-20140827142846.patch text/plain 2029 llango.u-szeged U3VidmVyc2lvbiBSZXZpc2lvbjogMTczMDAxCmRpZmYgLS1naXQgYS9XZWJzaXRlcy93ZWJraXQu b3JnL0NoYW5nZUxvZyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCmluZGV4IGNjNDc5 YWVmMTNmYmMxN2ZiMDdlZWVmN2QzMjVlYTJhNDRhODE3YmMuLjMxYzZlYjA5NGU3ZTVmYTU5YTky NmYwZjliODZlZjAwNGQzNGE4OTMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hh bmdlTG9nCisrKyBiL1dlYnNpdGVzL3dlYmtpdC5vcmcvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTQtMDgtMjcgIEzDoXN6bMOzIExhbmfDsyAgPGxsYW5nby51LXN6ZWdlZEBwYXJ0bmVy LnNhbXN1bmcuY29tPgorCisgICAgICAgIGh0dHA6Ly93ZWJraXQub3JnL2NvZGluZy9jb2Rpbmct c3R5bGUuaHRtbCBzaG91bGQgbWVudGlvbiBjaGVjay13ZWJraXQtc3R5bGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTk5MworCisgICAgICAgIFJl dmlld2VkIGJ5IERhcmluIEFkbGVyLgorCisgICAgICAgIEJhc2VkIG9uIHBhdGNoIGJ5IFBldGVy IFN6YW5rYSA8aDg2ODA2NEBzdHVkLnUtc3plZ2VkLmh1PgorCisgICAgICAgICogY29kaW5nL2Nv bnRyaWJ1dGluZy5odG1sOgorICAgICAgICBFeHRlbmQgdGhlIGRlc2NyaXB0aW9uIG9mIGNvZGUg c3R5bGUgZ3VpZGVsaW5lcyB3aXRoIGNoZWNrLXdlYmtpdC1zdHlsZSBpbiB0aGUgY29udHJpYnV0 aW5nLmh0bWwuCisKIDIwMTQtMDgtMTggIEJlbSBKb25lcy1CZXkgIDxiam9uZXNiZUBhZG9iZS5j b20+CiAKICAgICAgICAgUmVtb3ZlIHBlb3BsZSB0aGF0IGhhdmUgbGVmdCBBZG9iZSBmcm9tIFNl Y3VyaXR5IENvbnRhY3QgbGlzdApkaWZmIC0tZ2l0IGEvV2Vic2l0ZXMvd2Via2l0Lm9yZy9jb2Rp bmcvY29udHJpYnV0aW5nLmh0bWwgYi9XZWJzaXRlcy93ZWJraXQub3JnL2NvZGluZy9jb250cmli dXRpbmcuaHRtbAppbmRleCA1ODJlNThmODgxNjQ2NGJkMTM4NzFjNzRjODBhMTQyNGI4Njk2N2Y3 Li5mNTBjNzE5MTkzNjAwMjQzNjBkNWU1NjExNzE0MTY3Mzg2NWU0Mjc0IDEwMDY0NAotLS0gYS9X ZWJzaXRlcy93ZWJraXQub3JnL2NvZGluZy9jb250cmlidXRpbmcuaHRtbAorKysgYi9XZWJzaXRl cy93ZWJraXQub3JnL2NvZGluZy9jb250cmlidXRpbmcuaHRtbApAQCAtOTEsOCArOTEsOSBAQCBJ ZiB5b3UgYXJlIG1vZGlmeWluZyBzdWNoIGNvZGUsIGl0IGlzIGdlbmVyYWxseSBiZXN0IHRvIGNs ZWFuIGl0IHVwCiB0byBjb21wbHkgd2l0aCB0aGUgY3VycmVudCBndWlkZWxpbmVzLiBBbiBleGNl cHRpb24gaXMgbGVnYWN5IGNvbXBvbmVudHMsCiB3aGljaCBzaG91bGQgbm90IGJlIGNsZWFuZWQg dXAuPC9wPgogCi08cD5Zb3VyIHBhdGNoIHdpbGwgYmUgYXV0b21hdGljYWxseSBjaGVja2VkIGZv ciBzdHlsZSBjb21wbGlhbmNlIHdoZW4geW91Ci11cGxvYWQgaXQgdG8gdGhlIGJ1ZyB0cmFja2Vy LjwvcD4KKzxwPllvdXIgcGF0Y2ggd2lsbCBiZSBhdXRvbWF0aWNhbGx5IGNoZWNrZWQgZm9yIHN0 eWxlIGNvbXBsaWFuY2UgYmVmb3JlIHVwbG9hZGluZyBpZiB5b3UgdXNlIDxjb2RlPndlYmtpdC1w YXRjaCB1cGxvYWQ8L2NvZGU+LgorWW91IGNhbiBjaGVjayBzdHlsZSBtYW51YWxseSBieSBydW5u aW5nIHRoZSA8Y29kZT5Ub29scy9TY3JpcHRzL2NoZWNrLXdlYmtpdC1zdHlsZTwvY29kZT4gc2Ny aXB0LiBTdHlsZSB3aWxsIGFsc28gYmUgY2hlY2tlZCBvbiBlYWNoIHBhdGNoIGFmdGVyIGl0IGlz IHVwbG9hZGVkIGJ5IHRoZSA8YSBocmVmPSJodHRwOi8vdHJhYy53ZWJraXQub3JnL3dpa2kvRVdT Ij5XZWJLaXQgRWFybHkgV2FybmluZyBTeXN0ZW08L2E+LgorPC9wPgogCiA8aDM+UmVncmVzc2lv biB0ZXN0czwvaDM+CiA8cD5PbmNlIHlvdSBoYXZlIG1hZGUgeW91ciBjaGFuZ2VzLCB5b3UgbmVl ZCB0byBydW4gdGhlIHJlZ3Jlc3Npb24gdGVzdHMsIHdoaWNoIGlzIGRvbmUgdmlhIHRoZSA8Y29k ZT5ydW4td2Via2l0LXRlc3RzPC9jb2RlPiBzY3JpcHQuCg==