31985 2009-11-30 09:02:47 -0800 editing/selection/last-empty-inline is failing in Windows 2009-12-07 21:48:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED https://bug-29966-attachments.webkit.org/attachment.cgi?id=43915 P2 Normal --- 1 hamaji webkit-unassigned abarth oldest_to_newest 167257 0 hamaji 2009-11-30 09:02:47 -0800 I introduced (sorry!) a failing layout test (editing/selection/last-empty-inline.html) for Windows and Qt in Bug 29966. The change was: http://trac.webkit.org/changeset/51429 I put the failing test as the URL of this bug. This test drags the mouse from a point below the comma between "Hello" and "world!" and check if "world!" is selected. Before Bug 29966, "world!" wasn't selected even if we drag the mouse from the point below '!' after "world" to the comma between "Hello" and "world". The last-empty-inline was intended to check this behavior. I'll submit a patch which changes the test case so that it drags the mouse from the point below '!'. Note that it seems Qt lacks something to test editing features. So, I couldn't fix this test for now. By the way, I'm not sure if the original test case should pass as is. In Mac world, this should be definitely pass (clicking below the last line is considered as the click to the end of the last line). In Windows, I'm not sure what is the right behavior. With Firefox, "world!" is selected but nothing is selected with WebKit. WebKit ignores empty inline elements when it searches the clicked inline element even if the empty inline element is visible because of paddings. So, WebKit considers "Hello, world!" is the last line and the clicking below the last line is consider as the click to the middle of the last line in Windows. If someone think this is a bug, I'll file another bug. Hmm... my English isn't good to describe this kind of a bit complicated geometric stuff. Please feel free to say "hey, your English is terrible, elaborate again" if there are something unclear. 167260 1 44023 hamaji 2009-11-30 09:03:52 -0800 Created attachment 44023 Patch v1 167261 2 hamaji 2009-11-30 09:06:47 -0800 > Patch v1 Note that I confirmed this test fails before Bug 29966 on Mac and Windows. So, I think this test is still working as the regression test of Bug 29966. 167390 3 abarth 2009-11-30 12:51:41 -0800 style-queue ran check-webkit-style on attachment 44023 without any errors. 169353 4 44023 darin 2009-12-07 10:16:04 -0800 Comment on attachment 44023 Patch v1 I'm not sure this is OK, but I guess I'm sure enough to rubber-stamp the change. rs=me 169601 5 hamaji 2009-12-07 21:48:55 -0800 Committed r51834: <http://trac.webkit.org/changeset/51834> 44023 2009-11-30 09:03:52 -0800 2009-12-07 10:16:04 -0800 Patch v1 bug-31985-20091201020350.patch text/plain 4333 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBiMTdjZjU3Li5kNWQxMzZmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEt MzAgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBlZGl0aW5nL3NlbGVjdGlvbi9s YXN0LWVtcHR5LWlubGluZSBpcyBmYWlsaW5nIGluIFdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTg1CisKKyAgICAgICAgKiBlZGl0aW5n L3NlbGVjdGlvbi9sYXN0LWVtcHR5LWlubGluZS1leHBlY3RlZC50eHQ6CisgICAgICAgICogZWRp dGluZy9zZWxlY3Rpb24vbGFzdC1lbXB0eS1pbmxpbmUuaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9y bS9xdC9Ta2lwcGVkOgorICAgICAgICAqIHBsYXRmb3JtL3dpbi9Ta2lwcGVkOgorCiAyMDA5LTEx LTMwICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAgICAgICAgW1F0 XSBQdXQgdGVzdHMgaW50byBza2lwbGlzdCBiZWNhdXNlIG9mIG1pc3NpbmcgZmVhdHVyZXMuCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9sYXN0LWVtcHR5LWlubGlu ZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9sYXN0LWVtcHR5 LWlubGluZS1leHBlY3RlZC50eHQKaW5kZXggNDQ0NjRkMS4uZmQyZDllMSAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vbGFzdC1lbXB0eS1pbmxpbmUtZXhwZWN0ZWQu dHh0CisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2xhc3QtZW1wdHktaW5saW5l LWV4cGVjdGVkLnR4dApAQCAtMSwyICsxLDIgQEAKLVRvIHRlc3QgdGhpcyBtYW51YWxseSwgcHJl c3MgbW91c2UgYnV0dG9uIGJlbG93IHRoZSBjb21tYSBiZXR3ZWVuICJIZWxsbyIgYW5kICJ3b3Js ZCEiIGFuZCBkcmFnIHRoZSBtb3VzZSB0byB0aGUgY29tbWEuIEl0J3MgT0sgaWYgIndvcmxkISIg aXMgc2VsZWN0ZWQuCitUbyB0ZXN0IHRoaXMgbWFudWFsbHksIHByZXNzIG1vdXNlIGJ1dHRvbiBi ZWxvdyB0aGUgJyEnIGFuZCBkcmFnIHRoZSBtb3VzZSB0byB0aGUgY29tbWEgYmV0d2VlbiAiSGVs bG8iIGFuZCAid29ybGQhIi4gSXQncyBPSyBpZiAid29ybGQhIiBpcyBzZWxlY3RlZC4KIFBBU1MK ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2xhc3QtZW1wdHktaW5s aW5lLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9sYXN0LWVtcHR5LWlubGlu ZS5odG1sCmluZGV4IDIzMzI5ODEuLjBmZThjNjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Vk aXRpbmcvc2VsZWN0aW9uL2xhc3QtZW1wdHktaW5saW5lLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMv ZWRpdGluZy9zZWxlY3Rpb24vbGFzdC1lbXB0eS1pbmxpbmUuaHRtbApAQCAtMSw5ICsxLDkgQEAK IDxkaXY+Ci1UbyB0ZXN0IHRoaXMgbWFudWFsbHksIHByZXNzIG1vdXNlIGJ1dHRvbiBiZWxvdyB0 aGUgY29tbWEgYmV0d2VlbiAiSGVsbG8iIGFuZCAid29ybGQhIiBhbmQgZHJhZyB0aGUgbW91c2Ug dG8gdGhlIGNvbW1hLiBJdCdzIE9LIGlmICJ3b3JsZCEiIGlzIHNlbGVjdGVkLgorVG8gdGVzdCB0 aGlzIG1hbnVhbGx5LCBwcmVzcyBtb3VzZSBidXR0b24gYmVsb3cgdGhlICchJyBhbmQgZHJhZyB0 aGUgbW91c2UgdG8gdGhlIGNvbW1hIGJldHdlZW4gIkhlbGxvIiBhbmQgIndvcmxkISIuIEl0J3Mg T0sgaWYgIndvcmxkISIgaXMgc2VsZWN0ZWQuCiA8L2Rpdj4KIAogPGRpdiBpZD0icmVzdWx0IiBz dHlsZT0id2lkdGg6IDIwMHB4OyI+Ci08c3Bhbj5IZWxsbyw8L3NwYW4+PHNwYW4gaWQ9Indvcmxk Ij53b3JsZCE8L3NwYW4+PHNwYW4gc3R5bGU9InBhZGRpbmctbGVmdDogMjAwcHg7IHBhZGRpbmct Ym90dG9tOiAyMDBweDsgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsgaGVpZ2h0OiAyMDBweDsiPjwv c3Bhbj4KKzxzcGFuPkhlbGxvLDwvc3Bhbj48c3BhbiBpZD0id29ybGQiPndvcmxkITwvc3Bhbj48 YnI+PHNwYW4gc3R5bGU9InBhZGRpbmctbGVmdDogMjAwcHg7IHBhZGRpbmctYm90dG9tOiAyMDBw eDsgYmFja2dyb3VuZC1jb2xvcjogYmx1ZTsgaGVpZ2h0OiAyMDBweDsiPjwvc3Bhbj4KIDwvZGl2 PgogCiA8c2NyaXB0PgpAQCAtMTEsMTMgKzExLDE1IEBAIGlmICh3aW5kb3cubGF5b3V0VGVzdENv bnRyb2xsZXIpIHsKICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7CiAKICAg ICB2YXIgd29ybGQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgid29ybGQiKTsKLSAgICB2YXIg eCA9IHdvcmxkLm9mZnNldExlZnQ7Ci0gICAgdmFyIHkgPSB3b3JsZC5vZmZzZXRUb3A7CisgICAg dmFyIGVuZFggPSB3b3JsZC5vZmZzZXRMZWZ0OworICAgIHZhciBzdGFydFggPSBlbmRYICsgd29y bGQub2Zmc2V0V2lkdGg7CisgICAgdmFyIGVuZFkgPSB3b3JsZC5vZmZzZXRUb3A7CisgICAgdmFy IHN0YXJ0WSA9IGVuZFkgKyA1MDsKIAotICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgsIHkg KyA1MCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oc3RhcnRYLCBzdGFydFkpOwogICAg IGV2ZW50U2VuZGVyLm1vdXNlRG93bigpOwotICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKHgs IHkgKyA1MCk7Ci0gICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oeCwgeSk7CisgICAgZXZlbnRT ZW5kZXIubW91c2VNb3ZlVG8oc3RhcnRYLCBzdGFydFkpOworICAgIGV2ZW50U2VuZGVyLm1vdXNl TW92ZVRvKGVuZFgsIGVuZFkpOwogICAgIGV2ZW50U2VuZGVyLm1vdXNlVXAoKTsKIAogICAgIHZh ciByZXN1bHQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgicmVzdWx0Iik7CmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAppbmRleCAzYjVmN2I4Li4zOWZlYjFmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTMxNCw2ICszMTQsNyBAQCBlZGl0aW5nL3NlbGVjdGlvbi9leHBhbmRpbmctc2VsZWN0 aW9ucy5odG1sCiBlZGl0aW5nL3NlbGVjdGlvbi9mYWtlLWRvdWJsZWNsaWNrLmh0bWwKIGVkaXRp bmcvc2VsZWN0aW9uL2Zha2UtZHJhZy5odG1sCiBlZGl0aW5nL3NlbGVjdGlvbi9pbmxpbmUtY2xv c2VzdC1sZWFmLWNoaWxkLmh0bWwKK2VkaXRpbmcvc2VsZWN0aW9uL2xhc3QtZW1wdHktaW5saW5l Lmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9uL21peGVkLWVkaXRhYmlsaXR5LTEuaHRtbAogZWRpdGlu Zy9zZWxlY3Rpb24vcGFyYWdyYXBoLWdyYW51bGFyaXR5Lmh0bWwKIGVkaXRpbmcvc2VsZWN0aW9u L3NlbGVjdC1mcm9tLXRleHRmaWVsZC1vdXR3YXJkcy5odG1sCkBAIC01MjU2LDcgKzUyNTcsMyBA QCBzdmcvZmlsdGVycy9maWx0ZXJSZXMuc3ZnCiB0cmFuc2Zvcm1zLzJkL2hpbmRpLXJvdGF0ZWQu aHRtbAogdHJhbnNpdGlvbnMvbW92ZS1hZnRlci10cmFuc2l0aW9uLmh0bWwKIHRyYW5zaXRpb25z L3RyYW5zaXRpb24tZW5kLWV2ZW50LXJlbmRlcmluZy5odG1sCi0KLSMgRmFpbHVyZSBpbnRyb2R1 Y2VkIGJ5IGh0dHA6Ly90cmFjLndlYmtpdC5vcmcvY2hhbmdlc2V0LzUxNDI5Ci0jIGhhbWFqaSB3 aWxsIGxvb2sgaW50byB0aGlzLgotZWRpdGluZy9zZWxlY3Rpb24vbGFzdC1lbXB0eS1pbmxpbmUu aHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2luL1NraXBwZWQgYi9MYXlv dXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAppbmRleCBmMDdkMjI3Li41MDg1MmJkIDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS93aW4vU2tpcHBlZAorKysgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS93aW4vU2tpcHBlZApAQCAtNzEyLDcgKzcxMiwzIEBAIHBsdWdpbnMvcmVsb2Fk cGx1Z2lucy1uby1wYWdlcy5odG1sCiAKICMgVGhlc2UgdGVzdHMgcmVxdWlyZSBRdCBXaWRnZXRz CiBwbHVnaW5zL3F0LXF3aWRnZXQtcGx1Z2luLmh0bWwKLQotIyBGYWlsdXJlIGludHJvZHVjZWQg YnkgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvNTE0MjkKLSMgaGFtYWppIHdpbGwg bG9vayBpbnRvIHRoaXMuCi1lZGl0aW5nL3NlbGVjdGlvbi9sYXN0LWVtcHR5LWlubGluZS5odG1s Cg==