31976 2009-11-29 21:54:18 -0800 Update pywebsocket to 0.4.2.1 2009-11-30 16:40:16 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yuzo webkit-unassigned abarth ap commit-queue oldest_to_newest 167193 0 yuzo 2009-11-29 21:54:18 -0800 Update pywebsocket (http://code.google.com/p/pywebsocket/) to 0.4.2.1. 0.4.2 has a bug that some errors are logged to stderr even when log file is specified. For 0.4.2.1 the bug has been fixed. 167194 1 44007 yuzo 2009-11-29 21:57:13 -0800 Created attachment 44007 Update pywebsocket to 0.4.2.1 167383 2 abarth 2009-11-30 12:49:37 -0800 style-queue ran check-webkit-style on attachment 44007 without any errors. 167464 3 44007 ap 2009-11-30 16:31:04 -0800 Comment on attachment 44007 Update pywebsocket to 0.4.2.1 > + Update pywebsocket to 0.4.2.1. Do we really need 4-digit version numbers for pywebsocket? I'm not sure if any version numbers are needed at this point. > + logging.error( > + ('Exception in processing request from: %r' % (client_address,)) + > + '\n' + util.get_stack_trace()) We don't usually wrap such short lines. > + # Note: client_address is a tuple. To match it against %r, we need the > + # trailing comma. Ditto. r=me 167466 4 44007 commit-queue 2009-11-30 16:40:11 -0800 Comment on attachment 44007 Update pywebsocket to 0.4.2.1 Clearing flags on attachment: 44007 Committed r51521: <http://trac.webkit.org/changeset/51521> 167467 5 commit-queue 2009-11-30 16:40:16 -0800 All reviewed patches have been landed. Closing bug. 44007 2009-11-29 21:57:13 -0800 2009-11-30 16:40:11 -0800 Update pywebsocket to 0.4.2.1 bug-31976-20091130145711.patch text/plain 2111 yuzo ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBmYmUyNWNkLi45OWY2ZTQ1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MjkgIFl1em8gRnVqaXNoaW1hICA8eXV6b0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBweXdlYnNvY2tldCB0byAwLjQu Mi4xLgorICAgICAgICBUaGlzIGlzIHRvIGZpeCBhIGJ1ZyB0aGF0IHNvbWUgbWVzc2FnZXMgYXJl IGxvZ2dlZCB0byBzdGRlcnIgZXZlbiB3aGVuIHRoZSBsb2cgZmlsZSBpcyBzcGVjaWZpZWQuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTk3NgorCisg ICAgICAgICogcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29ja2V0L3N0YW5kYWxvbmUucHk6CisgICAg ICAgICogcHl3ZWJzb2NrZXQvc2V0dXAucHk6CisKIDIwMDktMTEtMjUgIFl1em8gRnVqaXNoaW1h ICA8eXV6b0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvcHl3ZWJzb2NrZXQvbW9kX3B5d2Vic29ja2V0L3N0YW5k YWxvbmUucHkgYi9XZWJLaXRUb29scy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvc3RhbmRh bG9uZS5weQppbmRleCAzYjJkMGRjLi5lZmMwZTlkIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9w eXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvc3RhbmRhbG9uZS5weQorKysgYi9XZWJLaXRUb29s cy9weXdlYnNvY2tldC9tb2RfcHl3ZWJzb2NrZXQvc3RhbmRhbG9uZS5weQpAQCAtNzUsNiArNzUs NyBAQCBleGNlcHQgSW1wb3J0RXJyb3I6CiAKIGltcG9ydCBkaXNwYXRjaAogaW1wb3J0IGhhbmRz aGFrZQoraW1wb3J0IHV0aWwKIAogCiBfTE9HX0xFVkVMUyA9IHsKQEAgLTE3Miw2ICsxNzMsMTUg QEAgY2xhc3MgV2ViU29ja2V0U2VydmVyKFNvY2tldFNlcnZlci5UaHJlYWRpbmdNaXhJbiwgQmFz ZUhUVFBTZXJ2ZXIuSFRUUFNlcnZlcik6CiAgICAgICAgICAgICBzb2NrZXRfID0gT3BlblNTTC5T U0wuQ29ubmVjdGlvbihjdHgsIHNvY2tldF8pCiAgICAgICAgIHJldHVybiBzb2NrZXRfCiAKKyAg ICBkZWYgaGFuZGxlX2Vycm9yKHNlbGYsIHJxdWVzdCwgY2xpZW50X2FkZHJlc3MpOgorICAgICAg ICAiIiJPdmVycmlkZSBTb2NrZXRTZXJ2ZXIuaGFuZGxlX2Vycm9yLiIiIgorCisgICAgICAgIGxv Z2dpbmcuZXJyb3IoCisgICAgICAgICAgICAoJ0V4Y2VwdGlvbiBpbiBwcm9jZXNzaW5nIHJlcXVl c3QgZnJvbTogJXInICUgKGNsaWVudF9hZGRyZXNzLCkpICsKKyAgICAgICAgICAgICdcbicgKyB1 dGlsLmdldF9zdGFja190cmFjZSgpKQorICAgICAgICAjIE5vdGU6IGNsaWVudF9hZGRyZXNzIGlz IGEgdHVwbGUuIFRvIG1hdGNoIGl0IGFnYWluc3QgJXIsIHdlIG5lZWQgdGhlCisgICAgICAgICMg dHJhaWxpbmcgY29tbWEuCisKIAogY2xhc3MgV2ViU29ja2V0UmVxdWVzdEhhbmRsZXIoU2ltcGxl SFRUUFNlcnZlci5TaW1wbGVIVFRQUmVxdWVzdEhhbmRsZXIpOgogICAgICIiIlNpbXBsZUhUVFBS ZXF1ZXN0SGFuZGxlciBzcGVjaWFsaXplZCBmb3IgV2ViIFNvY2tldC4iIiIKZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL3B5d2Vic29ja2V0L3NldHVwLnB5IGIvV2ViS2l0VG9vbHMvcHl3ZWJzb2Nr ZXQvc2V0dXAucHkKaW5kZXggYWUwN2Y4YS4uZmNkZjIzOCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9v bHMvcHl3ZWJzb2NrZXQvc2V0dXAucHkKKysrIGIvV2ViS2l0VG9vbHMvcHl3ZWJzb2NrZXQvc2V0 dXAucHkKQEAgLTU2LDcgKzU2LDcgQEAgc2V0dXAoYXV0aG9yPSdZdXpvIEZ1amlzaGltYScsCiAg ICAgICBuYW1lPV9QQUNLQUdFX05BTUUsCiAgICAgICBwYWNrYWdlcz1bX1BBQ0tBR0VfTkFNRV0s CiAgICAgICB1cmw9J2h0dHA6Ly9jb2RlLmdvb2dsZS5jb20vcC9weXdlYnNvY2tldC8nLAotICAg ICAgdmVyc2lvbj0nMC40LjInLAorICAgICAgdmVyc2lvbj0nMC40LjIuMScsCiAgICAgICApCiAK IAo=