31962 2009-11-29 14:34:24 -0800 [Qt] Fix some compiler warnings seen on QtWebKit/Mac 2009-11-30 08:55:08 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue steveblock oldest_to_newest 167106 0 laszlo.gombos 2009-11-29 14:34:24 -0800 Warnings to fix: WebCore/plugins/mac/PluginPackageMac.cpp: In member function 'bool WebCore::PluginPackage::fetchInfo()': WebCore/plugins/mac/PluginPackageMac.cpp:180: warning: label 'WTF' defined but not used WebCore/plugins/mac/PluginViewMac.cpp: In member function 'void WebCore::PluginView::setNPWindowIfNeeded()': WebCore/plugins/mac/PluginViewMac.cpp:384: warning: format '%d' expects type 'int', but argument 5 has type 'int32' WebCore/plugins/mac/PluginViewMac.cpp:384: warning: format '%d' expects type 'int', but argument 6 has type 'int32' WebCore/platform/network/ResourceHandle.h:99: warning: class WebCore::ResourceHandle has virtual functions but non-virtual destructor 167108 1 43992 laszlo.gombos 2009-11-29 14:56:07 -0800 Created attachment 43992 proposed patch 167245 2 43992 commit-queue 2009-11-30 08:42:34 -0800 Comment on attachment 43992 proposed patch Clearing flags on attachment: 43992 Committed r51490: <http://trac.webkit.org/changeset/51490> 167246 3 commit-queue 2009-11-30 08:42:38 -0800 All reviewed patches have been landed. Closing bug. 167252 4 steveblock 2009-11-30 08:55:08 -0800 *** Bug 31924 has been marked as a duplicate of this bug. *** 43992 2009-11-29 14:56:07 -0800 2009-11-30 08:42:33 -0800 proposed patch 31962.patch text/plain 3186 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTQ2NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjMgQEAKKzIwMDktMTEtMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRml4IHNvbWUgY29tcGlsZXIgd2FybmluZ3Mgc2VlbiBvbiBRdFdlYktpdC9N YWMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTYy CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIGFzIHRoZXJlIGlzIG5vIGZ1bmN0aW9uYWwgY2hhbmdl LgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5oOiBNYWtlIGRl c3RydWN0b3IgdmlydHVhbCBhcyAKKyAgICAgICAgYWZ0ZXIgcjUwNzcyIFJlc291cmNlSGFuZGxl IGhhcyB2aXJ0dWFsIGZ1bmN0aW9ucy4KKworICAgICAgICAqIHBsdWdpbnMvbWFjL1BsdWdpblBh Y2thZ2VNYWMuY3BwOiAKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmZldGNoSW5m byk6IEZpeCB0eXBvIFdURiBpcyBhIG5hbWVzcGFjZQorICAgICAgICBub3QgYSBsYWJlbAorCisg ICAgICAgICogcGx1Z2lucy9tYWMvUGx1Z2luVmlld01hYy5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpQbHVnaW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKTogQWRkIGwgdG8gdGhlIGZvcm1hdAor ICAgICAgICBzcGVjaWZpZXIKKwogMjAwOS0xMS0yOSAgWm9sdGFuIEhvcnZhdGggIDx6b2x0YW5A d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5oCShyZXZpc2lvbiA1MTQ2NykK KysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZUhhbmRsZS5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMTUsNyArMTE1LDcgQEAgcHVibGljOgogICAgIHN0YXRpYyBib29sIGRpZFNlbmRC b2R5RGF0YURlbGVnYXRlRXhpc3RzKCk7CiAjZW5kaWYKIAotICAgIH5SZXNvdXJjZUhhbmRsZSgp OworICAgIHZpcnR1YWwgflJlc291cmNlSGFuZGxlKCk7CiAKICNpZiBQTEFURk9STShNQUMpIHx8 IFVTRShDRk5FVFdPUkspCiAgICAgdm9pZCB3aWxsU2VuZFJlcXVlc3QoUmVzb3VyY2VSZXF1ZXN0 JiwgY29uc3QgUmVzb3VyY2VSZXNwb25zZSYgcmVkaXJlY3RSZXNwb25zZSk7CkluZGV4OiBXZWJD b3JlL3BsdWdpbnMvbWFjL1BsdWdpblBhY2thZ2VNYWMuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvcGx1Z2lucy9tYWMvUGx1Z2luUGFja2FnZU1hYy5jcHAJKHJldmlzaW9uIDUxNDY3KQorKysg V2ViQ29yZS9wbHVnaW5zL21hYy9QbHVnaW5QYWNrYWdlTWFjLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTc3LDcgKzE3Nyw3IEBAIGJvb2wgUGx1Z2luUGFja2FnZTo6ZmV0Y2hJbmZvKCkKIAogICAg ICAgICAgICAgV1RGOjpSZXRhaW5QdHI8Q0ZEaWN0aW9uYXJ5UmVmPiBleHRlbnNpb25zRGljdCA9 IChDRkRpY3Rpb25hcnlSZWYpdmFsdWVzW2ldOwogCi0gICAgICAgICAgICBXVEY6UmV0YWluUHRy PENGTnVtYmVyUmVmPiBlbmFibGVkID0gKENGTnVtYmVyUmVmKUNGRGljdGlvbmFyeUdldFZhbHVl KGV4dGVuc2lvbnNEaWN0LmdldCgpLCBDRlNUUigiV2ViUGx1Z2luVHlwZUVuYWJsZWQiKSk7Cisg ICAgICAgICAgICBXVEY6OlJldGFpblB0cjxDRk51bWJlclJlZj4gZW5hYmxlZCA9IChDRk51bWJl clJlZilDRkRpY3Rpb25hcnlHZXRWYWx1ZShleHRlbnNpb25zRGljdC5nZXQoKSwgQ0ZTVFIoIldl YlBsdWdpblR5cGVFbmFibGVkIikpOwogICAgICAgICAgICAgaWYgKGVuYWJsZWQpIHsKICAgICAg ICAgICAgICAgICBpbnQgZW5hYmxlZFZhbHVlID0gMDsKICAgICAgICAgICAgICAgICBpZiAoQ0ZO dW1iZXJHZXRWYWx1ZShlbmFibGVkLmdldCgpLCBrQ0ZOdW1iZXJJbnRUeXBlLCAmZW5hYmxlZFZh bHVlKSAmJiBlbmFibGVkVmFsdWUgPT0gMCkKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9tYWMvUGx1 Z2luVmlld01hYy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVnaW5zL21hYy9QbHVnaW5W aWV3TWFjLmNwcAkocmV2aXNpb24gNTE0NjcpCisrKyBXZWJDb3JlL3BsdWdpbnMvbWFjL1BsdWdp blZpZXdNYWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MDIsNyArNDAyLDcgQEAgdm9pZCBQbHVn aW5WaWV3OjpzZXROUFdpbmRvd0lmTmVlZGVkKCkKICAgICBtX25wV2luZG93LmNsaXBSZWN0LmJv dHRvbSA9IG1fd2luZG93UmVjdC55KCkgKyBtX3dpbmRvd1JlY3QuaGVpZ2h0KCk7CiAKICAgICBM T0coUGx1Z2lucywgIlBsdWdpblZpZXc6OnNldE5QV2luZG93SWZOZWVkZWQoKTogd2luZG93PSVw LCBjb250ZXh0PSVwLCIKLSAgICAgICAgICAgICIgd2luZG93Lng6JWQgd2luZG93Lnk6JWQgd2lu ZG93LndpZHRoOiVkIHdpbmRvdy5oZWlnaHQ6JWQgd2luZG93LmNsaXBSZWN0IHNpemU6JWR4JWQi LAorICAgICAgICAgICAgIiB3aW5kb3cueDolbGQgd2luZG93Lnk6JWxkIHdpbmRvdy53aWR0aDol ZCB3aW5kb3cuaGVpZ2h0OiVkIHdpbmRvdy5jbGlwUmVjdCBzaXplOiVkeCVkIiwKICAgICAgICAg ICAgIG5ld1dpbmRvd1JlZiwgbmV3Q29udGV4dFJlZiwgbV9ucFdpbmRvdy54LCBtX25wV2luZG93 LnksIG1fbnBXaW5kb3cud2lkdGgsIG1fbnBXaW5kb3cuaGVpZ2h0LAogICAgICAgICAgICAgbV9u cFdpbmRvdy5jbGlwUmVjdC5yaWdodCAtIG1fbnBXaW5kb3cuY2xpcFJlY3QubGVmdCwgbV9ucFdp bmRvdy5jbGlwUmVjdC5ib3R0b20gLSBtX25wV2luZG93LmNsaXBSZWN0LnRvcCk7CiAK