31958 2009-11-28 22:11:25 -0800 [Qt] Remove obsolete PLATFORM(KDE) code 2009-11-30 12:42:33 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned commit-queue eric faure hausmann mueller porten zack oldest_to_newest 167069 0 laszlo.gombos 2009-11-28 22:11:25 -0800 KDE is now using the "vanilla" QtWebKit - there is no KDE specific code remained in WebKit. As far as I can this is the case after r18098. 167070 1 43989 laszlo.gombos 2009-11-28 22:16:52 -0800 Created attachment 43989 proposed change 167074 2 eric 2009-11-29 07:14:31 -0800 OK, I believe you. CC'd a few folks who I believe still work on KDE. 167107 3 laszlo.gombos 2009-11-29 14:45:41 -0800 Thanks Eric for the review. I will wait about a week to see if anyone would object to this and will commit it. 167117 4 hausmann 2009-11-29 15:43:45 -0800 Nice cleanup! I believe that's the correct change. KDE has now a layer on top of QtWebKit, it does not require a special build/set of #ifdefs. 167240 5 43989 commit-queue 2009-11-30 08:24:06 -0800 Comment on attachment 43989 proposed change Rejecting patch 43989 from commit-queue. Failed to run "['WebKitTools/Scripts/build-webkit']" exit_code: 1 Last 500 characters of output: Script-14D857B50A469C100032146C.sh === BUILDING AGGREGATE TARGET All OF PROJECT JavaScriptCore WITH CONFIGURATION Release === Checking Dependencies... ** BUILD FAILED ** The following build commands failed: JavaScriptCore: Distributed-CompileC /Users/eseidel/Projects/CommitQueue/WebKitBuild/JavaScriptCore.build/Release/JavaScriptCore.build/Objects-normal/i386/Lexer.o /Users/eseidel/Projects/CommitQueue/JavaScriptCore/parser/Lexer.cpp normal i386 c++ com.apple.compilers.gcc.4_2 (1 failure) 167242 6 eric 2009-11-30 08:29:38 -0800 The commit queue got stuck on this patch for hours before I restarted it. I think it was a python compilation problem in the end since it went away after restart. bug 31983. It failed very quickly after restart, I've not tried applying it manually, but I believe this is a real compile failure. 167305 7 43989 laszlo.gombos 2009-11-30 11:08:15 -0800 Comment on attachment 43989 proposed change Clearing review flag as I think the build bot is right this time. Will fix the patch and resubmit for review. 167313 8 44033 laszlo.gombos 2009-11-30 11:56:51 -0800 Created attachment 44033 Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL 167366 9 44033 commit-queue 2009-11-30 12:42:26 -0800 Comment on attachment 44033 Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL Clearing flags on attachment: 44033 Committed r51505: <http://trac.webkit.org/changeset/51505> 167368 10 commit-queue 2009-11-30 12:42:33 -0800 All reviewed patches have been landed. Closing bug. 43989 2009-11-28 22:16:52 -0800 2009-11-30 11:56:51 -0800 proposed change 31958.patch text/plain 2083 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxNDY1KQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMjggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIG9ic29sZXRlIFBMQVRGT1JN KEtERSkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE5NTgKKworICAgICAgICBLREUgaXMgbm93IHVzaW5nIHVucGF0Y2hlZCBRdFdlYktpdC4K KworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6IFJlbW92ZSBjb2RlIGd1YXJkZWQgd2l0aCBL REVfVVNFX0ZJTkFMCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IFJlbW92ZSBQTEFURk9STShL REUpIGRlZmluaXRpb24gYW5kIGNvZGUgCisgICAgICAgIHNlY3Rpb24gdGhhdCBpcyBndWFyZGVk IHdpdGggaXQuCisKIDIwMDktMTEtMjggIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NA bm9raWEuY29tPgogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAJKHJldmlzaW9uIDUxNDYx KQorKysgSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzksMTAgKzM5LDYgQEAgdXNpbmcgbmFtZXNwYWNlIFVuaWNvZGU7CiAvLyBXZSBjYW4ndCBzcGVj aWZ5IHRoZSBuYW1lc3BhY2UgaW4geWFjYydzIEMgb3V0cHV0LCBzbyBkbyBpdCBoZXJlIGluc3Rl YWQuCiB1c2luZyBuYW1lc3BhY2UgSlNDOwogCi0jaWZuZGVmIEtERV9VU0VfRklOQUwKLSNpbmNs dWRlICJHcmFtbWFyLmgiCi0jZW5kaWYKLQogI2luY2x1ZGUgIkxvb2t1cC5oIgogI2luY2x1ZGUg IkxleGVyLmx1dC5oIgogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkocmV2aXNpb24gNTE0NjEp CisrKyBKYXZhU2NyaXB0Q29yZS93dGYvUGxhdGZvcm0uaAkod29ya2luZyBjb3B5KQpAQCAtMTQx LDE5ICsxNDEsMTUgQEAKIAogLyogUExBVEZPUk0oQ0hST01JVU0pICovCiAvKiBQTEFURk9STShR VCkgKi8KKy8qIFBMQVRGT1JNKFdYKSAqLwogLyogUExBVEZPUk0oR1RLKSAqLworLyogUExBVEZP Uk0oSEFJS1UpICovCiAvKiBQTEFURk9STShNQUMpICovCiAvKiBQTEFURk9STShXSU4pICovCiAj aWYgZGVmaW5lZChCVUlMRElOR19DSFJPTUlVTV9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1fQ0hS T01JVU0gMQogI2VsaWYgZGVmaW5lZChCVUlMRElOR19RVF9fKQogI2RlZmluZSBXVEZfUExBVEZP Uk1fUVQgMQotCi0vKiBQTEFURk9STShLREUpICovCi0jaWYgZGVmaW5lZChCVUlMRElOR19LREVf XykKLSNkZWZpbmUgV1RGX1BMQVRGT1JNX0tERSAxCi0jZW5kaWYKLQogI2VsaWYgZGVmaW5lZChC VUlMRElOR19XWF9fKQogI2RlZmluZSBXVEZfUExBVEZPUk1fV1ggMQogI2VsaWYgZGVmaW5lZChC VUlMRElOR19HVEtfXykKQEAgLTQ3Niw4ICs0NzIsNyBAQAogCiAjZW5kaWYgIC8qIFBMQVRGT1JN KFdJTkNFKSAmJiAhUExBVEZPUk0oUVQpICovCiAKLS8qIGZvciBVbmljb2RlLCBLREUgdXNlcyBR dCAqLwotI2lmIFBMQVRGT1JNKEtERSkgfHwgUExBVEZPUk0oUVQpCisjaWYgUExBVEZPUk0oUVQp CiAjZGVmaW5lIFdURl9VU0VfUVQ0X1VOSUNPREUgMQogI2VsaWYgUExBVEZPUk0oV0lOQ0UpCiAj ZGVmaW5lIFdURl9VU0VfV0lOQ0VfVU5JQ09ERSAxCg== 44033 2009-11-30 11:56:51 -0800 2009-11-30 12:42:26 -0800 Put back Grammar.h to Lexer.cpp is it is guarded with if_n_def KDE_USE_FINAL 31958.patch text/plain 2114 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxNDcyKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMzAgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVtb3ZlIG9ic29sZXRlIFBMQVRGT1JN KEtERSkgY29kZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE5NTgKKworICAgICAgICBLREUgaXMgbm93IHVzaW5nIHVucGF0Y2hlZCBRdFdlYktpdC4K KworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6IFJlbW92ZSBvYnNvbGV0ZSBLREVfVVNFX0ZJ TkFMIGd1YXJkCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IFJlbW92ZSBQTEFURk9STShLREUp IGRlZmluaXRpb24gYW5kIGNvZGUgCisgICAgICAgIHNlY3Rpb24gdGhhdCBpcyBndWFyZGVkIHdp dGggaXQuCisKIDIwMDktMTEtMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9r aWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpJbmRleDogSmF2YVNj cmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9w YXJzZXIvTGV4ZXIuY3BwCShyZXZpc2lvbiA1MTQ3MikKKysrIEphdmFTY3JpcHRDb3JlL3BhcnNl ci9MZXhlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDEwICszOSw3IEBAIHVzaW5nIG5hbWVz cGFjZSBVbmljb2RlOwogLy8gV2UgY2FuJ3Qgc3BlY2lmeSB0aGUgbmFtZXNwYWNlIGluIHlhY2Mn cyBDIG91dHB1dCwgc28gZG8gaXQgaGVyZSBpbnN0ZWFkLgogdXNpbmcgbmFtZXNwYWNlIEpTQzsK IAotI2lmbmRlZiBLREVfVVNFX0ZJTkFMCiAjaW5jbHVkZSAiR3JhbW1hci5oIgotI2VuZGlmCi0K ICNpbmNsdWRlICJMb29rdXAuaCIKICNpbmNsdWRlICJMZXhlci5sdXQuaCIKIApJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDUxNDcyKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1Bs YXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTE0MSwxOSArMTQxLDE1IEBACiAKIC8qIFBMQVRG T1JNKENIUk9NSVVNKSAqLwogLyogUExBVEZPUk0oUVQpICovCisvKiBQTEFURk9STShXWCkgKi8K IC8qIFBMQVRGT1JNKEdUSykgKi8KKy8qIFBMQVRGT1JNKEhBSUtVKSAqLwogLyogUExBVEZPUk0o TUFDKSAqLwogLyogUExBVEZPUk0oV0lOKSAqLwogI2lmIGRlZmluZWQoQlVJTERJTkdfQ0hST01J VU1fXykKICNkZWZpbmUgV1RGX1BMQVRGT1JNX0NIUk9NSVVNIDEKICNlbGlmIGRlZmluZWQoQlVJ TERJTkdfUVRfXykKICNkZWZpbmUgV1RGX1BMQVRGT1JNX1FUIDEKLQotLyogUExBVEZPUk0oS0RF KSAqLwotI2lmIGRlZmluZWQoQlVJTERJTkdfS0RFX18pCi0jZGVmaW5lIFdURl9QTEFURk9STV9L REUgMQotI2VuZGlmCi0KICNlbGlmIGRlZmluZWQoQlVJTERJTkdfV1hfXykKICNkZWZpbmUgV1RG X1BMQVRGT1JNX1dYIDEKICNlbGlmIGRlZmluZWQoQlVJTERJTkdfR1RLX18pCkBAIC00NzYsOCAr NDcyLDcgQEAKIAogI2VuZGlmICAvKiBQTEFURk9STShXSU5DRSkgJiYgIVBMQVRGT1JNKFFUKSAq LwogCi0vKiBmb3IgVW5pY29kZSwgS0RFIHVzZXMgUXQgKi8KLSNpZiBQTEFURk9STShLREUpIHx8 IFBMQVRGT1JNKFFUKQorI2lmIFBMQVRGT1JNKFFUKQogI2RlZmluZSBXVEZfVVNFX1FUNF9VTklD T0RFIDEKICNlbGlmIFBMQVRGT1JNKFdJTkNFKQogI2RlZmluZSBXVEZfVVNFX1dJTkNFX1VOSUNP REUgMQo=