31956 2009-11-28 15:52:02 -0800 Move some build decisions from Qt build system into source files 2009-12-18 16:30:11 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned abarth commit-queue eric kevino mark mjs oldest_to_newest 167055 0 laszlo.gombos 2009-11-28 15:52:02 -0800 This patch a step towards a new way to handle porting #ifdefs - as it has been proposed by Maciej Stachowiak on webkit-dev. > I know there is a potential compile time tradeoff, but in some ways > it would be nicer if all build systems built the same set of files, > and we ifdef'd the contents. That would put the policy decisions all > in one place (the port header). see https://lists.webkit.org/pipermail/webkit-dev/2009-May/007858.html. There was not probably a consensus on all aspects of Maciej's proposal but I was hoping that there was enough of consensus to approve the direction of the following patch. 167056 1 43985 laszlo.gombos 2009-11-28 16:04:05 -0800 Created attachment 43985 proposed patch 167060 2 kevino 2009-11-28 16:58:37 -0800 (In reply to comment #0) > This patch a step towards a new way to handle porting #ifdefs - as it has been > proposed by Maciej Stachowiak on webkit-dev. > > > I know there is a potential compile time tradeoff, but in some ways > > it would be nicer if all build systems built the same set of files, > > and we ifdef'd the contents. That would put the policy decisions all > > in one place (the port header). > > see https://lists.webkit.org/pipermail/webkit-dev/2009-May/007858.html. > > There was not probably a consensus on all aspects of Maciej's proposal but I > was hoping that there was enough of consensus to approve the direction of the > following patch. I like the general idea, as it would simplify the wx port's wscripts even more, but the wx part of the patch is wrong. We are compiling ThreadingPthreads.cpp on all platforms, not ThreadingNone.cpp. It should be safe to define JSC_MULTIPLE_THREADS for wx too, I'm actually not sure how it was overlooked. 167062 3 43987 laszlo.gombos 2009-11-28 17:45:40 -0800 Created attachment 43987 Respond to Kevin's comments Kevin, thanks for the comments. I removed the WX part from Platform.h - this makes the patch even simpler. I found ThreadingNone.cpp in JavaScriptCoreSources.bkl, this is why I though the Wx port is using ThreadingNone.cpp. Is the JavaScriptCoreSources.bkl file now obsolete ? As for JSC_MULTIPLE_THREADS for wx, can you please file a separate patch for that ? 167075 4 eric 2009-11-29 07:16:33 -0800 Hmm... This looks OK, but it's going to make for some crazy platform/ files in WebCore. :) 167264 5 kevino 2009-11-30 09:13:55 -0800 (In reply to comment #3) > Created an attachment (id=43987) [details] > Respond to Kevin's comments > > Kevin, thanks for the comments. I removed the WX part from Platform.h - this > makes the patch even simpler. > > I found ThreadingNone.cpp in JavaScriptCoreSources.bkl, this is why I though > the Wx port is using ThreadingNone.cpp. Is the JavaScriptCoreSources.bkl file > now obsolete ? Yes, actually all of the Bakefile stuff needs to be removed, as it is no longer being used. I just haven't had time to devote to doing the cleanup recently. > As for JSC_MULTIPLE_THREADS for wx, can you please file a separate patch for > that ? Yeah, I'll put this on my TODO list and handle it as a separate ticket. Thanks! 167378 6 abarth 2009-11-30 12:47:40 -0800 style-queue ran check-webkit-style on attachment 43987 without any errors. 167695 7 laszlo.gombos 2009-12-01 11:58:36 -0800 (In reply to comment #4) > Hmm... This looks OK, but it's going to make for some crazy platform/ files in > WebCore. :) I do not see landing this patch as a commitment to follow this approach trough for the entire WebKit source tree, but I did wanted to highlight that this was discussed on webkit-dev and proposed before. I think for now we should continue the discussion/reviews on a per patch bases. Kevin's feedback for the from the wx build system perspective seems to be positive. 172793 8 43987 kenneth 2009-12-17 08:39:15 -0800 Comment on attachment 43987 Respond to Kevin's comments Great change! There seems to be general consensus on this, so r+ 173396 9 43987 commit-queue 2009-12-18 16:30:03 -0800 Comment on attachment 43987 Respond to Kevin's comments Clearing flags on attachment: 43987 Committed r52355: <http://trac.webkit.org/changeset/52355> 173397 10 commit-queue 2009-12-18 16:30:11 -0800 All reviewed patches have been landed. Closing bug. 43985 2009-11-28 16:04:05 -0800 2009-11-28 17:45:40 -0800 proposed patch 31956.patch text/plain 7354 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDktMTEtMjggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgc29tZSBidWlsZCBkZWNpc2lvbnMgZnJv bSBRdCBidWlsZCBzeXN0ZW0gaW50byBzb3VyY2UgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTU2CisKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS5wcmk6IENvbXBpbGUgZmlsZXMgdW5jb25kaXRpb25hbGx5CisgICAgICAgICogaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JQb3NpeC5jcHA6IEd1YXJkIHdpdGggUExBVEZPUk0oVU5JWCkgJiYg IVBMQVRGT1JNKFNZTUJJQU4pCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4u Y3BwOiBHdWFyZCB3aXRoIFBMQVRGT1JNKFdJTl9PUykKKyAgICAgICAgKiBydW50aW1lL01hcmtT dGFja1Bvc2l4LmNwcDogR3VhcmQgd2l0aCBQTEFURk9STShVTklYKSAmJiAhUExBVEZPUk0oU1lN QklBTikKKyAgICAgICAgKiBydW50aW1lL01hcmtTdGFja1N5bWJpYW4uY3BwOiBHdWFyZCB3aXRo IFBMQVRGT1JNKFNZTUJJQU4pCisgICAgICAgICogcnVudGltZS9NYXJrU3RhY2tXaW4uY3BwOiBH dWFyZCB3aXRoIFBMQVRGT1JNKFdJTl9PUykKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogRGVm aW5lIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQgZm9yIFd4IHBvcnQgdG8gcGljayB1cCBUaHJlYWRp bmdOb25lLmNwcCBhbmQgCisgICAgICAgIGd1YXJkIEVOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFE UyB3aXRoIEVOQUJMRV9TSU5HTEVfVEhSRUFERUQgZm9yIHRoZSBRdCBwb3J0CisKKyAgICAgICAg KiB3dGYvVGhyZWFkaW5nTm9uZS5jcHA6IEd1YXJkIHdpdGggRU5BQkxFKFNJTkdMRV9USFJFQURF RCkKKyAgICAgICAgKiB3dGYvcXQvVGhyZWFkaW5nUXQuY3BwOiBHdWFyZCB3aXRoICFFTkFCTEUo U0lOR0xFX1RIUkVBREVEKQorCiAyMDA5LTExLTI4ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEu Z29tYm9zQG5va2lhLmNvbT4KIApJbmRleDogSmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUu cHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL0phdmFTY3JpcHRDb3JlLnByaQkocmV2 aXNpb24gNTE0NjEpCisrKyBKYXZhU2NyaXB0Q29yZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHdvcmtp bmcgY29weSkKQEAgLTExNCw2ICsxMTQsOSBAQCBTT1VSQ0VTICs9IFwKICAgICBpbnRlcnByZXRl ci9DYWxsRnJhbWUuY3BwIFwKICAgICBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAgXAogICAg IGludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHAgXAorICAgIGppdC9FeGVjdXRhYmxlQWxsb2Nh dG9yUG9zaXguY3BwIFwKKyAgICBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvclN5bWJpYW4uY3BwIFwK KyAgICBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvcldpbi5jcHAgXAogICAgIGppdC9FeGVjdXRhYmxl QWxsb2NhdG9yLmNwcCBcCiAgICAgaml0L0pJVEFyaXRobWV0aWMuY3BwIFwKICAgICBqaXQvSklU Q2FsbC5jcHAgXApAQCAtMTgzLDYgKzE4Niw5IEBAIFNPVVJDRVMgKz0gXAogICAgIHJ1bnRpbWUv SlNXcmFwcGVyT2JqZWN0LmNwcCBcCiAgICAgcnVudGltZS9MaXRlcmFsUGFyc2VyLmNwcCBcCiAg ICAgcnVudGltZS9Mb29rdXAuY3BwIFwKKyAgICBydW50aW1lL01hcmtTdGFja1Bvc2l4LmNwcCBc CisgICAgcnVudGltZS9NYXJrU3RhY2tTeW1iaWFuLmNwcCBcCisgICAgcnVudGltZS9NYXJrU3Rh Y2tXaW4uY3BwIFwKICAgICBydW50aW1lL01hcmtTdGFjay5jcHAgXAogICAgIHJ1bnRpbWUvTWF0 aE9iamVjdC5jcHAgXAogICAgIHJ1bnRpbWUvTmF0aXZlRXJyb3JDb25zdHJ1Y3Rvci5jcHAgXApA QCAtMjE5LDggKzIyNSwxMCBAQCBTT1VSQ0VTICs9IFwKICAgICB3dGYvSGFzaFRhYmxlLmNwcCBc CiAgICAgd3RmL01haW5UaHJlYWQuY3BwIFwKICAgICB3dGYvcXQvTWFpblRocmVhZFF0LmNwcCBc CisgICAgd3RmL3F0L1RocmVhZGluZ1F0LmNwcCBcCiAgICAgd3RmL1JhbmRvbU51bWJlci5jcHAg XAogICAgIHd0Zi9SZWZDb3VudGVkTGVha0NvdW50ZXIuY3BwIFwKKyAgICB3dGYvVGhyZWFkaW5n Tm9uZS5jcHAgXAogICAgIHd0Zi9UaHJlYWRpbmcuY3BwIFwKICAgICB3dGYvVHlwZVRyYWl0cy5j cHAgXAogICAgIHd0Zi91bmljb2RlL0NvbGxhdG9yRGVmYXVsdC5jcHAgXApAQCAtMjMwLDMwICsy MzgsMTAgQEAgU09VUkNFUyArPSBcCiAgICAgeWFyci9SZWdleEludGVycHJldGVyLmNwcCBcCiAg ICAgeWFyci9SZWdleEpJVC5jcHAKIAotc3ltYmlhbiB7Ci0gICAgU09VUkNFUyArPSBqaXQvRXhl Y3V0YWJsZUFsbG9jYXRvclN5bWJpYW4uY3BwIFwKLSAgICAgICAgICAgICAgcnVudGltZS9NYXJr U3RhY2tTeW1iaWFuLmNwcAotfSBlbHNlIHsKLSAgICB3aW4zMi0qfHdpbmNlKiB7Ci0gICAgICAg IFNPVVJDRVMgKz0gaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4uY3BwIFwKLSAgICAgICAgICAg ICAgICAgIHJ1bnRpbWUvTWFya1N0YWNrV2luLmNwcAotICAgIH0gZWxzZSB7Ci0gICAgICAgIFNP VVJDRVMgKz0gaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JQb3NpeC5jcHAgXAotICAgICAgICAgICAg ICAgICAgcnVudGltZS9NYXJrU3RhY2tQb3NpeC5jcHAKLSAgICB9Ci19Ci0KICFjb250YWlucyhE RUZJTkVTLCBVU0VfU1lTVEVNX01BTExPQykgewogICAgIFNPVVJDRVMgKz0gd3RmL1RDU3lzdGVt QWxsb2MuY3BwCiB9CiAKLSFjb250YWlucyhERUZJTkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVE PTEpIHsKLSAgICBTT1VSQ0VTICs9IHd0Zi9xdC9UaHJlYWRpbmdRdC5jcHAKLX0gZWxzZSB7Ci0g ICAgREVGSU5FUyArPSBFTkFCTEVfSlNDX01VTFRJUExFX1RIUkVBRFM9MAotICAgIFNPVVJDRVMg Kz0gd3RmL1RocmVhZGluZ05vbmUuY3BwCi19Ci0KICMgR0VORVJBVE9SIDEtQTogTFVUIGNyZWF0 b3IKIGx1dC5vdXRwdXQgPSAkJHtHRU5FUkFURURfU09VUkNFU19ESVJ9JCR7UU1BS0VfRElSX1NF UH0ke1FNQUtFX0ZJTEVfQkFTRX0ubHV0LmgKIGx1dC5jb21tYW5kcyA9IHBlcmwgJCRQV0QvY3Jl YXRlX2hhc2hfdGFibGUgJHtRTUFLRV9GSUxFX05BTUV9IC1pID4gJHtRTUFLRV9GSUxFX09VVH0K SW5kZXg6IEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXgu Y3BwCShyZXZpc2lvbiA1MTQ2MSkKKysrIEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yUG9zaXguY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAKICNpbmNs dWRlICJFeGVjdXRhYmxlQWxsb2NhdG9yLmgiCiAKLSNpZiBFTkFCTEUoQVNTRU1CTEVSKQorI2lm IEVOQUJMRShBU1NFTUJMRVIpICYmIFBMQVRGT1JNKFVOSVgpICYmICFQTEFURk9STShTWU1CSUFO KQogCiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNpbmNsdWRlIDx1bmlzdGQuaD4KSW5kZXg6IEph dmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yV2luLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJsZUFsbG9jYXRvcldpbi5jcHAJKHJldmlzaW9u IDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3IEBACiAKICNpbmNsdWRlICJFeGVjdXRhYmxl QWxsb2NhdG9yLmgiCiAKLSNpZiBFTkFCTEUoQVNTRU1CTEVSKQorI2lmIEVOQUJMRShBU1NFTUJM RVIpICYmIFBMQVRGT1JNKFdJTl9PUykKIAogI2luY2x1ZGUgIndpbmRvd3MuaCIKIApJbmRleDog SmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2tQb3NpeC5jcHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g SmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2tQb3NpeC5jcHAJKHJldmlzaW9uIDUxNDYx KQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2tQb3NpeC5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTI0LDEwICsyNCwxMCBAQAogICovCiAKICNpbmNsdWRlICJjb25maWcuaCIKLQot CiAjaW5jbHVkZSAiTWFya1N0YWNrLmgiCiAKKyNpZiBQTEFURk9STShVTklYKSAmJiAhUExBVEZP Uk0oU1lNQklBTikKKwogI2luY2x1ZGUgPHVuaXN0ZC5oPgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+ CiAKQEAgLTQ4LDMgKzQ4LDUgQEAgdm9pZCBNYXJrU3RhY2s6OnJlbGVhc2VTdGFjayh2b2lkKiBh ZGRyLAogfQogCiB9CisKKyNlbmRpZgpJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJr U3RhY2tTeW1iaWFuLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL01h cmtTdGFja1N5bWJpYW4uY3BwCShyZXZpc2lvbiA1MTQ2MSkKKysrIEphdmFTY3JpcHRDb3JlL3J1 bnRpbWUvTWFya1N0YWNrU3ltYmlhbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTIwLDYgKzIwLDgg QEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJNYXJrU3RhY2suaCIKIAorI2lmIFBM QVRGT1JNKFNZTUJJQU4pCisKICNpbmNsdWRlIDxlMzJoYWwuaD4KIAogbmFtZXNwYWNlIEpTQyB7 CkBAIC00MiwzICs0NCw1IEBAIHZvaWQgTWFya1N0YWNrOjpyZWxlYXNlU3RhY2sodm9pZCogYWRk ciwKIH0KIAogfQorCisjZW5kaWYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya1N0 YWNrV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtTdGFj a1dpbi5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJr U3RhY2tXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNCwxMCArMjQsMTAgQEAKICAqLwogCiAj aW5jbHVkZSAiY29uZmlnLmgiCi0KLQogI2luY2x1ZGUgIk1hcmtTdGFjay5oIgogCisjaWYgUExB VEZPUk0oV0lOX09TKQorCiAjaW5jbHVkZSAid2luZG93cy5oIgogCiBuYW1lc3BhY2UgSlNDIHsK QEAgLTUxLDMgKzUxLDUgQEAgdm9pZCBNYXJrU3RhY2s6OnJlbGVhc2VTdGFjayh2b2lkKiBhZGRy LAogfQogCiB9CisKKyNlbmRpZgpJbmRleDogSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDUx NDYxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAg LTQ0MCw3ICs0NDAsMTEgQEAKICNkZWZpbmUgV1RGX0NPTVBJTEVSX1dJTlNDVyAxCiAjZW5kaWYK IAotI2lmIChQTEFURk9STShJUEhPTkUpIHx8IFBMQVRGT1JNKE1BQykgfHwgUExBVEZPUk0oV0lO KSB8fCAoUExBVEZPUk0oUVQpICYmIFBMQVRGT1JNKERBUldJTikpKSAmJiAhZGVmaW5lZChFTkFC TEVfSlNDX01VTFRJUExFX1RIUkVBRFMpCisjaWYgUExBVEZPUk0oV1gpCisjZGVmaW5lIEVOQUJM RV9TSU5HTEVfVEhSRUFERUQgMQorI2VuZGlmCisKKyNpZiAoUExBVEZPUk0oSVBIT05FKSB8fCBQ TEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgKFBMQVRGT1JNKFFUKSAmJiBQTEFURk9S TShEQVJXSU4pICYmICFFTkFCTEUoU0lOR0xFX1RIUkVBREVEKSkpICYmICFkZWZpbmVkKEVOQUJM RV9KU0NfTVVMVElQTEVfVEhSRUFEUykKICNkZWZpbmUgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJF QURTIDEKICNlbmRpZgogCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvVGhyZWFkaW5nTm9uZS5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL1RocmVhZGluZ05vbmUuY3BwCShy ZXZpc2lvbiA1MTQ2MSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9UaHJlYWRpbmdOb25lLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2lu Y2x1ZGUgIlRocmVhZGluZy5oIgogCisjaWYgRU5BQkxFKFNJTkdMRV9USFJFQURFRCkKKwogbmFt ZXNwYWNlIFdURiB7CiAKIHZvaWQgaW5pdGlhbGl6ZVRocmVhZGluZygpIHsgfQpAQCAtNTcsMyAr NTksNSBAQCB2b2lkIGxvY2tBdG9taWNhbGx5SW5pdGlhbGl6ZWRTdGF0aWNNdXRlCiB2b2lkIHVu bG9ja0F0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpY011dGV4KCkgeyB9CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKKworI2VuZGlmCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvcXQvVGhyZWFk aW5nUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9xdC9UaHJlYWRpbmdR dC5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL3F0L1RocmVhZGlu Z1F0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjksOCBAQAogI2luY2x1ZGUgImNvbmZp Zy5oIgogI2luY2x1ZGUgIlRocmVhZGluZy5oIgogCisjaWYgIUVOQUJMRShTSU5HTEVfVEhSRUFE RUQpCisKICNpbmNsdWRlICJDdXJyZW50VGltZS5oIgogI2luY2x1ZGUgIkhhc2hNYXAuaCIKICNp bmNsdWRlICJNYWluVGhyZWFkLmgiCkBAIC0yNjcsMyArMjY5LDUgQEAgdm9pZCBUaHJlYWRDb25k aXRpb246OmJyb2FkY2FzdCgpCiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlm Cg== 43987 2009-11-28 17:45:40 -0800 2009-12-18 16:30:02 -0800 Respond to Kevin's comments 31956.patch text/plain 7204 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMTEtMjggIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1vdmUgc29tZSBidWlsZCBkZWNpc2lvbnMgZnJv bSBRdCBidWlsZCBzeXN0ZW0gaW50byBzb3VyY2UgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTU2CisKKyAgICAgICAgKiBKYXZhU2NyaXB0 Q29yZS5wcmk6IENvbXBpbGUgZmlsZXMgdW5jb25kaXRpb25hbGx5CisgICAgICAgICogaml0L0V4 ZWN1dGFibGVBbGxvY2F0b3JQb3NpeC5jcHA6IEd1YXJkIHdpdGggUExBVEZPUk0oVU5JWCkgJiYg IVBMQVRGT1JNKFNZTUJJQU4pCisgICAgICAgICogaml0L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4u Y3BwOiBHdWFyZCB3aXRoIFBMQVRGT1JNKFdJTl9PUykKKyAgICAgICAgKiBydW50aW1lL01hcmtT dGFja1Bvc2l4LmNwcDogR3VhcmQgd2l0aCBQTEFURk9STShVTklYKSAmJiAhUExBVEZPUk0oU1lN QklBTikKKyAgICAgICAgKiBydW50aW1lL01hcmtTdGFja1N5bWJpYW4uY3BwOiBHdWFyZCB3aXRo IFBMQVRGT1JNKFNZTUJJQU4pCisgICAgICAgICogcnVudGltZS9NYXJrU3RhY2tXaW4uY3BwOiBH dWFyZCB3aXRoIFBMQVRGT1JNKFdJTl9PUykKKyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDogR3Vh cmQgRU5BQkxFX0pTQ19NVUxUSVBMRV9USFJFQURTIHdpdGggRU5BQkxFX1NJTkdMRV9USFJFQURF RCBmb3IgdGhlIFF0IHBvcnQKKyAgICAgICAgKiB3dGYvVGhyZWFkaW5nTm9uZS5jcHA6IEd1YXJk IHdpdGggRU5BQkxFKFNJTkdMRV9USFJFQURFRCkKKyAgICAgICAgKiB3dGYvcXQvVGhyZWFkaW5n UXQuY3BwOiBHdWFyZCB3aXRoICFFTkFCTEUoU0lOR0xFX1RIUkVBREVEKQorCiAyMDA5LTExLTI4 ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIApJbmRleDogSmF2 YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUucHJpCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD b3JlL0phdmFTY3JpcHRDb3JlLnByaQkocmV2aXNpb24gNTE0NjEpCisrKyBKYXZhU2NyaXB0Q29y ZS9KYXZhU2NyaXB0Q29yZS5wcmkJKHdvcmtpbmcgY29weSkKQEAgLTExNCw2ICsxMTQsOSBAQCBT T1VSQ0VTICs9IFwKICAgICBpbnRlcnByZXRlci9DYWxsRnJhbWUuY3BwIFwKICAgICBpbnRlcnBy ZXRlci9JbnRlcnByZXRlci5jcHAgXAogICAgIGludGVycHJldGVyL1JlZ2lzdGVyRmlsZS5jcHAg XAorICAgIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwIFwKKyAgICBqaXQvRXhlY3V0 YWJsZUFsbG9jYXRvclN5bWJpYW4uY3BwIFwKKyAgICBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvcldp bi5jcHAgXAogICAgIGppdC9FeGVjdXRhYmxlQWxsb2NhdG9yLmNwcCBcCiAgICAgaml0L0pJVEFy aXRobWV0aWMuY3BwIFwKICAgICBqaXQvSklUQ2FsbC5jcHAgXApAQCAtMTgzLDYgKzE4Niw5IEBA IFNPVVJDRVMgKz0gXAogICAgIHJ1bnRpbWUvSlNXcmFwcGVyT2JqZWN0LmNwcCBcCiAgICAgcnVu dGltZS9MaXRlcmFsUGFyc2VyLmNwcCBcCiAgICAgcnVudGltZS9Mb29rdXAuY3BwIFwKKyAgICBy dW50aW1lL01hcmtTdGFja1Bvc2l4LmNwcCBcCisgICAgcnVudGltZS9NYXJrU3RhY2tTeW1iaWFu LmNwcCBcCisgICAgcnVudGltZS9NYXJrU3RhY2tXaW4uY3BwIFwKICAgICBydW50aW1lL01hcmtT dGFjay5jcHAgXAogICAgIHJ1bnRpbWUvTWF0aE9iamVjdC5jcHAgXAogICAgIHJ1bnRpbWUvTmF0 aXZlRXJyb3JDb25zdHJ1Y3Rvci5jcHAgXApAQCAtMjE5LDggKzIyNSwxMCBAQCBTT1VSQ0VTICs9 IFwKICAgICB3dGYvSGFzaFRhYmxlLmNwcCBcCiAgICAgd3RmL01haW5UaHJlYWQuY3BwIFwKICAg ICB3dGYvcXQvTWFpblRocmVhZFF0LmNwcCBcCisgICAgd3RmL3F0L1RocmVhZGluZ1F0LmNwcCBc CiAgICAgd3RmL1JhbmRvbU51bWJlci5jcHAgXAogICAgIHd0Zi9SZWZDb3VudGVkTGVha0NvdW50 ZXIuY3BwIFwKKyAgICB3dGYvVGhyZWFkaW5nTm9uZS5jcHAgXAogICAgIHd0Zi9UaHJlYWRpbmcu Y3BwIFwKICAgICB3dGYvVHlwZVRyYWl0cy5jcHAgXAogICAgIHd0Zi91bmljb2RlL0NvbGxhdG9y RGVmYXVsdC5jcHAgXApAQCAtMjMwLDMwICsyMzgsMTAgQEAgU09VUkNFUyArPSBcCiAgICAgeWFy ci9SZWdleEludGVycHJldGVyLmNwcCBcCiAgICAgeWFyci9SZWdleEpJVC5jcHAKIAotc3ltYmlh biB7Ci0gICAgU09VUkNFUyArPSBqaXQvRXhlY3V0YWJsZUFsbG9jYXRvclN5bWJpYW4uY3BwIFwK LSAgICAgICAgICAgICAgcnVudGltZS9NYXJrU3RhY2tTeW1iaWFuLmNwcAotfSBlbHNlIHsKLSAg ICB3aW4zMi0qfHdpbmNlKiB7Ci0gICAgICAgIFNPVVJDRVMgKz0gaml0L0V4ZWN1dGFibGVBbGxv Y2F0b3JXaW4uY3BwIFwKLSAgICAgICAgICAgICAgICAgIHJ1bnRpbWUvTWFya1N0YWNrV2luLmNw cAotICAgIH0gZWxzZSB7Ci0gICAgICAgIFNPVVJDRVMgKz0gaml0L0V4ZWN1dGFibGVBbGxvY2F0 b3JQb3NpeC5jcHAgXAotICAgICAgICAgICAgICAgICAgcnVudGltZS9NYXJrU3RhY2tQb3NpeC5j cHAKLSAgICB9Ci19Ci0KICFjb250YWlucyhERUZJTkVTLCBVU0VfU1lTVEVNX01BTExPQykgewog ICAgIFNPVVJDRVMgKz0gd3RmL1RDU3lzdGVtQWxsb2MuY3BwCiB9CiAKLSFjb250YWlucyhERUZJ TkVTLCBFTkFCTEVfU0lOR0xFX1RIUkVBREVEPTEpIHsKLSAgICBTT1VSQ0VTICs9IHd0Zi9xdC9U aHJlYWRpbmdRdC5jcHAKLX0gZWxzZSB7Ci0gICAgREVGSU5FUyArPSBFTkFCTEVfSlNDX01VTFRJ UExFX1RIUkVBRFM9MAotICAgIFNPVVJDRVMgKz0gd3RmL1RocmVhZGluZ05vbmUuY3BwCi19Ci0K ICMgR0VORVJBVE9SIDEtQTogTFVUIGNyZWF0b3IKIGx1dC5vdXRwdXQgPSAkJHtHRU5FUkFURURf U09VUkNFU19ESVJ9JCR7UU1BS0VfRElSX1NFUH0ke1FNQUtFX0ZJTEVfQkFTRX0ubHV0LmgKIGx1 dC5jb21tYW5kcyA9IHBlcmwgJCRQV0QvY3JlYXRlX2hhc2hfdGFibGUgJHtRTUFLRV9GSUxFX05B TUV9IC1pID4gJHtRTUFLRV9GSUxFX09VVH0KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ppdC9FeGVj dXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL2pp dC9FeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwCShyZXZpc2lvbiA1MTQ2MSkKKysrIEphdmFT Y3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxsb2NhdG9yUG9zaXguY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yNyw3ICsyNyw3IEBACiAKICNpbmNsdWRlICJFeGVjdXRhYmxlQWxsb2NhdG9yLmgiCiAK LSNpZiBFTkFCTEUoQVNTRU1CTEVSKQorI2lmIEVOQUJMRShBU1NFTUJMRVIpICYmIFBMQVRGT1JN KFVOSVgpICYmICFQTEFURk9STShTWU1CSUFOKQogCiAjaW5jbHVkZSA8c3lzL21tYW4uaD4KICNp bmNsdWRlIDx1bmlzdGQuaD4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL2ppdC9FeGVjdXRhYmxlQWxs b2NhdG9yV2luLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9qaXQvRXhlY3V0YWJs ZUFsbG9jYXRvcldpbi5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvaml0 L0V4ZWN1dGFibGVBbGxvY2F0b3JXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yNyw3ICsyNyw3 IEBACiAKICNpbmNsdWRlICJFeGVjdXRhYmxlQWxsb2NhdG9yLmgiCiAKLSNpZiBFTkFCTEUoQVNT RU1CTEVSKQorI2lmIEVOQUJMRShBU1NFTUJMRVIpICYmIFBMQVRGT1JNKFdJTl9PUykKIAogI2lu Y2x1ZGUgIndpbmRvd3MuaCIKIApJbmRleDogSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3Rh Y2tQb3NpeC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3Rh Y2tQb3NpeC5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9N YXJrU3RhY2tQb3NpeC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI0LDEwICsyNCwxMCBAQAogICov CiAKICNpbmNsdWRlICJjb25maWcuaCIKLQotCiAjaW5jbHVkZSAiTWFya1N0YWNrLmgiCiAKKyNp ZiBQTEFURk9STShVTklYKSAmJiAhUExBVEZPUk0oU1lNQklBTikKKwogI2luY2x1ZGUgPHVuaXN0 ZC5oPgogI2luY2x1ZGUgPHN5cy9tbWFuLmg+CiAKQEAgLTQ4LDMgKzQ4LDUgQEAgdm9pZCBNYXJr U3RhY2s6OnJlbGVhc2VTdGFjayh2b2lkKiBhZGRyLAogfQogCiB9CisKKyNlbmRpZgpJbmRleDog SmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2tTeW1iaWFuLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL01hcmtTdGFja1N5bWJpYW4uY3BwCShyZXZpc2lvbiA1 MTQ2MSkKKysrIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya1N0YWNrU3ltYmlhbi5jcHAJKHdv cmtpbmcgY29weSkKQEAgLTIwLDYgKzIwLDggQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNs dWRlICJNYXJrU3RhY2suaCIKIAorI2lmIFBMQVRGT1JNKFNZTUJJQU4pCisKICNpbmNsdWRlIDxl MzJoYWwuaD4KIAogbmFtZXNwYWNlIEpTQyB7CkBAIC00MiwzICs0NCw1IEBAIHZvaWQgTWFya1N0 YWNrOjpyZWxlYXNlU3RhY2sodm9pZCogYWRkciwKIH0KIAogfQorCisjZW5kaWYKSW5kZXg6IEph dmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya1N0YWNrV2luLmNwcAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZh U2NyaXB0Q29yZS9ydW50aW1lL01hcmtTdGFja1dpbi5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysg SmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2tXaW4uY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yNCwxMCArMjQsMTAgQEAKICAqLwogCiAjaW5jbHVkZSAiY29uZmlnLmgiCi0KLQogI2luY2x1 ZGUgIk1hcmtTdGFjay5oIgogCisjaWYgUExBVEZPUk0oV0lOX09TKQorCiAjaW5jbHVkZSAid2lu ZG93cy5oIgogCiBuYW1lc3BhY2UgSlNDIHsKQEAgLTUxLDMgKzUxLDUgQEAgdm9pZCBNYXJrU3Rh Y2s6OnJlbGVhc2VTdGFjayh2b2lkKiBhZGRyLAogfQogCiB9CisKKyNlbmRpZgpJbmRleDogSmF2 YVNjcmlwdENvcmUvd3RmL1BsYXRmb3JtLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUv d3RmL1BsYXRmb3JtLmgJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlwdENvcmUvd3RmL1Bs YXRmb3JtLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0MCw3ICs0NDAsNyBAQAogI2RlZmluZSBXVEZf Q09NUElMRVJfV0lOU0NXIDEKICNlbmRpZgogCi0jaWYgKFBMQVRGT1JNKElQSE9ORSkgfHwgUExB VEZPUk0oTUFDKSB8fCBQTEFURk9STShXSU4pIHx8IChQTEFURk9STShRVCkgJiYgUExBVEZPUk0o REFSV0lOKSkpICYmICFkZWZpbmVkKEVOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFEUykKKyNpZiAo UExBVEZPUk0oSVBIT05FKSB8fCBQTEFURk9STShNQUMpIHx8IFBMQVRGT1JNKFdJTikgfHwgKFBM QVRGT1JNKFFUKSAmJiBQTEFURk9STShEQVJXSU4pICYmICFFTkFCTEUoU0lOR0xFX1RIUkVBREVE KSkpICYmICFkZWZpbmVkKEVOQUJMRV9KU0NfTVVMVElQTEVfVEhSRUFEUykKICNkZWZpbmUgRU5B QkxFX0pTQ19NVUxUSVBMRV9USFJFQURTIDEKICNlbmRpZgogCkluZGV4OiBKYXZhU2NyaXB0Q29y ZS93dGYvVGhyZWFkaW5nTm9uZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3Rm L1RocmVhZGluZ05vbmUuY3BwCShyZXZpc2lvbiA1MTQ2MSkKKysrIEphdmFTY3JpcHRDb3JlL3d0 Zi9UaHJlYWRpbmdOb25lLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzAsNiArMzAsOCBAQAogI2lu Y2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRocmVhZGluZy5oIgogCisjaWYgRU5BQkxFKFNJ TkdMRV9USFJFQURFRCkKKwogbmFtZXNwYWNlIFdURiB7CiAKIHZvaWQgaW5pdGlhbGl6ZVRocmVh ZGluZygpIHsgfQpAQCAtNTcsMyArNTksNSBAQCB2b2lkIGxvY2tBdG9taWNhbGx5SW5pdGlhbGl6 ZWRTdGF0aWNNdXRlCiB2b2lkIHVubG9ja0F0b21pY2FsbHlJbml0aWFsaXplZFN0YXRpY011dGV4 KCkgeyB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKKworI2VuZGlmCkluZGV4OiBKYXZhU2Ny aXB0Q29yZS93dGYvcXQvVGhyZWFkaW5nUXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRD b3JlL3d0Zi9xdC9UaHJlYWRpbmdRdC5jcHAJKHJldmlzaW9uIDUxNDYxKQorKysgSmF2YVNjcmlw dENvcmUvd3RmL3F0L1RocmVhZGluZ1F0LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjksNiArMjks OCBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUgIlRocmVhZGluZy5oIgogCisjaWYg IUVOQUJMRShTSU5HTEVfVEhSRUFERUQpCisKICNpbmNsdWRlICJDdXJyZW50VGltZS5oIgogI2lu Y2x1ZGUgIkhhc2hNYXAuaCIKICNpbmNsdWRlICJNYWluVGhyZWFkLmgiCkBAIC0yNjcsMyArMjY5 LDUgQEAgdm9pZCBUaHJlYWRDb25kaXRpb246OmJyb2FkY2FzdCgpCiB9CiAKIH0gLy8gbmFtZXNw YWNlIFdlYkNvcmUKKworI2VuZGlmCg==