31945 2009-11-27 17:36:38 -0800 [bzt] style-queue should report style errors to bugzilla 2009-11-28 16:17:41 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 166980 0 abarth 2009-11-27 17:36:38 -0800 style-queue should report style errors to bugzilla 166981 1 43976 abarth 2009-11-27 17:39:03 -0800 Created attachment 43976 Patch 167039 2 43976 eric 2009-11-28 09:51:56 -0800 Comment on attachment 43976 Patch We should make args always be a list. I don't like having to handle both cases. 167043 3 abarth 2009-11-28 10:17:07 -0800 Can we do that in a follow up patch? I agree we should do that, but shaving that yak isn't required for this patch. 167046 4 43976 eric 2009-11-28 11:22:48 -0800 Comment on attachment 43976 Patch OK. But please at least add a FIXME next to the regexp one, since it shouldn't be needed. 167057 5 abarth 2009-11-28 16:17:41 -0800 Committed r51462: <http://trac.webkit.org/changeset/51462> 43976 2009-11-27 17:39:03 -0800 2009-11-28 11:22:48 -0800 Patch bug-31945-20091127173901.patch text/plain 2606 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhOTg0YmQxLi43NGFiMzRiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAKIAogICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBbYnp0XSBzdHlsZS1xdWV1 ZSBzaG91bGQgcmVwb3J0IHN0eWxlIGVycm9ycyB0byBidWd6aWxsYQorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE5NDUKKworICAgICAgICBDdXJyZW50 bHksIHdlJ3JlIGp1c3QgbG9nZ2luZyB0aGUgc3R5bGUgZXJyb3JzIGxvY2FsbHkuICBXaXRoIHRo aXMKKyAgICAgICAgcGF0Y2ggd2UnbGwgYWN0dWFsbHkgbG9nIHRoZSBlcnJvcnMgdG8gYnVnemls bGEuICBOb3RlOiBJIHBsYW4gdG8gcnVuCisgICAgICAgIHdpdGggdGhlICJsb2NhbC1vbmx5IiBs b2dnaW5nIGR1cmluZyBkZXZlbG9wbWVudC4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9j b21tYW5kcy9xdWV1ZXMucHk6CisgICAgICAgICogU2NyaXB0cy9tb2R1bGVzL3NjbS5weToKKwor MjAwOS0xMS0yNyAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFtienRdIHN0eWxlLXF1ZXVlIHNo b3VsZG4ndCByZWplY3QgcGF0Y2hlcyBmcm9tIHRoZSBjb21taXQtcXVldWUKICAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTQ0CiAKZGlmZiAtLWdpdCBh L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRU b29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5CmluZGV4IGIwY2U0NzQuLjEz ZGUxZmEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9x dWV1ZXMucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVl cy5weQpAQCAtMjAyLDYgKzIwMiwxNyBAQCBjbGFzcyBTdHlsZVF1ZXVlKEFic3RyYWN0VHJ5UXVl dWUpOgogICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90b29sKFsiY2hlY2stc3R5bGUiLCAiLS1m b3JjZS1jbGVhbiIsICItLW5vbi1pbnRlcmFjdGl2ZSIsICItLWVycm9yLWhhbmRsZXI9c3R5bGUt cXVldWUiLCBwYXRjaFsiaWQiXV0pCiAgICAgICAgIHNlbGYuX3BhdGNoZXMuZG9uZShwYXRjaCkK IAorICAgIEBjbGFzc21ldGhvZAorICAgIGRlZiBoYW5kbGVfc2NyaXB0X2Vycm9yKGNscywgdG9v bCwgcGF0Y2gsIHNjcmlwdF9lcnJvcik6CisgICAgICAgIGNvbW1hbmQgPSBzY3JpcHRfZXJyb3Iu c2NyaXB0X2FyZ3MKKyAgICAgICAgaWYgdHlwZShjb21tYW5kKSBpcyBsaXN0OgorICAgICAgICAg ICAgY29tbWFuZCA9IGNvbW1hbmRbMF0KKyAgICAgICAgaWYgcmUuc2VhcmNoKCJjaGVjay13ZWJr aXQtc3R5bGUiLCBjb21tYW5kKToKKyAgICAgICAgICAgIG1lc3NhZ2UgPSAiQXR0YWNobWVudCAl cyBkaWQgbm90IHBhc3MgJXM6XG5cbiVzIiAlIChwYXRjaFsiaWQiXSwgY2xzLm5hbWUsIHNjcmlw dF9lcnJvci5tZXNzYWdlX3dpdGhfb3V0cHV0KG91dHB1dF9saW1pdD1Ob25lKSkKKyAgICAgICAg ICAgICMgTG9jYWwtb25seSBsb2dnaW5nIGhlbHBmdWwgZm9yIGRldmVsb3BtZW50OgorICAgICAg ICAgICAgIyBsb2coIioqIEJFR0lOIEJVRyBQT1NUICoqXG4lcyoqIEVORCBCVUcgUE9TVCAqKiIg JSBtZXNzYWdlKQorICAgICAgICAgICAgdG9vbC5idWdzLnBvc3RfY29tbWVudF90b19idWcocGF0 Y2hbImJ1Z19pZCJdLCBtZXNzYWdlKQorCiAKIGNsYXNzIEJ1aWxkUXVldWUoQWJzdHJhY3RUcnlR dWV1ZSk6CiAgICAgbmFtZSA9ICJidWlsZC1xdWV1ZSIKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9zY20ucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvc2Nt LnB5CmluZGV4IGQzMjI3NjIuLmJlYjMyZGYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1Njcmlw dHMvbW9kdWxlcy9zY20ucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL3NjbS5w eQpAQCAtOTUsNyArOTUsNyBAQCBjbGFzcyBTY3JpcHRFcnJvcihFeGNlcHRpb24pOgogCiAgICAg ZGVmIG1lc3NhZ2Vfd2l0aF9vdXRwdXQoc2VsZiwgb3V0cHV0X2xpbWl0PTUwMCk6CiAgICAgICAg IGlmIHNlbGYub3V0cHV0OgotICAgICAgICAgICAgaWYgbGVuKHNlbGYub3V0cHV0KSA+IG91dHB1 dF9saW1pdDoKKyAgICAgICAgICAgIGlmIG91dHB1dF9saW1pdCBhbmQgbGVuKHNlbGYub3V0cHV0 KSA+IG91dHB1dF9saW1pdDoKICAgICAgICAgICAgICAgICAgcmV0dXJuICIlc1xuTGFzdCAlcyBj aGFyYWN0ZXJzIG9mIG91dHB1dDpcbiVzIiAlIChzZWxmLCBvdXRwdXRfbGltaXQsIHNlbGYub3V0 cHV0Wy1vdXRwdXRfbGltaXQ6XSkKICAgICAgICAgICAgIHJldHVybiAiJXNcbiVzIiAlIChzZWxm LCBzZWxmLm91dHB1dCkKICAgICAgICAgcmV0dXJuIHN0cihzZWxmKQo=