31944 2009-11-27 16:31:53 -0800 [bzt] style-queue shouldn't reject patches from the commit-queue 2009-11-28 10:28:28 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 166978 0 abarth 2009-11-27 16:31:53 -0800 Currently the style-queue subprocess gets confused and thinks its the commit-queue. If the patch has an error, it rejects it from the commit-queue. Instead, we should have style-queue specific logic. This patch doesn't add that logic, but it gives us a callback we can use to add that logic. 166979 1 43975 abarth 2009-11-27 16:32:55 -0800 Created attachment 43975 Patch 166982 2 eric 2009-11-27 18:06:28 -0800 I don't understand this patch or why it needs a command-line arg. I think the command-line arg is the part that really confuses me (it's kinda ugly). 166983 3 abarth 2009-11-27 18:11:29 -0800 The child process needs to know what to do with errors. The command line argument tells the child what command understands the errors and therefore who should process them. 167038 4 43975 eric 2009-11-28 09:50:41 -0800 Comment on attachment 43975 Patch Seems OK. --parent-command would be better as per our discussion. 167044 5 abarth 2009-11-28 10:27:42 -0800 Committed r51460: <http://trac.webkit.org/changeset/51460> 167045 6 abarth 2009-11-28 10:28:28 -0800 Patch landed. 43975 2009-11-27 16:32:55 -0800 2009-11-28 09:50:41 -0800 Patch bug-31944-20091127163253.patch text/plain 7117 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA5MGFlMDNhLi5hOTg0YmQxIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMDktMTEt MjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbYnp0XSBzdHlsZS1xdWV1ZSBzaG91bGRuJ3Qg cmVqZWN0IHBhdGNoZXMgZnJvbSB0aGUgY29tbWl0LXF1ZXVlCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTk0NAorCisgICAgICAgIEN1cnJlbnRseSB0 aGUgc3R5bGUtcXVldWUgc3VicHJvY2VzcyBnZXRzIGNvbmZ1c2VkIGFuZCB0aGlua3MgaXRzIHRo ZQorICAgICAgICBjb21taXQtcXVldWUuICBJZiB0aGUgcGF0Y2ggaGFzIGFuIGVycm9yLCBpdCBy ZWplY3RzIGl0IGZyb20gdGhlCisgICAgICAgIGNvbW1pdC1xdWV1ZS4gIEluc3RlYWQsIHdlIHNo b3VsZCBoYXZlIHN0eWxlLXF1ZXVlIHNwZWNpZmljIGxvZ2ljLgorICAgICAgICBUaGlzIHBhdGNo IGRvZXNuJ3QgYWRkIHRoYXQgbG9naWMsIGJ1dCBpdCBnaXZlcyB1cyBhIGNhbGxiYWNrIHdlIGNh bgorICAgICAgICB1c2UgdG8gYWRkIHRoYXQgbG9naWMuCisKKyAgICAgICAgKiBTY3JpcHRzL21v ZHVsZXMvYnVpbGRzdGVwcy5weToKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMv cXVldWVzLnB5OgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9sYW5kaW5nc2VxdWVuY2UucHk6 CisKKzIwMDktMTEtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKwogICAgICAg ICBSdWJiZXIgc3RhbXBlZCBieSBFcmljIFNlaWRlbC4KIAogICAgICAgICBSZW5hbWUgQ29tbWl0 UXVldWVTdGF0dXMgdG8gUXVldWVTdGF0dXNTZXJ2ZXIgdG8gYWxsb3cgZm9yIG1vcmUgcXVldWVz LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2J1aWxkc3RlcHMucHkg Yi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVpbGRzdGVwcy5weQppbmRleCA1YzUwZmJm Li5hYmMwNTYyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVpbGRz dGVwcy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvYnVpbGRzdGVwcy5weQpA QCAtNDksNiArNDksNyBAQCBjbGFzcyBCdWlsZFN0ZXBzOgogICAgICAgICAgICAgbWFrZV9vcHRp b24oIi0taWdub3JlLWJ1aWxkZXJzIiwgYWN0aW9uPSJzdG9yZV9mYWxzZSIsIGRlc3Q9ImNoZWNr X2J1aWxkZXJzIiwgZGVmYXVsdD1UcnVlLCBoZWxwPSJEb24ndCBjaGVjayB0byBzZWUgaWYgdGhl IGJ1aWxkLndlYmtpdC5vcmcgYnVpbGRlcnMgYXJlIGdyZWVuIGJlZm9yZSBsYW5kaW5nLiIpLAog ICAgICAgICAgICAgbWFrZV9vcHRpb24oIi0tcXVpZXQiLCBhY3Rpb249InN0b3JlX3RydWUiLCBk ZXN0PSJxdWlldCIsIGRlZmF1bHQ9RmFsc2UsIGhlbHA9IlByb2R1Y2UgbGVzcyBjb25zb2xlIG91 dHB1dC4iKSwKICAgICAgICAgICAgIG1ha2Vfb3B0aW9uKCItLW5vbi1pbnRlcmFjdGl2ZSIsIGFj dGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9Im5vbl9pbnRlcmFjdGl2ZSIsIGRlZmF1bHQ9RmFsc2Us IGhlbHA9Ik5ldmVyIHByb21wdCB0aGUgdXNlciwgZmFpbCBhcyBmYXN0IGFzIHBvc3NpYmxlLiIp LAorICAgICAgICAgICAgbWFrZV9vcHRpb24oIi0tZXJyb3ItaGFuZGxlciIsIGFjdGlvbj0ic3Rv cmUiLCBkZXN0PSJlcnJvcl9oYW5kbGVyIiwgZGVmYXVsdD1Ob25lLCBoZWxwPSJDb21tYW5kIHRv IGhhbmRsZSBlcnJvcnMgYXV0b21hdGljYWxseS4iKSwKICAgICAgICAgXSArIFdlYktpdFBvcnQu cG9ydF9vcHRpb25zKCkKIAogICAgIEBzdGF0aWNtZXRob2QKZGlmZiAtLWdpdCBhL1dlYktpdFRv b2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkgYi9XZWJLaXRUb29scy9TY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5CmluZGV4IDkxODM5N2YuLmIwY2U0NzQgMTAw NjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weQpAQCAt NDQsNyArNDQsNyBAQCBmcm9tIG1vZHVsZXMuYnVpbGRib3QgaW1wb3J0IEJ1aWxkQm90CiBmcm9t IG1vZHVsZXMuY2hhbmdlbG9ncyBpbXBvcnQgQ2hhbmdlTG9nCiBmcm9tIG1vZHVsZXMuY29tbWVu dHMgaW1wb3J0IGJ1Z19jb21tZW50X2Zyb21fY29tbWl0X3RleHQKIGZyb20gbW9kdWxlcy5ncmFt bWFyIGltcG9ydCBwbHVyYWxpemUKLWZyb20gbW9kdWxlcy5sYW5kaW5nc2VxdWVuY2UgaW1wb3J0 IExhbmRpbmdTZXF1ZW5jZSwgQ29uZGl0aW9uYWxMYW5kaW5nU2VxdWVuY2UKK2Zyb20gbW9kdWxl cy5sYW5kaW5nc2VxdWVuY2UgaW1wb3J0IExhbmRpbmdTZXF1ZW5jZSwgQ29uZGl0aW9uYWxMYW5k aW5nU2VxdWVuY2UsIExhbmRpbmdTZXF1ZW5jZUVycm9ySGFuZGxlcgogZnJvbSBtb2R1bGVzLmxv Z2dpbmcgaW1wb3J0IGVycm9yLCBsb2csIHRlZQogZnJvbSBtb2R1bGVzLm11bHRpY29tbWFuZHRv b2wgaW1wb3J0IE11bHRpQ29tbWFuZFRvb2wsIENvbW1hbmQKIGZyb20gbW9kdWxlcy5wYXRjaGNv bGxlY3Rpb24gaW1wb3J0IFBhdGNoQ29sbGVjdGlvbiwgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlv biwgUGVyc2lzdGVudFBhdGNoQ29sbGVjdGlvbkRlbGVnYXRlCkBAIC0xMDgsMTIgKzEwOCwxNCBA QCBjbGFzcyBBYnN0cmFjdFF1ZXVlKENvbW1hbmQsIFdvcmtRdWV1ZURlbGVnYXRlKToKICAgICAg ICAgd29ya19xdWV1ZS5ydW4oKQogCiAKLWNsYXNzIENvbW1pdFF1ZXVlKEFic3RyYWN0UXVldWUp OgorY2xhc3MgQ29tbWl0UXVldWUoQWJzdHJhY3RRdWV1ZSwgTGFuZGluZ1NlcXVlbmNlRXJyb3JI YW5kbGVyKToKICAgICBuYW1lID0gImNvbW1pdC1xdWV1ZSIKICAgICBzaG93X2luX21haW5faGVs cCA9IEZhbHNlCiAgICAgZGVmIF9faW5pdF9fKHNlbGYpOgogICAgICAgICBBYnN0cmFjdFF1ZXVl Ll9faW5pdF9fKHNlbGYpCiAKKyAgICAjIEFic3RyYWN0UXVldWUgbWV0aG9kcworCiAgICAgZGVm IGJlZ2luX3dvcmtfcXVldWUoc2VsZik6CiAgICAgICAgIEFic3RyYWN0UXVldWUuYmVnaW5fd29y a19xdWV1ZShzZWxmKQogCkBAIC0xMzMsMTMgKzEzNSwxOSBAQCBjbGFzcyBDb21taXRRdWV1ZShB YnN0cmFjdFF1ZXVlKToKICAgICAgICAgcmV0dXJuIChUcnVlLCAiTGFuZGluZyBwYXRjaCAlcyBm cm9tIGJ1ZyAlcy4iICUgKHBhdGNoWyJpZCJdLCBwYXRjaFsiYnVnX2lkIl0pLCBwYXRjaCkKIAog ICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6Ci0gICAgICAgIHNlbGYucnVu X2J1Z3ppbGxhX3Rvb2woWyJsYW5kLWF0dGFjaG1lbnQiLCAiLS1mb3JjZS1jbGVhbiIsICItLW5v bi1pbnRlcmFjdGl2ZSIsICItLXF1aWV0IiwgcGF0Y2hbImlkIl1dKQorICAgICAgICBzZWxmLnJ1 bl9idWd6aWxsYV90b29sKFsibGFuZC1hdHRhY2htZW50IiwgIi0tZm9yY2UtY2xlYW4iLCAiLS1u b24taW50ZXJhY3RpdmUiLCAiLS1lcnJvci1oYW5kbGVyPWNvbW1pdC1xdWV1ZSIsICItLXF1aWV0 IiwgcGF0Y2hbImlkIl1dKQogCiAgICAgZGVmIGhhbmRsZV91bmV4cGVjdGVkX2Vycm9yKHNlbGYs IHBhdGNoLCBtZXNzYWdlKToKICAgICAgICAgc2VsZi50b29sLmJ1Z3MucmVqZWN0X3BhdGNoX2Zy b21fY29tbWl0X3F1ZXVlKHBhdGNoWyJpZCJdLCBtZXNzYWdlKQogCisgICAgIyBMYW5kaW5nU2Vx dWVuY2VFcnJvckhhbmRsZXIgbWV0aG9kcworCisgICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIGhh bmRsZV9zY3JpcHRfZXJyb3IoY2xzLCB0b29sLCBwYXRjaCwgc2NyaXB0X2Vycm9yKToKKyAgICAg ICAgdG9vbC5idWdzLnJlamVjdF9wYXRjaF9mcm9tX2NvbW1pdF9xdWV1ZShwYXRjaFsiaWQiXSwg c2NyaXB0X2Vycm9yLm1lc3NhZ2Vfd2l0aF9vdXRwdXQoKSkKIAotY2xhc3MgQWJzdHJhY3RUcnlR dWV1ZShBYnN0cmFjdFF1ZXVlLCBQZXJzaXN0ZW50UGF0Y2hDb2xsZWN0aW9uRGVsZWdhdGUpOgor CitjbGFzcyBBYnN0cmFjdFRyeVF1ZXVlKEFic3RyYWN0UXVldWUsIFBlcnNpc3RlbnRQYXRjaENv bGxlY3Rpb25EZWxlZ2F0ZSwgTGFuZGluZ1NlcXVlbmNlRXJyb3JIYW5kbGVyKToKICAgICBkZWYg X19pbml0X18oc2VsZiwgb3B0aW9ucz1bXSk6CiAgICAgICAgIEFic3RyYWN0UXVldWUuX19pbml0 X18oc2VsZiwgb3B0aW9ucykKIApAQCAtMTc0LDYgKzE4MiwxMiBAQCBjbGFzcyBBYnN0cmFjdFRy eVF1ZXVlKEFic3RyYWN0UXVldWUsIFBlcnNpc3RlbnRQYXRjaENvbGxlY3Rpb25EZWxlZ2F0ZSk6 CiAgICAgICAgIGxvZyhtZXNzYWdlKQogICAgICAgICBzZWxmLl9wYXRjaGVzLmRvbmUocGF0Y2gp CiAKKyAgICAjIExhbmRpbmdTZXF1ZW5jZUVycm9ySGFuZGxlciBtZXRob2RzCisKKyAgICBAY2xh c3NtZXRob2QKKyAgICBkZWYgaGFuZGxlX3NjcmlwdF9lcnJvcihjbHMsIHRvb2wsIHBhdGNoLCBz Y3JpcHRfZXJyb3IpOgorICAgICAgICBsb2coc2NyaXB0X2Vycm9yLm1lc3NhZ2Vfd2l0aF9vdXRw dXQoKSkKKwogCiBjbGFzcyBTdHlsZVF1ZXVlKEFic3RyYWN0VHJ5UXVldWUpOgogICAgIG5hbWUg PSAic3R5bGUtcXVldWUiCkBAIC0xODUsNyArMTk5LDcgQEAgY2xhc3MgU3R5bGVRdWV1ZShBYnN0 cmFjdFRyeVF1ZXVlKToKICAgICAgICAgcmV0dXJuIChUcnVlLCAiQ2hlY2tpbmcgc3R5bGUgZm9y IHBhdGNoICVzIG9uIGJ1ZyAlcy4iICUgKHBhdGNoWyJpZCJdLCBwYXRjaFsiYnVnX2lkIl0pLCBw YXRjaCkKIAogICAgIGRlZiBwcm9jZXNzX3dvcmtfaXRlbShzZWxmLCBwYXRjaCk6Ci0gICAgICAg IHNlbGYucnVuX2J1Z3ppbGxhX3Rvb2woWyJjaGVjay1zdHlsZSIsICItLWZvcmNlLWNsZWFuIiwg Ii0tbm9uLWludGVyYWN0aXZlIiwgcGF0Y2hbImlkIl1dKQorICAgICAgICBzZWxmLnJ1bl9idWd6 aWxsYV90b29sKFsiY2hlY2stc3R5bGUiLCAiLS1mb3JjZS1jbGVhbiIsICItLW5vbi1pbnRlcmFj dGl2ZSIsICItLWVycm9yLWhhbmRsZXI9c3R5bGUtcXVldWUiLCBwYXRjaFsiaWQiXV0pCiAgICAg ICAgIHNlbGYuX3BhdGNoZXMuZG9uZShwYXRjaCkKIAogCkBAIC0yMDgsNSArMjIyLDUgQEAgY2xh c3MgQnVpbGRRdWV1ZShBYnN0cmFjdFRyeVF1ZXVlKToKICAgICAgICAgcmV0dXJuIChUcnVlLCAi QnVpbGRpbmcgcGF0Y2ggJXMgb24gYnVnICVzLiIgJSAocGF0Y2hbImlkIl0sIHBhdGNoWyJidWdf aWQiXSksIHBhdGNoKQogCiAgICAgZGVmIHByb2Nlc3Nfd29ya19pdGVtKHNlbGYsIHBhdGNoKToK LSAgICAgICAgc2VsZi5ydW5fYnVnemlsbGFfdG9vbChbImJ1aWxkLWF0dGFjaG1lbnQiLCBzZWxm LnBvcnQuZmxhZygpLCAiLS1mb3JjZS1jbGVhbiIsICItLXF1aWV0IiwgIi0tbm8tdXBkYXRlIiwg cGF0Y2hbImlkIl1dKQorICAgICAgICBzZWxmLnJ1bl9idWd6aWxsYV90b29sKFsiYnVpbGQtYXR0 YWNobWVudCIsIHNlbGYucG9ydC5mbGFnKCksICItLWZvcmNlLWNsZWFuIiwgIi0tcXVpZXQiLCAi LS1ub24taW50ZXJhY3RpdmUiLCAiLS1lcnJvci1oYW5kbGVyPWJ1aWxkLXF1ZXVlIiwgIi0tbm8t dXBkYXRlIiwgcGF0Y2hbImlkIl1dKQogICAgICAgICBzZWxmLl9wYXRjaGVzLmRvbmUocGF0Y2gp CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvbGFuZGluZ3NlcXVlbmNl LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2xhbmRpbmdzZXF1ZW5jZS5weQppbmRl eCA0MTVkZDc5Li4yNjEyMmFmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVs ZXMvbGFuZGluZ3NlcXVlbmNlLnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9s YW5kaW5nc2VxdWVuY2UucHkKQEAgLTM0LDYgKzM0LDEyIEBAIGZyb20gbW9kdWxlcy5zY20gaW1w b3J0IFNjcmlwdEVycm9yLCBDaGVja291dE5lZWRzVXBkYXRlCiBmcm9tIG1vZHVsZXMud2Via2l0 cG9ydCBpbXBvcnQgV2ViS2l0UG9ydAogZnJvbSBtb2R1bGVzLndvcmtxdWV1ZSBpbXBvcnQgV29y a1F1ZXVlCiAKK2NsYXNzIExhbmRpbmdTZXF1ZW5jZUVycm9ySGFuZGxlcigpOgorICAgIEBjbGFz c21ldGhvZAorICAgIGRlZiBoYW5kbGVfc2NyaXB0X2Vycm9yKGNscywgdG9vbCwgcGF0Y2gsIHNj cmlwdF9lcnJvcik6CisgICAgICAgIHJhaXNlIE5vdEltcGxlbWVudGVkRXJyb3IsICJzdWJjbGFz c2VzIG11c3QgaW1wbGVtZW50IgorCisKIGNsYXNzIExhbmRpbmdTZXF1ZW5jZToKICAgICBkZWYg X19pbml0X18oc2VsZiwgcGF0Y2gsIG9wdGlvbnMsIHRvb2wpOgogICAgICAgICBzZWxmLl9wYXRj aCA9IHBhdGNoCkBAIC02MSw5ICs2Nyw5IEBAIGNsYXNzIExhbmRpbmdTZXF1ZW5jZToKICAgICAg ICAgZXhjZXB0IFNjcmlwdEVycm9yLCBlOgogICAgICAgICAgICAgaWYgbm90IHNlbGYuX29wdGlv bnMucXVpZXQ6CiAgICAgICAgICAgICAgICAgbG9nKGUubWVzc2FnZV93aXRoX291dHB1dCgpKQot ICAgICAgICAgICAgaWYgc2VsZi5fb3B0aW9ucy5ub25faW50ZXJhY3RpdmU6Ci0gICAgICAgICAg ICAgICAgIyBNYXJrIHRoZSBwYXRjaCBhcyBjb21taXQtcXVldWUtIGFuZCBjb21tZW50IGluIHRo ZSBidWcuCi0gICAgICAgICAgICAgICAgc2VsZi5fdG9vbC5idWdzLnJlamVjdF9wYXRjaF9mcm9t X2NvbW1pdF9xdWV1ZShzZWxmLl9wYXRjaFsiaWQiXSwgZS5tZXNzYWdlX3dpdGhfb3V0cHV0KCkp CisgICAgICAgICAgICBpZiBzZWxmLl9vcHRpb25zLmVycm9yX2hhbmRsZXI6CisgICAgICAgICAg ICAgICAgY29tbWFuZCA9IHNlbGYuX3Rvb2wuY29tbWFuZF9ieV9uYW1lKHNlbGYuX29wdGlvbnMu ZXJyb3JfaGFuZGxlcikKKyAgICAgICAgICAgICAgICBjb21tYW5kLmhhbmRsZV9zY3JpcHRfZXJy b3Ioc2VsZi5fdG9vbCwgc2VsZi5fcGF0Y2gsIGUpCiAgICAgICAgICAgICBXb3JrUXVldWUuZXhp dF9hZnRlcl9oYW5kbGVkX2Vycm9yKGUpCiAKICAgICBkZWYgY2xlYW4oc2VsZik6Cg==