31943 2009-11-27 16:07:20 -0800 Apply workaround for the limitation of VirtualFree with MEM_RELEASE to all ports running on Windows 2009-11-30 06:45:15 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 laszlo.gombos webkit-unassigned aroben bfulgham commit-queue eric hausmann sfalken oldest_to_newest 166975 0 laszlo.gombos 2009-11-27 16:07:20 -0800 This patch is related to commit r47159 (http://trac.webkit.org/changeset/47159). On windows we cannot release a part of a region with VirtualFree. To get around this we'll release the entire region and reallocate the size that we want. This needs to be done for all ports running on Windows (Gtk, Qt, Wx, etc) not just for PLATFORM(WIN). PLATFORM(WIN) guard should be changed to PLATFORM(WIN_OS). 166976 1 43974 laszlo.gombos 2009-11-27 16:10:06 -0800 Created attachment 43974 proposed patch. 167035 2 43974 eric 2009-11-28 09:46:41 -0800 Comment on attachment 43974 proposed patch. Looks OK to me. 167048 3 43974 commit-queue 2009-11-28 13:48:26 -0800 Comment on attachment 43974 proposed patch. Clearing flags on attachment: 43974 Committed r51461: <http://trac.webkit.org/changeset/51461> 167049 4 commit-queue 2009-11-28 13:48:32 -0800 All reviewed patches have been landed. Closing bug. 167200 5 hausmann 2009-11-30 00:59:23 -0800 Cherry-picked into QtWebKit 4.6 maintenance branch as 205da189165ea7ba9940bb3bf183b856ce0be874 167230 6 aroben 2009-11-30 06:45:15 -0800 I wonder if HAVE(VIRTUALALLOC) would be more appropriate? 43974 2009-11-27 16:10:06 -0800 2009-11-28 13:48:25 -0800 proposed patch. 31943.patch text/plain 1362 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxNDUxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEtMjcgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFwcGx5IHdvcmthcm91bmQgZm9yIHRoZSBsaW1p dGF0aW9uIG9mIFZpcnR1YWxGcmVlIHdpdGggTUVNX1JFTEVBU0UgdG8gYWxsIHBvcnRzIHJ1bm5p bmcgb24gV2luZG93cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MzE5NDMKKworICAgICAgICAqIHJ1bnRpbWUvTWFya1N0YWNrLmg6CisgICAgICAgIChK U0M6Ok1hcmtTdGFjazo6TWFya1N0YWNrQXJyYXk6OnNocmlua0FsbG9jYXRpb24pOgorCiAyMDA5 LTExLTI1ICBPbGl2ZXIgSHVudCAgPG9saXZlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgR2F2aW4gQmFycmFjbG91Z2guCkluZGV4OiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL01h cmtTdGFjay5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3J1bnRpbWUvTWFya1N0YWNr LmgJKHJldmlzaW9uIDUxNDUwKQorKysgSmF2YVNjcmlwdENvcmUvcnVudGltZS9NYXJrU3RhY2su aAkod29ya2luZyBjb3B5KQpAQCAtMTUzLDcgKzE1Myw3IEBAIG5hbWVzcGFjZSBKU0MgewogICAg ICAgICAgICAgICAgIEFTU0VSVCgwID09IChzaXplICUgTWFya1N0YWNrOjpwYWdlU2l6ZSgpKSk7 CiAgICAgICAgICAgICAgICAgaWYgKHNpemUgPT0gbV9hbGxvY2F0ZWQpCiAgICAgICAgICAgICAg ICAgICAgIHJldHVybjsKLSNpZiBQTEFURk9STShXSU4pIHx8IFBMQVRGT1JNKFNZTUJJQU4pCisj aWYgUExBVEZPUk0oV0lOX09TKSB8fCBQTEFURk9STShTWU1CSUFOKQogICAgICAgICAgICAgICAg IC8vIFdlIGNhbm5vdCByZWxlYXNlIGEgcGFydCBvZiBhIHJlZ2lvbiB3aXRoIFZpcnR1YWxGcmVl LiAgVG8gZ2V0IGFyb3VuZCB0aGlzLAogICAgICAgICAgICAgICAgIC8vIHdlJ2xsIHJlbGVhc2Ug dGhlIGVudGlyZSByZWdpb24gYW5kIHJlYWxsb2NhdGUgdGhlIHNpemUgdGhhdCB3ZSB3YW50Lgog ICAgICAgICAgICAgICAgIHJlbGVhc2VTdGFjayhtX2RhdGEsIG1fYWxsb2NhdGVkKTsK