31931 2009-11-27 06:02:44 -0800 [Freetype] Don't use non-scalable fonts 2015-01-12 15:32:31 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED PlatformOnly P2 Normal --- 0 pclouds clopez calvaris cgarcia clopez commit-queue darin gyuyoung.kim kling koivisto mmaxfield mrobinson svillar zecke oldest_to_newest 166883 0 pclouds 2009-11-27 06:02:44 -0800 Hi, I don't know if this is WebKit bug or cairo/freetype. About a month ago, every time I surfed pages with CJK letters inside, CPU went up 100% for a while, then back to normal. Recently this happens more often even with pages that have no CJK letters. I ran with gdb and stopped the program a few times while CPU spiked and got this call trace #0 0xb5af410b in pcf_load_font () from /usr/lib/libfreetype.so.6 #1 0xb5af55c7 in PCF_Face_Init () from /usr/lib/libfreetype.so.6 #2 0xb5aad6b5 in open_face () from /usr/lib/libfreetype.so.6 #3 0xb5aaefb9 in FT_Open_Face () from /usr/lib/libfreetype.so.6 #4 0xb5ab0e66 in FT_New_Face () from /usr/lib/libfreetype.so.6 #5 0xb5ee858b in cairo_ft_scaled_font_lock_face () from /usr/lib/libcairo.so.2 #6 0xb7b23c72 in WebCore::SimpleFontData::containsCharacters () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #7 0xb7af8948 in WebCore::FontCache::getFontDataForCharacters () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #8 0xb78322cb in WebCore::Font::glyphDataForCharacter () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #9 0xb78411bb in WebCore::WidthIterator::advance () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #10 0xb7831a60 in WebCore::Font::floatWidthForSimpleText () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #11 0xb782a99d in WebCore::Font::floatWidth () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #12 0xb78ab2ec in WebCore::RenderBlock::findNextLineBreak () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #13 0xb78ad6b7 in WebCore::RenderBlock::layoutInlineChildren () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 #14 0xb789fd56 in WebCore::RenderBlock::layoutBlock () from /home/pclouds/opt/webkit/lib/libwebkit-1.0.so.2 OProfile said most of time was spent inside zlib, which was probably because all my pcf fonts were compressed. I tested with WebKit r51413, cairo 1.8.8, freetype 2.3.11. An easy test is open yahoo.co.jp. My PCF fonts are baemuk-fonts, font-adobe-75dpi, font-cursor-misc, font-misc-misc, unifont (Gentoo package names). Any suggestions how to find out where the bottleneck is? 166987 1 pclouds 2009-11-27 19:21:37 -0800 This is the list of fonts opened and number of open times (browsing yahoo.co.jp): 1 open("/usr/share/fonts/corefonts/arialbd.ttf", O_RDONLY) = 19 56 open("/usr/share/fonts/corefonts/arialbd.ttf", O_RDONLY) = 21 1 open("/usr/share/fonts/corefonts/arialbd.ttf", O_RDONLY) = 26 1 open("/usr/share/fonts/corefonts/arial.ttf", O_RDONLY) = 17 355 open("/usr/share/fonts/corefonts/arial.ttf", O_RDONLY) = 21 54 open("/usr/share/fonts/corefonts/courbd.ttf", O_RDONLY) = 21 370 open("/usr/share/fonts/corefonts/couri.ttf", O_RDONLY) = 21 329 open("/usr/share/fonts/corefonts/cour.ttf", O_RDONLY) = 21 321 open("/usr/share/fonts/dejavu/DejaVuSans-BoldOblique.ttf", O_RDONLY) = 21 347 open("/usr/share/fonts/dejavu/DejaVuSansMono-Bold.ttf", O_RDONLY) = 21 369 open("/usr/share/fonts/dejavu/DejaVuSans.ttf", O_RDONLY) = 21 323 open("/usr/share/fonts/dejavu/DejaVuSerif-Italic.ttf", O_RDONLY) = 21 322 open("/usr/share/fonts/dejavu/DejaVuSerif.ttf", O_RDONLY) = 21 356 open("/usr/share/fonts/freefont-ttf/FreeMono.ttf", O_RDONLY) = 21 322 open("/usr/share/fonts/freefont-ttf/FreeSans.ttf", O_RDONLY) = 21 390 open("/usr/share/fonts/freefont-ttf/FreeSerif.ttf", O_RDONLY) = 21 389 open("/usr/share/fonts/misc/10x20.pcf.gz", O_RDONLY) = 21 313 open("/usr/share/fonts/misc/12x13ja.pcf.gz", O_RDONLY) = 21 358 open("/usr/share/fonts/misc/6x13.pcf.gz", O_RDONLY) = 21 375 open("/usr/share/fonts/misc/9x15.pcf.gz", O_RDONLY) = 21 328 open("/usr/share/fonts/misc/9x18.pcf.gz", O_RDONLY) = 21 366 open("/usr/share/fonts/unifont/unifont-h.pcf.gz", O_RDONLY) = 21 171173 2 zecke 2009-12-13 01:06:17 -0800 Could you find out who decides to open the pcf fonts? Specially how it decides to use the AxB.pcf.gz fonts? In WebCore/platform/graphics/gtk/FontPlatformDataGtk.cpp we are driving FontConfig... you could use FcPatternPrint on the pattern we put into fontconfig and get out of it to see what we are selecting. 627989 3 mrobinson 2012-05-18 13:30:08 -0700 Can you post a link to the page that has this issue? 628340 4 pclouds 2012-05-18 20:20:27 -0700 (In reply to comment #3) > Can you post a link to the page that has this issue? http://www.yahoo.co.jp/ (not sure if it's still an issue as I'm not using webkit browser right now) 828664 5 mrobinson 2013-02-08 10:20:33 -0800 It seems that non-scalable fonts just give us issues. We should instruct WebKitGTK+ to never select a non-scalable font. 1060680 6 clopez 2015-01-12 14:45:12 -0800 *** Bug 140290 has been marked as a duplicate of this bug. *** 1060682 7 clopez 2015-01-12 14:47:42 -0800 I have uploaded a simple test case here where webkitgtk+ selects a non scalable font when ${etcfontconfig}/conf.d/70-no-bitmaps.conf is missing http://people.igalia.com/clopez/wkbug/140290/test.html 1060695 8 244472 clopez 2015-01-12 15:24:26 -0800 Created attachment 244472 Patch 1060696 9 244472 mrobinson 2015-01-12 15:26:24 -0800 Comment on attachment 244472 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=244472&action=review > Source/WebCore/platform/graphics/freetype/FontCacheFreeType.cpp:169 > + // Always prefer scalable fonts. Otherwise we may end choosing fonts that look horrible. > + FcPatternAddBool(pattern.get(), FC_SCALABLE, FcTrue); A better comment might be, "Never choose unscalable fonts, as they pixelate when displayed at different sizes." "look horrible" is a subjective statement. :) 1060697 10 clopez 2015-01-12 15:32:31 -0800 Committed r178301: <http://trac.webkit.org/changeset/178301> 244472 2015-01-12 15:24:26 -0800 2015-01-12 15:26:24 -0800 Patch bug-31931-20150113002431.patch text/plain 1832 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc4MzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggN2YwMGQwYzg4OTAwZjMw YjkyM2M1OTdjM2M0YTQ3ZDRjY2QwM2M5MC4uYTVhYTVlN2Q3Y2VkZmFmMTBjMGIwZjU2ZGIxYjFi MWZkNDEwYzk1MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE1LTAxLTEyICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtG cmVldHlwZV0gRG9uJ3QgdXNlIG5vbi1zY2FsYWJsZSBmb250cy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTMxCisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkZvbnRDYWNoZTo6Y3JlYXRlRm9udFBsYXRmb3JtRGF0YSk6IFBy ZWZlciBzY2FsYWJsZSBmb250cy4KKwogMjAxNS0wMS0xMiAgQW5kcmVhcyBLbGluZyAgPGFrbGlu Z0BhcHBsZS5jb20+CiAKICAgICAgICAgR2VvbG9jYXRpb24gb2JqZWN0cyBzaG91bGRuJ3QgcHJl dmVudCBwYWdlIGNhY2hpbmcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9mcmVldHlwZS9Gb250Q2FjaGVGcmVlVHlwZS5jcHAKaW5kZXggY2My NzBlN2U1MjlhYzJmNDY5YTk2NjUwMjM4NWQ4ZmVkMTg0OGFkMS4uZmVjOTQzYjc2YjRkZjE2OGIx ZDc1NDIxNTA3MmJiYTA4ZmM0ZTFhYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZnJlZXR5cGUvRm9udENhY2hlRnJlZVR5cGUuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZyZWV0eXBlL0ZvbnRDYWNoZUZyZWVUeXBlLmNwcApA QCAtMTY1LDYgKzE2NSw4IEBAIHN0ZDo6dW5pcXVlX3B0cjxGb250UGxhdGZvcm1EYXRhPiBGb250 Q2FjaGU6OmNyZWF0ZUZvbnRQbGF0Zm9ybURhdGEoY29uc3QgRm9udERlCiAgICAgLy8gc2F5cyB0 aGF0IHdlIG11c3QgZmluZCBhbiBleGFjdCBtYXRjaCBmb3IgZm9udCBmYW1pbHksIHNsYW50IChp dGFsaWMgb3Igb2JsaXF1ZSBjYW4gYmUgdXNlZCkKICAgICAvLyBhbmQgZm9udCB3ZWlnaHQgKHdl IG9ubHkgbWF0Y2ggYm9sZC9ub24tYm9sZCBoZXJlKS4KICAgICBSZWZQdHI8RmNQYXR0ZXJuPiBw YXR0ZXJuID0gYWRvcHRSZWYoRmNQYXR0ZXJuQ3JlYXRlKCkpOworICAgIC8vIEFsd2F5cyBwcmVm ZXIgc2NhbGFibGUgZm9udHMuIE90aGVyd2lzZSB3ZSBtYXkgZW5kIGNob29zaW5nIGZvbnRzIHRo YXQgbG9vayBob3JyaWJsZS4KKyAgICBGY1BhdHRlcm5BZGRCb29sKHBhdHRlcm4uZ2V0KCksIEZD X1NDQUxBQkxFLCBGY1RydWUpOwogICAgIFN0cmluZyBmYW1pbHlOYW1lU3RyaW5nKGdldEZhbWls eU5hbWVTdHJpbmdGcm9tRmFtaWx5KGZhbWlseSkpOwogICAgIGlmICghRmNQYXR0ZXJuQWRkU3Ry aW5nKHBhdHRlcm4uZ2V0KCksIEZDX0ZBTUlMWSwgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBGY0No YXI4Kj4oZmFtaWx5TmFtZVN0cmluZy51dGY4KCkuZGF0YSgpKSkpCiAgICAgICAgIHJldHVybiBu dWxscHRyOwo=