31930 2009-11-27 05:42:03 -0800 We don't need 270k memory to determine the vptrs 2009-12-09 15:01:47 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Minor --- 0 zherczeg webkit-unassigned abarth barraclough commit-queue eric sam zoltan oldest_to_newest 166879 0 zherczeg 2009-11-27 05:42:03 -0800 I think it is a typo. 166880 1 43946 zherczeg 2009-11-27 05:48:05 -0800 Created attachment 43946 Allocation fix 166963 2 43946 barraclough 2009-11-27 15:26:25 -0800 Comment on attachment 43946 Allocation fix Lol, no, I don't think this should be taking 270k! Nice catch. r+ with one comment, since you're no longer calling fastMalloc could you also please delete the comment saying: // Bizarrely, calling fastMalloc here is faster than allocating space on the stack. cheers, G. 167008 3 zoltan 2009-11-28 02:31:40 -0800 Committed r51457: <http://trac.webkit.org/changeset/51457> 167202 4 44011 zherczeg 2009-11-30 01:18:33 -0800 Created attachment 44011 Patch update (by Sam Weinig) Additional changes suggested by Sam. (He probably meant COMPILE_ASSERT since STATIC_ASSERT does not exists) Should be reviewed by him. 167386 5 abarth 2009-11-30 12:50:35 -0800 style-queue ran check-webkit-style on attachment 44011 without any errors. 167499 6 44011 eric 2009-11-30 21:46:36 -0800 Comment on attachment 44011 Patch update (by Sam Weinig) The speedup is only in debug builds I'm sure. 167500 7 eric 2009-11-30 21:47:41 -0800 I can't tell if this bug should be closed or not. I reviewed an r? pach on it, but I'm not sure if it should have been closed in the first place. 167525 8 zherczeg 2009-11-30 23:30:58 -0800 (In reply to comment #7) > I can't tell if this bug should be closed or not. I reviewed an r? pach on it, > but I'm not sure if it should have been closed in the first place. The first patch was the true patch. After it was landed, Sam asked me to change ASSERT-s to COMPILE_ASSERTs, and he was curious also about the gain of that patch. Thank you for reviewing, but I still feel he should review it, since he asked for these changes (unfortunately I can't specify the name of the reviewer anymore). (Hmm, if the changelog is not clear, perhaps I should make it more descriptive.) 167591 9 eric 2009-12-01 07:11:46 -0800 If you want patches reviewed, you need to re-open the bug though. Re-opening the bug. 168114 10 43946 eric 2009-12-02 11:59:30 -0800 Comment on attachment 43946 Allocation fix Obsoleting this patch, it was landed as r51457. 170194 11 eric 2009-12-09 14:46:59 -0800 @Zoltan: Ping? 170197 12 44011 eric 2009-12-09 14:48:24 -0800 Comment on attachment 44011 Patch update (by Sam Weinig) Oh, never mind, This Zoltan is not the same as zoltan@webkit.org. queueing for auto-commit. 170211 13 44011 commit-queue 2009-12-09 15:01:39 -0800 Comment on attachment 44011 Patch update (by Sam Weinig) Clearing flags on attachment: 44011 Committed r51928: <http://trac.webkit.org/changeset/51928> 170212 14 commit-queue 2009-12-09 15:01:47 -0800 All reviewed patches have been landed. Closing bug. 43946 2009-11-27 05:48:05 -0800 2009-12-02 11:59:30 -0800 Allocation fix 0001-vptrs-typo.patch text/plain 2406 zherczeg RnJvbSAzZTEwZGYwNWJhNGExNjRkMzA3OGZjYTA5MmI5NTkwYWVlZTc3ZDI5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBGcmksIDI3IE5vdiAyMDA5IDE0OjQ1OjM2ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gdnB0cnMtdHlwbwoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGlu Zi51LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAg ICAgfCAgIDExICsrKysrKysrKysrCiBKYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xvYmFsRGF0 YS5jcHAgfCAgICA5ICsrKysrKy0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCsp LCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBi L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAzY2JlNjNlLi5jMzZjNDczIDEwMDY0NAot LS0gYS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMjcgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6 ZWdAaW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTkz MAorCisgICAgICAgIFNlZW1zIGEgdHlwby4gV2UgZG9uJ3QgbmVlZCB+MjcwayBtZW1vcnkgdG8g ZGV0ZXJtaW5lIHRoZSB2cHRycy4KKworICAgICAgICAqIHJ1bnRpbWUvSlNHbG9iYWxEYXRhLmNw cDoKKyAgICAgICAgKEpTQzo6VlB0clNldDo6VlB0clNldCk6CisKIDIwMDktMTEtMjUgIE9saXZl ciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHYXZpbiBC YXJyYWNsb3VnaC4KZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxE YXRhLmNwcCBiL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxEYXRhLmNwcAppbmRleCAw YTdiZDY5Li5lZWQ0Y2VjIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTR2xv YmFsRGF0YS5jcHAKKysrIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEuY3Bw CkBAIC05MSwyNSArOTEsMjggQEAgc3RydWN0IFZQdHJTZXQgewogVlB0clNldDo6VlB0clNldCgp CiB7CiAgICAgLy8gQml6YXJyZWx5LCBjYWxsaW5nIGZhc3RNYWxsb2MgaGVyZSBpcyBmYXN0ZXIg dGhhbiBhbGxvY2F0aW5nIHNwYWNlIG9uIHRoZSBzdGFjay4KLSAgICB2b2lkKiBzdG9yYWdlID0g ZmFzdE1hbGxvYyhzaXplb2YoQ29sbGVjdG9yQmxvY2spKTsKKyAgICBDb2xsZWN0b3JDZWxsIGNl bGw7CisgICAgdm9pZCogc3RvcmFnZSA9ICZjZWxsOwogCisgICAgQVNTRVJUKHNpemVvZihKU0Fy cmF5KSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCkpOwogICAgIEpTQ2VsbCoganNBcnJheSA9IG5l dyAoc3RvcmFnZSkgSlNBcnJheShKU0FycmF5OjpjcmVhdGVTdHJ1Y3R1cmUoanNOdWxsKCkpKTsK ICAgICBqc0FycmF5VlB0ciA9IGpzQXJyYXktPnZwdHIoKTsKICAgICBqc0FycmF5LT5+SlNDZWxs KCk7CiAKKyAgICBBU1NFUlQoc2l6ZW9mKEpTQnl0ZUFycmF5KSA8PSBzaXplb2YoQ29sbGVjdG9y Q2VsbCkpOwogICAgIEpTQ2VsbCoganNCeXRlQXJyYXkgPSBuZXcgKHN0b3JhZ2UpIEpTQnl0ZUFy cmF5KEpTQnl0ZUFycmF5OjpWUHRyU3RlYWxpbmdIYWNrKTsKICAgICBqc0J5dGVBcnJheVZQdHIg PSBqc0J5dGVBcnJheS0+dnB0cigpOwogICAgIGpzQnl0ZUFycmF5LT5+SlNDZWxsKCk7CiAKKyAg ICBBU1NFUlQoc2l6ZW9mKEpTU3RyaW5nKSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCkpOwogICAg IEpTQ2VsbCoganNTdHJpbmcgPSBuZXcgKHN0b3JhZ2UpIEpTU3RyaW5nKEpTU3RyaW5nOjpWUHRy U3RlYWxpbmdIYWNrKTsKICAgICBqc1N0cmluZ1ZQdHIgPSBqc1N0cmluZy0+dnB0cigpOwogICAg IGpzU3RyaW5nLT5+SlNDZWxsKCk7CiAKKyAgICBBU1NFUlQoc2l6ZW9mKEpTRnVuY3Rpb24pIDw9 IHNpemVvZihDb2xsZWN0b3JDZWxsKSk7CiAgICAgSlNDZWxsKiBqc0Z1bmN0aW9uID0gbmV3IChz dG9yYWdlKSBKU0Z1bmN0aW9uKEpTRnVuY3Rpb246OmNyZWF0ZVN0cnVjdHVyZShqc051bGwoKSkp OwogICAgIGpzRnVuY3Rpb25WUHRyID0ganNGdW5jdGlvbi0+dnB0cigpOwogICAgIGpzRnVuY3Rp b24tPn5KU0NlbGwoKTsKLQotICAgIGZhc3RGcmVlKHN0b3JhZ2UpOwogfQogCiBKU0dsb2JhbERh dGE6OkpTR2xvYmFsRGF0YShib29sIGlzU2hhcmVkLCBjb25zdCBWUHRyU2V0JiB2cHRyU2V0KQot LSAKMS42LjAuNAoK 44011 2009-11-30 01:18:33 -0800 2009-12-09 15:01:39 -0800 Patch update (by Sam Weinig) 0001-vptrs-2.patch text/plain 2621 zherczeg RnJvbSAyNjczMjQ0MzhjN2FmODYxYTUwZmEwYmFiYTRhMWNmZjFjYzYzOGE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBNb24sIDMwIE5vdiAyMDA5IDEwOjAzOjM5ICswMTAwClN1YmplY3Q6IFtQQVRD SF0gdnB0cnMtMgoKU2lnbmVkLW9mZi1ieTogWm9sdGFuIEhlcmN6ZWcgPHpoZXJjemVnQGluZi51 LXN6ZWdlZC5odT4KLS0tCiBKYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg fCAgIDEyICsrKysrKysrKysrKwogSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0dsb2JhbERhdGEu Y3BwIHwgICAgOCArKysrLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNiBpbnNlcnRpb25zKCspLCA0 IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0ph dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAyNGJhOTkzLi4yMTMwYjMwIDEwMDY0NAotLS0g YS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMzAgIFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdA aW5mLnUtc3plZ2VkLmh1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTkzMAor CisgICAgICAgIFVwZGF0ZSB0byByNTE0NTcuIEFTU0VSVHMgY2hhbmdlZCB0byBDT01QSUxFX0FT U0VSVHMuCisgICAgICAgIFRoZSBzcGVlZHVwIGlzIDI1JS4KKworICAgICAgICAqIHJ1bnRpbWUv SlNHbG9iYWxEYXRhLmNwcDoKKyAgICAgICAgKEpTQzo6VlB0clNldDo6VlB0clNldCk6CisKIDIw MDktMTEtMjkgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvSmF2YVNjcmlwdENv cmUvcnVudGltZS9KU0dsb2JhbERhdGEuY3BwIGIvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU0ds b2JhbERhdGEuY3BwCmluZGV4IDY3Y2IxZTUuLjgzZmE3NDUgMTAwNjQ0Ci0tLSBhL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNHbG9iYWxEYXRhLmNwcAorKysgYi9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0pTR2xvYmFsRGF0YS5jcHAKQEAgLTkzLDIyICs5MywyMiBAQCBWUHRyU2V0OjpWUHRyU2V0 KCkKICAgICBDb2xsZWN0b3JDZWxsIGNlbGw7CiAgICAgdm9pZCogc3RvcmFnZSA9ICZjZWxsOwog Ci0gICAgQVNTRVJUKHNpemVvZihKU0FycmF5KSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCkpOwor ICAgIENPTVBJTEVfQVNTRVJUKHNpemVvZihKU0FycmF5KSA8PSBzaXplb2YoQ29sbGVjdG9yQ2Vs bCksIHNpemVvZl9KU0FycmF5X211c3RfYmVfbGVzc190aGFuX0NvbGxlY3RvckNlbGwpOwogICAg IEpTQ2VsbCoganNBcnJheSA9IG5ldyAoc3RvcmFnZSkgSlNBcnJheShKU0FycmF5OjpjcmVhdGVT dHJ1Y3R1cmUoanNOdWxsKCkpKTsKICAgICBqc0FycmF5VlB0ciA9IGpzQXJyYXktPnZwdHIoKTsK ICAgICBqc0FycmF5LT5+SlNDZWxsKCk7CiAKLSAgICBBU1NFUlQoc2l6ZW9mKEpTQnl0ZUFycmF5 KSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCkpOworICAgIENPTVBJTEVfQVNTRVJUKHNpemVvZihK U0J5dGVBcnJheSkgPD0gc2l6ZW9mKENvbGxlY3RvckNlbGwpLCBzaXplb2ZfSlNCeXRlQXJyYXlf bXVzdF9iZV9sZXNzX3RoYW5fQ29sbGVjdG9yQ2VsbCk7CiAgICAgSlNDZWxsKiBqc0J5dGVBcnJh eSA9IG5ldyAoc3RvcmFnZSkgSlNCeXRlQXJyYXkoSlNCeXRlQXJyYXk6OlZQdHJTdGVhbGluZ0hh Y2spOwogICAgIGpzQnl0ZUFycmF5VlB0ciA9IGpzQnl0ZUFycmF5LT52cHRyKCk7CiAgICAganNC eXRlQXJyYXktPn5KU0NlbGwoKTsKIAotICAgIEFTU0VSVChzaXplb2YoSlNTdHJpbmcpIDw9IHNp emVvZihDb2xsZWN0b3JDZWxsKSk7CisgICAgQ09NUElMRV9BU1NFUlQoc2l6ZW9mKEpTU3RyaW5n KSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCksIHNpemVvZl9KU1N0cmluZ19tdXN0X2JlX2xlc3Nf dGhhbl9Db2xsZWN0b3JDZWxsKTsKICAgICBKU0NlbGwqIGpzU3RyaW5nID0gbmV3IChzdG9yYWdl KSBKU1N0cmluZyhKU1N0cmluZzo6VlB0clN0ZWFsaW5nSGFjayk7CiAgICAganNTdHJpbmdWUHRy ID0ganNTdHJpbmctPnZwdHIoKTsKICAgICBqc1N0cmluZy0+fkpTQ2VsbCgpOwogCi0gICAgQVNT RVJUKHNpemVvZihKU0Z1bmN0aW9uKSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCkpOworICAgIENP TVBJTEVfQVNTRVJUKHNpemVvZihKU0Z1bmN0aW9uKSA8PSBzaXplb2YoQ29sbGVjdG9yQ2VsbCks IHNpemVvZl9KU0Z1bmN0aW9uX211c3RfYmVfbGVzc190aGFuX0NvbGxlY3RvckNlbGwpOwogICAg IEpTQ2VsbCoganNGdW5jdGlvbiA9IG5ldyAoc3RvcmFnZSkgSlNGdW5jdGlvbihKU0Z1bmN0aW9u OjpjcmVhdGVTdHJ1Y3R1cmUoanNOdWxsKCkpKTsKICAgICBqc0Z1bmN0aW9uVlB0ciA9IGpzRnVu Y3Rpb24tPnZwdHIoKTsKICAgICBqc0Z1bmN0aW9uLT5+SlNDZWxsKCk7Ci0tIAoxLjYuMC40Cgo=