<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31928</bug_id>
          
          <creation_ts>2009-11-27 05:03:20 -0800</creation_ts>
          <short_desc>DOMWindow::inspectorTimelineAgent is not guarded with ENABLE(INSPECTOR)</short_desc>
          <delta_ts>2009-11-30 09:17:55 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Steve Block">steveblock</reporter>
          <assigned_to name="Steve Block">steveblock</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>eric</cc>
    
    <cc>pfeldman</cc>
    
    <cc>timothy</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>166875</commentid>
    <comment_count>0</comment_count>
    <who name="Steve Block">steveblock</who>
    <bug_when>2009-11-27 05:03:20 -0800</bug_when>
    <thetext>DOMWindow::inspectorTimelineAgent is not guarded with ENABLE(INSPECTOR). This uses methods defined only when INSPECTOR is enabled.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166877</commentid>
    <comment_count>1</comment_count>
      <attachid>43945</attachid>
    <who name="Steve Block">steveblock</who>
    <bug_when>2009-11-27 05:08:42 -0800</bug_when>
    <thetext>Created attachment 43945
Patch 1 for Bug 31928</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167031</commentid>
    <comment_count>2</comment_count>
      <attachid>43945</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-28 09:40:59 -0800</bug_when>
    <thetext>Comment on attachment 43945
Patch 1 for Bug 31928

LGTM.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167266</commentid>
    <comment_count>3</comment_count>
      <attachid>43945</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-30 09:17:49 -0800</bug_when>
    <thetext>Comment on attachment 43945
Patch 1 for Bug 31928

Clearing flags on attachment: 43945

Committed r51495: &lt;http://trac.webkit.org/changeset/51495&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167267</commentid>
    <comment_count>4</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2009-11-30 09:17:55 -0800</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43945</attachid>
            <date>2009-11-27 05:08:42 -0800</date>
            <delta_ts>2009-11-30 09:17:49 -0800</delta_ts>
            <desc>Patch 1 for Bug 31928</desc>
            <filename>inspector.txt</filename>
            <type>text/plain</type>
            <size>1239</size>
            <attacher name="Steve Block">steveblock</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MTQzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMjcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n
bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IEFkZHMgRU5BQkxFKElOU1BFQ1RPUikgZ3VhcmRzIGFyb3VuZCBET01XaW5kb3c6Omluc3BlY3Rv
clRpbWVsaW5lQWdlbnQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn
LmNnaT9pZD0zMTkyOAorCisgICAgICAgIEJ1aWxkIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMuCisK
KyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6IE1vZGlmaWVkLiBBZGRzIEVOQUJMRShJTlNQ
RUNUT1IpIGd1YXJkcyBhcm91bmQgRE9NV2luZG93OjppbnNwZWN0b3JUaW1lbGluZUFnZW50Lgor
CiAyMDA5LTExLTI3ICBZdXJ5IFNlbWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAg
ICAgICAgIFJldmlld2VkIGJ5IFBhdmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL3BhZ2UvRE9N
V2luZG93LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkocmV2
aXNpb24gNTE0MzgpCisrKyBXZWJDb3JlL3BhZ2UvRE9NV2luZG93LmNwcAkod29ya2luZyBjb3B5
KQpAQCAtMTI5OSwxMiArMTI5OSwxNCBAQCB2b2lkIERPTVdpbmRvdzo6ZGlzcGF0Y2hMb2FkRXZl
bnQoKQogI2VuZGlmCiB9CiAKKyNpZiBFTkFCTEUoSU5TUEVDVE9SKQogSW5zcGVjdG9yVGltZWxp
bmVBZ2VudCogRE9NV2luZG93OjppbnNwZWN0b3JUaW1lbGluZUFnZW50KCkgCiB7CiAgICAgaWYg
KGZyYW1lKCkgJiYgZnJhbWUoKS0+cGFnZSgpKQogICAgICAgICByZXR1cm4gZnJhbWUoKS0+cGFn
ZSgpLT5pbnNwZWN0b3JUaW1lbGluZUFnZW50KCk7CiAgICAgcmV0dXJuIDA7CiB9CisjZW5kaWYK
IAogYm9vbCBET01XaW5kb3c6OmRpc3BhdGNoRXZlbnQoUGFzc1JlZlB0cjxFdmVudD4gcHJwRXZl
bnQsIFBhc3NSZWZQdHI8RXZlbnRUYXJnZXQ+IHBycFRhcmdldCkKIHsK
</data>

          </attachment>
      

    </bug>

</bugzilla>