31926 2009-11-27 04:30:49 -0800 V8 WorkerContextExecutionProxy does not have necessary guards for SHARED_WORKERS 2009-11-30 09:03:50 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock atwilson commit-queue eric oldest_to_newest 166870 0 steveblock 2009-11-27 04:30:49 -0800 V8 WorkerContextExecutionProxy does not have necessary guards for SHARED_WORKERS. Methods of this class use types only defined when SHARED_WORKERS is enabled. 166874 1 43944 steveblock 2009-11-27 04:51:58 -0800 Created attachment 43944 Patch 1 for Bug 31926 167030 2 43944 eric 2009-11-28 09:38:18 -0800 Comment on attachment 43944 Patch 1 for Bug 31926 OK 167258 3 43944 commit-queue 2009-11-30 09:03:43 -0800 Comment on attachment 43944 Patch 1 for Bug 31926 Clearing flags on attachment: 43944 Committed r51493: <http://trac.webkit.org/changeset/51493> 167259 4 commit-queue 2009-11-30 09:03:50 -0800 All reviewed patches have been landed. Closing bug. 43944 2009-11-27 04:51:58 -0800 2009-11-30 09:03:42 -0800 Patch 1 for Bug 31926 sharedWorkers.txt text/plain 3222 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTQzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMjcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgU0hBUkVEX1dPUktFUlMgZ3VhcmRzIHRvIFY4IFdvcmtlckNvbnRleHRFeGVjdXRpb25Q cm94eS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx OTI2CisKKyAgICAgICAgQnVpbGQgZml4IG9ubHksIG5vIG5ldyB0ZXN0cy4KKworICAgICAgICAq IGJpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eS5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJveHk6OmluaXRDb250ZXh0SWZOZWVkZWQp OgorICAgICAgICAoV2ViQ29yZTo6V29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5Ojpjb252ZXJ0 VG9WOE9iamVjdCk6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0RXhlY3V0aW9uUHJv eHk6OmNvbnZlcnRFdmVudFRhcmdldFRvVjhPYmplY3QpOgorCiAyMDA5LTExLTI3ICBZdXJ5IFNl bWlraGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBh dmVsIEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1dvcmtlckNvbnRleHRFeGVj dXRpb25Qcm94eS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9Xb3JrZXJD b250ZXh0RXhlY3V0aW9uUHJveHkuY3BwCShyZXZpc2lvbiA1MTQzOCkKKysrIFdlYkNvcmUvYmlu ZGluZ3MvdjgvV29ya2VyQ29udGV4dEV4ZWN1dGlvblByb3h5LmNwcAkod29ya2luZyBjb3B5KQpA QCAtMTUwLDcgKzE1MCwxMSBAQCB2b2lkIFdvcmtlckNvbnRleHRFeGVjdXRpb25Qcm94eTo6aW5p dENvCiAgICAgdjg6OkhhbmRsZTx2ODo6U3RyaW5nPiBpbXBsaWNpdFByb3RvU3RyaW5nID0gdjg6 OlN0cmluZzo6TmV3KCJfX3Byb3RvX18iKTsKIAogICAgIC8vIENyZWF0ZSBhIG5ldyBKUyBvYmpl Y3QgYW5kIHVzZSBpdCBhcyB0aGUgcHJvdG90eXBlIGZvciB0aGUgc2hhZG93IGdsb2JhbCBvYmpl Y3QuCi0gICAgVjhDbGFzc0luZGV4OjpWOFdyYXBwZXJUeXBlIGNvbnRleHRUeXBlID0gbV93b3Jr ZXJDb250ZXh0LT5pc0RlZGljYXRlZFdvcmtlckNvbnRleHQoKSA/IFY4Q2xhc3NJbmRleDo6REVE SUNBVEVEV09SS0VSQ09OVEVYVCA6IFY4Q2xhc3NJbmRleDo6U0hBUkVEV09SS0VSQ09OVEVYVDsK KyAgICBWOENsYXNzSW5kZXg6OlY4V3JhcHBlclR5cGUgY29udGV4dFR5cGUgPSBWOENsYXNzSW5k ZXg6OkRFRElDQVRFRFdPUktFUkNPTlRFWFQ7CisjaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJTKQor ICAgIGlmICghbV93b3JrZXJDb250ZXh0LT5pc0RlZGljYXRlZFdvcmtlckNvbnRleHQoKSkKKyAg ICAgICAgY29udGV4dFR5cGUgPSBWOENsYXNzSW5kZXg6OlNIQVJFRFdPUktFUkNPTlRFWFQ7Cisj ZW5kaWYKICAgICB2ODo6SGFuZGxlPHY4OjpGdW5jdGlvbj4gd29ya2VyQ29udGV4dENvbnN0cnVj dG9yID0gVjhET01XcmFwcGVyOjpnZXRDb25zdHJ1Y3RvckZvckNvbnRleHQoY29udGV4dFR5cGUs IGNvbnRleHQpOwogICAgIHY4OjpMb2NhbDx2ODo6T2JqZWN0PiBqc1dvcmtlckNvbnRleHQgPSBT YWZlQWxsb2NhdGlvbjo6bmV3SW5zdGFuY2Uod29ya2VyQ29udGV4dENvbnN0cnVjdG9yKTsKICAg ICAvLyBCYWlsIG91dCBpZiBhbGxvY2F0aW9uIGZhaWxlZC4KQEAgLTE3NSw3ICsxNzksMTEgQEAg djg6OkhhbmRsZTx2ODo6VmFsdWU+IFdvcmtlckNvbnRleHRFeGVjdQogICAgIGlmICghaW1wbCkK ICAgICAgICAgcmV0dXJuIHY4OjpOdWxsKCk7CiAKLSAgICBpZiAodHlwZSA9PSBWOENsYXNzSW5k ZXg6OkRFRElDQVRFRFdPUktFUkNPTlRFWFQgfHwgdHlwZSA9PSBWOENsYXNzSW5kZXg6OlNIQVJF RFdPUktFUkNPTlRFWFQpCisgICAgaWYgKHR5cGUgPT0gVjhDbGFzc0luZGV4OjpERURJQ0FURURX T1JLRVJDT05URVhUCisjaWYgRU5BQkxFKFNIQVJFRF9XT1JLRVJTKQorICAgICAgICB8fCB0eXBl ID09IFY4Q2xhc3NJbmRleDo6U0hBUkVEV09SS0VSQ09OVEVYVAorI2VuZGlmCisgICAgICAgICkK ICAgICAgICAgcmV0dXJuIGNvbnZlcnRXb3JrZXJDb250ZXh0VG9WOE9iamVjdChzdGF0aWNfY2Fz dDxXb3JrZXJDb250ZXh0Kj4oaW1wbCkpOwogCiAgICAgYm9vbCBpc0FjdGl2ZURvbU9iamVjdCA9 IGZhbHNlOwpAQCAtMjg3LDE3ICsyOTUsMjEgQEAgdjg6OkhhbmRsZTx2ODo6VmFsdWU+IFdvcmtl ckNvbnRleHRFeGVjdQogICAgIGlmICh3b3JrZXJDb250ZXh0KQogICAgICAgICByZXR1cm4gY29u dmVydFdvcmtlckNvbnRleHRUb1Y4T2JqZWN0KHdvcmtlckNvbnRleHQpOwogCisjaWYgRU5BQkxF KFNIQVJFRF9XT1JLRVJTKQogICAgIFNoYXJlZFdvcmtlckNvbnRleHQqIHNoYXJlZFdvcmtlckNv bnRleHQgPSB0YXJnZXQtPnRvU2hhcmVkV29ya2VyQ29udGV4dCgpOwogICAgIGlmIChzaGFyZWRX b3JrZXJDb250ZXh0KQogICAgICAgICByZXR1cm4gY29udmVydFdvcmtlckNvbnRleHRUb1Y4T2Jq ZWN0KHNoYXJlZFdvcmtlckNvbnRleHQpOworI2VuZGlmCiAKICAgICBXb3JrZXIqIHdvcmtlciA9 IHRhcmdldC0+dG9Xb3JrZXIoKTsKICAgICBpZiAod29ya2VyKQogICAgICAgICByZXR1cm4gY29u dmVydFRvVjhPYmplY3QoVjhDbGFzc0luZGV4OjpXT1JLRVIsIHdvcmtlcik7CiAKKyNpZiBFTkFC TEUoU0hBUkVEX1dPUktFUlMpCiAgICAgU2hhcmVkV29ya2VyKiBzaGFyZWRXb3JrZXIgPSB0YXJn ZXQtPnRvU2hhcmVkV29ya2VyKCk7CiAgICAgaWYgKHNoYXJlZFdvcmtlcikKICAgICAgICAgcmV0 dXJuIGNvbnZlcnRUb1Y4T2JqZWN0KFY4Q2xhc3NJbmRleDo6U0hBUkVEV09SS0VSLCBzaGFyZWRX b3JrZXIpOworI2VuZGlmCiAKICAgICBYTUxIdHRwUmVxdWVzdCogeGhyID0gdGFyZ2V0LT50b1hN TEh0dHBSZXF1ZXN0KCk7CiAgICAgaWYgKHhocikK