31925 2009-11-27 04:17:49 -0800 Memory usage code in V8GCController lacks PLATFORM(CHROMIUM) guards 2009-11-30 09:23:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 steveblock steveblock antonm steveblock oldest_to_newest 166868 0 steveblock 2009-11-27 04:17:49 -0800 Memory usage code in V8GCController lacks PLATFORM(CHROMIUM) guards. This code uses ChromiumBridge and Chromium-specific constant values. 166869 1 43941 steveblock 2009-11-27 04:26:13 -0800 Created attachment 43941 Patch 1 for Bug 31925 167029 2 43941 eric 2009-11-28 09:37:17 -0800 Comment on attachment 43941 Patch 1 for Bug 31925 I take it this is because Andriod is compiling with V8 now. The ChangeLog might want to mention that. :) 167206 3 steveblock 2009-11-30 02:35:54 -0800 This was introduced in http://trac.webkit.org/changeset/50752 167207 4 steveblock 2009-11-30 02:43:21 -0800 Committed as http://trac.webkit.org/changeset/51483 167269 5 antonm 2009-11-30 09:18:23 -0800 (In reply to comment #4) > Committed as http://trac.webkit.org/changeset/51483 Thanks and sorry for breaking it. How could I have checked it before submitting? 167272 6 steveblock 2009-11-30 09:23:34 -0800 > Thanks and sorry for breaking it. No problem > How could I have checked it before submitting? You couldn't have. We're working as fast as we can to unfork the Android port and set up an Android buildbot! 43941 2009-11-27 04:26:13 -0800 2009-11-28 09:37:17 -0800 Patch 1 for Bug 31925 v8GCController.txt text/plain 1956 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTQzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMDktMTEtMjcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgUExBVEZPUk0oQ0hST01JVU0pIGd1YXJkcyBhcm91bmQgbWVtb3J5IHVzYWdlIGNvZGUg aW4gVjhHQ0NvbnRyb2xsZXIuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTkyNQorCisgICAgICAgIEJ1aWxkIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMu IChPT1BTISkKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4R0NDb250cm9sbGVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6OlY4R0NDb250cm9sbGVyOjpjaGVja01lbW9yeVVzYWdlKToKKwogMjAw OS0xMS0yNyAgWXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFuLgpJbmRleDogV2ViQ29yZS9iaW5kaW5ncy92OC9W OEdDQ29udHJvbGxlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92OC9WOEdD Q29udHJvbGxlci5jcHAJKHJldmlzaW9uIDUxNDM4KQorKysgV2ViQ29yZS9iaW5kaW5ncy92OC9W OEdDQ29udHJvbGxlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5Niw3ICszOTYsMTEgQEAgbmFt ZXNwYWNlIHsKIAogaW50IGdldE1lbW9yeVVzYWdlSW5NQigpCiB7CisjaWYgUExBVEZPUk0oQ0hS T01JVU0pCiAgICAgcmV0dXJuIENocm9taXVtQnJpZGdlOjptZW1vcnlVc2FnZU1CKCk7CisjZWxz ZQorICAgIHJldHVybiAwOworI2VuZGlmCiB9CiAKIH0gIC8vIGFub255bW91cyBuYW1lc3BhY2UK QEAgLTQyNyw2ICs0MzEsOCBAQCB2b2lkIFY4R0NDb250cm9sbGVyOjpnY0VwaWxvZ3VlKCkKIAog dm9pZCBWOEdDQ29udHJvbGxlcjo6Y2hlY2tNZW1vcnlVc2FnZSgpCiB7CisjaWYgUExBVEZPUk0o Q0hST01JVU0pCisgICAgLy8gVGhlc2UgdmFsdWVzIGFyZSBhcHByb3ByaWF0ZSBmb3IgQ2hyb21p dW0gb25seS4KICAgICBjb25zdCBpbnQgbG93VXNhZ2VNQiA9IDI1NjsgIC8vIElmIG1lbW9yeSB1 c2FnZSBpcyBiZWxvdyB0aGlzIHRocmVzaG9sZCwgZG8gbm90IGJvdGhlciBmb3JjaW5nIEdDLgog ICAgIGNvbnN0IGludCBoaWdoVXNhZ2VNQiA9IDEwMjQ7ICAvLyBJZiBtZW1vcnkgdXNhZ2UgaXMg YWJvdmUgdGhpcyB0aHJlc2hvbGQsIGZvcmNlIEdDIG1vcmUgYWdncmVzaXZlbHkuCiAgICAgY29u c3QgaW50IGhpZ2hVc2FnZURlbHRhTUIgPSAxMjg7ICAvLyBEZWx0YSBvZiBtZW1vcnkgdXNhZ2Ug Z3Jvd3RoICh2cy4gbGFzdCB3b3JraW5nU2V0RXN0aW1hdGVNQikgdG8gZm9yY2UgR0Mgd2hlbiBt ZW1vcnkgdXNhZ2UgaXMgaGlnaC4KQEAgLTQzNCw2ICs0NDAsNyBAQCB2b2lkIFY4R0NDb250cm9s bGVyOjpjaGVja01lbW9yeVVzYWdlKCkKICAgICBpbnQgbWVtb3J5VXNhZ2VNQiA9IGdldE1lbW9y eVVzYWdlSW5NQigpOwogICAgIGlmICgobWVtb3J5VXNhZ2VNQiA+IGxvd1VzYWdlTUIgJiYgbWVt b3J5VXNhZ2VNQiA+IDIgKiB3b3JraW5nU2V0RXN0aW1hdGVNQikgfHwgKG1lbW9yeVVzYWdlTUIg PiBoaWdoVXNhZ2VNQiAmJiBtZW1vcnlVc2FnZU1CID4gd29ya2luZ1NldEVzdGltYXRlTUIgKyBo aWdoVXNhZ2VEZWx0YU1CKSkKICAgICAgICAgdjg6OlY4OjpMb3dNZW1vcnlOb3RpZmljYXRpb24o KTsKKyNlbmRpZgogfQogCiAK