31924 2009-11-27 03:39:42 -0800 ResourceHandle has virtual methods but non-virtual destructor 2009-11-30 08:55:08 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED DUPLICATE 31962 P2 Normal --- 1 steveblock steveblock ap eric steveblock oldest_to_newest 166866 0 steveblock 2009-11-27 03:39:42 -0800 ResourceHandle has virtual methods but a non-virtual destructor. This can cause build warnings or errors. These virtual methods were added in http://trac.webkit.org/changeset/50772. 166867 1 43940 steveblock 2009-11-27 03:45:06 -0800 Created attachment 43940 Patch 1 for Bug 31924 167027 2 43940 eric 2009-11-28 09:30:29 -0800 Comment on attachment 43940 Patch 1 for Bug 31924 OK. 167028 3 eric 2009-11-28 09:31:47 -0800 Please CC the folks who made the change when making a build fix. :) http://trac.webkit.org/changeset/50772 167250 4 steveblock 2009-11-30 08:54:40 -0800 Already fixed in https://bugs.webkit.org/show_bug.cgi?id=31962, which was filed after this bug, but made it into the commit queue first. 167251 5 steveblock 2009-11-30 08:55:08 -0800 *** This bug has been marked as a duplicate of bug 31962 *** 43940 2009-11-27 03:45:06 -0800 2009-11-30 08:54:02 -0800 Patch 1 for Bug 31924 resourceHandleDestructor.txt text/plain 1148 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTQzOSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMDktMTEtMjcgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IE1ha2VzIFJlc291cmNlSGFuZGxlIGRlc3RydWN0b3IgdmlydHVhbCwgYXMgdGhpcyBjbGFzcyBu b3cgaGFzIHZpcnR1YWwgbWV0aG9kcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxOTI0CisKKyAgICAgICAgQnVpbGQgZml4IG9ubHksIG5vIG5ldyB0 ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUuaDogTW9k aWZpZWQuIE1hZGUgZGVzdHJ1Y3RvciB2aXJ0dWFsLgorCiAyMDA5LTExLTI3ICBZdXJ5IFNlbWlr aGF0c2t5ICA8eXVyeXNAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFBhdmVs IEZlbGRtYW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUu aAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUu aAkocmV2aXNpb24gNTE0MzgpCisrKyBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VI YW5kbGUuaAkod29ya2luZyBjb3B5KQpAQCAtMTE1LDcgKzExNSw3IEBAIHB1YmxpYzoKICAgICBz dGF0aWMgYm9vbCBkaWRTZW5kQm9keURhdGFEZWxlZ2F0ZUV4aXN0cygpOwogI2VuZGlmCiAKLSAg ICB+UmVzb3VyY2VIYW5kbGUoKTsKKyAgICB2aXJ0dWFsIH5SZXNvdXJjZUhhbmRsZSgpOwogCiAj aWYgUExBVEZPUk0oTUFDKSB8fCBVU0UoQ0ZORVRXT1JLKQogICAgIHZvaWQgd2lsbFNlbmRSZXF1 ZXN0KFJlc291cmNlUmVxdWVzdCYsIGNvbnN0IFJlc291cmNlUmVzcG9uc2UmIHJlZGlyZWN0UmVz cG9uc2UpOwo=