31919 2009-11-26 11:33:02 -0800 REGRESSION(51418): fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard Commit Bot 2009-11-27 08:21:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned cmarrin commit-queue dglazkov fishd kbr oliver oldest_to_newest 166765 0 eric 2009-11-26 11:33:02 -0800 fast/canvas/webgl/gl-object-get-calls.html is failing on the Leopard Commit Bot https://bugs.webkit.org/show_bug.cgi?id=21554#c21 https://bugs.webkit.org/show_bug.cgi?id=31903#c4 I think it's failing 100% of the time. I recommend we skip the test or roll out the associated change so the commit-queue can run again. --- /tmp/layout-test-results/fast/canvas/webgl/gl-object-get-calls-expected.txt 2009-11-26 11:25:35.000000000 -0800 +++ /tmp/layout-test-results/fast/canvas/webgl/gl-object-get-calls-actual.txt 2009-11-26 11:25:35.000000000 -0800 @@ -7,7 +7,7 @@ PASS gl.getError() is 0 PASS gl.getError() is 0 PASS gl.getError() is 0 -PASS gl.checkFramebufferStatus(gl.FRAMEBUFFER) is gl.FRAMEBUFFER_COMPLETE +FAIL gl.checkFramebufferStatus(gl.FRAMEBUFFER) should be 36053. Was 36061. PASS gl.getFramebufferAttachmentParameter(gl.FRAMEBUFFER, gl.COLOR_ATTACHMENT0, gl.FRAMEBUFFER_ATTACHMENT_OBJECT_TYPE) is gl.TEXTURE PASS gl.getFramebufferAttachmentParameter(gl.FRAMEBUFFER, gl.COLOR_ATTACHMENT0, gl.FRAMEBUFFER_ATTACHMENT_OBJECT_NAME) is non-null. PASS gl.getFramebufferAttachmentParameter(gl.FRAMEBUFFER, gl.COLOR_ATTACHMENT0, gl.FRAMEBUFFER_ATTACHMENT_TEXTURE_LEVEL) is 0 It looks like the same failure we saw when trying to get the patch landed in the first place. :( 166766 1 eric 2009-11-26 11:34:39 -0800 bug 21554 was the first failure we've seen like this. All patches have failed on the commit-queue since. I've stopped the queue for now. 166769 2 eric 2009-11-26 11:39:05 -0800 https://bugs.webkit.org/show_bug.cgi?id=30091 http://trac.webkit.org/changeset/51418 is what started the failures. 166773 3 eric 2009-11-26 12:09:33 -0800 I'm going to try moving the commit-queue to a different machine as a work-around from my end. 166784 4 kbr 2009-11-26 13:25:19 -0800 I don't have commit rights; can you please comment out the failing line, regenerate the -expected.txt file and commit the result? 166790 5 oliver 2009-11-26 14:15:53 -0800 (In reply to comment #4) > I don't have commit rights; can you please comment out the failing line, > regenerate the -expected.txt file and commit the result? We need to find out why it's failing on some systems but not others, and add logic to ensure identical behaviour. 166791 6 kbr 2009-11-26 14:25:19 -0800 (In reply to comment #5) > (In reply to comment #4) > > I don't have commit rights; can you please comment out the failing line, > > regenerate the -expected.txt file and commit the result? > > We need to find out why it's failing on some systems but not others, and add > logic to ensure identical behaviour. We need to get the commit queue reopened. There is already a bug about the unportability of this test: https://bugs.webkit.org/show_bug.cgi?id=31843 . 166799 7 mrowe 2009-11-26 16:59:40 -0800 (In reply to comment #4) > I don't have commit rights; can you please comment out the failing line, > regenerate the -expected.txt file and commit the result? That sounds like it would have the effect of breaking the test on the build bots. That makes it an unacceptable solution. 166865 8 43939 kbr 2009-11-27 03:35:56 -0800 Created attachment 43939 Patch Temporarily disabled portion of test which is failing on some machines but not others. Root cause will be investigated under https://bugs.webkit.org/show_bug.cgi?id=31843 . This is the correct fix for this issue. The remaining portions of the test are both valid and valuable. 166899 9 43939 eric 2009-11-27 08:09:41 -0800 Comment on attachment 43939 Patch Looks fine to me. Thank you for the quick fix. As noted in comment #3, I attempted to move the commit-bot to a new machine. That move was successful. (As you can see at http://webkit-commit-queue.appspot.com/), but this fix will make the tests pass correctly for everyone (including the old commit-bot machine if we need to move it back). Setting cq+ too since I don't see you in committers.py yet. Should be landed within 15 minutes or so while we return to enjoying our post-turkey haze. :) 166900 10 43939 commit-queue 2009-11-27 08:21:08 -0800 Comment on attachment 43939 Patch Clearing flags on attachment: 43939 Committed r51441: <http://trac.webkit.org/changeset/51441> 166901 11 commit-queue 2009-11-27 08:21:13 -0800 All reviewed patches have been landed. Closing bug. 43939 2009-11-27 03:35:56 -0800 2009-11-27 08:21:07 -0800 Patch workaround.patch text/plain 3267 kbr SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDUxNDM5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMjcgIEtlbm5ldGggUnVzc2VsbCAg PGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJFR1JFU1NJT04oNTE0MTgpOiBmYXN0L2NhbnZhcy93ZWJnbC9nbC1vYmplY3Qt Z2V0LWNhbGxzLmh0bWwgaXMgZmFpbGluZyBvbiB0aGUgTGVvcGFyZCBjb21taXQgYm90CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTkxOQorCisgICAg ICAgIFRlbXBvcmFyaWx5IGRpc2FibGVkIHBvcnRpb24gb2YgdGVzdCB3aGljaCBpcyBmYWlsaW5n IG9uIHNvbWUKKyAgICAgICAgbWFjaGluZXMgYnV0IG5vdCBvdGhlcnMuIFJvb3QgY2F1c2Ugd2ls bCBiZSBpbnZlc3RpZ2F0ZWQgdW5kZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxODQzIC4KKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2ds LW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIGZhc3QvY2FudmFzL3dl YmdsL3NjcmlwdC10ZXN0cy9nbC1vYmplY3QtZ2V0LWNhbGxzLmpzOgorCiAyMDA5LTExLTI2ICBT aGluaWNoaXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZp ZXdlZCByZWQgYm90IGZpeC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ds LW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L2Zhc3QvY2FudmFzL3dlYmdsL2dsLW9iamVjdC1nZXQtY2FsbHMtZXhwZWN0ZWQudHh0CShyZXZp c2lvbiA1MTQzOCkKKysrIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2dsLW9iamVjdC1n ZXQtY2FsbHMtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC03LDcgKzcsNiBAQCBQQVNT IGdsLmdldEJ1ZmZlclBhcmFtZXRlcihnbC5BUlJBWV9CVUZGCiBQQVNTIGdsLmdldEVycm9yKCkg aXMgMAogUEFTUyBnbC5nZXRFcnJvcigpIGlzIDAKIFBBU1MgZ2wuZ2V0RXJyb3IoKSBpcyAwCi1Q QVNTIGdsLmNoZWNrRnJhbWVidWZmZXJTdGF0dXMoZ2wuRlJBTUVCVUZGRVIpIGlzIGdsLkZSQU1F QlVGRkVSX0NPTVBMRVRFCiBQQVNTIGdsLmdldEZyYW1lYnVmZmVyQXR0YWNobWVudFBhcmFtZXRl cihnbC5GUkFNRUJVRkZFUiwgZ2wuQ09MT1JfQVRUQUNITUVOVDAsIGdsLkZSQU1FQlVGRkVSX0FU VEFDSE1FTlRfT0JKRUNUX1RZUEUpIGlzIGdsLlRFWFRVUkUKIFBBU1MgZ2wuZ2V0RnJhbWVidWZm ZXJBdHRhY2htZW50UGFyYW1ldGVyKGdsLkZSQU1FQlVGRkVSLCBnbC5DT0xPUl9BVFRBQ0hNRU5U MCwgZ2wuRlJBTUVCVUZGRVJfQVRUQUNITUVOVF9PQkpFQ1RfTkFNRSkgaXMgbm9uLW51bGwuCiBQ QVNTIGdsLmdldEZyYW1lYnVmZmVyQXR0YWNobWVudFBhcmFtZXRlcihnbC5GUkFNRUJVRkZFUiwg Z2wuQ09MT1JfQVRUQUNITUVOVDAsIGdsLkZSQU1FQlVGRkVSX0FUVEFDSE1FTlRfVEVYVFVSRV9M RVZFTCkgaXMgMApJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRl c3RzL2dsLW9iamVjdC1nZXQtY2FsbHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFz dC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3RzL2dsLW9iamVjdC1nZXQtY2FsbHMuanMJKHJldmlz aW9uIDUxNDM4KQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvc2NyaXB0LXRlc3Rz L2dsLW9iamVjdC1nZXQtY2FsbHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDEyIEBA IHNob3VsZEJlKCdnbC5nZXRFcnJvcigpJywgJzAnKTsKIGdsLnJlbmRlcmJ1ZmZlclN0b3JhZ2Uo Z2wuUkVOREVSQlVGRkVSLCBnbC5ERVBUSF9DT01QT05FTlQsIDIsIDIpOwogc2hvdWxkQmUoJ2ds LmdldEVycm9yKCknLCAnMCcpOwogZ2wuZnJhbWVidWZmZXJSZW5kZXJidWZmZXIoZ2wuRlJBTUVC VUZGRVIsIGdsLkRFUFRIX0FUVEFDSE1FTlQsIGdsLlJFTkRFUkJVRkZFUiwgcmVuZGVyYnVmZmVy KTsKLXNob3VsZEJlKCdnbC5jaGVja0ZyYW1lYnVmZmVyU3RhdHVzKGdsLkZSQU1FQlVGRkVSKScs ICdnbC5GUkFNRUJVRkZFUl9DT01QTEVURScpOworLy8gRklYTUU6IG9uIHNvbWUgbWFjaGluZXMg KGluIHBhcnRpY3VsYXIgdGhlIFdlYktpdCBjb21taXQgYm90cykgdGhlCisvLyBmcmFtZWJ1ZmZl ciBzdGF0dXMgaXMgRlJBTUVCVUZGRVJfVU5TVVBQT1JURUQ7IG1vcmUgaW52ZXN0aWdhdGlvbgor Ly8gaXMgbmVlZGVkIHdoeSB0aGlzIGlzIHRoZSBjYXNlLCBiZWNhdXNlIHRoZSBGQk8gYWxsb2Nh dGVkCisvLyBpbnRlcm5hbGx5IGJ5IHRoZSBXZWJLaXQgaW1wbGVtZW50YXRpb24gaGFzIGFsbW9z dCBpZGVudGljYWwKKy8vIHBhcmFtZXRlcnMgdG8gdGhpcyBvbmUuIFNlZSBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE4NDMuCisvL3Nob3VsZEJlKCdnbC5jaGVja0Zy YW1lYnVmZmVyU3RhdHVzKGdsLkZSQU1FQlVGRkVSKScsICdnbC5GUkFNRUJVRkZFUl9DT01QTEVU RScpOwogc2hvdWxkQmUoJ2dsLmdldEZyYW1lYnVmZmVyQXR0YWNobWVudFBhcmFtZXRlcihnbC5G UkFNRUJVRkZFUiwgZ2wuQ09MT1JfQVRUQUNITUVOVDAsIGdsLkZSQU1FQlVGRkVSX0FUVEFDSE1F TlRfT0JKRUNUX1RZUEUpJywgJ2dsLlRFWFRVUkUnKTsKIHNob3VsZEJlTm9uTnVsbCgnZ2wuZ2V0 RnJhbWVidWZmZXJBdHRhY2htZW50UGFyYW1ldGVyKGdsLkZSQU1FQlVGRkVSLCBnbC5DT0xPUl9B VFRBQ0hNRU5UMCwgZ2wuRlJBTUVCVUZGRVJfQVRUQUNITUVOVF9PQkpFQ1RfTkFNRSknKTsKIHNo b3VsZEJlKCdnbC5nZXRGcmFtZWJ1ZmZlckF0dGFjaG1lbnRQYXJhbWV0ZXIoZ2wuRlJBTUVCVUZG RVIsIGdsLkNPTE9SX0FUVEFDSE1FTlQwLCBnbC5GUkFNRUJVRkZFUl9BVFRBQ0hNRU5UX1RFWFRV UkVfTEVWRUwpJywgJzAnKTsK