<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31913</bug_id>
          
          <creation_ts>2009-11-26 08:16:26 -0800</creation_ts>
          <short_desc>[Android] Upstream WebCore/history/android: Require some platform specific state attached to HistoryItem.</short_desc>
          <delta_ts>2009-12-03 04:18:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Android</rep_platform>
          <op_sys>Android</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>31867</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="Ben Murdoch">benm</reporter>
          <assigned_to name="Ben Murdoch">benm</assigned_to>
          <cc>abarth</cc>
    
    <cc>android-webkit-unforking</cc>
    
    <cc>beidson</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>166737</commentid>
    <comment_count>0</comment_count>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-11-26 08:16:26 -0800</bug_when>
    <thetext>Master bug for upstreaming Android history changes: https://bugs.webkit.org/show_bug.cgi?id=31867

As is the case with the Mac and Qt ports, Android requires some state stored with each WebCore::HistoryItem (for example, the zoom scale of the page).

Patch to follow.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166746</commentid>
    <comment_count>1</comment_count>
      <attachid>43925</attachid>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-11-26 09:58:33 -0800</bug_when>
    <thetext>Created attachment 43925
Patch

This patch adds Android specific member data to HistoryItem.h and implements Android specific functionality in new files added to the history/android directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167078</commentid>
    <comment_count>2</comment_count>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-29 07:44:38 -0800</bug_when>
    <thetext>I wonder how the iPhone does this.  Or if the iPhone even bothers to hold current zoom when going between history items.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>167373</commentid>
    <comment_count>3</comment_count>
    <who name="Adam Barth">abarth</who>
    <bug_when>2009-11-30 12:45:55 -0800</bug_when>
    <thetext>style-queue ran check-webkit-style on attachment 43925 without any errors.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168099</commentid>
    <comment_count>4</comment_count>
      <attachid>43925</attachid>
    <who name="Brady Eidson">beidson</who>
    <bug_when>2009-12-02 11:29:45 -0800</bug_when>
    <thetext>Comment on attachment 43925
Patch


&gt; Index: WebCore/history/HistoryItem.h
&gt; ===================================================================

&gt; +#if PLATFORM(ANDROID)
&gt; +#include &quot;AndroidWebHistoryBridge.h&quot;
&gt; +#endif
&gt; +
&gt;  namespace WebCore {

Since nothing in the header needs the full class declaration, this should be a forward declaration instead of an #include

I really hate the name &quot;bridge.&quot;  It implies a completely different pattern than what I think you&apos;re going for here.  We used to call the platform/API glue interface between WebCore and WebKit the &quot;bridge&quot;.  Your bridge object seems to simply be a container for platform specific data.  Can&apos;t you call it something else that isn&apos;t as ambiguous?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168110</commentid>
    <comment_count>5</comment_count>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-12-02 11:46:48 -0800</bug_when>
    <thetext>(In reply to comment #4)
&gt; (From update of attachment 43925 [details])
&gt; 
&gt; &gt; Index: WebCore/history/HistoryItem.h
&gt; &gt; ===================================================================
&gt; 
&gt; &gt; +#if PLATFORM(ANDROID)
&gt; &gt; +#include &quot;AndroidWebHistoryBridge.h&quot;
&gt; &gt; +#endif
&gt; &gt; +
&gt; &gt;  namespace WebCore {
&gt; 
&gt; Since nothing in the header needs the full class declaration, this should be a
&gt; forward declaration instead of an #include

Good point, thanks. I&apos;ll fix this on landing.

&gt; 
&gt; I really hate the name &quot;bridge.&quot;  It implies a completely different pattern
&gt; than what I think you&apos;re going for here.  We used to call the platform/API glue
&gt; interface between WebCore and WebKit the &quot;bridge&quot;.  Your bridge object seems to
&gt; simply be a container for platform specific data.  Can&apos;t you call it something
&gt; else that isn&apos;t as ambiguous?

Well, it&apos;s both... it holds platform specific data and the implementation of AndroidWebHistoryBridge::updateHistoryItem() does live in WebKit, so it&apos;s also a bridge connecting WebCore and WebKit?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168133</commentid>
    <comment_count>6</comment_count>
      <attachid>43925</attachid>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-12-02 13:01:32 -0800</bug_when>
    <thetext>Comment on attachment 43925
Patch

cq- for manual landing.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168348</commentid>
    <comment_count>7</comment_count>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-12-03 03:37:59 -0800</bug_when>
    <thetext>(In reply to comment #5)
&gt; (In reply to comment #4)
&gt; &gt; (From update of attachment 43925 [details] [details])
&gt; &gt; 
&gt; &gt; &gt; Index: WebCore/history/HistoryItem.h
&gt; &gt; &gt; ===================================================================
&gt; &gt; 
&gt; &gt; &gt; +#if PLATFORM(ANDROID)
&gt; &gt; &gt; +#include &quot;AndroidWebHistoryBridge.h&quot;
&gt; &gt; &gt; +#endif
&gt; &gt; &gt; +
&gt; &gt; &gt;  namespace WebCore {
&gt; &gt; 
&gt; &gt; Since nothing in the header needs the full class declaration, this should be a
&gt; &gt; forward declaration instead of an #include
&gt; 
&gt; Good point, thanks. I&apos;ll fix this on landing.
&gt; 

Actually, we do need the include, as the new member for Android is a RefPtr.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>168355</commentid>
    <comment_count>8</comment_count>
    <who name="Ben Murdoch">benm</who>
    <bug_when>2009-12-03 04:18:35 -0800</bug_when>
    <thetext>Landed as r51628.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43925</attachid>
            <date>2009-11-26 09:58:33 -0800</date>
            <delta_ts>2009-12-02 13:01:32 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>31913.txt</filename>
            <type>text/plain</type>
            <size>7085</size>
            <attacher name="Ben Murdoch">benm</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MTQxOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMjEgQEAKKzIwMDktMTEtMjYgIEJlbiBNdXJkb2NoICA8YmVubUBnb29nbGUuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtBbmRy
b2lkXSBVcHN0cmVhbSBXZWJDb3JlL2hpc3RvcnkvYW5kcm9pZDogUmVxdWlyZSBzb21lIHBsYXRm
b3JtIHNwZWNpZmljIHN0YXRlIGF0dGFjaGVkIHRvIEhpc3RvcnlJdGVtLgorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE5MTMKKworICAgICAgICBBbmRy
b2lkIHN0b3JlcyBpbmZvcm1hdGlvbiBzdWNoIGFzIHRoZSB6b29tIHNjYWxlIGZhY3RvciBhbmQg
YnJpZGdlIGJhY2sgdG8gdGhlIEphdmEgY291bnRlcnBhcnQgd2l0aCBIaXN0b3J5SXRlbS4KKwor
ICAgICAgICBObyBuZXcgdGVzdHMgcmVxdWlyZWQgYXMgdGhpcyBpcyBBbmRyb2lkIHNwZWNpZmlj
IGNvZGUuCisKKyAgICAgICAgKiBoaXN0b3J5L0hpc3RvcnlJdGVtLmg6IEFkZCBBbmRyb2lkIHNw
ZWNpZmljIG1lbWJlciBkYXRhIHRvIEhpc3RvcnlJdGVtLgorICAgICAgICAqIGhpc3RvcnkvYW5k
cm9pZDogQWRkZWQuCisgICAgICAgICogaGlzdG9yeS9hbmRyb2lkL0FuZHJvaWRXZWJIaXN0b3J5
QnJpZGdlLmg6IEFkZGVkLgorICAgICAgICAqIGhpc3RvcnkvYW5kcm9pZC9IaXN0b3J5SXRlbUFu
ZHJvaWQuY3BwOiBBZGRlZCwgcHJvdmlkZXMgaW1wbGVtZW50YXRpb24gZm9yIEFuZHJvaWQgc3Bl
Y2lmaWMgbWVtYmVyIGZ1bmN0aW9ucyBpbiBIaXN0b3J5SXRlbS4KKyAgICAgICAgKFdlYkNvcmU6
Okhpc3RvcnlJdGVtOjpicmlkZ2UpOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6Okhpc3RvcnlJ
dGVtOjpzZXRCcmlkZ2UpOiBBZGRlZC4KKwogMjAwOS0xMS0yNiAgQW50b24gTXVoaW4gIDxhbnRv
bm1AY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCkluZGV4
OiBXZWJDb3JlL2hpc3RvcnkvSGlzdG9yeUl0ZW0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2hp
c3RvcnkvSGlzdG9yeUl0ZW0uaAkocmV2aXNpb24gNTE0MTYpCisrKyBXZWJDb3JlL2hpc3Rvcnkv
SGlzdG9yeUl0ZW0uaAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsMTAgQEAgdHlwZWRlZiBz
dHJ1Y3Qgb2JqY19vYmplY3QqIGlkOwogI2luY2x1ZGUgPFFEYXRhU3RyZWFtPgogI2VuZGlmCiAK
KyNpZiBQTEFURk9STShBTkRST0lEKQorI2luY2x1ZGUgIkFuZHJvaWRXZWJIaXN0b3J5QnJpZGdl
LmgiCisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBjbGFzcyBDYWNoZWRQYWdlOwpA
QCAtMTc1LDYgKzE3OSwxMSBAQCBwdWJsaWM6IAogICAgIFFEYXRhU3RyZWFtJiBzYXZlU3RhdGUo
UURhdGFTdHJlYW0mIG91dCwgaW50IHZlcnNpb24pIGNvbnN0OwogI2VuZGlmCiAKKyNpZiBQTEFU
Rk9STShBTkRST0lEKQorICAgIHZvaWQgc2V0QnJpZGdlKEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdl
KiBicmlkZ2UpOworICAgIEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdlKiBicmlkZ2UoKSBjb25zdDsK
KyNlbmRpZgorCiAjaWZuZGVmIE5ERUJVRwogICAgIGludCBzaG93VHJlZSgpIGNvbnN0OwogICAg
IGludCBzaG93VHJlZVdpdGhJbmRlbnQodW5zaWduZWQgaW5kZW50TGV2ZWwpIGNvbnN0OwpAQCAt
MjQzLDYgKzI1MiwxMSBAQCBwcml2YXRlOgogI2lmIFBMQVRGT1JNKFFUKQogICAgIFFWYXJpYW50
IG1fdXNlckRhdGE7CiAjZW5kaWYKKworI2lmIFBMQVRGT1JNKEFORFJPSUQpCisgICAgUmVmUHRy
PEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdlPiBtX2JyaWRnZTsKKyNlbmRpZgorCiB9OyAvL2NsYXNz
IEhpc3RvcnlJdGVtCiAKIH0gLy9uYW1lc3BhY2UgV2ViQ29yZQpJbmRleDogV2ViQ29yZS9oaXN0
b3J5L2FuZHJvaWQvQW5kcm9pZFdlYkhpc3RvcnlCcmlkZ2UuaAo9PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJD
b3JlL2hpc3RvcnkvYW5kcm9pZC9BbmRyb2lkV2ViSGlzdG9yeUJyaWRnZS5oCShyZXZpc2lvbiAw
KQorKysgV2ViQ29yZS9oaXN0b3J5L2FuZHJvaWQvQW5kcm9pZFdlYkhpc3RvcnlCcmlkZ2UuaAko
cmV2aXNpb24gMCkKQEAgLTAsMCArMSw2MSBAQAorLyoKKyAqIENvcHlyaWdodCAyMDA5LCBUaGUg
QW5kcm9pZCBPcGVuIFNvdXJjZSBQcm9qZWN0CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVz
ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmlj
YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv
bnMKKyAqIGFyZSBtZXQ6CisgKiAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz
dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg
Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICogUmVkaXN0cmli
dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK
KyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg
ZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy
aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FS
RSBJUyBQUk9WSURFRCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgYGBBUyBJUycnIEFORCBBTlkK
KyAqIEVYUFJFU1MgT1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElN
SVRFRCBUTywgVEhFCisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFO
RCBGSVRORVNTIEZPUiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJ
TiBOTyBFVkVOVCBTSEFMTCBUSEUgQ09QWVJJR0hUIE9XTkVSIE9SCisgKiBDT05UUklCVVRPUlMg
QkUgTElBQkxFIEZPUiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwK
KyAqIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBO
T1QgTElNSVRFRCBUTywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS
VklDRVM7IExPU1MgT0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U
RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklM
SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAo
SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VU
IE9GIFRIRSBVU0UKKyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg
UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2lmbmRlZiBBbmRyb2lkV2ViSGlz
dG9yeUJyaWRnZV9oCisjZGVmaW5lIEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdlX2gKKworI2luY2x1
ZGUgPHd0Zi9SZWZDb3VudGVkLmg+CisKK25hbWVzcGFjZSBXZWJDb3JlIHsKKworY2xhc3MgSGlz
dG9yeUl0ZW07CisKK2NsYXNzIEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdlIDogcHVibGljIFJlZkNv
dW50ZWQ8QW5kcm9pZFdlYkhpc3RvcnlCcmlkZ2U+IHsKK3B1YmxpYzoKKyAgICBBbmRyb2lkV2Vi
SGlzdG9yeUJyaWRnZSgpCisgICAgICAgIDogbV9zY2FsZSgxMDApCisgICAgICAgICwgbV9zY3Jl
ZW5XaWR0aFNjYWxlKDEwMCkKKyAgICAgICAgLCBtX2FjdGl2ZShmYWxzZSkKKyAgICAgICAgLCBt
X2hpc3RvcnlJdGVtKDApIHsgfQorICAgIHZpcnR1YWwgfkFuZHJvaWRXZWJIaXN0b3J5QnJpZGdl
KCkgeyB9CisgICAgdmlydHVhbCB2b2lkIHVwZGF0ZUhpc3RvcnlJdGVtKEhpc3RvcnlJdGVtKiBp
dGVtKSA9IDA7CisKKyAgICB2b2lkIHNldFNjYWxlKGludCBzKSB7IG1fc2NhbGUgPSBzOyB9Cisg
ICAgdm9pZCBzZXRTY3JlZW5XaWR0aFNjYWxlKGludCBzKSB7IG1fc2NyZWVuV2lkdGhTY2FsZSA9
IHM7IH0KKyAgICBpbnQgc2NhbGUoKSBjb25zdCB7IHJldHVybiBtX3NjYWxlOyB9CisgICAgaW50
IHNjcmVlbldpZHRoU2NhbGUoKSBjb25zdCB7IHJldHVybiBtX3NjcmVlbldpZHRoU2NhbGU7IH0K
KyAgICBIaXN0b3J5SXRlbSogaGlzdG9yeUl0ZW0oKSBjb25zdCB7IHJldHVybiBtX2hpc3RvcnlJ
dGVtOyB9CisgICAgdm9pZCBzZXRBY3RpdmUoKSB7IG1fYWN0aXZlID0gdHJ1ZTsgfQorCitwcm90
ZWN0ZWQ6CisgICAgaW50IG1fc2NhbGU7CisgICAgaW50IG1fc2NyZWVuV2lkdGhTY2FsZTsKKyAg
ICBib29sIG1fYWN0aXZlOworICAgIEhpc3RvcnlJdGVtKiBtX2hpc3RvcnlJdGVtOworfTsKKwor
fSAvLyBuYW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYgLy8gQW5kcm9pZFdlYkhpc3RvcnlCcmlk
Z2VfaAoKUHJvcGVydHkgY2hhbmdlcyBvbjogV2ViQ29yZS9oaXN0b3J5L2FuZHJvaWQvQW5kcm9p
ZFdlYkhpc3RvcnlCcmlkZ2UuaApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBu
YXRpdmUKCkluZGV4OiBXZWJDb3JlL2hpc3RvcnkvYW5kcm9pZC9IaXN0b3J5SXRlbUFuZHJvaWQu
Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaGlzdG9yeS9hbmRyb2lkL0hpc3RvcnlJdGVtQW5k
cm9pZC5jcHAJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL2hpc3RvcnkvYW5kcm9pZC9IaXN0b3J5
SXRlbUFuZHJvaWQuY3BwCShyZXZpc2lvbiAwKQpAQCAtMCwwICsxLDQ2IEBACisvKgorICogQ29w
eXJpZ2h0IDIwMDksIFRoZSBBbmRyb2lkIE9wZW4gU291cmNlIFByb2plY3QKKyAqCisgKiBSZWRp
c3RyaWJ1dGlvbiBhbmQgdXNlIGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdp
dGhvdXQKKyAqIG1vZGlmaWNhdGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBm
b2xsb3dpbmcgY29uZGl0aW9ucworICogYXJlIG1ldDoKKyAqICAqIFJlZGlzdHJpYnV0aW9ucyBv
ZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3Rp
Y2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIu
CisgKiAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1Y2UgdGhl
IGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh
bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyIGluIHRoZQorICogICAgZG9jdW1lbnRhdGlvbiBh
bmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlIGRpc3RyaWJ1dGlvbi4KKyAq
CisgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBg
YEFTIElTJycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xV
RElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUKKyAqIElNUExJRUQgV0FSUkFOVElFUyBPRiBN
RVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUgorICogUFVSUE9TRSBB
UkUgRElTQ0xBSU1FRC4gIElOIE5PIEVWRU5UIFNIQUxMIFRIRSBDT1BZUklHSFQgT1dORVIgT1IK
KyAqIENPTlRSSUJVVE9SUyBCRSBMSUFCTEUgRk9SIEFOWSBESVJFQ1QsIElORElSRUNULCBJTkNJ
REVOVEFMLCBTUEVDSUFMLAorICogRVhFTVBMQVJZLCBPUiBDT05TRVFVRU5USUFMIERBTUFHRVMg
KElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogUFJPQ1VSRU1FTlQgT0YgU1VCU1RJ
VFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERBVEEsIE9SCisgKiBQUk9GSVRT
OyBPUiBCVVNJTkVTUyBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FVU0VEIEFORCBPTiBBTlkgVEhF
T1JZCisgKiBPRiBMSUFCSUxJVFksIFdIRVRIRVIgSU4gQ09OVFJBQ1QsIFNUUklDVCBMSUFCSUxJ
VFksIE9SIFRPUlQKKyAqIChJTkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJ
TkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQorICogT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJ
RiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KKyAqLworCisjaW5j
bHVkZSAiY29uZmlnLmgiCisjaW5jbHVkZSAiSGlzdG9yeUl0ZW0uaCIKKworbmFtZXNwYWNlIFdl
YkNvcmUgeworCitjbGFzcyBBbmRyb2lkV2ViSGlzdG9yeUJyaWRnZTsKKworQW5kcm9pZFdlYkhp
c3RvcnlCcmlkZ2UqIEhpc3RvcnlJdGVtOjpicmlkZ2UoKSBjb25zdAoreworICAgIGlmICghbV9i
cmlkZ2UpCisgICAgICAgIHJldHVybiAwOworICAgIHJldHVybiBtX2JyaWRnZS5nZXQoKTsKK30K
Kwordm9pZCBIaXN0b3J5SXRlbTo6c2V0QnJpZGdlKEFuZHJvaWRXZWJIaXN0b3J5QnJpZGdlKiBi
cmlkZ2UpCit7CisgICAgbV9icmlkZ2UgPSBhZG9wdFJlZihicmlkZ2UpOworfQorCit9IC8vIG5h
bWVzcGFjZSBXZWJDb3JlCisKClByb3BlcnR5IGNoYW5nZXMgb246IFdlYkNvcmUvaGlzdG9yeS9h
bmRyb2lkL0hpc3RvcnlJdGVtQW5kcm9pZC5jcHAKX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46ZW9sLXN0
eWxlCiAgICsgbmF0aXZlCgo=
</data>
<flag name="review"
          id="25670"
          type_id="1"
          status="+"
          setter="beidson"
    />
    <flag name="commit-queue"
          id="25973"
          type_id="3"
          status="-"
          setter="benm"
    />
          </attachment>
      

    </bug>

</bugzilla>