31901 2009-11-25 21:46:21 -0800 Incorrect behaviour of jneq_null in the interpreter 2009-11-27 13:29:13 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 oliver webkit-unassigned barraclough eric oldest_to_newest 166628 0 oliver 2009-11-25 21:46:21 -0800 The interpreters implementation of op_jneq_null is incorrect when the value being compared is set to masquerade as undefined. The result is that if (document.all == null) { alert("PASS") } else { alert("FAIL") } Will fail. 166629 1 43894 oliver 2009-11-25 21:48:05 -0800 Created attachment 43894 Patch 166630 2 eric 2009-11-25 21:53:56 -0800 I'm sure Oliver will chase down the right people, but just in case. 166632 3 43894 eric 2009-11-25 21:55:12 -0800 Comment on attachment 43894 Patch I would be happy to r+ this, as it sounds simple. Except w/o test result updates, it's difficult for me to see how it's correct. 166633 4 oliver 2009-11-25 21:58:02 -0800 (In reply to comment #3) > (From update of attachment 43894 [details]) > I would be happy to r+ this, as it sounds simple. Except w/o test result > updates, it's difficult for me to see how it's correct. The interpreter currently fails tests due to this -- the issue is that the existing logic will always short circuit on the isUndefinedOrNull for any cell -- eg. the type where we actually have to do the masquerade check. 166650 5 eric 2009-11-25 22:46:05 -0800 Yeah, I think my confusion is just that I was surprised there were no test expectation changes in your patch. That's all. 166939 6 oliver 2009-11-27 13:29:13 -0800 Committed r51424 43894 2009-11-25 21:48:05 -0800 2009-11-26 15:09:28 -0800 Patch bug-31901-20091125214803.patch text/plain 1423 oliver ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCBkNWQ1MDZlLi5hOTlmYzhlIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUg QEAKKzIwMDktMTEtMjUgIE9saXZlciBIdW50ICA8b2xpdmVyQGFwcGxlLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJbmNvcnJlY3QgYmVoYXZp b3VyIG9mIGpuZXFfbnVsbCBpbiB0aGUgaW50ZXJwcmV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxOTAxCisKKyAgICAgICAgQ29ycmVjdCB0aGUg bG9naWMgb2Ygam5lcV9udWxsLiAgVGhpcyBpcyBhbHJlYWR5IGNvdmVyZWQgYnkgZXhpc3Rpbmcg dGVzdHMuCisKKyAgICAgICAgKiBpbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHA6CisgICAgICAg IChKU0M6OkludGVycHJldGVyOjpwcml2YXRlRXhlY3V0ZSk6CisKIDIwMDktMTEtMjQgIERtaXRy eSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJp YyBTZWlkZWwuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnBy ZXRlci5jcHAgYi9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRlcnByZXRlci5jcHAKaW5k ZXggYmVhMWUwYy4uODEyNDgwOCAxMDA2NDQKLS0tIGEvSmF2YVNjcmlwdENvcmUvaW50ZXJwcmV0 ZXIvSW50ZXJwcmV0ZXIuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL2ludGVycHJldGVyL0ludGVy cHJldGVyLmNwcApAQCAtMjcwNyw3ICsyNzA3LDcgQEAgSlNWYWx1ZSBJbnRlcnByZXRlcjo6cHJp dmF0ZUV4ZWN1dGUoRXhlY3V0aW9uRmxhZyBmbGFnLCBSZWdpc3RlckZpbGUqIHJlZ2lzdGVyRmkK ICAgICAgICAgaW50IHRhcmdldCA9IHZQQ1syXS51Lm9wZXJhbmQ7CiAgICAgICAgIEpTVmFsdWUg c3JjVmFsdWUgPSBjYWxsRnJhbWUtPnIoc3JjKS5qc1ZhbHVlKCk7CiAKLSAgICAgICAgaWYgKCFz cmNWYWx1ZS5pc1VuZGVmaW5lZE9yTnVsbCgpIHx8IChzcmNWYWx1ZS5pc0NlbGwoKSAmJiAhc3Jj VmFsdWUuYXNDZWxsKCktPnN0cnVjdHVyZSgpLT50eXBlSW5mbygpLm1hc3F1ZXJhZGVzQXNVbmRl ZmluZWQoKSkpIHsKKyAgICAgICAgaWYgKCFzcmNWYWx1ZS5pc1VuZGVmaW5lZE9yTnVsbCgpICYm ICghc3JjVmFsdWUuaXNDZWxsKCkgfHwgIXNyY1ZhbHVlLmFzQ2VsbCgpLT5zdHJ1Y3R1cmUoKS0+ dHlwZUluZm8oKS5tYXNxdWVyYWRlc0FzVW5kZWZpbmVkKCkpKSB7CiAgICAgICAgICAgICB2UEMg Kz0gdGFyZ2V0OwogICAgICAgICAgICAgTkVYVF9JTlNUUlVDVElPTigpOwogICAgICAgICB9Cg==