31898 2009-11-25 19:35:01 -0800 [Qt] Make QtLauncher default to http scheme 2009-12-01 14:05:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 dbates dbates abarth commit-queue eric kenneth zoltan oldest_to_newest 166610 0 dbates 2009-11-25 19:35:01 -0800 We should make the QtLauncher default to the http scheme for URLs so that it is more user friendly. 166611 1 43889 dbates 2009-11-25 19:37:56 -0800 Created attachment 43889 Patch 167365 2 abarth 2009-11-30 12:41:59 -0800 Attachment 43889 did not pass style-queue: Failed to run "WebKitTools/Scripts/check-webkit-style" exit_code: 1 WebKit/qt/QtLauncher/main.cpp:191: Tab found; better to use spaces [whitespace/tab] [1] Done processing WebKit/qt/QtLauncher/main.cpp Total errors found: 1 167417 3 44040 dbates 2009-11-30 13:53:51 -0800 Created attachment 44040 Patch Removed tab character from patch that the style-bot found. 167421 4 abarth 2009-11-30 13:57:38 -0800 style-queue ran check-webkit-style on attachment 44040 without any errors. 167735 5 44040 commit-queue 2009-12-01 14:05:10 -0800 Comment on attachment 44040 Patch Clearing flags on attachment: 44040 Committed r51558: <http://trac.webkit.org/changeset/51558> 167736 6 commit-queue 2009-12-01 14:05:15 -0800 All reviewed patches have been landed. Closing bug. 43889 2009-11-25 19:37:56 -0800 2009-11-30 13:53:51 -0800 Patch Bug31898.patch text/plain 2191 dbates SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTE0MDUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMjUgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTg5OAorCisgICAg ICAgIE1ha2VzIFF0TGF1bmNoZXIgZGVmYXVsdCB0byB0aGUgaHR0cCBzY2hlbWUgZm9yIFVSTHMu CisKKyAgICAgICAgKiBRdExhdW5jaGVyL21haW4uY3BwOgorICAgICAgICAoTWFpbldpbmRvdzo6 TWFpbldpbmRvdyk6CisgICAgICAgIChNYWluV2luZG93OjpjaGFuZ2VMb2NhdGlvbik6CisgICAg ICAgIChtYWluKToKKwogMjAwOS0xMS0yMyAgRGF2aWQgQm9kZGllICA8ZGJvZGRpZUB0cm9sbHRl Y2guY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpJbmRleDogV2Vi S2l0L3F0L1F0TGF1bmNoZXIvbWFpbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L1F0TGF1 bmNoZXIvbWFpbi5jcHAJKHJldmlzaW9uIDUxNDAyKQorKysgV2ViS2l0L3F0L1F0TGF1bmNoZXIv bWFpbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTE4NywxMCArMTg3LDExIEBAIHB1YmxpYzoKICAg ICAgICAgICAgIHVybCA9IGZpLmFic29sdXRlRmlsZVBhdGgoKTsKIAogICAgICAgICBRVXJsIHF1 cmwgPSB1cmxGcm9tVXNlcklucHV0KHVybCk7CisgICAgICAgIGlmIChxdXJsLnNjaGVtZSgpLmlz RW1wdHkoKSkKKwkgICAgICAgIHF1cmwgPSBRVXJsKCJodHRwOi8vIiArIHVybCArICIvIik7CiAg ICAgICAgIGlmIChxdXJsLmlzVmFsaWQoKSkgewogICAgICAgICAgICAgdXJsRWRpdC0+c2V0VGV4 dChxdXJsLnRvRW5jb2RlZCgpKTsKICAgICAgICAgICAgIHZpZXctPmxvYWQocXVybCk7Ci0KICAg ICAgICAgfQogCiAgICAgICAgIC8vIHRoZSB6b29tIHZhbHVlcyBhcmUgY2hvc2VuIHRvIGJlIGxp a2UgaW4gTW96aWxsYSBGaXJlZm94IDMKQEAgLTIxMiwxMSArMjEzLDEzIEBAIHByb3RlY3RlZCBz bG90czoKICAgICB2b2lkIGNoYW5nZUxvY2F0aW9uKCkgewogICAgICAgICBRU3RyaW5nIHN0cmlu ZyA9IHVybEVkaXQtPnRleHQoKTsKICAgICAgICAgUVVybCB1cmwgPSB1cmxGcm9tVXNlcklucHV0 KHN0cmluZyk7Ci0gICAgICAgIGlmICghdXJsLmlzVmFsaWQoKSkKKyAgICAgICAgaWYgKHVybC5z Y2hlbWUoKS5pc0VtcHR5KCkpCiAgICAgICAgICAgICB1cmwgPSBRVXJsKCJodHRwOi8vIiArIHN0 cmluZyArICIvIik7Ci0gICAgICAgIHVybEVkaXQtPnNldFRleHQodXJsLnRvRW5jb2RlZCgpKTsK LSAgICAgICAgdmlldy0+bG9hZCh1cmwpOwotICAgICAgICB2aWV3LT5zZXRGb2N1cyhRdDo6T3Ro ZXJGb2N1c1JlYXNvbik7CisgICAgICAgIGlmICh1cmwuaXNWYWxpZCgpKSB7CisgICAgICAgICAg ICB1cmxFZGl0LT5zZXRUZXh0KHVybC50b0VuY29kZWQoKSk7CisgICAgICAgICAgICB2aWV3LT5s b2FkKHVybCk7CisgICAgICAgICAgICB2aWV3LT5zZXRGb2N1cyhRdDo6T3RoZXJGb2N1c1JlYXNv bik7CisgICAgICAgIH0KICAgICB9CiAKICAgICB2b2lkIGxvYWRGaW5pc2hlZCgpIHsKQEAgLTU2 Miw3ICs1NjUsNyBAQCBpbnQgbGF1bmNoZXJNYWluKGNvbnN0IFFBcHBsaWNhdGlvbiYgYXBwCiBp bnQgbWFpbihpbnQgYXJnYywgY2hhciAqKmFyZ3YpCiB7CiAgICAgUUFwcGxpY2F0aW9uIGFwcChh cmdjLCBhcmd2KTsKLSAgICBRU3RyaW5nIHVybCA9IFFTdHJpbmcoIiUxLyUyIikuYXJnKFFEaXI6 OmhvbWVQYXRoKCkpLmFyZyhRTGF0aW4xU3RyaW5nKCJpbmRleC5odG1sIikpOworICAgIFFTdHJp bmcgdXJsID0gUVN0cmluZygiZmlsZTovLyUxLyUyIikuYXJnKFFEaXI6OmhvbWVQYXRoKCkpLmFy ZyhRTGF0aW4xU3RyaW5nKCJpbmRleC5odG1sIikpOwogCiAgICAgUVdlYlNldHRpbmdzOjpzZXRN YXhpbXVtUGFnZXNJbkNhY2hlKDQpOwogCg== 44040 2009-11-30 13:53:51 -0800 2009-12-01 14:05:09 -0800 Patch Bug31898_1.patch text/plain 2211 dbates SW5kZXg6IFdlYktpdC9xdC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3F0L0NoYW5n ZUxvZwkocmV2aXNpb24gNTE0NjUpCisrKyBXZWJLaXQvcXQvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMzAgIERhbmllbCBCYXRlcyAgPGRiYXRlc0B3 ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTg5OAorCisgICAg ICAgIE1ha2VzIFF0TGF1bmNoZXIgZGVmYXVsdCB0byB0aGUgaHR0cCBzY2hlbWUgZm9yIFVSTHMu CisKKyAgICAgICAgKiBRdExhdW5jaGVyL21haW4uY3BwOgorICAgICAgICAoTWFpbldpbmRvdzo6 TWFpbldpbmRvdyk6CisgICAgICAgIChNYWluV2luZG93OjpjaGFuZ2VMb2NhdGlvbik6CisgICAg ICAgIChtYWluKToKKwogMjAwOS0xMS0yOCAgU2ltb24gSGF1c21hbm4gIDxzaW1vbi5oYXVzbWFu bkBub2tpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3Rp YW5zZW4uCkluZGV4OiBXZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBXZWJLaXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcAkocmV2aXNpb24gNTE0NjUpCisrKyBXZWJL aXQvcXQvUXRMYXVuY2hlci9tYWluLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg3LDEwICsxODcs MTEgQEAgcHVibGljOgogICAgICAgICAgICAgdXJsID0gZmkuYWJzb2x1dGVGaWxlUGF0aCgpOwog CiAgICAgICAgIFFVcmwgcXVybCA9IHVybEZyb21Vc2VySW5wdXQodXJsKTsKKyAgICAgICAgaWYg KHF1cmwuc2NoZW1lKCkuaXNFbXB0eSgpKQorICAgICAgICAgICAgcXVybCA9IFFVcmwoImh0dHA6 Ly8iICsgdXJsICsgIi8iKTsKICAgICAgICAgaWYgKHF1cmwuaXNWYWxpZCgpKSB7CiAgICAgICAg ICAgICB1cmxFZGl0LT5zZXRUZXh0KHF1cmwudG9FbmNvZGVkKCkpOwogICAgICAgICAgICAgdmll dy0+bG9hZChxdXJsKTsKLQogICAgICAgICB9CiAKICAgICAgICAgLy8gdGhlIHpvb20gdmFsdWVz IGFyZSBjaG9zZW4gdG8gYmUgbGlrZSBpbiBNb3ppbGxhIEZpcmVmb3ggMwpAQCAtMjEyLDExICsy MTMsMTMgQEAgcHJvdGVjdGVkIHNsb3RzOgogICAgIHZvaWQgY2hhbmdlTG9jYXRpb24oKSB7CiAg ICAgICAgIFFTdHJpbmcgc3RyaW5nID0gdXJsRWRpdC0+dGV4dCgpOwogICAgICAgICBRVXJsIHVy bCA9IHVybEZyb21Vc2VySW5wdXQoc3RyaW5nKTsKLSAgICAgICAgaWYgKCF1cmwuaXNWYWxpZCgp KQorICAgICAgICBpZiAodXJsLnNjaGVtZSgpLmlzRW1wdHkoKSkKICAgICAgICAgICAgIHVybCA9 IFFVcmwoImh0dHA6Ly8iICsgc3RyaW5nICsgIi8iKTsKLSAgICAgICAgdXJsRWRpdC0+c2V0VGV4 dCh1cmwudG9FbmNvZGVkKCkpOwotICAgICAgICB2aWV3LT5sb2FkKHVybCk7Ci0gICAgICAgIHZp ZXctPnNldEZvY3VzKFF0OjpPdGhlckZvY3VzUmVhc29uKTsKKyAgICAgICAgaWYgKHVybC5pc1Zh bGlkKCkpIHsKKyAgICAgICAgICAgIHVybEVkaXQtPnNldFRleHQodXJsLnRvRW5jb2RlZCgpKTsK KyAgICAgICAgICAgIHZpZXctPmxvYWQodXJsKTsKKyAgICAgICAgICAgIHZpZXctPnNldEZvY3Vz KFF0OjpPdGhlckZvY3VzUmVhc29uKTsKKyAgICAgICAgfQogICAgIH0KIAogICAgIHZvaWQgbG9h ZEZpbmlzaGVkKCkgewpAQCAtNTYyLDcgKzU2NSw3IEBAIGludCBsYXVuY2hlck1haW4oY29uc3Qg UUFwcGxpY2F0aW9uJiBhcHAKIGludCBtYWluKGludCBhcmdjLCBjaGFyICoqYXJndikKIHsKICAg ICBRQXBwbGljYXRpb24gYXBwKGFyZ2MsIGFyZ3YpOwotICAgIFFTdHJpbmcgdXJsID0gUVN0cmlu ZygiJTEvJTIiKS5hcmcoUURpcjo6aG9tZVBhdGgoKSkuYXJnKFFMYXRpbjFTdHJpbmcoImluZGV4 Lmh0bWwiKSk7CisgICAgUVN0cmluZyB1cmwgPSBRU3RyaW5nKCJmaWxlOi8vJTEvJTIiKS5hcmco UURpcjo6aG9tZVBhdGgoKSkuYXJnKFFMYXRpbjFTdHJpbmcoImluZGV4Lmh0bWwiKSk7CiAKICAg ICBRV2ViU2V0dGluZ3M6OnNldE1heGltdW1QYWdlc0luQ2FjaGUoNCk7CiAK