31895 2009-11-25 17:04:54 -0800 Clean up V8 bindings for CSSStyleDeclaration and CSSVariableDeclaration 2009-11-30 10:59:50 -0800 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 arv arv abarth commit-queue dglazkov oldest_to_newest 166583 0 arv 2009-11-25 17:04:54 -0800 These index getters never return a null string so to make things clearer do not use string-or-null index getter. 166584 1 43880 arv 2009-11-25 17:15:09 -0800 Created attachment 43880 Adds a setCollectionStringIndexedGetter and uses that instead of setCollectionStringOrNullIndexedGetter 166770 2 43929 arv 2009-11-26 11:39:34 -0800 Created attachment 43929 Patch (with ChangeLog this time) 166844 3 43929 abarth 2009-11-26 23:45:06 -0800 Comment on attachment 43929 Patch (with ChangeLog this time) This looks reasonable. Do we really use uint32_t? I would have expected us to use unsigned. 166938 4 arv 2009-11-27 12:37:43 -0800 uint32_t seems more correct to me since that is the requirement for array indeces in EcmaScript. 166944 5 abarth 2009-11-27 14:10:26 -0800 I'll leave it up to your judgement. Do we use uint32_t in other places where we deal with array indicies? 167303 6 43929 commit-queue 2009-11-30 10:59:44 -0800 Comment on attachment 43929 Patch (with ChangeLog this time) Clearing flags on attachment: 43929 Committed r51501: <http://trac.webkit.org/changeset/51501> 167304 7 commit-queue 2009-11-30 10:59:50 -0800 All reviewed patches have been landed. Closing bug. 43880 2009-11-25 17:15:09 -0800 2009-11-26 11:39:34 -0800 Adds a setCollectionStringIndexedGetter and uses that instead of setCollectionStringOrNullIndexedGetter 0001-Patch-1.patch text/plain 3750 arv RnJvbSBmMDg4OTNkM2U2OGFhYzkyMGVjOGM1ZjJkNmJjMTJjOGE1MTFhNzdhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmlrIEFydmlkc3NvbiA8YXJ2QGNocm9taXVtLm9yZz4KRGF0 ZTogV2VkLCAyNSBOb3YgMjAwOSAxNzowOToxMiAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFBhdGNo IDEKCi0tLQogV2ViQ29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rpb24uaCAgIHwgICAxOSArKysr KysrKysrKysrKysrKysrCiBXZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAgfCAg ICA0ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMo LSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oIGIvV2Vi Q29yZS9iaW5kaW5ncy92OC9WOENvbGxlY3Rpb24uaAppbmRleCBlNzJkYzA3Li4wYTQxMzRlIDEw MDY0NAotLS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oCisrKyBiL1dlYkNv cmUvYmluZGluZ3MvdjgvVjhDb2xsZWN0aW9uLmgKQEAgLTE3Nyw2ICsxNzcsMTggQEAgbmFtZXNw YWNlIFdlYkNvcmUgewogICAgIH0KIAogCisgICAgLy8gQSB0ZW1wbGF0ZSBmb3IgaW5kZXhlZCBn ZXR0ZXJzIG9uIGNvbGxlY3Rpb25zIG9mIHN0cmluZ3MuCisgICAgdGVtcGxhdGU8Y2xhc3MgQ29s bGVjdGlvbj4gc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjb2xsZWN0aW9uU3RyaW5nSW5k ZXhlZFByb3BlcnR5R2V0dGVyKHVpbnQzMl90IGluZGV4LCBjb25zdCB2ODo6QWNjZXNzb3JJbmZv JiBpbmZvKQorICAgIHsKKyAgICAgICAgLy8gRklYTUU6IGFzc2VydCB0aGF0IG9iamVjdCBtdXN0 IGJlIGEgY29sbGVjdGlvbiB0eXBlCisgICAgICAgIEFTU0VSVChWOERPTVdyYXBwZXI6Om1heWJl RE9NV3JhcHBlcihpbmZvLkhvbGRlcigpKSk7CisgICAgICAgIFY4Q2xhc3NJbmRleDo6VjhXcmFw cGVyVHlwZSB3cmFwcGVyVHlwZSA9IFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUoaW5mby5I b2xkZXIoKSk7CisgICAgICAgIENvbGxlY3Rpb24qIGNvbGxlY3Rpb24gPSBWOERPTVdyYXBwZXI6 OmNvbnZlcnRUb05hdGl2ZU9iamVjdDxDb2xsZWN0aW9uPih3cmFwcGVyVHlwZSwgaW5mby5Ib2xk ZXIoKSk7CisgICAgICAgIFN0cmluZyByZXN1bHQgPSBjb2xsZWN0aW9uLT5pdGVtKGluZGV4KTsK KyAgICAgICAgcmV0dXJuIHY4U3RyaW5nKHJlc3VsdCk7CisgICAgfQorCisKICAgICAvLyBBZGQg aW5kZXhlZCBnZXR0ZXIgdG8gdGhlIGZ1bmN0aW9uIHRlbXBsYXRlIGZvciBhIGNvbGxlY3Rpb24u CiAgICAgdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlvbiwgY2xhc3MgSXRlbVR5cGU+IHN0YXRpYyB2 b2lkIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyKHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uVGVt cGxhdGU+IGRlc2MsIFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlKQogICAgIHsKQEAg LTIwOCw2ICsyMjAsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBkZXNjLT5JbnN0 YW5jZVRlbXBsYXRlKCktPlNldEluZGV4ZWRQcm9wZXJ0eUhhbmRsZXIoY29sbGVjdGlvblN0cmlu Z09yTnVsbEluZGV4ZWRQcm9wZXJ0eUdldHRlcjxDb2xsZWN0aW9uPiwgMCwgMCwgMCwgY29sbGVj dGlvbkluZGV4ZWRQcm9wZXJ0eUVudW1lcmF0b3I8Q29sbGVjdGlvbj4pOwogICAgIH0KIAorCisg ICAgLy8gQWRkIGluZGV4ZWQgZ2V0dGVyIHJldHVybmluZyBhIHN0cmluZyB0byBhIGZ1bmN0aW9u IHRlbXBsYXRlIGZvciBhIGNvbGxlY3Rpb24uCisgICAgdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlv bj4gc3RhdGljIHZvaWQgc2V0Q29sbGVjdGlvblN0cmluZ0luZGV4ZWRHZXR0ZXIodjg6OkhhbmRs ZTx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gZGVzYykKKyAgICB7CisgICAgICAgIGRlc2MtPkluc3Rh bmNlVGVtcGxhdGUoKS0+U2V0SW5kZXhlZFByb3BlcnR5SGFuZGxlcihjb2xsZWN0aW9uU3RyaW5n SW5kZXhlZFByb3BlcnR5R2V0dGVyPENvbGxlY3Rpb24+LCAwLCAwLCAwLCBjb2xsZWN0aW9uSW5k ZXhlZFByb3BlcnR5RW51bWVyYXRvcjxDb2xsZWN0aW9uPik7CisgICAgfQorCiAgICAgdjg6Okhh bmRsZTx2ODo6VmFsdWU+IHRvT3B0aW9uc0NvbGxlY3Rpb25TZXR0ZXIodWludDMyX3QgaW5kZXgs IHY4OjpIYW5kbGU8djg6OlZhbHVlPiwgSFRNTFNlbGVjdEVsZW1lbnQqKTsKIAogfSAvLyBuYW1l c3BhY2UgV2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBw ZXIuY3BwIGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDE1Zjk2 NmUuLmM0MzRmYzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVy LmNwcAorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTI3NSw3 ICsyNzUsNyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01XcmFw cGVyOjpnZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICAvLyBzZXR0ZXIuIFRo ZXJlZm9yZSwgdGhlIGludGVyY2VwdG9yIGhhcyB0byBiZSBvbiB0aGUgb2JqZWN0CiAgICAgICAg IC8vIGl0c2VsZiBhbmQgbm90IG9uIHRoZSBwcm90b3R5cGUgb2JqZWN0LgogICAgICAgICBkZXNj cmlwdG9yLT5JbnN0YW5jZVRlbXBsYXRlKCktPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKCBVU0Vf TkFNRURfUFJPUEVSVFlfR0VUVEVSKENTU1N0eWxlRGVjbGFyYXRpb24pLCBVU0VfTkFNRURfUFJP UEVSVFlfU0VUVEVSKENTU1N0eWxlRGVjbGFyYXRpb24pKTsKLSAgICAgICAgc2V0Q29sbGVjdGlv blN0cmluZ09yTnVsbEluZGV4ZWRHZXR0ZXI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4oZGVzY3JpcHRv cik7CisgICAgICAgIHNldENvbGxlY3Rpb25TdHJpbmdJbmRleGVkR2V0dGVyPENTU1N0eWxlRGVj bGFyYXRpb24+KGRlc2NyaXB0b3IpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFY4Q2xhc3NJ bmRleDo6Q1NTUlVMRUxJU1Q6CiAgICAgICAgIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyPENT U1J1bGVMaXN0LCBDU1NSdWxlPihkZXNjcmlwdG9yLCAgVjhDbGFzc0luZGV4OjpDU1NSVUxFKTsK QEAgLTI4NCw3ICsyODQsNyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4g VjhET01XcmFwcGVyOjpnZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICBzZXRD b2xsZWN0aW9uSW5kZXhlZEdldHRlcjxDU1NWYWx1ZUxpc3QsIENTU1ZhbHVlPihkZXNjcmlwdG9y LCBWOENsYXNzSW5kZXg6OkNTU1ZBTFVFKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWOENs YXNzSW5kZXg6OkNTU1ZBUklBQkxFU0RFQ0xBUkFUSU9OOgotICAgICAgICBzZXRDb2xsZWN0aW9u U3RyaW5nT3JOdWxsSW5kZXhlZEdldHRlcjxDU1NWYXJpYWJsZXNEZWNsYXJhdGlvbj4oZGVzY3Jp cHRvcik7CisgICAgICAgIHNldENvbGxlY3Rpb25TdHJpbmdJbmRleGVkR2V0dGVyPENTU1Zhcmlh Ymxlc0RlY2xhcmF0aW9uPihkZXNjcmlwdG9yKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBW OENsYXNzSW5kZXg6OldFQktJVENTU1RSQU5TRk9STVZBTFVFOgogICAgICAgICBzZXRDb2xsZWN0 aW9uSW5kZXhlZEdldHRlcjxXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZSwgQ1NTVmFsdWU+KGRlc2Ny aXB0b3IsIFY4Q2xhc3NJbmRleDo6Q1NTVkFMVUUpOwotLSAKMS42LjQuMgoK 43929 2009-11-26 11:39:34 -0800 2009-11-30 10:59:43 -0800 Patch (with ChangeLog this time) 0001-Pathch-2.patch text/plain 4713 arv RnJvbSBjMTdmYTZmMDUwMWFhYWI0NzRhYjNkZjE2MWZkMjE5ZDg3YWRiNjFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBFcmlrIEFydmlkc3NvbiA8YXJ2QGNocm9taXVtLm9yZz4KRGF0 ZTogVGh1LCAyNiBOb3YgMjAwOSAxMTozODozOCAtMDgwMApTdWJqZWN0OiBbUEFUQ0hdIFBhdGhj aCAyCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICB8ICAgMTcgKysr KysrKysrKysrKysrKysKIFdlYkNvcmUvYmluZGluZ3MvdjgvVjhDb2xsZWN0aW9uLmggICB8ICAg MTkgKysrKysrKysrKysrKysrKysrKwogV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIu Y3BwIHwgICAgNCArKy0tCiAzIGZpbGVzIGNoYW5nZWQsIDM4IGluc2VydGlvbnMoKyksIDIgZGVs ZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5n ZUxvZwppbmRleCBjZWFhZTc0Li41YmEzNWI0IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxv ZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDA5LTExLTI2ICBF cmlrIEFydmlkc3NvbiAgPGFydkBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYW4gdXAgVjggYmluZGluZ3MgZm9yIENTU1N0 eWxlRGVjbGFyYXRpb24gYW5kIENTU1ZhcmlhYmxlRGVjbGFyYXRpb24KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODk1CisKKyAgICAgICAgTm8gbmV3 IHRlc3RzLiBUaGlzIGlzIGFscmVhZHkgY292ZXJlZCBieToKKyAgICAgICAgICAgICAgICBmYXN0 L2RvbS9DU1NTdHlsZURlY2xhcmF0aW9uL2Nzcy1jb21wdXRlZC1zdHlsZS1pdGVtLmh0bWwKKyAg ICAgICAgICAgICAgICBmYXN0L2RvbS9DU1NTdHlsZURlY2xhcmF0aW9uL2Nzcy1zdHlsZS1pdGVt Lmh0bWwKKworICAgICAgICAqIGJpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oOgorICAgICAgICAo V2ViQ29yZTo6Y29sbGVjdGlvblN0cmluZ0luZGV4ZWRQcm9wZXJ0eUdldHRlcik6CisgICAgICAg IChXZWJDb3JlOjpzZXRDb2xsZWN0aW9uU3RyaW5nSW5kZXhlZEdldHRlcik6CisgICAgICAgICog YmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlY4RE9NV3Jh cHBlcjo6Z2V0VGVtcGxhdGUpOgorCiAyMDA5LTExLTIzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5m cmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oIGIvV2ViQ29yZS9i aW5kaW5ncy92OC9WOENvbGxlY3Rpb24uaAppbmRleCBlNzJkYzA3Li4wYTQxMzRlIDEwMDY0NAot LS0gYS9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4Q29sbGVjdGlvbi5oCisrKyBiL1dlYkNvcmUvYmlu ZGluZ3MvdjgvVjhDb2xsZWN0aW9uLmgKQEAgLTE3Nyw2ICsxNzcsMTggQEAgbmFtZXNwYWNlIFdl YkNvcmUgewogICAgIH0KIAogCisgICAgLy8gQSB0ZW1wbGF0ZSBmb3IgaW5kZXhlZCBnZXR0ZXJz IG9uIGNvbGxlY3Rpb25zIG9mIHN0cmluZ3MuCisgICAgdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlv bj4gc3RhdGljIHY4OjpIYW5kbGU8djg6OlZhbHVlPiBjb2xsZWN0aW9uU3RyaW5nSW5kZXhlZFBy b3BlcnR5R2V0dGVyKHVpbnQzMl90IGluZGV4LCBjb25zdCB2ODo6QWNjZXNzb3JJbmZvJiBpbmZv KQorICAgIHsKKyAgICAgICAgLy8gRklYTUU6IGFzc2VydCB0aGF0IG9iamVjdCBtdXN0IGJlIGEg Y29sbGVjdGlvbiB0eXBlCisgICAgICAgIEFTU0VSVChWOERPTVdyYXBwZXI6Om1heWJlRE9NV3Jh cHBlcihpbmZvLkhvbGRlcigpKSk7CisgICAgICAgIFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlw ZSB3cmFwcGVyVHlwZSA9IFY4RE9NV3JhcHBlcjo6ZG9tV3JhcHBlclR5cGUoaW5mby5Ib2xkZXIo KSk7CisgICAgICAgIENvbGxlY3Rpb24qIGNvbGxlY3Rpb24gPSBWOERPTVdyYXBwZXI6OmNvbnZl cnRUb05hdGl2ZU9iamVjdDxDb2xsZWN0aW9uPih3cmFwcGVyVHlwZSwgaW5mby5Ib2xkZXIoKSk7 CisgICAgICAgIFN0cmluZyByZXN1bHQgPSBjb2xsZWN0aW9uLT5pdGVtKGluZGV4KTsKKyAgICAg ICAgcmV0dXJuIHY4U3RyaW5nKHJlc3VsdCk7CisgICAgfQorCisKICAgICAvLyBBZGQgaW5kZXhl ZCBnZXR0ZXIgdG8gdGhlIGZ1bmN0aW9uIHRlbXBsYXRlIGZvciBhIGNvbGxlY3Rpb24uCiAgICAg dGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlvbiwgY2xhc3MgSXRlbVR5cGU+IHN0YXRpYyB2b2lkIHNl dENvbGxlY3Rpb25JbmRleGVkR2V0dGVyKHY4OjpIYW5kbGU8djg6OkZ1bmN0aW9uVGVtcGxhdGU+ IGRlc2MsIFY4Q2xhc3NJbmRleDo6VjhXcmFwcGVyVHlwZSB0eXBlKQogICAgIHsKQEAgLTIwOCw2 ICsyMjAsMTMgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICBkZXNjLT5JbnN0YW5jZVRl bXBsYXRlKCktPlNldEluZGV4ZWRQcm9wZXJ0eUhhbmRsZXIoY29sbGVjdGlvblN0cmluZ09yTnVs bEluZGV4ZWRQcm9wZXJ0eUdldHRlcjxDb2xsZWN0aW9uPiwgMCwgMCwgMCwgY29sbGVjdGlvbklu ZGV4ZWRQcm9wZXJ0eUVudW1lcmF0b3I8Q29sbGVjdGlvbj4pOwogICAgIH0KIAorCisgICAgLy8g QWRkIGluZGV4ZWQgZ2V0dGVyIHJldHVybmluZyBhIHN0cmluZyB0byBhIGZ1bmN0aW9uIHRlbXBs YXRlIGZvciBhIGNvbGxlY3Rpb24uCisgICAgdGVtcGxhdGU8Y2xhc3MgQ29sbGVjdGlvbj4gc3Rh dGljIHZvaWQgc2V0Q29sbGVjdGlvblN0cmluZ0luZGV4ZWRHZXR0ZXIodjg6OkhhbmRsZTx2ODo6 RnVuY3Rpb25UZW1wbGF0ZT4gZGVzYykKKyAgICB7CisgICAgICAgIGRlc2MtPkluc3RhbmNlVGVt cGxhdGUoKS0+U2V0SW5kZXhlZFByb3BlcnR5SGFuZGxlcihjb2xsZWN0aW9uU3RyaW5nSW5kZXhl ZFByb3BlcnR5R2V0dGVyPENvbGxlY3Rpb24+LCAwLCAwLCAwLCBjb2xsZWN0aW9uSW5kZXhlZFBy b3BlcnR5RW51bWVyYXRvcjxDb2xsZWN0aW9uPik7CisgICAgfQorCiAgICAgdjg6OkhhbmRsZTx2 ODo6VmFsdWU+IHRvT3B0aW9uc0NvbGxlY3Rpb25TZXR0ZXIodWludDMyX3QgaW5kZXgsIHY4OjpI YW5kbGU8djg6OlZhbHVlPiwgSFRNTFNlbGVjdEVsZW1lbnQqKTsKIAogfSAvLyBuYW1lc3BhY2Ug V2ViQ29yZQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3Bw IGIvV2ViQ29yZS9iaW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCmluZGV4IDE1Zjk2NmUuLmM0 MzRmYzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAor KysgYi9XZWJDb3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKQEAgLTI3NSw3ICsyNzUs NyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01XcmFwcGVyOjpn ZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICAvLyBzZXR0ZXIuIFRoZXJlZm9y ZSwgdGhlIGludGVyY2VwdG9yIGhhcyB0byBiZSBvbiB0aGUgb2JqZWN0CiAgICAgICAgIC8vIGl0 c2VsZiBhbmQgbm90IG9uIHRoZSBwcm90b3R5cGUgb2JqZWN0LgogICAgICAgICBkZXNjcmlwdG9y LT5JbnN0YW5jZVRlbXBsYXRlKCktPlNldE5hbWVkUHJvcGVydHlIYW5kbGVyKCBVU0VfTkFNRURf UFJPUEVSVFlfR0VUVEVSKENTU1N0eWxlRGVjbGFyYXRpb24pLCBVU0VfTkFNRURfUFJPUEVSVFlf U0VUVEVSKENTU1N0eWxlRGVjbGFyYXRpb24pKTsKLSAgICAgICAgc2V0Q29sbGVjdGlvblN0cmlu Z09yTnVsbEluZGV4ZWRHZXR0ZXI8Q1NTU3R5bGVEZWNsYXJhdGlvbj4oZGVzY3JpcHRvcik7Cisg ICAgICAgIHNldENvbGxlY3Rpb25TdHJpbmdJbmRleGVkR2V0dGVyPENTU1N0eWxlRGVjbGFyYXRp b24+KGRlc2NyaXB0b3IpOwogICAgICAgICBicmVhazsKICAgICBjYXNlIFY4Q2xhc3NJbmRleDo6 Q1NTUlVMRUxJU1Q6CiAgICAgICAgIHNldENvbGxlY3Rpb25JbmRleGVkR2V0dGVyPENTU1J1bGVM aXN0LCBDU1NSdWxlPihkZXNjcmlwdG9yLCAgVjhDbGFzc0luZGV4OjpDU1NSVUxFKTsKQEAgLTI4 NCw3ICsyODQsNyBAQCB2ODo6UGVyc2lzdGVudDx2ODo6RnVuY3Rpb25UZW1wbGF0ZT4gVjhET01X cmFwcGVyOjpnZXRUZW1wbGF0ZShWOENsYXNzSW5kZXg6OlY4VwogICAgICAgICBzZXRDb2xsZWN0 aW9uSW5kZXhlZEdldHRlcjxDU1NWYWx1ZUxpc3QsIENTU1ZhbHVlPihkZXNjcmlwdG9yLCBWOENs YXNzSW5kZXg6OkNTU1ZBTFVFKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWOENsYXNzSW5k ZXg6OkNTU1ZBUklBQkxFU0RFQ0xBUkFUSU9OOgotICAgICAgICBzZXRDb2xsZWN0aW9uU3RyaW5n T3JOdWxsSW5kZXhlZEdldHRlcjxDU1NWYXJpYWJsZXNEZWNsYXJhdGlvbj4oZGVzY3JpcHRvcik7 CisgICAgICAgIHNldENvbGxlY3Rpb25TdHJpbmdJbmRleGVkR2V0dGVyPENTU1ZhcmlhYmxlc0Rl Y2xhcmF0aW9uPihkZXNjcmlwdG9yKTsKICAgICAgICAgYnJlYWs7CiAgICAgY2FzZSBWOENsYXNz SW5kZXg6OldFQktJVENTU1RSQU5TRk9STVZBTFVFOgogICAgICAgICBzZXRDb2xsZWN0aW9uSW5k ZXhlZEdldHRlcjxXZWJLaXRDU1NUcmFuc2Zvcm1WYWx1ZSwgQ1NTVmFsdWU+KGRlc2NyaXB0b3Is IFY4Q2xhc3NJbmRleDo6Q1NTVkFMVUUpOwotLSAKMS42LjQuMgoK