31889 2009-11-25 13:45:35 -0800 [v8] WebCore::WebGLArrayBufferInternal::byteLengthAttrGetter NULL pointer 2009-12-07 11:36:49 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED http://skypher.com/SkyLined/Repro/WebKit/Bug%2031889%20-%20WebCore..WebGLArrayBufferInternal..byteLengthAttrGetter%20NULL%20pointer/repro.html P2 Normal --- 1 skylined kbr cmarrin commit-queue dglazkov eric fishd simon.fraser webkit.review.bot oldest_to_newest 166548 0 43870 skylined 2009-11-25 13:45:35 -0800 Created attachment 43870 Repro Repro: <SCRIPT> new WebGLArrayBuffer().byteLength; </SCRIPT> 168618 1 kbr 2009-12-03 19:01:47 -0800 This is a Chromium-specific bug. There is confusion in the V8 bindings between the case where you fetch a preexisting WebGLArrayBuffer object (for example, WebGLArray.buffer) or call the WebGLArrayBuffer constructor with no arguments (new WebGLArrayBuffer()). As far as I know, there is currently no way to distinguish between these two cases, so we guess incorrectly and end up with a partially initialized JavaScript object. I'll need to consult with the V8 team to understand how to fix this issue. In the interim, I'm lowering this to P2 because it isn't the highest priority issue. 168698 2 skylined 2009-12-04 01:33:48 -0800 Then maybe we should close this bug and use the Chrome bug (http://code.google.com/p/chromium/issues/detail?id=28821) to track it, or open a new v8 bug? 169014 3 kbr 2009-12-04 19:30:43 -0800 This is definitely the right place for this bug since any fix will have to go into the WebKit repository. After looking more at the JSC bindings I see what I was doing incorrectly in the V8 bindings for this constructor. Patch to follow. 169015 4 44347 kbr 2009-12-04 19:36:04 -0800 Created attachment 44347 Patch Fixed bug in handling of zero-argument constructor call. 169016 5 webkit.review.bot 2009-12-04 19:40:39 -0800 style-queue ran check-webkit-style on attachment 44347 without any errors. 169378 6 44347 dglazkov 2009-12-07 10:44:20 -0800 Comment on attachment 44347 Patch r=me. 169402 7 44347 commit-queue 2009-12-07 11:36:43 -0800 Comment on attachment 44347 Patch Clearing flags on attachment: 44347 Committed r51785: <http://trac.webkit.org/changeset/51785> 169403 8 commit-queue 2009-12-07 11:36:49 -0800 All reviewed patches have been landed. Closing bug. 43870 2009-11-25 13:45:35 -0800 2009-11-25 13:45:35 -0800 Repro repro.html text/html 57 skylined PFNDUklQVD4NCiAgbmV3IFdlYkdMQXJyYXlCdWZmZXIoKS5ieXRlTGVuZ3RoOw0KPC9TQ1JJUFQ+ 44347 2009-12-04 19:36:04 -0800 2009-12-07 11:36:42 -0800 Patch 31889.patch text/plain 5985 kbr SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTcyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTItMDQgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFt2 OF0gV2ViQ29yZTo6V2ViR0xBcnJheUJ1ZmZlckludGVybmFsOjpieXRlTGVuZ3RoQXR0ckdldHRl ciBOVUxMIHBvaW50ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMxODg5CisKKyAgICAgICAgRml4ZWQgYnVnIGluIGhhbmRsaW5nIG9mIHplcm8tYXJn dW1lbnQgY29uc3RydWN0b3IgY2FsbC4KKworICAgICAgICBUZXN0OiBmYXN0L2NhbnZhcy93ZWJn bC9idWctMzE4ODkuaHRtbAorCisgICAgICAgICogYmluZGluZ3MvdjgvY3VzdG9tL1Y4V2ViR0xB cnJheUJ1ZmZlckN1c3RvbS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDQUxMQkFDS19GVU5DX0RF Q0wpOgorCiAyMDA5LTEyLTA0ICBBZGFtIExhbmdsZXkgIDxhZ2xAZ29vZ2xlLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KSW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvdjgv Y3VzdG9tL1Y4V2ViR0xBcnJheUJ1ZmZlckN1c3RvbS5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9iaW5kaW5ncy92OC9jdXN0b20vVjhXZWJHTEFycmF5QnVmZmVyQ3VzdG9tLmNwcAkocmV2aXNp b24gNTE3MjQpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOFdlYkdMQXJyYXlCdWZm ZXJDdXN0b20uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00OCwyOCArNDgsMzEgQEAgQ0FMTEJBQ0tf RlVOQ19ERUNMKFdlYkdMQXJyYXlCdWZmZXJDb25zdAogICAgIGlmICghYXJncy5Jc0NvbnN0cnVj dENhbGwoKSkKICAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIkRPTSBvYmplY3QgY29uc3RydWN0 b3IgY2Fubm90IGJlIGNhbGxlZCBhcyBhIGZ1bmN0aW9uLiIpOwogCi0gICAgaW50IGFyZ0xlbiA9 IGFyZ3MuTGVuZ3RoKCk7Ci0gICAgaWYgKGFyZ0xlbiA9PSAwKSB7Ci0gICAgICAgIC8vIFRoaXMg aGFwcGVucyB3aGVuIHdlIHJldHVybiBhIHByZXZpb3VzbHkgY29uc3RydWN0ZWQKLSAgICAgICAg Ly8gV2ViR0xBcnJheUJ1ZmZlciwgZS5nLiBmcm9tIHRoZSBjYWxsIHRvIFdlYkdMQXJyYXkuYnVm ZmVyLgotICAgICAgICAvLyBUaGUgVjhET01XcmFwcGVyIHdpbGwgc2V0IHRoZSBpbnRlcm5hbCBw b2ludGVyIGluIHRoZQotICAgICAgICAvLyBjcmVhdGVkIG9iamVjdC4gVW5mb3J0dW5hdGVseSBp dCBkb2Vzbid0IGxvb2sgbGlrZSBpdCdzCi0gICAgICAgIC8vIHBvc3NpYmxlIHRvIGRpc3Rpbmd1 aXNoIGJldHdlZW4gdGhpcyBjYXNlIGFuZCB0aGF0IHdoZXJlCi0gICAgICAgIC8vIHRoZSB1c2Vy IGNhbGxzICJuZXcgV2ViR0xBcnJheUJ1ZmZlcigpIiBmcm9tIEphdmFTY3JpcHQuCi0gICAgICAg IHJldHVybiBhcmdzLkhvbGRlcigpOwotICAgIH0KKyAgICAvLyBJZiB3ZSByZXR1cm4gYSBwcmV2 aW91c2x5IGNvbnN0cnVjdGVkIFdlYkdMQXJyYXlCdWZmZXIsCisgICAgLy8gZS5nLiBmcm9tIHRo ZSBjYWxsIHRvIFdlYkdMQXJyYXkuYnVmZmVyLCB0aGlzIGNvZGUgaXMgY2FsbGVkCisgICAgLy8g d2l0aCBhIHplcm8tbGVuZ3RoIGFyZ3VtZW50IGxpc3QuIFRoZSBWOERPTVdyYXBwZXIgd2lsbCB0 aGVuCisgICAgLy8gc2V0IHRoZSBpbnRlcm5hbCBwb2ludGVyIGluIHRoZSBuZXdseS1jcmVhdGVk IG9iamVjdC4KKyAgICAvLyBVbmZvcnR1bmF0ZWx5IGl0IGRvZXNuJ3QgbG9vayBsaWtlIGl0J3Mg cG9zc2libGUgdG8gZGlzdGluZ3Vpc2gKKyAgICAvLyBiZXR3ZWVuIHRoaXMgY2FzZSBhbmQgdGhh dCB3aGVyZSB0aGUgdXNlciBjYWxscyAibmV3CisgICAgLy8gV2ViR0xBcnJheUJ1ZmZlcigpIiBm cm9tIEphdmFTY3JpcHQuIFRvIGd1YXJkIGFnYWluc3QgcHJvYmxlbXMsCisgICAgLy8gd2UgYWx3 YXlzIGNyZWF0ZSBhdCBsZWFzdCBhIHplcm8tbGVuZ3RoIFdlYkdMQXJyYXlCdWZmZXIsIGV2ZW4K KyAgICAvLyBpZiBpdCBpcyBpbW1lZGlhdGVseSBvdmVyd3JpdHRlbiBieSB0aGUgVjhET01XcmFw cGVyLgogCiAgICAgLy8gU3VwcG9ydGVkIGNvbnN0cnVjdG9yczoKICAgICAvLyBXZWJHTEFycmF5 QnVmZmVyKG4pIHdoZXJlIG4gaXMgYW4gaW50ZWdlcjoKICAgICAvLyAgIC0tIGNyZWF0ZSBhbiBl bXB0eSBidWZmZXIgb2YgbiBieXRlcwogCi0gICAgaWYgKGFyZ0xlbiAhPSAxKQorICAgIGludCBh cmdMZW4gPSBhcmdzLkxlbmd0aCgpOworICAgIGlmIChhcmdMZW4gPiAxKQogICAgICAgICByZXR1 cm4gdGhyb3dFcnJvcigiV3JvbmcgbnVtYmVyIG9mIGFyZ3VtZW50cyBzcGVjaWZpZWQgdG8gY29u c3RydWN0b3IgKHJlcXVpcmVzIDEpIik7CiAKICAgICBpbnQgbGVuID0gMDsKLSAgICBpZiAoIWFy Z3NbMF0tPklzSW50MzIoKSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIkFyZ3VtZW50IHRv IFdlYkdMQXJyYXlCdWZmZXIgY29uc3RydWN0b3Igd2FzIG5vdCBhbiBpbnRlZ2VyIik7Ci0gICAg bGVuID0gdG9JbnQzMihhcmdzWzBdKTsKKyAgICBpZiAoYXJnTGVuID4gMCkgeworICAgICAgICBp ZiAoIWFyZ3NbMF0tPklzSW50MzIoKSkKKyAgICAgICAgICAgIHJldHVybiB0aHJvd0Vycm9yKCJB cmd1bWVudCB0byBXZWJHTEFycmF5QnVmZmVyIGNvbnN0cnVjdG9yIHdhcyBub3QgYW4gaW50ZWdl ciIpOworICAgICAgICBsZW4gPSB0b0ludDMyKGFyZ3NbMF0pOworICAgIH0KKwogICAgIFJlZlB0 cjxXZWJHTEFycmF5QnVmZmVyPiBidWZmZXIgPSBXZWJHTEFycmF5QnVmZmVyOjpjcmVhdGUobGVu KTsKICAgICAvLyBUcmFuc2Zvcm0gdGhlIGhvbGRlciBpbnRvIGEgd3JhcHBlciBvYmplY3QgZm9y IHRoZSBhcnJheS4KICAgICBWOERPTVdyYXBwZXI6OnNldERPTVdyYXBwZXIoYXJncy5Ib2xkZXIo KSwgVjhDbGFzc0luZGV4OjpUb0ludChWOENsYXNzSW5kZXg6OldFQkdMQVJSQVlCVUZGRVIpLCBi dWZmZXIuZ2V0KCkpOwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNTE3MjQpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNyBAQAorMjAwOS0xMi0wNCAgS2Vu bmV0aCBSdXNzZWxsICA8a2JyQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW3Y4XSBXZWJDb3JlOjpXZWJHTEFycmF5QnVmZmVySW50 ZXJuYWw6OmJ5dGVMZW5ndGhBdHRyR2V0dGVyIE5VTEwgcG9pbnRlcgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE4ODkKKworICAgICAgICBGaXhlZCBi dWcgaW4gaGFuZGxpbmcgb2YgemVyby1hcmd1bWVudCBjb25zdHJ1Y3RvciBjYWxsLgorCisgICAg ICAgIFRlc3Q6IGZhc3QvY2FudmFzL3dlYmdsL2J1Zy0zMTg4OS5odG1sCisKKyAgICAgICAgKiBm YXN0L2NhbnZhcy93ZWJnbC9idWctMzE4ODktZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2NhbnZhcy93ZWJnbC9idWctMzE4ODkuaHRtbDogQWRkZWQuCisKIDIwMDktMTItMDQg IEtlbnQgSGFuc2VuICA8a2VudC5oYW5zZW5Abm9raWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IERhcmluIEFkbGVyLgpJbmRleDogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvYnVn LTMxODg5LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2NhbnZh cy93ZWJnbC9idWctMzE4ODktZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVz dHMvZmFzdC9jYW52YXMvd2ViZ2wvYnVnLTMxODg5LWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSw5IEBACitSZWdyZXNzaW9uIHRlc3QgZm9yIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMTg4OSA6IFt2OF0gV2ViQ29yZTo6V2ViR0xBcnJheUJ1ZmZl ckludGVybmFsOjpieXRlTGVuZ3RoQXR0ckdldHRlciBOVUxMIHBvaW50ZXIKKworT24gc3VjY2Vz cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg IlRFU1QgQ09NUExFVEUiLgorCitQQVNTIG5ldyBXZWJHTEFycmF5QnVmZmVyKCkuYnl0ZUxlbmd0 aCBkaWQgbm90IGNyYXNoCitQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCisKK1RFU1Qg Q09NUExFVEUKKwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMv d2ViZ2wvYnVnLTMxODg5LWV4cGVjdGVkLnR4dApfX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjplb2wtc3R5 bGUKICAgKyBMRgoKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2J1Zy0zMTg4 OS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2J1Zy0z MTg4OS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wv YnVnLTMxODg5Lmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMjggQEAKKzxodG1sPgorPGhl YWQ+Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXN0eWxlLmNzcyIvPgorPHNjcmlwdCBzcmM9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0icmVzb3VyY2VzL3dlYmdsLXRlc3QuanMi Pjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8ZGl2IGlkPSJkZXNjcmlwdGlvbiI+PC9kaXY+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKworPHNjcmlwdD4KKworZGVzY3JpcHRpb24oJ1Jl Z3Jlc3Npb24gdGVzdCBmb3IgPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMxODg5Ij5odHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MzE4ODk8L2E+IDogPGNvZGU+W3Y4XSBXZWJDb3JlOjpXZWJHTEFycmF5QnVmZmVySW50ZXJuYWw6 OmJ5dGVMZW5ndGhBdHRyR2V0dGVyIE5VTEwgcG9pbnRlcjwvY29kZT4nKTsKKworPCEtLSBUaGUg Zm9sbG93aW5nIHVzZWQgdG8gY2F1c2UgYSBjcmFzaCBpbiBDaHJvbWUgLS0+CituZXcgV2ViR0xB cnJheUJ1ZmZlcigpLmJ5dGVMZW5ndGg7CisKK3Rlc3RQYXNzZWQoIm5ldyBXZWJHTEFycmF5QnVm ZmVyKCkuYnl0ZUxlbmd0aCBkaWQgbm90IGNyYXNoIik7CitzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOworCis8L3NjcmlwdD4KKzxzY3JpcHQgc3JjPSIuLi8uLi9qcy9yZXNvdXJjZXMvanMtdGVz dC1wb3N0LmpzIj48L3NjcmlwdD4KKworPHNjcmlwdD4KKzwvc2NyaXB0PgorCis8L2JvZHk+Cis8 L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2VzIG9uOiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJn bC9idWctMzE4ODkuaHRtbApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCk5hbWU6IHN2bjplb2wtc3R5bGUKICAgKyBMRgoK