31882 2009-11-25 10:39:16 -0800 [Chromium] Unable to repost form data by hitting reload 2009-11-25 13:10:20 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 166506 0 fishd 2009-11-25 10:39:16 -0800 [Chromium] Unable to repost form data by hitting reload When the results of a form submission are not in the cache, the user will see an error page indicating (with a scary warning) that they would need to hit reload in order to see the page. However, doing so does not work. Instead, Chrome issues a GET request to the URL. Original bug report: http://code.google.com/p/chromium/issues/detail?id=28678 Repro steps: 1- Load a page with a HTML form that does a POST 2- Submit the form 3- Go back 4- Clear your cache 5- Go forward 6- Observe the 'Confirm Form Resubmission' error page 7- Hit reload 8- Hit OK 9- Notice that the browser sends a GET instead of a POST 166529 1 43863 fishd 2009-11-25 12:43:54 -0800 Created attachment 43863 v1 patch I went about writing a test for this, but sadly it can't work in DRT or TestShell because neither loads error pages. As a result I have no way to simulate the steps from comment #0. Enabling error pages would interfere with existing tests. I could modify the layoutTestController to support an option that would enable error pages, but that seems like a much larger change that I'd rather defer to a separate patch. (I'd like to land this so I can backport it to the Chrome 4 branch.) 166531 2 43863 abarth 2009-11-25 12:50:46 -0800 Comment on attachment 43863 v1 patch This sounds reasonable. Again, my confidence here is low. Thanks for explaining why this is hard to test. + m_frame->loader()->activeDocumentLoader()->originalRequestCopy(); I'd prefer grabbing this object via m_frame->loader()->originalRequest(); but that's not essential. 166536 3 fishd 2009-11-25 12:55:41 -0800 > I'd prefer grabbing this object via m_frame->loader()->originalRequest(); but > that's not essential. Oh, good call! Thanks, I'll do that. 166538 4 fishd 2009-11-25 13:10:20 -0800 Landed as http://trac.webkit.org/changeset/51394 43863 2009-11-25 12:43:54 -0800 2009-11-25 12:50:46 -0800 v1 patch repost_1.txt text/plain 1926 fishd SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1MTM5MikKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAwOS0xMS0yNSAgRGFy aW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFtDaHJvbWl1bV0gVW5hYmxlIHRvIHJlcG9zdCBmb3Jt IGRhdGEgYnkgaGl0dGluZyByZWxvYWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTMxODgyCisKKyAgICAgICAgKiBzcmMvV2ViRnJhbWVJbXBsLmNwcDoK KyAgICAgICAgKFdlYktpdDo6V2ViRnJhbWVJbXBsOjpsb2FkRGF0YSk6CisKIDIwMDktMTEtMjUg IERpbWl0cmkgR2xhemtvdiAgPGRnbGF6a292QGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1l SW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1w bC5jcHAJKHJldmlzaW9uIDUxMzkyKQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUlt cGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC03NDMsOCArNzQzLDIwIEBAIHZvaWQgV2ViRnJhbWVJ bXBsOjpsb2FkRGF0YShjb25zdCBXZWJEYXQKICAgICBTdWJzdGl0dXRlRGF0YSBzdWJzdERhdGEo ZGF0YSwgbWltZVR5cGUsIHRleHRFbmNvZGluZywgdW5yZWFjaGFibGVVUkwpOwogICAgIEFTU0VS VChzdWJzdERhdGEuaXNWYWxpZCgpKTsKIAorICAgIC8vIElmIHdlIGFyZSBsb2FkaW5nIHN1YnN0 aXR1dGUgZGF0YSB0byByZXBsYWNlIGFuIGV4aXN0aW5nIGxvYWQsIHRoZW4KKyAgICAvLyBpbmhl cml0IGFsbCBvZiB0aGUgcHJvcGVydGllcyBvZiB0aGF0IG9yaWdpbmFsIHJlcXVlc3QuICBUaGlz IHdheSwKKyAgICAvLyByZWxvYWQgd2lsbCByZS1hdHRlbXB0IHRoZSBvcmlnaW5hbCByZXF1ZXN0 LiAgSXQgaXMgZXNzZW50aWFsIHRoYXQKKyAgICAvLyB3ZSBvbmx5IGRvIHRoaXMgd2hlbiB0aGVy ZSBpcyBhbiB1bnJlYWNoYWJsZVVSTCBzaW5jZSBhIG5vbi1lbXB0eQorICAgIC8vIHVucmVhY2hh YmxlVVJMIGluZm9ybXMgRnJhbWVMb2FkZXI6OnJlbG9hZCB0byBsb2FkIHVucmVhY2hhYmxlVVJM CisgICAgLy8gaW5zdGVhZCBvZiB0aGUgY3VycmVudGx5IGxvYWRlZCBVUkwuCisgICAgUmVzb3Vy Y2VSZXF1ZXN0IHJlcXVlc3Q7CisgICAgaWYgKHJlcGxhY2UgJiYgIXVucmVhY2hhYmxlVVJMLmlz RW1wdHkoKSkKKyAgICAgICAgcmVxdWVzdCA9IG1fZnJhbWUtPmxvYWRlcigpLT5hY3RpdmVEb2N1 bWVudExvYWRlcigpLT5vcmlnaW5hbFJlcXVlc3RDb3B5KCk7CisgICAgcmVxdWVzdC5zZXRVUkwo YmFzZVVSTCk7CisKICAgICBzdG9wTG9hZGluZygpOyAgLy8gTWFrZSBzdXJlIGV4aXN0aW5nIGFj dGl2aXR5IHN0b3BzLgotICAgIG1fZnJhbWUtPmxvYWRlcigpLT5sb2FkKFJlc291cmNlUmVxdWVz dChiYXNlVVJMKSwgc3Vic3REYXRhLCBmYWxzZSk7CisKKyAgICBtX2ZyYW1lLT5sb2FkZXIoKS0+ bG9hZChyZXF1ZXN0LCBzdWJzdERhdGEsIGZhbHNlKTsKICAgICBpZiAocmVwbGFjZSkgewogICAg ICAgICAvLyBEbyB0aGlzIHRvIGZvcmNlIFdlYktpdCB0byB0cmVhdCB0aGUgbG9hZCBhcyByZXBs YWNpbmcgdGhlIGN1cnJlbnRseQogICAgICAgICAvLyBsb2FkZWQgcGFnZS4K