31866 2009-11-25 03:26:58 -0800 Some tests are crashing from time to time 2009-11-25 05:01:39 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 gustavo webkit-unassigned oldest_to_newest 166402 0 gustavo 2009-11-25 03:26:58 -0800 I got this in valgrind while investigatin some of the crashes. Patch fixing this specific issue incoming. ==8035== Invalid read of size 8 ==8035== at 0x5B6063F: WebCore::closeCallback(_GObject*, _GAsyncResult*, void*) (ResourceHandleSoup.cpp:696) ==8035== by 0xA55DE76: async_ready_close_callback_wrapper (ginputstream.c:491) ==8035== by 0xA56CA59: complete_in_idle_cb_for_thread (gsimpleasyncresult.c:650) ==8035== by 0xAC4AF29: g_main_context_dispatch (gmain.c:1960) ==8035== by 0xAC4E787: g_main_context_iterate (gmain.c:2591) ==8035== by 0xAC4EC5C: g_main_loop_run (gmain.c:2799) ==8035== by 0x8C85CA6: gtk_main (gtkmain.c:1218) ==8035== by 0x41202E: runTest(std::string const&) (DumpRenderTree.cpp:496) ==8035== by 0x412488: main (DumpRenderTree.cpp:848) ==8035== Address 0x13d5cf00 is 0 bytes inside a block of size 1,248 free'd ==8035== at 0x4C21DBC: free (vg_replace_malloc.c:325) ==8035== by 0x415E73: WTF::fastFree(void*) (FastMalloc.cpp:294) ==8035== by 0x513DCCB: WTF::FastAllocBase::operator delete(void*) (FastAllocBase.h:104) ==8035== by 0x56BC5F4: WebCore::MainResourceLoader::~MainResourceLoader() (MainResourceLoader.cpp:59) ==8035== by 0x568E5F5: WTF::RefCounted<WebCore::ResourceLoader>::deref() (RefCounted.h:109) ==8035== by 0x568E9D8: WTF::RefPtr<WebCore::MainResourceLoader>::~RefPtr() (RefPtr.h:53) ==8035== by 0x56BB83D: WebCore::MainResourceLoader::didCancel(WebCore::ResourceError const&) (MainResourceLoader.cpp:102) ==8035== by 0x56C6216: WebCore::ResourceLoader::cancel(WebCore::ResourceError const&) (ResourceLoader.cpp:350) ==8035== by 0x56C5B39: WebCore::ResourceLoader::cancel() (ResourceLoader.cpp:340) ==8035== by 0x568C36E: WebCore::DocumentLoader::stopLoading(WebCore::DatabasePolicy) (DocumentLoader.cpp:294) ==8035== by 0x56A21D6: WebCore::FrameLoader::stopAllLoaders(WebCore::DatabasePolicy) (FrameLoader.cpp:2260) ==8035== by 0x56AB8CF: WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WTF::PassRefPtr<WebCore::FormState>, bool) (FrameLoader.cpp:3449) ==8035== 166403 1 43835 gustavo 2009-11-25 03:28:49 -0800 Created attachment 43835 proposed fix 166404 2 43835 xan.lopez 2009-11-25 03:41:03 -0800 Comment on attachment 43835 proposed fix LGTM. 166407 3 gustavo 2009-11-25 05:01:39 -0800 Landed as r51380. 43835 2009-11-25 03:28:49 -0800 2009-11-25 03:41:03 -0800 proposed fix 0001-Handle-cancelled-loads-correctly-in-closeCallback.patch text/plain 1837 gustavo RnJvbSA2ZDNiZDE3OTdmMTM4OWVkNDdmMWExODM5Mjg0MDg2NzFmNzYyYmIwIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHdXN0YXZvIE5vcm9uaGEgU2lsdmEgPGd1c3Rhdm8ubm9yb25o YUBjb2xsYWJvcmEuY28udWs+CkRhdGU6IFdlZCwgMjUgTm92IDIwMDkgMDk6Mjg6MDggLTAyMDAK U3ViamVjdDogW1BBVENIXSBIYW5kbGUgY2FuY2VsbGVkIGxvYWRzIGNvcnJlY3RseSBpbiBjbG9z ZUNhbGxiYWNrCgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbmV0d29yay9zb3Vw L1Jlc291cmNlSGFuZGxlU291cC5jcHAgICB8ICAgIDcgKysrKysrKwogMiBmaWxlcyBjaGFuZ2Vk LCAyMCBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDQxZDRlMC4uOTMzZGVhMSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAwOS0xMS0yNSAgR3VzdGF2byBOb3JvbmhhIFNpbHZhICA8Z3VzdGF2by5u b3JvbmhhQGNvbGxhYm9yYS5jby51az4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBTb21lIHRlc3RzIGFyZSBjcmFzaGluZyBmcm9tIHRpbWUgdG8gdGlt ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE4NjYK KworICAgICAgICBNYWtlIHN1cmUgd2UgZG8gbm90IG5vdGlmeSB0aGUgY2xpZW50IG9mIGEgZmlu aXNoZWQgbG9hZCwgaWYgdGhlCisgICAgICAgIGxvYWQgaGFzIGJlZW4gY2FuY2VsbGVkLCBvciB0 aGUgY2xpZW50IGlzIGdvbmUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVz b3VyY2VIYW5kbGVTb3VwLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Oik6CisKIDIwMDktMTEtMjMg IEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAv UmVzb3VyY2VIYW5kbGVTb3VwLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1Jl c291cmNlSGFuZGxlU291cC5jcHAKaW5kZXggMmU0OTdhYi4uNjM2N2EzZSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvc291cC9SZXNvdXJjZUhhbmRsZVNvdXAuY3BwCkBA IC02OTMsNiArNjkzLDEzIEBAIHN0YXRpYyB2b2lkIGNsb3NlQ2FsbGJhY2soR09iamVjdCogc291 cmNlLCBHQXN5bmNSZXN1bHQqIHJlcywgZ3BvaW50ZXIpCiAKICAgICBnX2lucHV0X3N0cmVhbV9j bG9zZV9maW5pc2goZC0+bV9pbnB1dFN0cmVhbSwgcmVzLCAwKTsKICAgICBjbGVhbnVwR2lvT3Bl cmF0aW9uKGhhbmRsZS5nZXQoKSk7CisKKyAgICAvLyBUaGUgbG9hZCBtYXkgaGF2ZSBiZWVuIGNh bmNlbGxlZCwgdGhlIGNsaWVudCBtYXkgaGF2ZSBiZWVuCisgICAgLy8gZGVzdHJveWVkIGFscmVh ZHkuIEluIHN1Y2ggY2FzZXMgY2FsbGluZyBkaWRGaW5pc2hMb2FkaW5nIGlzIGEKKyAgICAvLyBi YWQgaWRlYS4KKyAgICBpZiAoZC0+bV9jYW5jZWxsZWQgfHwgIWNsaWVudCkKKyAgICAgICAgcmV0 dXJuOworCiAgICAgY2xpZW50LT5kaWRGaW5pc2hMb2FkaW5nKGhhbmRsZS5nZXQoKSk7CiB9CiAK LS0gCjEuNi41LjMKCg==