31864 2009-11-25 01:51:22 -0800 [GTK] use gst_init_check() instead of gst_init() 2009-11-25 07:59:19 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 pnormand webkit-unassigned commit-queue oldest_to_newest 166389 0 pnormand 2009-11-25 01:51:22 -0800 During initialization of the GStreamer player we call gst_init() but this function can call exit(1) if something went wrong. I don't think we want that :) So we should use gst_init_check() which returns a boolean stating success or not of the GStreamer framework initialization. 166397 1 43833 pnormand 2009-11-25 02:11:37 -0800 Created attachment 43833 Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application To prevent eventual unexpected exit of the application. 166443 2 43833 eric 2009-11-25 07:47:28 -0800 Comment on attachment 43833 Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application Looks right to me. cq+ too since Philippe is not in committers.py. 166450 3 43833 commit-queue 2009-11-25 07:59:14 -0800 Comment on attachment 43833 Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application Clearing flags on attachment: 43833 Committed r51382: <http://trac.webkit.org/changeset/51382> 166451 4 commit-queue 2009-11-25 07:59:19 -0800 All reviewed patches have been landed. Closing bug. 43833 2009-11-25 02:11:37 -0800 2009-11-25 07:59:13 -0800 Use gst_init_check() instead of gst_init() to prevent eventual unexpected exit of the application Use-gstinitcheck-instead-of-gstinit-to-prevent-eve.patch text/plain 2691 pnormand RnJvbSAwOWQ2OTExZDZhYjlhMjY2NzQyNDRhNDM4MmFlNGVmMjFmM2FiZmNiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBXZWQsIDI1IE5vdiAyMDA5IDExOjEwOjQyICswMTAwClN1YmplY3Q6IFtQQVRDSF0g VXNlIGdzdF9pbml0X2NoZWNrKCkgaW5zdGVhZCBvZiBnc3RfaW5pdCgpIHRvIHByZXZlbnQgZXZl bnR1YWwgdW5leHBlY3RlZCBleGl0IG9mIHRoZSBhcHBsaWNhdGlvbgoKLS0tCiBXZWJDb3JlL0No YW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTQgKysrKysrKysr KysrKysKIC4uLi9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcCAg IHwgICAxOSArKysrKysrKysrKysrLS0tLS0tCiAyIGZpbGVzIGNoYW5nZWQsIDI3IGluc2VydGlv bnMoKyksIDYgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCA3MDUyOWIyLi5iNTI1MmFiIDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisy MDA5LTExLTI1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSB1c2UgZ3N0 X2luaXRfY2hlY2soKSBpbnN0ZWFkIG9mIGdzdF9pbml0KCkKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODY0CisKKyAgICAgICAgVXNlIGdzdF9pbml0 X2NoZWNrKCkgaW5zdGVhZCBvZiBnc3RfaW5pdCgpIHRvIHByZXZlbnQgZXZlbnR1YWwKKyAgICAg ICAgdW5leHBlY3RlZCBleGl0IG9mIHRoZSBhcHBsaWNhdGlvbi4KKworICAgICAgICAqIHBsYXRm b3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6ZG9fZ3N0X2luaXQpOgorICAgICAgICAoV2ViQ29yZTo6TWVkaWFQbGF5ZXJQ cml2YXRlOjppc0F2YWlsYWJsZSk6CisKIDIwMDktMTEtMjQgIFpvbHRhbiBIb3J2YXRoICA8em9s dGFuQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVH U3RyZWFtZXIuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ndGsvTWVkaWFQbGF5ZXJQ cml2YXRlR1N0cmVhbWVyLmNwcAppbmRleCBiMzI1ZDhjLi5jMDI0MmExIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2d0ay9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIu Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3RrL01lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lci5jcHAKQEAgLTE0NiwyMSArMTQ2LDI4IEBAIHZvaWQgTWVkaWFQbGF5ZXJQcml2 YXRlOjpyZWdpc3Rlck1lZGlhRW5naW5lKE1lZGlhRW5naW5lUmVnaXN0cmFyIHJlZ2lzdHJhcikK IAogc3RhdGljIGJvb2wgZ3N0SW5pdGlhbGl6ZWQgPSBmYWxzZTsKIAotc3RhdGljIHZvaWQgZG9f Z3N0X2luaXQoKQorc3RhdGljIGJvb2wgZG9fZ3N0X2luaXQoKQogewogICAgIC8vIEZJWE1FOiBX ZSBzaG91bGQgcGFzcyB0aGUgYXJndW1lbnRzIGZyb20gdGhlIGNvbW1hbmQgbGluZQogICAgIGlm ICghZ3N0SW5pdGlhbGl6ZWQpIHsKLSAgICAgICAgZ3N0X2luaXQoMCwgMCk7Ci0gICAgICAgIGdz dEluaXRpYWxpemVkID0gdHJ1ZTsKLSAgICAgICAgZ3N0X2VsZW1lbnRfcmVnaXN0ZXIoMCwgIndl YmtpdG1lZGlhc3JjIiwgR1NUX1JBTktfUFJJTUFSWSwKLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgV0VCS0lUX1RZUEVfREFUQV9TUkMpOworICAgICAgICBHT3duUHRyPEdFcnJvcj4gZXJy b3I7CisgICAgICAgIGdzdEluaXRpYWxpemVkID0gZ3N0X2luaXRfY2hlY2soMCwgMCwgJmVycm9y Lm91dFB0cigpKTsKKyAgICAgICAgaWYgKCFnc3RJbml0aWFsaXplZCkKKyAgICAgICAgICAgIExP R19WRVJCT1NFKE1lZGlhLCAiQ291bGQgbm90IGluaXRpYWxpemUgR1N0cmVhbWVyOiAlcyIsCisg ICAgICAgICAgICAgICAgICAgICAgICBlcnJvciA/IGVycm9yLT5tZXNzYWdlIDogInVua25vd24g ZXJyb3Igb2NjdXJyZWQiKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgZ3N0X2VsZW1lbnRf cmVnaXN0ZXIoMCwgIndlYmtpdG1lZGlhc3JjIiwgR1NUX1JBTktfUFJJTUFSWSwKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgIFdFQktJVF9UWVBFX0RBVEFfU1JDKTsKIAogICAgIH0K KyAgICByZXR1cm4gZ3N0SW5pdGlhbGl6ZWQ7CiB9CiAKIGJvb2wgTWVkaWFQbGF5ZXJQcml2YXRl Ojppc0F2YWlsYWJsZSgpCiB7Ci0gICAgZG9fZ3N0X2luaXQoKTsKKyAgICBpZiAoIWRvX2dzdF9p bml0KCkpCisgICAgICAgIHJldHVybiBmYWxzZTsKKwogICAgIEdzdEVsZW1lbnRGYWN0b3J5KiBm YWN0b3J5ID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9maW5kKCJwbGF5YmluMiIpOwogICAgIGlmIChm YWN0b3J5KSB7CiAgICAgICAgIGdzdF9vYmplY3RfdW5yZWYoR1NUX09CSkVDVChmYWN0b3J5KSk7 Ci0tIAoxLjYuMy4z