31853 2009-11-24 16:49:56 -0800 bugzilla-tool should have a mark-fixed command 2009-12-02 10:00:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth ddkilzer mjs oldest_to_newest 166311 0 eric 2009-11-24 16:49:56 -0800 bugzilla-tool should have a mark-fixed command I'm not sure it entirely fits with the current model, but there is the occasional time when you need to commit by hand and it's nice to have bugzilla-tool be able to mark the bug you just commited as fixed/closed. This could be an "uncommon" command not shown in the standard --help. 166327 1 abarth 2009-11-24 18:37:24 -0800 This is like a five line patch with LandingSequence. Basically, you just want to run the last step of the landing sequence. 166336 2 abarth 2009-11-24 19:04:12 -0800 All reviewed patches have been landed. Closing bug. 166337 3 abarth 2009-11-24 19:04:33 -0800 Guess it works. :) 166338 4 43825 abarth 2009-11-24 19:05:23 -0800 Created attachment 43825 Patch 166341 5 43825 eric 2009-11-24 20:27:51 -0800 Comment on attachment 43825 Patch "All reviewed patches have been landed" seems wrong for this. Maybe we should prompt for a reason? 166357 6 abarth 2009-11-24 22:39:50 -0800 Maybe it shouldn't leave a comment at all? Maybe it should prompt for a revision number? 166421 7 eric 2009-11-25 07:09:07 -0800 We could just make "REASON" a required argument. We could have it confirm that it had found the right bug/revision combo by showing you the bug title. It could/should also update the bug with the correct revision number and trac link. I think a version of this which simply required a REASON argument would be a fine first-step though. :) 166593 8 43825 abarth 2009-11-25 18:07:52 -0800 Comment on attachment 43825 Patch I think Eric wanted to R- this patch. 166595 9 abarth 2009-11-25 18:11:55 -0800 This is not really fixed. 166596 10 43885 abarth 2009-11-25 18:12:26 -0800 Created attachment 43885 Patch 166597 11 abarth 2009-11-25 18:13:01 -0800 openzored 166598 12 43886 abarth 2009-11-25 18:19:17 -0800 Created attachment 43886 Patch 166603 13 abarth 2009-11-25 18:25:39 -0800 Committed r51404: <http://trac.webkit.org/changeset/51404> 167994 14 ddkilzer 2009-12-02 07:59:36 -0800 See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed. 168039 15 abarth 2009-12-02 09:57:24 -0800 (In reply to comment #14) > See also Bug 28910 and WebKitTools/Scripts/mark-bug-fixed. Holy duplicated code, Batman! 168042 16 abarth 2009-12-02 10:00:21 -0800 Follow up in https://bugs.webkit.org/show_bug.cgi?id=32073 43825 2009-11-24 19:05:23 -0800 2009-11-25 18:12:22 -0800 Patch bug-31853-20091124190522.patch text/plain 1491 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBiNmMxN2NlLi4xOTAwOTE1IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MjQgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHNob3VsZCBoYXZlIGEg bWFyay1maXhlZCBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTg1MworCisgICAgICAgIFByZXR0eSBzaW1wbGUgc3R1ZmYuCisKKyAgICAg ICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5OgorCiAyMDA5LTExLTI0ICBF cmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFt IEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRz L3VwbG9hZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy91cGxvYWQu cHkKaW5kZXggN2VjNDIzOC4uMDgyNzgwMSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0 cy9tb2R1bGVzL2NvbW1hbmRzL3VwbG9hZC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5CkBAIC0xNjksNiArMTY5LDE5IEBAIGNsYXNzIFBvc3RD b21taXRzKENvbW1hbmQpOgogICAgICAgICAgICAgdG9vbC5idWdzLmFkZF9wYXRjaF90b19idWco YnVnX2lkLCBkaWZmX2ZpbGUsIGRlc2NyaXB0aW9uLCBjb21tZW50X3RleHQsIG1hcmtfZm9yX3Jl dmlldz1vcHRpb25zLnJldmlldywgbWFya19mb3JfY29tbWl0X3F1ZXVlPW9wdGlvbnMucmVxdWVz dF9jb21taXQpCiAKIAorY2xhc3MgTWFya0ZpeGVkKENvbW1hbmQpOgorICAgIG5hbWUgPSAibWFy ay1maXhlZCIKKyAgICBkZWYgX19pbml0X18oc2VsZik6CisgICAgICAgIENvbW1hbmQuX19pbml0 X18oc2VsZiwgIk1hcmsgdGhlIHNwZWNpZmllZCBidWdzIGFzIGZpeGVkIiwgIkJVR19JRCBbQlVH X0lEU10iKQorCisgICAgZGVmIGV4ZWN1dGUoc2VsZiwgb3B0aW9ucywgYXJncywgdG9vbCk6Cisg ICAgICAgIGlmIG5vdCBhcmdzOgorICAgICAgICAgICAgZXJyb3IoIiVzIHJlcXVpcmVkIiAlIHNl bGYuYXJndW1lbnRfbmFtZXMpCisKKyAgICAgICAgZm9yIGJ1Z19pZCBpbiBhcmdzOgorICAgICAg ICAgICAgdG9vbC5idWdzLmNsb3NlX2J1Z19hc19maXhlZChidWdfaWQsICJBbGwgcmV2aWV3ZWQg cGF0Y2hlcyBoYXZlIGJlZW4gbGFuZGVkLiAgQ2xvc2luZyBidWcuIikKKworCiBjbGFzcyBDcmVh dGVCdWcoQ29tbWFuZCk6CiAgICAgbmFtZSA9ICJjcmVhdGUtYnVnIgogICAgIGRlZiBfX2luaXRf XyhzZWxmKToK 43885 2009-11-25 18:12:26 -0800 2009-11-25 18:19:13 -0800 Patch bug-31853-20091125181225.patch text/plain 1425 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhYjA1NTc0Li45ZGEwZGI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHNob3VsZCBoYXZlIGEg bWFyay1maXhlZCBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTg1MworCisgICAgICAgIFByZXR0eSBzaW1wbGUgc3R1ZmYuCisKKyAgICAg ICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5OgorCiAyMDA5LTExLTI1ICBC cmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NvbW1hbmRzL3VwbG9hZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21t YW5kcy91cGxvYWQucHkKaW5kZXggMTU2MWE1NS4uMzE1ZGFmMiAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3VwbG9hZC5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5CkBAIC0xNjYsNiArMTY2LDE4IEBA IGNsYXNzIFBvc3RDb21taXRzKENvbW1hbmQpOgogICAgICAgICAgICAgdG9vbC5idWdzLmFkZF9w YXRjaF90b19idWcoYnVnX2lkLCBkaWZmX2ZpbGUsIGRlc2NyaXB0aW9uLCBjb21tZW50X3RleHQs IG1hcmtfZm9yX3Jldmlldz1vcHRpb25zLnJldmlldywgbWFya19mb3JfY29tbWl0X3F1ZXVlPW9w dGlvbnMucmVxdWVzdF9jb21taXQpCiAKIAorY2xhc3MgTWFya0ZpeGVkKENvbW1hbmQpOgorICAg IG5hbWUgPSAibWFyay1maXhlZCIKKyAgICBkZWYgX19pbml0X18oc2VsZik6CisgICAgICAgIENv bW1hbmQuX19pbml0X18oc2VsZiwgIk1hcmsgdGhlIHNwZWNpZmllZCBidWcgYXMgZml4ZWQiLCAi QlVHX0lEIFJFQVNPTiIpCisKKyAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0 b29sKToKKyAgICAgICAgaWYgbGVuKGFyZ3MpIDwgMjoKKyAgICAgICAgICAgIGVycm9yKCIlcyBy ZXF1aXJlZCIgJSBzZWxmLmFyZ3VtZW50X25hbWVzKQorCisgICAgICAgIHRvb2wuYnVncy5jbG9z ZV9idWdfYXNfZml4ZWQoYXJnc1swXSwgYXJnc1sxXSkKKworCiBjbGFzcyBDcmVhdGVCdWcoQ29t bWFuZCk6CiAgICAgbmFtZSA9ICJjcmVhdGUtYnVnIgogICAgIGRlZiBfX2luaXRfXyhzZWxmKToK 43886 2009-11-25 18:19:17 -0800 2009-11-25 18:22:59 -0800 Patch bug-31853-20091125181916.patch text/plain 1340 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhYjA1NTc0Li45ZGEwZGI2IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMDktMTEt MjUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBidWd6aWxsYS10b29sIHNob3VsZCBoYXZlIGEg bWFyay1maXhlZCBjb21tYW5kCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0zMTg1MworCisgICAgICAgIFByZXR0eSBzaW1wbGUgc3R1ZmYuCisKKyAgICAg ICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5OgorCiAyMDA5LTExLTI1ICBC cmlhbiBXZWluc3RlaW4gIDxid2VpbnN0ZWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdl ZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1 bGVzL2NvbW1hbmRzL3VwbG9hZC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21t YW5kcy91cGxvYWQucHkKaW5kZXggMTU2MWE1NS4uMmI0MDlkNSAxMDA2NDQKLS0tIGEvV2ViS2l0 VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3VwbG9hZC5weQorKysgYi9XZWJLaXRUb29s cy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvdXBsb2FkLnB5CkBAIC0xNjYsNiArMTY2LDE1IEBA IGNsYXNzIFBvc3RDb21taXRzKENvbW1hbmQpOgogICAgICAgICAgICAgdG9vbC5idWdzLmFkZF9w YXRjaF90b19idWcoYnVnX2lkLCBkaWZmX2ZpbGUsIGRlc2NyaXB0aW9uLCBjb21tZW50X3RleHQs IG1hcmtfZm9yX3Jldmlldz1vcHRpb25zLnJldmlldywgbWFya19mb3JfY29tbWl0X3F1ZXVlPW9w dGlvbnMucmVxdWVzdF9jb21taXQpCiAKIAorY2xhc3MgTWFya0ZpeGVkKENvbW1hbmQpOgorICAg IG5hbWUgPSAibWFyay1maXhlZCIKKyAgICBkZWYgX19pbml0X18oc2VsZik6CisgICAgICAgIENv bW1hbmQuX19pbml0X18oc2VsZiwgIk1hcmsgdGhlIHNwZWNpZmllZCBidWcgYXMgZml4ZWQiLCAi QlVHX0lEIFJFQVNPTiIpCisKKyAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0 b29sKToKKyAgICAgICAgdG9vbC5idWdzLmNsb3NlX2J1Z19hc19maXhlZChhcmdzWzBdLCBhcmdz WzFdKQorCisKIGNsYXNzIENyZWF0ZUJ1ZyhDb21tYW5kKToKICAgICBuYW1lID0gImNyZWF0ZS1i dWciCiAgICAgZGVmIF9faW5pdF9fKHNlbGYpOgo=