31851 2009-11-24 14:50:40 -0800 [Qt] QWebInspector unusable on certain window managers 2009-12-15 03:16:06 -0800 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke webkit-unassigned abarth hausmann jturcotte oldest_to_newest 166283 0 43811 zecke 2009-11-24 14:50:40 -0800 Created attachment 43811 Call setVisible from within the closeEvent QWebInspector::hideEvent will call setVisible on the InspectorController disabling/resetting certain views. E.g. on ion3 the hide event is called when switching windows... so when going back to the QWebView every information is gone.. The code could be changed to call it from within the closeEvent. This should work for many usecases and in the worse case data of the InspectorController is held in memory a bit longer. For binary compability reasons I'm leaving an empty ::hideEvent in the code... 167356 1 abarth 2009-11-30 12:38:21 -0800 style-queue successfully ran check-webkit-style on attachment 43811 without any errors 168953 2 43811 hausmann 2009-12-04 15:21:36 -0800 Comment on attachment 43811 Call setVisible from within the closeEvent I think the patch is correct. Holger, do you think it's worth including in Qt 4.6.1? (in which case we need to cherry-pick a version that uses ::event() instead) Jocelyn, any thoughts? :) 169022 3 zecke 2009-12-04 21:56:49 -0800 (In reply to comment #2) > (From update of attachment 43811 [details]) > I think the patch is correct. > > Holger, do you think it's worth including in Qt 4.6.1? (in which case we need > to cherry-pick a version that uses ::event() instead) Yes, without this the web inspector is completely useless on ion3... > > Jocelyn, any thoughts? :) 169089 4 jturcotte 2009-12-06 05:06:57 -0800 yep, I agree! 171765 5 zecke 2009-12-15 01:31:30 -0800 Landed in r52144. 171780 6 44856 zecke 2009-12-15 02:43:34 -0800 Created attachment 44856 Backport for 4.6 backport for the 4.6 branch 171786 7 hausmann 2009-12-15 03:03:27 -0800 (In reply to comment #6) > Created an attachment (id=44856) [details] > Backport for 4.6 > > backport for the 4.6 branch Thanks! Pushed into qtwebkit-4.6 as f1c562daf7b4d784cb9f386e47fc132e0843321f 43811 2009-11-24 14:50:40 -0800 2009-12-15 00:31:48 -0800 Call setVisible from within the closeEvent 0004-Qt-Do-not-disable-the-inspector-on-show-and-hide.patch text/plain 2682 zecke RnJvbSAwNzlhZThiM2QwY2ViNTkxN2IzOTBmNzA2NDYwMjEyZGJhMDQwOGRmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjQgTm92IDIwMDkgMTk6MTQ6MzYgKzAxMDAKU3ViamVjdDog W1BBVENIIDQvNl0gW1F0XSBEbyBub3QgZGlzYWJsZSB0aGUgaW5zcGVjdG9yIG9uIHNob3cgYW5k IGhpZGUKCk9uIFF0L1gxMSB3aXRoIHNvbWUgd2luZG93IG1hbmFnZXJzIHRoZSB3aW5kb3cgd2ls bCBiZQpoaWRkZW4gd2hlbiBzd2l0Y2hpbmcgd2luZG93cy4gSW4gdGhpcyBjYXNlIGFsbCB0aGUg cmVzdWx0cwphcmUgZ29uZSB3aGVuIGNvbWluZyBiYWNrIHRvIHRoZSB3aW5kb3cuCgpBdHRlbXB0 IHRvIHVzZSB0aGUgQ2xvc2VFdmVudCB0byBmaWd1cmUgb3V0IGlmIHRoZSB3aW5kb3cKd2FzIGNs b3NlZCBhbmQgd2l0aGRyYXduIGFzIHRoaXMgaXMgbW9yZSBmcmllbmRseSB0byB0aGUKdXNlciBv ZiB0aGUgaW5zcGVjdG9yIGNsaWVudC4KCiogQXBpL3F3ZWJpbnNwZWN0b3IuY3BwOgooUVdlYklu c3BlY3Rvcjo6aGlkZUV2ZW50KToKKFFXZWJJbnNwZWN0b3I6OmNsb3NlRXZlbnQpOgoqIEFwaS9x d2ViaW5zcGVjdG9yLmg6Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmNwcCB8ICAg IDUgKysrKysKIFdlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5oICAgfCAgICAxICsKIFdlYktp dC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAgfCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIDMg ZmlsZXMgY2hhbmdlZCwgMjUgaW5zZXJ0aW9ucygrKSwgMCBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJpbnNwZWN0b3IuY3BwIGIvV2ViS2l0L3F0L0FwaS9xd2Vi aW5zcGVjdG9yLmNwcAppbmRleCBmNDNjYmJmLi5iMmQ3YjI4IDEwMDY0NAotLS0gYS9XZWJLaXQv cXQvQXBpL3F3ZWJpbnNwZWN0b3IuY3BwCisrKyBiL1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rv ci5jcHAKQEAgLTE1OSw2ICsxNTksMTEgQEAgdm9pZCBRV2ViSW5zcGVjdG9yOjpzaG93RXZlbnQo UVNob3dFdmVudCogZXZlbnQpCiAvKiEgXHJlaW1wICovCiB2b2lkIFFXZWJJbnNwZWN0b3I6Omhp ZGVFdmVudChRSGlkZUV2ZW50KiBldmVudCkKIHsKK30KKworLyohIFxyZWltcCAqLwordm9pZCBR V2ViSW5zcGVjdG9yOjpjbG9zZUV2ZW50KFFDbG9zZUV2ZW50KiBldmVudCkKK3sKICAgICBpZiAo ZC0+cGFnZSkKICAgICAgICAgZC0+cGFnZS0+ZC0+aW5zcGVjdG9yQ29udHJvbGxlcigpLT5zZXRX aW5kb3dWaXNpYmxlKGZhbHNlKTsKIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYmlu c3BlY3Rvci5oIGIvV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmgKaW5kZXggYTVjMWVkNS4u NmNkYTQ3OSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmgKKysrIGIv V2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmgKQEAgLTQzLDYgKzQzLDcgQEAgcHJvdGVjdGVk OgogICAgIHZvaWQgcmVzaXplRXZlbnQoUVJlc2l6ZUV2ZW50KiBldmVudCk7CiAgICAgdm9pZCBz aG93RXZlbnQoUVNob3dFdmVudCogZXZlbnQpOwogICAgIHZvaWQgaGlkZUV2ZW50KFFIaWRlRXZl bnQqIGV2ZW50KTsKKyAgICB2b2lkIGNsb3NlRXZlbnQoUUNsb3NlRXZlbnQqIGV2ZW50KTsKIAog cHJpdmF0ZToKICAgICBRV2ViSW5zcGVjdG9yUHJpdmF0ZSogZDsKZGlmZiAtLWdpdCBhL1dlYktp dC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDgxNDJjMWYuLmJkZjFk MGMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0NoYW5n ZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDA5LTExLTI0ICBIb2xnZXIgSGFucyBQZXRlciBGcmV5 dGhlciAgPHplY2tlQHNlbGZpc2gub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtRdF0gRG8gbm90IGRpc2FibGUgdGhlIGluc3BlY3RvciBvbiBz aG93IGFuZCBoaWRlCisKKyAgICAgICAgT24gUXQvWDExIHdpdGggc29tZSB3aW5kb3cgbWFuYWdl cnMgdGhlIHdpbmRvdyB3aWxsIGJlCisgICAgICAgIGhpZGRlbiB3aGVuIHN3aXRjaGluZyB3aW5k b3dzLiBJbiB0aGlzIGNhc2UgYWxsIHRoZSByZXN1bHRzCisgICAgICAgIGFyZSBnb25lIHdoZW4g Y29taW5nIGJhY2sgdG8gdGhlIHdpbmRvdy4KKworICAgICAgICBBdHRlbXB0IHRvIHVzZSB0aGUg Q2xvc2VFdmVudCB0byBmaWd1cmUgb3V0IGlmIHRoZSB3aW5kb3cKKyAgICAgICAgd2FzIGNsb3Nl ZCBhbmQgd2l0aGRyYXduIGFzIHRoaXMgaXMgbW9yZSBmcmllbmRseSB0byB0aGUKKyAgICAgICAg dXNlciBvZiB0aGUgaW5zcGVjdG9yIGNsaWVudC4KKworICAgICAgICAqIEFwaS9xd2ViaW5zcGVj dG9yLmNwcDoKKyAgICAgICAgKFFXZWJJbnNwZWN0b3I6OmhpZGVFdmVudCk6CisgICAgICAgIChR V2ViSW5zcGVjdG9yOjpjbG9zZUV2ZW50KToKKyAgICAgICAgKiBBcGkvcXdlYmluc3BlY3Rvci5o OgorCiAyMDA5LTExLTEyICBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciAgPHplY2tlQHNlbGZp c2gub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgotLSAKMS42LjMu MwoK 44856 2009-12-15 02:43:34 -0800 2009-12-15 02:43:34 -0800 Backport for 4.6 0001-Qt-Do-not-disable-the-inspector-on-show-and-hide.patch text/plain 2457 zecke RnJvbSA3ZGYzMWJlN2IzZjI3MjMwMmJiNDY2YmIzZDY2NmNiMGQ3Mjk5ZmZhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMTUgRGVjIDIwMDkgMTE6NDA6MzEgKzAxMDAKU3ViamVjdDog W1BBVENIXSBbUXRdIERvIG5vdCBkaXNhYmxlIHRoZSBpbnNwZWN0b3Igb24gc2hvdyBhbmQgaGlk ZQoKaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODUxCgpPbiBRdC9Y MTEgd2l0aCBzb21lIHdpbmRvdyBtYW5hZ2VycyB0aGUgd2luZG93IHdpbGwgYmUKaGlkZGVuIHdo ZW4gc3dpdGNoaW5nIHdpbmRvd3MuIEluIHRoaXMgY2FzZSBhbGwgdGhlIHJlc3VsdHMKYXJlIGdv bmUgd2hlbiBjb21pbmcgYmFjayB0byB0aGUgd2luZG93LgoKQXR0ZW1wdCB0byB1c2UgdGhlIENs b3NlRXZlbnQgdG8gZmlndXJlIG91dCBpZiB0aGUgd2luZG93CndhcyBjbG9zZWQgYW5kIHdpdGhk cmF3biBhcyB0aGlzIGlzIG1vcmUgZnJpZW5kbHkgdG8gdGhlCnVzZXIgb2YgdGhlIGluc3BlY3Rv ciBjbGllbnQuCgoqIEFwaS9xd2ViaW5zcGVjdG9yLmNwcDoKKFFXZWJJbnNwZWN0b3I6OmV2ZW50 KToKKFFXZWJJbnNwZWN0b3I6OmhpZGVFdmVudCk6Ci0tLQogV2ViS2l0L3F0L0FwaS9xd2ViaW5z cGVjdG9yLmNwcCB8ICAgIDUgKysrLS0KIFdlYktpdC9xdC9DaGFuZ2VMb2cgICAgICAgICAgICAg fCAgIDE5ICsrKysrKysrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9u cygrKSwgMiBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQXBpL3F3ZWJpbnNw ZWN0b3IuY3BwIGIvV2ViS2l0L3F0L0FwaS9xd2ViaW5zcGVjdG9yLmNwcAppbmRleCA0NTc4ZGM5 Li5iZDE3ODJmIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBpL3F3ZWJpbnNwZWN0b3IuY3BwCisr KyBiL1dlYktpdC9xdC9BcGkvcXdlYmluc3BlY3Rvci5jcHAKQEAgLTE0Myw2ICsxNDMsOSBAQCBR U2l6ZSBRV2ViSW5zcGVjdG9yOjpzaXplSGludCgpIGNvbnN0CiAvKiEgXHJlaW1wICovCiBib29s IFFXZWJJbnNwZWN0b3I6OmV2ZW50KFFFdmVudCogZXYpCiB7CisgICAgaWYgKGV2LT50eXBlKCkg PT0gUUV2ZW50OjpDbG9zZSAmJiBkLT5wYWdlKQorICAgICAgICBkLT5wYWdlLT5kLT5pbnNwZWN0 b3JDb250cm9sbGVyKCktPnNldFdpbmRvd1Zpc2libGUoZmFsc2UpOworCiAgICAgcmV0dXJuIFFX aWRnZXQ6OmV2ZW50KGV2KTsKIH0KIApAQCAtMTYzLDggKzE2Niw2IEBAIHZvaWQgUVdlYkluc3Bl Y3Rvcjo6c2hvd0V2ZW50KFFTaG93RXZlbnQqIGV2ZW50KQogLyohIFxyZWltcCAqLwogdm9pZCBR V2ViSW5zcGVjdG9yOjpoaWRlRXZlbnQoUUhpZGVFdmVudCogZXZlbnQpCiB7Ci0gICAgaWYgKGQt PnBhZ2UpCi0gICAgICAgIGQtPnBhZ2UtPmQtPmluc3BlY3RvckNvbnRyb2xsZXIoKS0+c2V0V2lu ZG93VmlzaWJsZShmYWxzZSk7CiB9CiAKIC8qISBcaW50ZXJuYWwgKi8KZGlmZiAtLWdpdCBhL1dl YktpdC9xdC9DaGFuZ2VMb2cgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCmluZGV4IDc5ODc2MTMuLjJi NTAxMDUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3F0L0No YW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDA5LTEyLTE1ICBIb2xnZXIgSGFucyBQZXRlciBG cmV5dGhlciAgPHplY2tlQHNlbGZpc2gub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRG8gbm90IGRpc2FibGUgdGhlIGluc3BlY3RvciBv biBzaG93IGFuZCBoaWRlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0zMTg1MQorCisgICAgICAgIE9uIFF0L1gxMSB3aXRoIHNvbWUgd2luZG93IG1hbmFn ZXJzIHRoZSB3aW5kb3cgd2lsbCBiZQorICAgICAgICBoaWRkZW4gd2hlbiBzd2l0Y2hpbmcgd2lu ZG93cy4gSW4gdGhpcyBjYXNlIGFsbCB0aGUgcmVzdWx0cworICAgICAgICBhcmUgZ29uZSB3aGVu IGNvbWluZyBiYWNrIHRvIHRoZSB3aW5kb3cuCisKKyAgICAgICAgQXR0ZW1wdCB0byB1c2UgdGhl IENsb3NlRXZlbnQgdG8gZmlndXJlIG91dCBpZiB0aGUgd2luZG93CisgICAgICAgIHdhcyBjbG9z ZWQgYW5kIHdpdGhkcmF3biBhcyB0aGlzIGlzIG1vcmUgZnJpZW5kbHkgdG8gdGhlCisgICAgICAg IHVzZXIgb2YgdGhlIGluc3BlY3RvciBjbGllbnQuCisKKyAgICAgICAgKiBBcGkvcXdlYmluc3Bl Y3Rvci5jcHA6CisgICAgICAgIChRV2ViSW5zcGVjdG9yOjpldmVudCk6CisgICAgICAgIChRV2Vi SW5zcGVjdG9yOjpoaWRlRXZlbnQpOgorCiAyMDA5LTEwLTE5ICBOYXRlIENoYXBpbiAgPGphcGhl dEBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgYnVpbGQgZml4LgotLSAKMS42 LjMuMwoK