31849 2009-11-24 14:37:40 -0800 [Qt] Implement initializeMaximumHTTPConnectionCountPerHost 2010-04-06 03:26:31 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke webkit-unassigned commit-queue eric markus mjs webkit.review.bot oldest_to_newest 166279 0 43807 zecke 2009-11-24 14:37:40 -0800 Created attachment 43807 Provide an implementation Provide a Qt implementation for the above method. The current limit inside the Qt framework is six connections per host (and three in the pipeline). 166446 1 eric 2009-11-25 07:52:56 -0800 Why "must this match"? I agree it probably should, I'm just confused by the comment. 166996 2 zecke 2009-11-27 21:00:51 -0800 You are right. There is no must. I will post an updated patch. 168346 3 44225 zecke 2009-12-03 03:36:02 -0800 Created attachment 44225 Provide a Qt specific implementation Slight improvement of the comment. I probably need to do some grammar and spelling fixes in one more round. 168347 4 webkit.review.bot 2009-12-03 03:37:47 -0800 style-queue ran check-webkit-style on attachment 44225 without any errors. 168945 5 44225 hausmann 2009-12-04 15:08:06 -0800 Comment on attachment 44225 Provide a Qt specific implementation r=me 171178 6 44225 commit-queue 2009-12-13 01:32:24 -0800 Comment on attachment 44225 Provide a Qt specific implementation Rejecting patch 44225 from commit-queue. Failed to run "['/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', '--reviewer', 'Simon Hausmann', '--force']" exit_code: 1 Last 500 characters of output: m/network/qt/ResourceRequestQt.cpp | 16 +++++++++++++++- 3 files changed, 34 insertions(+), 2 deletions(-) ------------------------------------------------------------------- patching file WebCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file WebCore/platform/network/ResourceRequestBase.cpp Hunk #1 FAILED at 378. 1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/network/ResourceRequestBase.cpp.rej patching file WebCore/platform/network/qt/ResourceRequestQt.cpp 171282 7 zecke 2009-12-13 18:43:57 -0800 I waited for Dimitri to respond to my response. If Dimitri thinks there should be more work done we can reopen the bug again, for now closing is the most easy way to make it drop out of the review queue. 171284 8 zecke 2009-12-13 18:56:29 -0800 Okay, this was on the wrong bug. I will land this change in a second.. so there is no need to reopen it. 171285 9 zecke 2009-12-13 19:11:33 -0800 Landed in r52079. 208977 10 markus 2010-04-06 03:26:31 -0700 This negatively interfers with HTTP pipelining in QNetworkAccessManager. I've sent a mail to the qtwebkit dev list. 43807 2009-11-24 14:37:40 -0800 2009-11-27 21:01:19 -0800 Provide an implementation 0005-Qt-Use-the-correct-number-of-parallel-connections.patch text/plain 2987 zecke RnJvbSAyMGExZmYxNWVkNjNmNDBmY2Q4NDAzYjIzNGRlMjAxZTU4Y2E5ZmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjQgTm92IDIwMDkgMTk6MTY6NDkgKzAxMDAKU3ViamVjdDog W1BBVENIIDUvNl0gW1F0XSBVc2UgdGhlIGNvcnJlY3QgbnVtYmVyIG9mIHBhcmFsbGVsIGNvbm5l Y3Rpb25zCgpVc2UgdGhlIGNvcnJlY3QgSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QgbnVtYmVy IG9uIFF0Cmluc3RlYWQgb2YgdGhlIGRlZmF1bHQgb2YgZm91ci4gT24gU3ltYmlhbiB0aGUgbnVt YmVyIGlzCnNldCB0byB0aHJlZSBhbmQgb24gYWxsIG90aGVyIHBsYXRmb3JtcyBpdCBpcyBzZXQg dG8gNi4KCiogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RCYXNlLmNwcDoKKiBwbGF0 Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcDoKKFdlYkNvcmU6OmluaXRpYWxp emVNYXhpbXVtSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QpOgotLS0KIFdlYkNvcmUvQ2hhbmdl TG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysrKysrKysr CiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAgIHwgICAg MiArLQogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcCB8 ICAgMTEgKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygrKSwgMSBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDcwNjBlZTUuLmM1M2UzNzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMjAgQEAKIAogICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBbUXRdIFVzZSB0aGUgY29ycmVj dCBudW1iZXIgb2YgcGFyYWxsZWwgY29ubmVjdGlvbnMKKworICAgICAgICBVc2UgdGhlIGNvcnJl Y3QgSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QgbnVtYmVyIG9uIFF0CisgICAgICAgIGluc3Rl YWQgb2YgdGhlIGRlZmF1bHQgb2YgZm91ci4gT24gU3ltYmlhbiB0aGUgbnVtYmVyIGlzCisgICAg ICAgIHNldCB0byB0aHJlZSBhbmQgb24gYWxsIG90aGVyIHBsYXRmb3JtcyBpdCBpcyBzZXQgdG8g Ni4KKworICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHA6 CisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJlcXVlc3RRdC5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjppbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9uQ291bnRQZXJI b3N0KToKKworMjAwOS0xMS0yNCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBz ZWxmaXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwogICAg ICAgICBbUXRdIFVzZSBRTmV0d29ya1JlcGx5OjpyYXdIZWFkZXJQYWlycwogICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE4MjYKIApkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwIGIvV2ViQ29y ZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCmluZGV4IGUwNzA3ZDku Ljk2NmY5ZWQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJl cXVlc3RCYXNlLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1 ZXN0QmFzZS5jcHAKQEAgLTM3OCw3ICszNzgsNyBAQCB2b2lkIFJlc291cmNlUmVxdWVzdEJhc2U6 OnVwZGF0ZVJlc291cmNlUmVxdWVzdCgpIGNvbnN0CiAgICAgbV9yZXNvdXJjZVJlcXVlc3RVcGRh dGVkID0gdHJ1ZTsKIH0KIAotI2lmICFQTEFURk9STShNQUMpICYmICFVU0UoQ0ZORVRXT1JLKSAm JiAhVVNFKFNPVVApICYmICFQTEFURk9STShDSFJPTUlVTSkKKyNpZiAhUExBVEZPUk0oTUFDKSAm JiAhVVNFKENGTkVUV09SSykgJiYgIVVTRShTT1VQKSAmJiAhUExBVEZPUk0oQ0hST01JVU0pICYm ICFQTEFURk9STShRVCkKIHVuc2lnbmVkIGluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25D b3VudFBlckhvc3QoKQogewogICAgIC8vIFRoaXMgaXMgdXNlZCBieSB0aGUgbG9hZGVyIHRvIGNv bnRyb2wgdGhlIG51bWJlciBvZiBpc3N1ZWQgcGFyYWxsZWwgbG9hZCByZXF1ZXN0cy4gCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3Bw IGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0LmNwcAppbmRl eCA3NTJhYmZlLi5mNzZhZTJhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsv cXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9SZXNvdXJjZVJlcXVlc3RRdC5jcHAKQEAgLTI3LDYgKzI3LDE3IEBACiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAorLy8gVGhpcyBtdXN0IG1hdGNoIHRoZSBkZWZhdWx0Q2hhbm5lbENvdW50IG9m IHRoZQorLy8gcWh0dHBuZXR3b3JrY29ubmVjdGlvbi5jcHAgZmlsZSBvZiBRdC4KK3Vuc2lnbmVk IGluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QoKQoreworI2lmZGVm IFFfT1NfU1lNQklBTgorICAgIHJldHVybiAzOworI2Vsc2UKKyAgICByZXR1cm4gNjsKKyNlbmRp ZgorfQorCiBRTmV0d29ya1JlcXVlc3QgUmVzb3VyY2VSZXF1ZXN0Ojp0b05ldHdvcmtSZXF1ZXN0 KFFPYmplY3QqIG9yaWdpbmF0aW5nRnJhbWUpIGNvbnN0CiB7CiAgICAgUU5ldHdvcmtSZXF1ZXN0 IHJlcXVlc3Q7Ci0tIAoxLjYuMy4zCgo= 44225 2009-12-03 03:36:02 -0800 2009-12-13 01:32:24 -0800 Provide a Qt specific implementation 0002-Qt-Implement-initializeMaximumHTTPConnectionCountPer.patch text/plain 3884 zecke RnJvbSA0MTJiYWZhZTViYWIzYmIzMDEwNzlhYmEzYjliZTI0OWI2MmZlMjk1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8emVja2VAc2Vs ZmlzaC5vcmc+CkRhdGU6IFR1ZSwgMjQgTm92IDIwMDkgMTk6MTY6NDkgKzAxMDAKU3ViamVjdDog W1BBVENIIDIvNV0gW1F0XSBJbXBsZW1lbnQgaW5pdGlhbGl6ZU1heGltdW1IVFRQQ29ubmVjdGlv bkNvdW50UGVySG9zdC4KClF0IGFsbG93cyB0byBoYXZlIHRocmVlIGNvbm5lY3Rpb25zIHBlciBo b3N0IG9uIFN5bWJpYW4sIGZvcgpldmVyeSBvdGhlciBwbGF0Zm9ybSB0aGUgbGltaXQgaXMgc2V0 IHRvIHNpeCBjb25uZWN0aW9ucyBwZXIKaG9zdCBidXQgdGhlIGRlZmF1bHQgaW1wbGVtZW50YXRp b24gd2lsbCBvbmx5IHNjaGVkdWxlIGZvdXIKY29ubmVjdGlvbnMgcGVyIGhvc3QuCkluIGEgbWFu dWFsIHRlc3Qgd2Ugc2VlbSB0byBnZXQgdGhlIGJlc3QgbG9hZGluZyBzcGVlZCBieQpnb2luZyB3 aXRoIFF0J3MgbGltaXQgYW5kIHNjaGVkdWxlIHR3byBtb3JlIGpvYnMgdG8gYWxsb3cgUXQKdG8g cHJlcGFyZSB0aGVtLgoKKiBwbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3Bw OgoqIHBsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3BwOgooV2ViQ29yZTo6 aW5pdGlhbGl6ZU1heGltdW1IVFRQQ29ubmVjdGlvbkNvdW50UGVySG9zdCk6Ci0tLQogV2ViQ29y ZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTggKysrKysr KysrKysrKysrKysrCiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFz ZS5jcHAgIHwgICAgMiArLQogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVx dWVzdFF0LmNwcCB8ICAgMTYgKysrKysrKysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAzNCBp bnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdl TG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggM2Q2ZGY1Zi4uZjVkYzZiNSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwy MSBAQAorMjAwOS0xMS0zMCAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxm aXNoLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBbUXRdIEltcGxlbWVudCBpbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9uQ291bnRQZXJI b3N0LgorCisgICAgICAgIFF0IGFsbG93cyB0byBoYXZlIHRocmVlIGNvbm5lY3Rpb25zIHBlciBo b3N0IG9uIFN5bWJpYW4sIGZvcgorICAgICAgICBldmVyeSBvdGhlciBwbGF0Zm9ybSB0aGUgbGlt aXQgaXMgc2V0IHRvIHNpeCBjb25uZWN0aW9ucyBwZXIKKyAgICAgICAgaG9zdCBidXQgdGhlIGRl ZmF1bHQgaW1wbGVtZW50YXRpb24gd2lsbCBvbmx5IHNjaGVkdWxlIGZvdXIKKyAgICAgICAgY29u bmVjdGlvbnMgcGVyIGhvc3QuCisgICAgICAgIEluIGEgbWFudWFsIHRlc3Qgd2Ugc2VlbSB0byBn ZXQgdGhlIGJlc3QgbG9hZGluZyBzcGVlZCBieQorICAgICAgICBnb2luZyB3aXRoIFF0J3MgbGlt aXQgYW5kIHNjaGVkdWxlIHR3byBtb3JlIGpvYnMgdG8gYWxsb3cgUXQKKyAgICAgICAgdG8gcHJl cGFyZSB0aGVtLgorCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RC YXNlLmNwcDoKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL3F0L1Jlc291cmNlUmVxdWVzdFF0 LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25D b3VudFBlckhvc3QpOgorCiAyMDA5LTExLTMwICBYYW4gTG9wZXogIDx4bG9wZXpAaWdhbGlhLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBHdXN0YXZvIE5vcm9uaGEuCmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAgYi9XZWJDb3Jl L3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAKaW5kZXggZTA3MDdkOS4u OTY2ZjllZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVx dWVzdEJhc2UuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVl c3RCYXNlLmNwcApAQCAtMzc4LDcgKzM3OCw3IEBAIHZvaWQgUmVzb3VyY2VSZXF1ZXN0QmFzZTo6 dXBkYXRlUmVzb3VyY2VSZXF1ZXN0KCkgY29uc3QKICAgICBtX3Jlc291cmNlUmVxdWVzdFVwZGF0 ZWQgPSB0cnVlOwogfQogCi0jaWYgIVBMQVRGT1JNKE1BQykgJiYgIVVTRShDRk5FVFdPUkspICYm ICFVU0UoU09VUCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQorI2lmICFQTEFURk9STShNQUMpICYm ICFVU0UoQ0ZORVRXT1JLKSAmJiAhVVNFKFNPVVApICYmICFQTEFURk9STShDSFJPTUlVTSkgJiYg IVBMQVRGT1JNKFFUKQogdW5zaWduZWQgaW5pdGlhbGl6ZU1heGltdW1IVFRQQ29ubmVjdGlvbkNv dW50UGVySG9zdCgpCiB7CiAgICAgLy8gVGhpcyBpcyB1c2VkIGJ5IHRoZSBsb2FkZXIgdG8gY29u dHJvbCB0aGUgbnVtYmVyIG9mIGlzc3VlZCBwYXJhbGxlbCBsb2FkIHJlcXVlc3RzLiAKZGlmZiAt LWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9SZXNvdXJjZVJlcXVlc3RRdC5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvUmVzb3VyY2VSZXF1ZXN0UXQuY3BwCmluZGV4 IDc1MmFiZmUuLjM0MWU2YWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9SZXNvdXJjZVJlcXVlc3RRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0 L1Jlc291cmNlUmVxdWVzdFF0LmNwcApAQCAtMSw1ICsxLDUgQEAKIC8qCi0gICAgQ29weXJpZ2h0 IChDKSAyMDA4IE5va2lhIENvcnBvcmF0aW9uIGFuZC9vciBpdHMgc3Vic2lkaWFyeSgtaWVzKQor ICAgIENvcHlyaWdodCAoQykgMjAwOSBOb2tpYSBDb3Jwb3JhdGlvbiBhbmQvb3IgaXRzIHN1YnNp ZGlhcnkoLWllcykKIAogICAgIFRoaXMgbGlicmFyeSBpcyBmcmVlIHNvZnR3YXJlOyB5b3UgY2Fu IHJlZGlzdHJpYnV0ZSBpdCBhbmQvb3IKICAgICBtb2RpZnkgaXQgdW5kZXIgdGhlIHRlcm1zIG9m IHRoZSBHTlUgTGlicmFyeSBHZW5lcmFsIFB1YmxpYwpAQCAtMjcsNiArMjcsMjAgQEAKIAogbmFt ZXNwYWNlIFdlYkNvcmUgewogCisvLyBDdXJyZW50bHkgUXQgYWxsb3dzIHRocmVlIGNvbm5lY3Rp b25zIHBlciBob3N0IG9uIHN5bWJpYW4gYW5kIHNpeAorLy8gZm9yIGV2ZXJ5b25lIGVsc2UuIFRo ZSBsaW1pdCBjYW4gYmUgZm91bmQgaW4gcWh0dHBuZXR3b3JrY29ubmVjdGlvbi5jcHAuCisvLyBU byBhY2hpZXZlIHRoZSBiZXN0IHJlc3VsdCB3ZSB3YW50IFdlYktpdCB0byBzY2hlZHVsZSB0aGUg am9icyBzbyB3ZQorLy8gYXJlIHVzaW5nIHRoZSBsaW1pdCBhcyBmb3VuZCBpbiBRdC4gVG8gYWxs b3cgUXQgdG8gZmlsbCBpdHMgcXVldWUKKy8vIGFuZCBwcmVwYXJlIGpvYnMgd2Ugd2lsbCBzY2hl ZHVsZSB0d28gbW9yZSBkb3dubG9hZHMuCit1bnNpZ25lZCBpbml0aWFsaXplTWF4aW11bUhUVFBD b25uZWN0aW9uQ291bnRQZXJIb3N0KCkKK3sKKyNpZmRlZiBRX09TX1NZTUJJQU4KKyAgICByZXR1 cm4gMyArIDI7CisjZWxzZQorICAgIHJldHVybiA2ICsgMjsKKyNlbmRpZgorfQorCiBRTmV0d29y a1JlcXVlc3QgUmVzb3VyY2VSZXF1ZXN0Ojp0b05ldHdvcmtSZXF1ZXN0KFFPYmplY3QqIG9yaWdp bmF0aW5nRnJhbWUpIGNvbnN0CiB7CiAgICAgUU5ldHdvcmtSZXF1ZXN0IHJlcXVlc3Q7Ci0tIAox LjYuMy4zCgo=