31845 2009-11-24 12:07:49 -0800 queries_unittest.py should test command output 2009-11-24 15:19:40 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 166225 0 eric 2009-11-24 12:07:49 -0800 queries_unittest.py should test command output Right now we only test to make sure that the commands can be executed w/o throwing an exception. Lets test to make sure the commands actually output as expected too. 166234 1 43797 eric 2009-11-24 12:14:38 -0800 Created attachment 43797 Patch 166266 2 43797 abarth 2009-11-24 13:43:13 -0800 Comment on attachment 43797 Patch This is great! We'll eventually want to factor that functionality in a base class so other tests can make use of it, but we can cross that bridge when we come to it. 166295 3 43797 commit-queue 2009-11-24 15:19:35 -0800 Comment on attachment 43797 Patch Clearing flags on attachment: 43797 Committed r51362: <http://trac.webkit.org/changeset/51362> 166296 4 commit-queue 2009-11-24 15:19:40 -0800 All reviewed patches have been landed. Closing bug. 43797 2009-11-24 12:14:38 -0800 2009-11-24 15:19:35 -0800 Patch bug-31845-20091124151437.patch text/plain 3250 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxOGU5ZmJkLi43OGM4NmRiIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMTEt MjQgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIHF1ZXJpZXNfdW5pdHRlc3QucHkgc2hvdWxkIHRl c3QgY29tbWFuZCBvdXRwdXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTMxODQ1CisKKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVl cmllc191bml0dGVzdC5weToKKyAgICAgICAgIC0gQ2FwdHVyZSBzdGRvdXQgYW5kIHN0ZGVyciBh bmQgY29tcGFyZSB3aXRoIGV4cGVjdGVkIHN0cmluZ3MuCisKIDIwMDktMTEtMjEgIEVyaWMgU2Vp ZGVsICA8ZXJpY0B3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGgu CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVlcmll c191bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWVy aWVzX3VuaXR0ZXN0LnB5CmluZGV4IDVlOGRkYzEuLjZiYWU3MjIgMTAwNjQ0Ci0tLSBhL1dlYktp dFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWVyaWVzX3VuaXR0ZXN0LnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWVyaWVzX3VuaXR0ZXN0LnB5 CkBAIC0yNywyMCArMjcsNDggQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZFTiBJRiBBRFZJU0VE IE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIAogaW1wb3J0IHVuaXR0ZXN0Citm cm9tIFN0cmluZ0lPIGltcG9ydCBTdHJpbmdJTwogCiBmcm9tIG1vZHVsZXMuY29tbWFuZHMucXVl cmllcyBpbXBvcnQgKgogZnJvbSBtb2R1bGVzLm1vY2tfYnVnemlsbGF0b29sIGltcG9ydCAqCiAK IGNsYXNzIFF1ZXJ5Q29tbWFuZHNUZXN0KHVuaXR0ZXN0LlRlc3RDYXNlKToKKyAgICBkZWYgX2Nh cHR1cmVfb3V0cHV0X3dpdGhfbmFtZShvdXRwdXRfbmFtZSk6CisgICAgICAgIHNlbGYuc2F2ZWRf b3V0cHV0c1tvdXRwdXRfbmFtZV0gPSBnZXRhdHRyKHN5cywgb3V0cHV0X25hbWUpCisgICAgICAg IHNldGF0dHIoc3lzLCBvdXRwdXRfbmFtZSwgU3RyaW5nSU8uU3RyaW5nSU8oKSkKKworICAgIGRl ZiBfcmVsZWFzZV9vdXRwdXRfd2l0aF9uYW1lKG91dHB1dF9uYW1lKToKKyAgICAgICAgY2FwdHVy ZWRfb3V0cHV0ID0gZ2V0YXR0cihzeXMsIG91dHB1dF9uYW1lKS5nZXR2YWx1ZSgpCisgICAgICAg IHNldGF0dHIoc3lzLCBvdXRwdXRfbmFtZSwgc2VsZi5zYXZlZF9vdXRwdXRzW291dHB1dF9uYW1l XSkKKyAgICAgICAgZGVsIHNlbGYuc2F2ZWRfb3V0cHV0c1tvdXRwdXRfbmFtZV0KKyAgICAgICAg cmV0dXJuIGNhcHR1cmVkX291dHB1dAorCisgICAgZGVmIF9jYXB0dXJlX291dHB1dChzZWxmKToK KyAgICAgICAgc2VsZi5fY2FwdHVyZV9vdXRwdXRfd2l0aF9uYW1lKCJzdGRvdXQiKQorICAgICAg ICBzZWxmLl9jYXB0dXJlX291dHB1dF93aXRoX25hbWUoInN0ZGVyciIpCisKKyAgICBkZWYgX3Jl c3RvcmVfb3V0cHV0KHNlbGYpOgorICAgICAgICByZXR1cm4gKHNlbGYuX3JlbGVhc2Vfb3V0cHV0 X3dpdGhfbmFtZSgic3Rkb3V0IiksIHNlbGYuX3JlbGVhc2Vfb3V0cHV0X3dpdGhfbmFtZSgic3Rk ZXJyIikpCisKKyAgICBkZWYgX2Fzc2VydF9leGVjdXRlX291dHB1dHMoc2VsZiwgY29tbWFuZCwg Y29tbWFuZF9hcmdzLCBleHBlY3RlZF9zdGRvdXQsIGV4cGVjdGVkX3N0ZGVyciA9ICIiKToKKyAg ICAgICAgc2VsZi5fY2FwdHVyZV9vdXRwdXQoKQorICAgICAgICBjb21tYW5kLmV4ZWN1dGUoTm9u ZSwgY29tbWFuZF9hcmdzLCBNb2NrQnVnemlsbGFUb29sKCkpCisgICAgICAgIChzdGRvdXRfc3Ry aW5nLCBzdGRlcnJfc3RyaW5nKSA9IHNlbGYuX3Jlc3RvcmVfb3V0cHV0KCkKKyAgICAgICAgc2Vs Zi5hc3NlcnRFcXVhbChzdGRvdXRfc3RyaW5nLCBleHBlY3RlZF9zdGRvdXQpCisgICAgICAgIHNl bGYuYXNzZXJ0RXF1YWwoZXhwZWN0ZWRfc3RkZXJyLCBleHBlY3RlZF9zdGRlcnIpCisKICAgICBk ZWYgdGVzdF9idWdzX3RvX2NvbW1pdChzZWxmKToKLSAgICAgICAgQnVnc1RvQ29tbWl0KCkuZXhl Y3V0ZShOb25lLCBOb25lLCBNb2NrQnVnemlsbGFUb29sKCkpCisgICAgICAgIHNlbGYuX2Fzc2Vy dF9leGVjdXRlX291dHB1dHMoQnVnc1RvQ29tbWl0KCksIE5vbmUsICI0MlxuNzVcbiIpCiAKICAg ICBkZWYgdGVzdF9wYXRjaGVzX3RvX2NvbW1pdChzZWxmKToKLSAgICAgICAgUGF0Y2hlc1RvQ29t bWl0KCkuZXhlY3V0ZShOb25lLCBOb25lLCBNb2NrQnVnemlsbGFUb29sKCkpCisgICAgICAgIGV4 cGVjdGVkX3N0ZG91dCA9ICJodHRwOi8vZXhhbXBsZS5jb20vMTk3XG5odHRwOi8vZXhhbXBsZS5j b20vMTI4XG4iCisgICAgICAgIGV4cGVjdGVkX3N0ZGVyciA9ICJQYXRjaGVzIGluIGNvbW1pdCBx dWV1ZTpcbiIKKyAgICAgICAgc2VsZi5fYXNzZXJ0X2V4ZWN1dGVfb3V0cHV0cyhQYXRjaGVzVG9D b21taXQoKSwgTm9uZSwgZXhwZWN0ZWRfc3Rkb3V0LCBleHBlY3RlZF9zdGRlcnIpCiAKICAgICBk ZWYgdGVzdF9yZXZpZXdlZF9wYXRjaGVzKHNlbGYpOgotICAgICAgICBhcmdzID0gWzQyXQotICAg ICAgICBSZXZpZXdlZFBhdGNoZXMoKS5leGVjdXRlKE5vbmUsIGFyZ3MsIE1vY2tCdWd6aWxsYVRv b2woKSkKKyAgICAgICAgZXhwZWN0ZWRfc3Rkb3V0ID0gImh0dHA6Ly9leGFtcGxlLmNvbS8xOTdc bmh0dHA6Ly9leGFtcGxlLmNvbS8xMjhcbiIKKyAgICAgICAgc2VsZi5fYXNzZXJ0X2V4ZWN1dGVf b3V0cHV0cyhSZXZpZXdlZFBhdGNoZXMoKSwgWzQyXSwgZXhwZWN0ZWRfc3Rkb3V0KQogCiAgICAg ZGVmIHRlc3RfdHJlZV9zdGF0dXMoc2VsZik6Ci0gICAgICAgIFRyZWVTdGF0dXMoKS5leGVjdXRl KE5vbmUsIE5vbmUsIE1vY2tCdWd6aWxsYVRvb2woKSkKKyAgICAgICAgZXhwZWN0ZWRfc3Rkb3V0 ID0gIm9rICAgOiBCdWlsZGVyMVxub2sgICA6IEJ1aWxkZXIyXG4iCisgICAgICAgIHNlbGYuX2Fz c2VydF9leGVjdXRlX291dHB1dHMoVHJlZVN0YXR1cygpLCBOb25lLCBleHBlY3RlZF9zdGRvdXQp Cg==