31840 2009-11-24 10:50:12 -0800 bisect-builds broke after r50080 2009-11-25 14:13:55 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.4 RESOLVED FIXED http://trac.webkit.org/changeset/50080 P2 Normal --- 30572 1 ddkilzer ddkilzer mitz ossy oldest_to_newest 166175 0 ddkilzer 2009-11-24 10:50:12 -0800 * SUMMARY The changes to the bisect-builds script in r50080 were incorrect. Patch forthcoming. 166181 1 43789 ddkilzer 2009-11-24 10:52:00 -0800 Created attachment 43789 Patch v1 166211 2 ddkilzer 2009-11-24 11:51:44 -0800 Committed r51346: <http://trac.webkit.org/changeset/51346> 166543 3 ossy 2009-11-25 13:27:04 -0800 (In reply to comment #2) > Committed r51346: <http://trac.webkit.org/changeset/51346> Thanks for fix. Unfortunately I wasn't able to try it on Mac before landing. But I have no idea why it was incorrect, I frequently use similar exec statements. Strange ... 166554 4 ddkilzer 2009-11-25 14:13:55 -0800 (In reply to comment #3) > (In reply to comment #2) > > Committed r51346: <http://trac.webkit.org/changeset/51346> > Thanks for fix. Unfortunately I wasn't able to try it on Mac before landing. > But I have no idea why it was incorrect, I frequently use similar exec > statements. Strange ... It's because exec() is different from the backtick operator (``). exec() will run the program and then exit the Perl script immediately. The backtick operator (``) is more like a system() call where it runs the command, then returns to the Perl script to continue executing it. 43789 2009-11-24 10:52:00 -0800 2009-11-24 10:52:49 -0800 Patch v1 bug-31840-v1.diff text/plain 1916 ddkilzer ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBlMTZhNTFmLi5lNmQyYzliIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEt MjQgIERhdmlkIEtpbHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBiaXNlY3Qt YnVpbGRzOiBmaXggdW5tb3VudGluZyBvZiBETUcgZmlsZXMgYWZ0ZXIgcjUwMDgwCisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL2Jpc2Vj dC1idWlsZHM6CisgICAgICAgIChtb3VudEFuZFJ1bk5pZ2h0bHkpOiBTd2l0Y2hlZCBiYWNrIHRv IHVzaW5nIGJhY2t0aWNrcyB0byBydW4KKyAgICAgICAgdGhlIGhkaXV0aWwgY29tbWFuZCBzaW5j ZSBleGVjKCkgd2lsbCB0ZXJtaW5hdGUgdGhlIGV4aXN0aW5nCisgICAgICAgIHNjcmlwdCwgd2hp Y2ggaXMgbm90IHdoYXQgd2Ugd2FudC4gIFN0b3JlIHRoZSBvdXRwdXQgb2YKKyAgICAgICAgRmls ZTo6U3BlYy0+ZGV2bnVsbCgpIGluIGEgdmFyaWFibGUgZm9yIHVzZSBpbiB0aGUgaGRpdXRpbAor ICAgICAgICBkZXRhY2ggY29tbWFuZHMuCisKIDIwMDktMTEtMTMgIEtlbm5ldGggUm9oZGUgQ2hy aXN0aWFuc2VuICA8a2VubmV0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNp bW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVp bGRzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9iaXNlY3QtYnVpbGRzCmluZGV4IDU1YmYyMzguLjA2 M2I2MWUgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYmlzZWN0LWJ1aWxkcworKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL2Jpc2VjdC1idWlsZHMKQEAgLTM2MywxMiArMzYzLDEzIEBA IHN1YiBtb3VudEFuZFJ1bk5pZ2h0bHkoJCQkJCkKICAgICBteSAkbW91bnRQYXRoID0gIi9Wb2x1 bWVzL1dlYktpdCI7CiAgICAgbXkgJHdlYmtpdEFwcCA9IEZpbGU6OlNwZWMtPmNhdGZpbGUoJG1v dW50UGF0aCwgIldlYktpdC5hcHAiKTsKICAgICBteSAkZGlza0ltYWdlID0gRmlsZTo6U3BlYy0+ Y2F0ZmlsZSgkZGlyZWN0b3J5LCAkZmlsZW5hbWUpOworICAgIG15ICRkZXZOdWxsID0gRmlsZTo6 U3BlYy0+ZGV2bnVsbCgpOwogCiAgICAgbXkgJGkgPSAwOwogICAgIHdoaWxlICgtZSAkbW91bnRQ YXRoKSB7CiAgICAgICAgICRpKys7CiAgICAgICAgIHVzbGVlcCAxMDAgaWYgJGkgPiAxOwotICAg ICAgICBleGVjICJoZGl1dGlsIiwgImRldGFjaCAnJG1vdW50UGF0aCcgMj4gIiAuIEZpbGU6OlNw ZWMtPmRldm51bGwoKTsKKyAgICAgICAgYGhkaXV0aWwgZGV0YWNoICckbW91bnRQYXRoJyAyPiAk ZGV2TnVsbGA7CiAgICAgICAgIGRpZSAiQ291bGQgbm90IHVubW91bnQgJGRpc2tJbWFnZSBhdCAk bW91bnRQYXRoIiBpZiAkaSA+IDEwMDsKICAgICB9CiAgICAgZGllICJDYW4ndCBtb3VudCAkZGlz a0ltYWdlOiAkbW91bnRQYXRoIGFscmVhZHkgZXhpc3RzISIgaWYgLWUgJG1vdW50UGF0aDsKQEAg LTM5Myw3ICszOTQsNyBAQCBzdWIgbW91bnRBbmRSdW5OaWdodGx5KCQkJCQpCiAgICAgJHRlbXBG aWxlIHx8PSAiIjsKICAgICBgRFlMRF9GUkFNRVdPUktfUEFUSD0kZnJhbWV3b3JrUGF0aCBXRUJL SVRfVU5TRVRfRFlMRF9GUkFNRVdPUktfUEFUSD1ZRVMgJHNhZmFyaSAkdGVtcEZpbGVgOwogCi0g ICAgZXhlYyAiaGRpdXRpbCIsICJkZXRhY2ggJyRtb3VudFBhdGgnIDI+ICIgLiBGaWxlOjpTcGVj LT5kZXZudWxsKCk7CisgICAgYGhkaXV0aWwgZGV0YWNoICckbW91bnRQYXRoJyAyPiAkZGV2TnVs bGA7CiB9CiAKIHN1YiBwYXJzZVJldmlzaW9ucygkJDskKQo=