31833 2009-11-24 07:35:10 -0800 [Chromium] Fix DOM storage layout tests 2009-11-24 08:19:16 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue dglazkov fishd jorlow oldest_to_newest 166066 0 abarth 2009-11-24 07:35:10 -0800 Fix the dom storage layout tests broken by a recent patch: LayoutTests/storage/domstorage/localstorage/index-get-and-set.html = TEXT LayoutTests/storage/domstorage/localstorage/onstorage-attribute-markup.html = TEXT LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setattribute.html = TEXT LayoutTests/storage/domstorage/localstorage/onstorage-attribute-setwindow.html = TEXT LayoutTests/storage/domstorage/localstorage/simple-events.html = TEXT LayoutTests/storage/domstorage/window-attributes-exist.html = TEXT LayoutTests/storage/domstorage/localstorage/iframe-events.html = TIMEOUT 166071 1 43767 abarth 2009-11-24 07:42:03 -0800 Created attachment 43767 Patch 166087 2 43767 dglazkov 2009-11-24 07:57:09 -0800 Comment on attachment 43767 Patch ok. Can you file a bug and give it to Jeremy on the "fix for realz"? 166089 3 43767 abarth 2009-11-24 08:01:17 -0800 Comment on attachment 43767 Patch Will do. 166095 4 43767 commit-queue 2009-11-24 08:16:02 -0800 Comment on attachment 43767 Patch Clearing flags on attachment: 43767 Committed r51338: <http://trac.webkit.org/changeset/51338> 166096 5 commit-queue 2009-11-24 08:16:08 -0800 All reviewed patches have been landed. Closing bug. 166101 6 abarth 2009-11-24 08:19:16 -0800 Filed as https://bugs.webkit.org/show_bug.cgi?id=31835. 43767 2009-11-24 07:42:03 -0800 2009-11-24 08:16:01 -0800 Patch bug-31833-20091124074202.patch text/plain 2992 abarth SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTEzMzcpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjkgQEAKKzIwMDktMTEtMjQgIEFkYW0g QmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbQ2hyb21pdW1dIEZpeCBET00gc3RvcmFnZSBsYXlvdXQgdGVz dHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODMz CisKKyAgICAgICAgVGhlIGlzc3VlIGlzLCBlc3NlbnRpYWxseSwgdGhhdCB0aGlzIGNvZGUgYXNz dW1lcyB0aGF0CisgICAgICAgIFNlY3VyaXR5T3JpZ2luOjpjcmVhdGVTdHJpbmcgY2FuIHJlLWNy ZWF0ZSBhIFNlY3VyaXR5T3JpZ2luIGdpdmVuCisgICAgICAgIHRoZSBzdHJpbmcgcHJvZHVjZWQg ZnJvbSBTZWN1cml0eU9yaWdpbjo6dG9TdHJpbmcuICBUaGlzIGlzIGEgYm9ndXMKKyAgICAgICAg YXNzdW1wdGlvbiBpbiBhIG51bWJlciBvZiBjb3JuZXIgY2FzZXMgKGUuZy4sIGRvY3VtZW50LmRv bWFpbiwKKyAgICAgICAgQHNhbmRib3gpLiAgQSByZWNlbnQgcGF0Y2ggKGh0dHA6Ly90cmFjLndl YmtpdC5vcmcvY2hhbmdlc2V0LzUxMjk0KQorICAgICAgICBtYWtlIHRoaXMgYXNzdW1wdGlvbiBm dXJ0aGVyIGludmFsaWQgaW4gdGhlIGNhc2Ugb2Ygb2YgZmlsZTovLyBVUkxzLgorCisgICAgICAg IFRoZSBjb3JyZWN0IGZpeCBpcyBmb3IgdGhpcyBjb2RlIHRvIHVzZSBXZWJTZWN1cml0eU9yaWdp biBvYmplY3RzCisgICAgICAgIChhbmQgbm90IHN0cmluZ3MpIHRvIHJlcHJlc2VudCBTZWN1cml0 eU9yaWdpbiBvYmplY3RzLiAgSG93ZXZlciwgdGhlCisgICAgICAgIGV4cGVydCBvbiB0aGlzIGNv ZGUgaXMgb24gdmFjYXRpb24sIGFuZCBJIGRvbid0IHdhbnQgdG8gZG8gbWFqb3IKKyAgICAgICAg c3VyZ2VyeSBoZXJlIHdpdGhvdXQgaGlzIGludm9sdmVtZW50LiAgVGhpcyBwYXRjaCBpcyBhIHRl bXBvcmFyeSBmaXgKKyAgICAgICAgdG8gZ2V0IHRoZXNlIHRlc3RzIHBhc3NpbmcgYWdhaW4uICBX ZSdsbCBkbyB0aGUgcmlnaHQgZml4IG9uY2UKKyAgICAgICAgam9ybG93IGdldHMgYmFjayBmcm9t IHZhY2F0aW9uLgorCisgICAgICAgIFRlc3RzOiBDb3ZlcmVkIGJ5IGEgbnVtYmVyIG9mIGV4aXN0 aW5nIERPTSBzdG9yYWdlIHRlc3RzLgorCisgICAgICAgICogc3JjL1dlYlN0b3JhZ2VOYW1lc3Bh Y2VJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViU3RvcmFnZU5hbWVzcGFjZUltcGw6OmNy ZWF0ZVN0b3JhZ2VBcmVhKToKKwogMjAwOS0xMS0yMyAgSmlhbiBMaSAgPGppYW5saUBjaHJvbWl1 bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChDaHJvbWl1bSBidWlsZCBmaXgp LgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlTmFtZXNwYWNlSW1wbC5jcHAK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdlTmFtZXNwYWNlSW1w bC5jcHAJKHJldmlzaW9uIDUxMzI2KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJTdG9yYWdl TmFtZXNwYWNlSW1wbC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTYxLDcgKzYxLDIwIEBAIFdlYlN0 b3JhZ2VOYW1lc3BhY2VJbXBsOjp+V2ViU3RvcmFnZU5hbWUKIAogV2ViU3RvcmFnZUFyZWEqIFdl YlN0b3JhZ2VOYW1lc3BhY2VJbXBsOjpjcmVhdGVTdG9yYWdlQXJlYShjb25zdCBXZWJTdHJpbmcm IG9yaWdpblN0cmluZykKIHsKLSAgICBSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+IG9y aWdpbiA9IFdlYkNvcmU6OlNlY3VyaXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKG9yaWdpblN0 cmluZyk7CisgICAgV2ViQ29yZTo6U3RyaW5nIG9yaWdpbldlYkNvcmVTdHJpbmcgPSBvcmlnaW5T dHJpbmc7CisgICAgaWYgKG9yaWdpbldlYkNvcmVTdHJpbmcgPT0gImZpbGU6Ly8iKSB7CisgICAg ICAgIC8vIEZJWE1FOiBXZSBzaG91bGQgcmVhbGx5IGJlIHBhc3NpbmcgYXJvdW5kIFdlYlNlY3Vy aXR5T3JpZ2luIG9iamVjdHMKKyAgICAgICAgLy8gICAgICAgIHRvIHJlcHJlc2VudCBzZWN1cml0 eSBvcmlnaW5zIGluc3RlYWQgb2Ygc3RyaW5ncy4gIE9uZSBpc3N1ZQorICAgICAgICAvLyAgICAg ICAgd2l0aCB1c2luZyBzdHJpbmdzIGlzIHRoYXQgY3JlYXRlRnJvbVN0cmluZyh0b1N0cmluZykg ZG9lcworICAgICAgICAvLyAgICAgICAgbm90IHJvdW5kLXRyaXAgZm9yIGZpbGUgVVJMcyBiZWNh dXNlIGZpbGU6Ly8gbG9va3MgbGlrZSBhCisgICAgICAgIC8vICAgICAgICBkaXJlY3RvcnkgKHdo aWNoIGlzIHNhbmRib3hlZCkuCisgICAgICAgIC8vCisgICAgICAgIC8vIEZvciB0aGUgdGltZSBi ZWluZywgd2Ugd29yayBhcm91bmQgdGhpcyBpc3N1ZSBieSB1c2luZyAiZmlsZTovLy9hIiwKKyAg ICAgICAgLy8gd2hpY2ggZG9lcyBub3QgbG9vayBsaWtlIGEgZGlyZWN0b3J5LiAgV2Ugc2hvdWxk IGZpeCB0aGlzIHdoZW4KKyAgICAgICAgLy8gam9ybG93IGdldHMgYmFjayBmcm9tIHZhY3RhdGlv bi4KKyAgICAgICAgb3JpZ2luV2ViQ29yZVN0cmluZyA9ICJmaWxlOi8vL2EiOworICAgIH0KKyAg ICBSZWZQdHI8V2ViQ29yZTo6U2VjdXJpdHlPcmlnaW4+IG9yaWdpbiA9IFdlYkNvcmU6OlNlY3Vy aXR5T3JpZ2luOjpjcmVhdGVGcm9tU3RyaW5nKG9yaWdpbldlYkNvcmVTdHJpbmcpOwogICAgIHJl dHVybiBuZXcgV2ViU3RvcmFnZUFyZWFJbXBsKG1fc3RvcmFnZU5hbWVzcGFjZS0+c3RvcmFnZUFy ZWEob3JpZ2luLnJlbGVhc2UoKSkpOwogfQogCg==