31830 2009-11-24 06:43:02 -0800 Chromium: Expose method for reporting user stats to the host. 2009-11-24 11:39:32 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman dglazkov fishd oldest_to_newest 166054 0 pfeldman 2009-11-24 06:43:02 -0800 We'd like to push some stats from web inspector to the host. 166056 1 43766 pfeldman 2009-11-24 06:44:54 -0800 Created attachment 43766 [PATCH] Note that I should land it after implementation lands in Chromium. 166085 2 43766 abarth 2009-11-24 07:56:29 -0800 Comment on attachment 43766 [PATCH] Marking cq- so we don't accidentally commit this before the downstream change. 166137 3 43766 dglazkov 2009-11-24 10:12:43 -0800 Comment on attachment 43766 [PATCH] ok. 166142 4 43766 eric 2009-11-24 10:17:11 -0800 Comment on attachment 43766 [PATCH] Where is this ever used? Why would we add this virtual function w/o it ever being used anywhere... This change is not required before the downstream one since you can always add a virtual method which is never called. In fact, this change would break the downstream version if checked in, so I'm not sure I understand why this is being added at all w/o ever being used. I guess I don't understand the patch or the r+. 166144 5 pfeldman 2009-11-24 10:19:14 -0800 > I guess I don't understand the patch or the r+. http://codereview.chromium.org/435019/show 166162 6 43787 pfeldman 2009-11-24 10:38:00 -0800 Created attachment 43787 [PATCH] Darin suggests that it is exposed to whole WebKit. 166164 7 43787 fishd 2009-11-24 10:41:15 -0800 Comment on attachment 43787 [PATCH] Darin suggests that it is exposed to whole WebKit. > + // By default, histogram is exponential, so that min=1, max=1000000, bucketCound=50 would do. Setting nit: s/bucketCound/bucketCount/ 166169 8 fishd 2009-11-24 10:45:40 -0800 if you add a default implementation, then you don't have to worry about a painful two sided landing virtual void histogramCounts(...) { } 166204 9 pfeldman 2009-11-24 11:39:32 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebKit/chromium/ChangeLog M WebKit/chromium/public/WebKitClient.h Committed r51345 Landed with drive-by default implementations for the whole client itself. 43766 2009-11-24 06:44:54 -0800 2009-11-24 10:38:00 -0800 [PATCH] histogram text/plain 1099 pfeldman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGMwMTc2MzcuLmViZTY3MWEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDA5LTExLTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtIERldlRvb2xzOiBFeHBvc2UgbWV0aG9kIGZvciByZXBvcnRpbmcgdXNlciBzdGF0cworICAg ICAgICB0byB0aGUgaG9zdC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzE4MzAKKworICAgICAgICAqIHB1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5k Q2xpZW50Lmg6CisKIDIwMDktMTEtMjMgIEppYW4gTGkgIDxqaWFubGlAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoQ2hyb21pdW0gYnVpbGQgZml4KS4KZGlmZiAt LWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViRGV2VG9vbHNGcm9udGVuZENsaWVudC5o IGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgKaW5k ZXggZjJhNmM0Yy4uMGViYWNlNyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9X ZWJEZXZUb29sc0Zyb250ZW5kQ2xpZW50LmgKQEAgLTUxLDYgKzUxLDggQEAgcHVibGljOgogICAg IHZpcnR1YWwgdm9pZCBkb2NrV2luZG93KCkgPSAwOwogICAgIHZpcnR1YWwgdm9pZCB1bmRvY2tX aW5kb3coKSA9IDA7CiAKKyAgICB2aXJ0dWFsIHZvaWQgaGlzdG9ncmFtQ291bnRzKGNvbnN0IFdl YlN0cmluZyYgbmFtZSwgaW50IHNhbXBsZSwgaW50IG1pbiwgaW50IG1heCwgaW50IGJ1Y2tldENv dW50KSA9IDA7CisKIHByb3RlY3RlZDoKICAgICB2aXJ0dWFsIH5XZWJEZXZUb29sc0Zyb250ZW5k Q2xpZW50KCkge30KIH07Cg== 43787 2009-11-24 10:38:00 -0800 2009-11-24 10:41:15 -0800 [PATCH] Darin suggests that it is exposed to whole WebKit. histogram text/plain 1429 pfeldman ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDIxYmI3NGUuLjQzOGUxMmUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDA5LTExLTI0ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENocm9t aXVtOiBFeHBvc2UgbWV0aG9kIGZvciByZXBvcnRpbmcgdXNlciBzdGF0cworICAgICAgICB0byB0 aGUgaG9zdC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzE4MzAKKworICAgICAgICAqIHB1YmxpYy9XZWJLaXRDbGllbnQuaDoKKwogMjAwOS0xMS0y NCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi S2l0Q2xpZW50LmggYi9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYktpdENsaWVudC5oCmluZGV4 IDNhMWUwNTUuLjVhN2YwODQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2Vi S2l0Q2xpZW50LmgKKysrIGIvV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJLaXRDbGllbnQuaApA QCAtMjEzLDYgKzIxMywxMCBAQCBwdWJsaWM6CiAgICAgdmlydHVhbCB2b2lkIHRyYWNlRXZlbnRC ZWdpbihjb25zdCBjaGFyKiBuYW1lLCB2b2lkKiBpZCwgY29uc3QgY2hhciogZXh0cmEpID0gMDsK ICAgICB2aXJ0dWFsIHZvaWQgdHJhY2VFdmVudEVuZChjb25zdCBjaGFyKiBuYW1lLCB2b2lkKiBp ZCwgY29uc3QgY2hhciogZXh0cmEpID0gMDsKIAorICAgIC8vIEdlbmVyaWMgY2FsbGJhY2sgZm9y IHJlcG9ydGluZyBoaXN0b2dyYW0gZGF0YS4gUmFuZ2UgaXMgaWRlbnRpZmllZCBieSB0aGUgbWlu LCBtYXggcGFpci4KKyAgICAvLyBCeSBkZWZhdWx0LCBoaXN0b2dyYW0gaXMgZXhwb25lbnRpYWws IHNvIHRoYXQgbWluPTEsIG1heD0xMDAwMDAwLCBidWNrZXRDb3VuZD01MCB3b3VsZCBkby4gU2V0 dGluZworICAgIC8vIGxpbmVhciB0byB0cnVlIHdvdWxkIHJlcXVpcmUgYnVja2V0IGNvdW50IHRv IGNvdmVyIHdob2xlIG1pbi1tYXggcmFuZ2UuCisgICAgdmlydHVhbCB2b2lkIGhpc3RvZ3JhbUNv dW50cyhjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGludCBzYW1wbGUsIGludCBtaW4sIGludCBtYXgs IGludCBidWNrZXRDb3VudCwgYm9vbCBsaW5lYXIpID0gMDsKIAogICAgIC8vIFJlc291cmNlcyAt LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogCg==