<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>31827</bug_id>
          
          <creation_ts>2009-11-24 05:26:13 -0800</creation_ts>
          <short_desc>Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore</short_desc>
          <delta_ts>2009-11-25 00:29:27 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Other</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Zoltan Horvath">zoltan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>166040</commentid>
    <comment_count>0</comment_count>
      <attachid>43761</attachid>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-11-24 05:26:13 -0800</bug_when>
    <thetext>Created attachment 43761
Patch

Reviewed by NOBODY (OOPS!).

Allow custom memory allocation control for classes of the plugins and rendering directory in WebCore
https://bugs.webkit.org/show_bug.cgi?id=

Inherits the following classes from Noncopyable because these are instantiated
by &apos;new&apos; and no need to be copyable:

class/struct name               - instantiated at: WebCore/&apos;location&apos;

class PluginRequest             - plugins/PluginView.cpp:521
class PluginMainThreadScheduler - plugins/PluginMainThreadScheduler.cpp:34
class PluginDatabase            - plugins/PluginDatabase.cpp:50
struct MimeClassInfo            - plugins/PluginInfoStore.cpp:50
struct PluginInfo               - plugins/PluginInfoStore.cpp:40
class RenderArena               - dom/Document.cpp:1401
class RenderImageScaleData      - rendering/RenderImage.cpp:149
class TableLayout               - (its child class) rendering/RenderTable.cpp:82
struct ColumnInfo               - rendering/RenderBlock.cpp:3590
struct FloatingObject           - rendering/RenderBlock.cpp:2300
struct MaxMargin                - rendering/RenderBlock.cpp:4794
class RenderMarquee             - rendering/RenderLayer.cpp:3277

* plugins/PluginData.h:
* plugins/PluginDatabase.h:
* plugins/PluginMainThreadScheduler.h:
* plugins/PluginView.h:
* rendering/RenderArena.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
* rendering/RenderImage.cpp:
* rendering/RenderMarquee.h:
* rendering/TableLayout.h:</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166140</commentid>
    <comment_count>1</comment_count>
      <attachid>43761</attachid>
    <who name="Eric Seidel (no email)">eric</who>
    <bug_when>2009-11-24 10:15:25 -0800</bug_when>
    <thetext>Comment on attachment 43761
Patch

I expect we&apos;re increasing the size of the WebCore binary by adding all these template instantiations.  That said, this change looks right, and is useful for documenting the use of these classes.  I&apos;m still not sure I fully understand your quest to make new/delete replaceable, but this change is a good one.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166360</commentid>
    <comment_count>2</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-11-24 23:46:34 -0800</bug_when>
    <thetext>&gt; I&apos;m still not sure I fully understand
&gt; your quest to make new/delete replaceable, but this change is a good one.

Unfortunately, the global operator new technique doesn&apos;t work (on Linux and Windows). When you use the WebKit as a shared library for an application it will customizes the application&apos;s new/delete also. This can lead to weird problems. (e.g. crash) The FastAllocBase solution provides a safety way to customize new/delete through locally in the classes, not by the global way. So, we&apos;ll have full allocation control over the classes.

I&apos;m going to land the patch now, thanks for the review. :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>166363</commentid>
    <comment_count>3</comment_count>
    <who name="Zoltan Horvath">zoltan</who>
    <bug_when>2009-11-25 00:29:27 -0800</bug_when>
    <thetext>Landed in 51378.
http://trac.webkit.org/changeset/51378</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>43761</attachid>
            <date>2009-11-24 05:26:13 -0800</date>
            <delta_ts>2009-11-24 10:15:25 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>20091124142611.patch</filename>
            <type>text/plain</type>
            <size>7390</size>
            <attacher name="Zoltan Horvath">zoltan</attacher>
            
              <data encoding="base64">SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n
CShyZXZpc2lvbiA1MTMzNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA
IC0xLDMgKzEsMzkgQEAKKzIwMDktMTEtMjQgIFpvbHRhbiBIb3J2YXRoICA8em9sdGFuQHdlYmtp
dC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
QWxsb3cgY3VzdG9tIG1lbW9yeSBhbGxvY2F0aW9uIGNvbnRyb2wgZm9yIGNsYXNzZXMgb2YgdGhl
IHBsdWdpbnMgYW5kIHJlbmRlcmluZyBkaXJlY3RvcnkgaW4gV2ViQ29yZQorICAgICAgICBodHRw
czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9CisKKyAgICAgICAgSW5oZXJpdHMg
dGhlIGZvbGxvd2luZyBjbGFzc2VzIGZyb20gTm9uY29weWFibGUgYmVjYXVzZSB0aGVzZSBhcmUg
aW5zdGFudGlhdGVkCisgICAgICAgIGJ5ICduZXcnIGFuZCBubyBuZWVkIHRvIGJlIGNvcHlhYmxl
OgorCisgICAgICAgIGNsYXNzL3N0cnVjdCBuYW1lICAgICAgICAgICAgICAgLSBpbnN0YW50aWF0
ZWQgYXQ6IFdlYkNvcmUvJ2xvY2F0aW9uJworCisgICAgICAgIGNsYXNzIFBsdWdpblJlcXVlc3Qg
ICAgICAgICAgICAgLSBwbHVnaW5zL1BsdWdpblZpZXcuY3BwOjUyMQorICAgICAgICBjbGFzcyBQ
bHVnaW5NYWluVGhyZWFkU2NoZWR1bGVyIC0gcGx1Z2lucy9QbHVnaW5NYWluVGhyZWFkU2NoZWR1
bGVyLmNwcDozNAorICAgICAgICBjbGFzcyBQbHVnaW5EYXRhYmFzZSAgICAgICAgICAgIC0gcGx1
Z2lucy9QbHVnaW5EYXRhYmFzZS5jcHA6NTAKKyAgICAgICAgc3RydWN0IE1pbWVDbGFzc0luZm8g
ICAgICAgICAgICAtIHBsdWdpbnMvUGx1Z2luSW5mb1N0b3JlLmNwcDo1MAorICAgICAgICBzdHJ1
Y3QgUGx1Z2luSW5mbyAgICAgICAgICAgICAgIC0gcGx1Z2lucy9QbHVnaW5JbmZvU3RvcmUuY3Bw
OjQwCisgICAgICAgIGNsYXNzIFJlbmRlckFyZW5hICAgICAgICAgICAgICAgLSBkb20vRG9jdW1l
bnQuY3BwOjE0MDEKKyAgICAgICAgY2xhc3MgUmVuZGVySW1hZ2VTY2FsZURhdGEgICAgICAtIHJl
bmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6MTQ5CisgICAgICAgIGNsYXNzIFRhYmxlTGF5b3V0ICAg
ICAgICAgICAgICAgLSAoaXRzIGNoaWxkIGNsYXNzKSByZW5kZXJpbmcvUmVuZGVyVGFibGUuY3Bw
OjgyCisgICAgICAgIHN0cnVjdCBDb2x1bW5JbmZvICAgICAgICAgICAgICAgLSByZW5kZXJpbmcv
UmVuZGVyQmxvY2suY3BwOjM1OTAKKyAgICAgICAgc3RydWN0IEZsb2F0aW5nT2JqZWN0ICAgICAg
ICAgICAtIHJlbmRlcmluZy9SZW5kZXJCbG9jay5jcHA6MjMwMAorICAgICAgICBzdHJ1Y3QgTWF4
TWFyZ2luICAgICAgICAgICAgICAgIC0gcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcDo0Nzk0Cisg
ICAgICAgIGNsYXNzIFJlbmRlck1hcnF1ZWUgICAgICAgICAgICAgLSByZW5kZXJpbmcvUmVuZGVy
TGF5ZXIuY3BwOjMyNzcKKworICAgICAgICAqIHBsdWdpbnMvUGx1Z2luRGF0YS5oOgorICAgICAg
ICAqIHBsdWdpbnMvUGx1Z2luRGF0YWJhc2UuaDoKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpbk1h
aW5UaHJlYWRTY2hlZHVsZXIuaDoKKyAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXcuaDoKKyAg
ICAgICAgKiByZW5kZXJpbmcvUmVuZGVyQXJlbmEuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvUmVu
ZGVyQmxvY2suY3BwOgorICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCbG9jay5oOgorICAgICAg
ICAqIHJlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHA6CisgICAgICAgICogcmVuZGVyaW5nL1JlbmRl
ck1hcnF1ZWUuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvVGFibGVMYXlvdXQuaDoKKwogMjAwOS0x
MS0yNCAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCBwcm9kdWN0
aW9uIGJ1aWxkcyB3aGVyZSB0aGUgc291cmNlIHRyZWUgbWF5IGJlIHJlYWQtb25seS4KSW5kZXg6
IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbHVn
aW5zL1BsdWdpbkRhdGEuaAkocmV2aXNpb24gNTEzMzcpCisrKyBXZWJDb3JlL3BsdWdpbnMvUGx1
Z2luRGF0YS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yOSwxNCArMjksMTQgQEAgbmFtZXNwYWNlIFdl
YkNvcmUgewogICAgIGNsYXNzIFBhZ2U7CiAgICAgc3RydWN0IFBsdWdpbkluZm87CiAKLSAgICBz
dHJ1Y3QgTWltZUNsYXNzSW5mbyB7CisgICAgc3RydWN0IE1pbWVDbGFzc0luZm8gOiBOb25jb3B5
YWJsZSB7CiAgICAgICAgIFN0cmluZyB0eXBlOwogICAgICAgICBTdHJpbmcgZGVzYzsKICAgICAg
ICAgU3RyaW5nIHN1ZmZpeGVzOwogICAgICAgICBQbHVnaW5JbmZvKiBwbHVnaW47CiAgICAgfTsK
IAotICAgIHN0cnVjdCBQbHVnaW5JbmZvIHsKKyAgICBzdHJ1Y3QgUGx1Z2luSW5mbyA6IE5vbmNv
cHlhYmxlIHsKICAgICAgICAgU3RyaW5nIG5hbWU7CiAgICAgICAgIFN0cmluZyBmaWxlOwogICAg
ICAgICBTdHJpbmcgZGVzYzsKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5o
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5oCShyZXZpc2lv
biA1MTMzNykKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5EYXRhYmFzZS5oCSh3b3JraW5nIGNv
cHkpCkBAIC00NSw3ICs0NSw3IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogICAgIHR5cGVkZWYg
SGFzaFNldDxSZWZQdHI8UGx1Z2luUGFja2FnZT4sIFBsdWdpblBhY2thZ2VIYXNoPiBQbHVnaW5T
ZXQ7CiAKLSAgICBjbGFzcyBQbHVnaW5EYXRhYmFzZSB7CisgICAgY2xhc3MgUGx1Z2luRGF0YWJh
c2UgOiBwdWJsaWMgTm9uY29weWFibGUgewogICAgIHB1YmxpYzoKICAgICAgICAgUGx1Z2luRGF0
YWJhc2UoKTsKIApJbmRleDogV2ViQ29yZS9wbHVnaW5zL1BsdWdpbk1haW5UaHJlYWRTY2hlZHVs
ZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsdWdpbnMvUGx1Z2luTWFpblRocmVhZFNjaGVk
dWxlci5oCShyZXZpc2lvbiA1MTMzNykKKysrIFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5NYWluVGhy
ZWFkU2NoZWR1bGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDcgKzM2LDcgQEAgdHlwZWRlZiBO
UFBfdCogTlBQOwogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLWNsYXNzIFBsdWdpbk1haW5UaHJl
YWRTY2hlZHVsZXIgeworY2xhc3MgUGx1Z2luTWFpblRocmVhZFNjaGVkdWxlciA6IHB1YmxpYyBO
b25jb3B5YWJsZSB7CiBwdWJsaWM6CiAgICAgdHlwZWRlZiB2b2lkIE1haW5UaHJlYWRGdW5jdGlv
bih2b2lkKik7CiAKSW5kZXg6IFdlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaAkocmV2aXNpb24gNTEzMzcpCisrKyBX
ZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC04NCw3ICs4NCw3
IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgUGx1Z2luU3RhdHVzTG9hZGVkU3VjY2Vz
c2Z1bGx5CiAgICAgfTsKIAotICAgIGNsYXNzIFBsdWdpblJlcXVlc3QgeworICAgIGNsYXNzIFBs
dWdpblJlcXVlc3QgOiBwdWJsaWMgTm9uY29weWFibGUgewogICAgIHB1YmxpYzoKICAgICAgICAg
UGx1Z2luUmVxdWVzdChjb25zdCBGcmFtZUxvYWRSZXF1ZXN0JiBmcmFtZUxvYWRSZXF1ZXN0LCBi
b29sIHNlbmROb3RpZmljYXRpb24sIHZvaWQqIG5vdGlmeURhdGEsIGJvb2wgc2hvdWxkQWxsb3dQ
b3B1cHMpCiAgICAgICAgICAgICA6IG1fZnJhbWVMb2FkUmVxdWVzdChmcmFtZUxvYWRSZXF1ZXN0
KQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQXJlbmEuaAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX
ZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJBcmVuYS5oCShyZXZpc2lvbiA1MTMzNykKKysrIFdlYkNv
cmUvcmVuZGVyaW5nL1JlbmRlckFyZW5hLmgJKHdvcmtpbmcgY29weSkKQEAgLTM2LDEyICszNiwx
MyBAQAogI2RlZmluZSBSZW5kZXJBcmVuYV9oCiAKICNpbmNsdWRlICJBcmVuYS5oIgorI2luY2x1
ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIHN0YXRpYyBj
b25zdCBzaXplX3QgZ01heFJlY3ljbGVkU2l6ZSA9IDQwMDsKIAotY2xhc3MgUmVuZGVyQXJlbmEg
eworY2xhc3MgUmVuZGVyQXJlbmEgOiBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgogICAg
IFJlbmRlckFyZW5hKHVuc2lnbmVkIGFyZW5hU2l6ZSA9IDQwOTYpOwogICAgIH5SZW5kZXJBcmVu
YSgpOwpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suY3BwCj09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K
LS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmNwcAkocmV2aXNpb24gNTEzMzcpCisr
KyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTU4
LDcgKzU4LDcgQEAgc3RhdGljIGNvbnN0IGludCB2ZXJ0aWNhbExpbmVDbGlja0Z1ZGdlRgogCiB1
c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwogCi1zdHJ1Y3QgQ29sdW1uSW5mbyB7CitzdHJ1Y3Qg
Q29sdW1uSW5mbyA6IHB1YmxpYyBOb25jb3B5YWJsZSB7CiAgICAgQ29sdW1uSW5mbygpCiAgICAg
ICAgIDogbV9kZXNpcmVkQ29sdW1uV2lkdGgoMCkKICAgICAgICAgLCBtX2Rlc2lyZWRDb2x1bW5D
b3VudCgxKQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQmxvY2suaAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9jay5oCShyZXZpc2lvbiA1MTMzNykKKysr
IFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJsb2NrLmgJKHdvcmtpbmcgY29weSkKQEAgLTM3NCw3
ICszNzQsNyBAQCBwcml2YXRlOgogCiAgICAgdm9pZCB1cGRhdGVTY3JvbGxJbmZvQWZ0ZXJMYXlv
dXQoKTsKIAotICAgIHN0cnVjdCBGbG9hdGluZ09iamVjdCB7CisgICAgc3RydWN0IEZsb2F0aW5n
T2JqZWN0IDogTm9uY29weWFibGUgewogICAgICAgICBlbnVtIFR5cGUgewogICAgICAgICAgICAg
RmxvYXRMZWZ0LAogICAgICAgICAgICAgRmxvYXRSaWdodApAQCAtNDkwLDcgKzQ5MCw3IEBAIHBy
aXZhdGU6CiAgICAgUmVuZGVySW5saW5lKiBtX2lubGluZUNvbnRpbnVhdGlvbjsKIAogICAgIC8v
IEFsbG9jYXRlZCBvbmx5IHdoZW4gc29tZSBvZiB0aGVzZSBmaWVsZHMgaGF2ZSBub24tZGVmYXVs
dCB2YWx1ZXMKLSAgICBzdHJ1Y3QgTWF4TWFyZ2luIHsKKyAgICBzdHJ1Y3QgTWF4TWFyZ2luIDog
Tm9uY29weWFibGUgewogICAgICAgICBNYXhNYXJnaW4oY29uc3QgUmVuZGVyQmxvY2sqIG8pIAog
ICAgICAgICAgICAgOiBtX3RvcFBvcyh0b3BQb3NEZWZhdWx0KG8pKQogICAgICAgICAgICAgLCBt
X3RvcE5lZyh0b3BOZWdEZWZhdWx0KG8pKQpJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy
SW1hZ2UuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckltYWdlLmNw
cAkocmV2aXNpb24gNTEzMzcpCisrKyBXZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJJbWFnZS5jcHAJ
KHdvcmtpbmcgY29weSkKQEAgLTQ5LDcgKzQ5LDcgQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogc3Rh
dGljIGNvbnN0IGRvdWJsZSBjSW50ZXJwb2xhdGlvbkN1dG9mZiA9IDgwMC4gKiA4MDAuOwogc3Rh
dGljIGNvbnN0IGRvdWJsZSBjTG93UXVhbGl0eVRpbWVUaHJlc2hvbGQgPSAwLjA1MDsgLy8gNTAg
bXMKIAotY2xhc3MgUmVuZGVySW1hZ2VTY2FsZURhdGEgeworY2xhc3MgUmVuZGVySW1hZ2VTY2Fs
ZURhdGEgOiBwdWJsaWMgTm9uY29weWFibGUgewogcHVibGljOgogICAgIFJlbmRlckltYWdlU2Nh
bGVEYXRhKFJlbmRlckltYWdlKiBpbWFnZSwgY29uc3QgSW50U2l6ZSYgc2l6ZSwgZG91YmxlIHRp
bWUsIGJvb2wgbG93UXVhbGl0eVNjYWxlKQogICAgICAgICA6IG1fc2l6ZShzaXplKQpJbmRleDog
V2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyTWFycXVlZS5oCj09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv
cmVuZGVyaW5nL1JlbmRlck1hcnF1ZWUuaAkocmV2aXNpb24gNTEzMzcpCisrKyBXZWJDb3JlL3Jl
bmRlcmluZy9SZW5kZXJNYXJxdWVlLmgJKHdvcmtpbmcgY29weSkKQEAgLTUzLDcgKzUzLDcgQEAg
bmFtZXNwYWNlIFdlYkNvcmUgewogY2xhc3MgUmVuZGVyTGF5ZXI7CiAKIC8vIFRoaXMgY2xhc3Mg
aGFuZGxlcyB0aGUgYXV0by1zY3JvbGxpbmcgb2YgbGF5ZXJzIHdpdGggb3ZlcmZsb3c6IG1hcnF1
ZWUuCi1jbGFzcyBSZW5kZXJNYXJxdWVlIHsKK2NsYXNzIFJlbmRlck1hcnF1ZWUgOiBwdWJsaWMg
Tm9uY29weWFibGUgewogcHVibGljOgogICAgIFJlbmRlck1hcnF1ZWUoUmVuZGVyTGF5ZXIqKTsK
IApJbmRleDogV2ViQ29yZS9yZW5kZXJpbmcvVGFibGVMYXlvdXQuaAo9PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX
ZWJDb3JlL3JlbmRlcmluZy9UYWJsZUxheW91dC5oCShyZXZpc2lvbiA1MTMzNykKKysrIFdlYkNv
cmUvcmVuZGVyaW5nL1RhYmxlTGF5b3V0LmgJKHdvcmtpbmcgY29weSkKQEAgLTIxLDExICsyMSwx
MyBAQAogI2lmbmRlZiBUYWJsZUxheW91dF9oCiAjZGVmaW5lIFRhYmxlTGF5b3V0X2gKIAorI2lu
Y2x1ZGUgPHd0Zi9Ob25jb3B5YWJsZS5oPgorCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNz
IFJlbmRlclRhYmxlOwogCi1jbGFzcyBUYWJsZUxheW91dCB7CitjbGFzcyBUYWJsZUxheW91dCA6
IHB1YmxpYyBOb25jb3B5YWJsZSB7CiBwdWJsaWM6CiAgICAgVGFibGVMYXlvdXQoUmVuZGVyVGFi
bGUqIHRhYmxlKQogICAgICAgICA6IG1fdGFibGUodGFibGUpCg==
</data>
<flag name="review"
          id="25491"
          type_id="1"
          status="+"
          setter="eric"
    />
          </attachment>
      

    </bug>

</bugzilla>