31820 2009-11-23 22:00:20 -0800 [Chromium] Ignore line-height CSS property for search fields 2009-11-24 18:16:50 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 tkent tkent commit-queue oldest_to_newest 166000 0 tkent 2009-11-23 22:00:20 -0800 http://crbug.com/20551 LayoutTests/fast/forms/control-restrict-line-height.html checks that the following controls should ignore line-height CSS property, and Chromium/Windows and Chromium/Linux don't ignore it for button and search. - <select> - <input type=button> - <input type=search> This bug addresses the type=search case. 166005 1 43750 tkent 2009-11-23 23:04:43 -0800 Created attachment 43750 Proposed patch Chromium try logs: Linux: http://build.chromium.org/buildbot/try-server/builders/layout_linux/builds/746 Windows: http://build.chromium.org/buildbot/try-server/builders/layout_win/builds/734 166128 2 43750 eric 2009-11-24 10:00:25 -0800 Comment on attachment 43750 Proposed patch OK, looks sane. 166323 3 43750 commit-queue 2009-11-24 18:16:45 -0800 Comment on attachment 43750 Proposed patch Clearing flags on attachment: 43750 Committed r51368: <http://trac.webkit.org/changeset/51368> 166324 4 commit-queue 2009-11-24 18:16:50 -0800 All reviewed patches have been landed. Closing bug. 43750 2009-11-23 23:04:43 -0800 2009-11-24 18:16:45 -0800 Proposed patch 0001-search-lineheight-1.patch text/plain 2528 tkent ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2ZmYmExZC4uZTM2OWUzMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAwOS0xMS0yMyAgS2VudCBUYW11cmEg IDx0a2VudEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW0Nocm9taXVtXSBJZ25vcmUgbGluZS1oZWlnaHQgQ1NTIHByb3BlcnR5 IHNwZWNpZmllZCB0byBhIHNlYXJjaCBmaWVsZCBvbgorICAgICAgICBXaW5kb3dzIGFuZCBMaW51 eC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODIw CisKKyAgICAgICAgTGF5b3V0VGVzdHMvZmFzdC9mb3Jtcy9jb250cm9sLXJlc3RyaWN0LWxpbmUt aGVpZ2h0Lmh0bWwgY2hlY2tzIHRoYXQgdGhlCisgICAgICAgIGZvbGxvd2luZyBjb250cm9scyBz aG91bGQgaWdub3JlIGxpbmUtaGVpZ2h0IENTUyBwcm9wZXJ0eS4KKyAgICAgICAgIC0gPHNlbGVj dD4KKyAgICAgICAgIC0gPGlucHV0IHR5cGU9YnV0dG9uPgorICAgICAgICAgLSA8aW5wdXQgdHlw ZT1zZWFyY2g+CisgICAgICAgIFRoaXMgY2hhbmdlIGFkZHJlc3NlcyB0aGUgPGlucHV0IHR5cGU9 c2VhcmNoPiBpc3N1ZSB3aXRoIENocm9taXVtL1dpbmRvd3MKKyAgICAgICAgYW5kIENocm9taXVt L0xpbnV4LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclRoZW1lQ2hyb21pdW1Ta2lhOjphZGp1c3RTZWFy Y2hGaWVsZFN0eWxlKTogSW1wbGVtZW50IHRoaXMgdG8gaWdub3JlIGxpbmUtaGVpZ2h0LgorICAg ICAgICAqIHJlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oOiBEZWNsYXJlIGFkanVz dFNlYXJjaEZpZWxkU3R5bGUoKS4KKwogMjAwOS0xMS0yMyAgQWFyb24gR29sZGVuICA8YWdvbGRl bkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3NrdXJ5YWtvdi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNw cCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21pdW1Ta2lhLmNwcAppbmRleCBi NTgyYzE4Li44NmNkNzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVt ZUNocm9taXVtU2tpYS5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVDaHJv bWl1bVNraWEuY3BwCkBAIC0zNTgsNiArMzU4LDEyIEBAIGJvb2wgUmVuZGVyVGhlbWVDaHJvbWl1 bVNraWE6OnBhaW50VGV4dEFyZWEoUmVuZGVyT2JqZWN0KiBvLCBjb25zdCBSZW5kZXJPYmplY3Q6 CiAgICAgcmV0dXJuIHBhaW50VGV4dEZpZWxkKG8sIGksIHIpOwogfQogCit2b2lkIFJlbmRlclRo ZW1lQ2hyb21pdW1Ta2lhOjphZGp1c3RTZWFyY2hGaWVsZFN0eWxlKENTU1N0eWxlU2VsZWN0b3Iq LCBSZW5kZXJTdHlsZSogc3R5bGUsIEVsZW1lbnQqKSBjb25zdAoreworICAgICAvLyBJZ25vcmUg bGluZS1oZWlnaHQuCisgICAgIHN0eWxlLT5zZXRMaW5lSGVpZ2h0KFJlbmRlclN0eWxlOjppbml0 aWFsTGluZUhlaWdodCgpKTsKK30KKwogYm9vbCBSZW5kZXJUaGVtZUNocm9taXVtU2tpYTo6cGFp bnRTZWFyY2hGaWVsZChSZW5kZXJPYmplY3QqIG8sIGNvbnN0IFJlbmRlck9iamVjdDo6UGFpbnRJ bmZvJiBpLCBjb25zdCBJbnRSZWN0JiByKQogewogICAgIHJldHVybiBwYWludFRleHRGaWVsZChv LCBpLCByKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRoZW1lQ2hyb21p dW1Ta2lhLmggYi9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUaGVtZUNocm9taXVtU2tpYS5oCmlu ZGV4IDk4ZTNhMzUuLjI0MWU4MzYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRoZW1lQ2hyb21pdW1Ta2lhLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGhlbWVD aHJvbWl1bVNraWEuaApAQCAtNzYsNiArNzYsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAg ICAgICAgdmlydHVhbCBib29sIHBhaW50VGV4dEFyZWEoUmVuZGVyT2JqZWN0KiwgY29uc3QgUmVu ZGVyT2JqZWN0OjpQYWludEluZm8mLCBjb25zdCBJbnRSZWN0Jik7CiAKKyAgICAgICAgdmlydHVh bCB2b2lkIGFkanVzdFNlYXJjaEZpZWxkU3R5bGUoQ1NTU3R5bGVTZWxlY3RvciosIFJlbmRlclN0 eWxlKiwgRWxlbWVudCopIGNvbnN0OwogICAgICAgICB2aXJ0dWFsIGJvb2wgcGFpbnRTZWFyY2hG aWVsZChSZW5kZXJPYmplY3QqLCBjb25zdCBSZW5kZXJPYmplY3Q6OlBhaW50SW5mbyYsIGNvbnN0 IEludFJlY3QmKTsKIAogICAgICAgICB2aXJ0dWFsIHZvaWQgYWRqdXN0U2VhcmNoRmllbGRDYW5j ZWxCdXR0b25TdHlsZShDU1NTdHlsZVNlbGVjdG9yKiwgUmVuZGVyU3R5bGUqLCBFbGVtZW50Kikg Y29uc3Q7Ci0tIAoxLjYuMy4zCgo=