31818 2009-11-23 20:16:03 -0800 scm_unittest.py is too slow 2009-12-15 00:57:53 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth evan webkit.review.bot oldest_to_newest 165986 0 eric 2009-11-23 20:16:03 -0800 scm_unittest.py is too slow If you run run-webkit-unittests -v you'll see that we spend basically all of our time running the unit tests running the scm usit tests. This is because we create a new svn and git repository on every test and that's slow. We should find a better way to opt-in to creating a new repository so that we can have faster overall testing. 171744 1 44851 abarth 2009-12-15 00:27:18 -0800 Created attachment 44851 Patch 171745 2 webkit.review.bot 2009-12-15 00:28:03 -0800 style-queue ran check-webkit-style on attachment 44851 without any errors. 171746 3 44851 eric 2009-12-15 00:31:17 -0800 Comment on attachment 44851 Patch You might consider using .remove() instead. Also needs a #HACK or #FIXME comment. 171749 4 abarth 2009-12-15 00:57:53 -0800 Committed r52142: <http://trac.webkit.org/changeset/52142> 44851 2009-12-15 00:27:18 -0800 2009-12-15 00:31:16 -0800 Patch bug-31818-20091215002716.patch text/plain 1640 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2ZTY2NjUwLi5kMjI5ZjQwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTIt MTUgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBzY21fdW5pdHRlc3QucHkgaXMgdG9vIHNsb3cK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODE4CisK KyAgICAgICAgTm93IHdlIGRvbid0IHJ1biB0aGUgU0NNIHVuaXQgdGVzdHMgdW5sZXNzIHdlIGdl dCB0aGUgLS1hbGwgZmxhZyBvbiB0aGUKKyAgICAgICAgY29tbWFuZCBsaW5lLiAgRXJpYyBhbmQg SSB3ZXJlIGNvbW1lbnRpbmcgb3V0IHRoaXMgdGVzdCBiZWNhdXNlIGl0IHdhcworICAgICAgICB0 b28gcGFpbmZ1bCB0byBydW4uCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi13ZWJraXQtdW5pdHRl c3RzOgorCiAyMDA5LTEyLTE0ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZC4gIEZpeCBmYWlsaW5nIHVuaXR0ZXN0LgpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXVuaXR0ZXN0cyBiL1dlYktpdFRvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC11bml0dGVzdHMKaW5kZXggNTQ1OTE2OC4uZjA4Njg2MCAxMDA3NTUKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXVuaXR0ZXN0cworKysgYi9XZWJLaXRU b29scy9TY3JpcHRzL3J1bi13ZWJraXQtdW5pdHRlc3RzCkBAIC0yNyw2ICsyNyw3IEBACiAjIChJ TkNMVURJTkcgTkVHTElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQg T0YgVEhFIFVTRQogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgogCitpbXBvcnQgc3lzCiBpbXBvcnQgdW5pdHRlc3QK IAogZnJvbSBtb2R1bGVzLmJ1Z3ppbGxhX3VuaXR0ZXN0IGltcG9ydCAqCkBAIC00Miw5ICs0Mywx MiBAQCBmcm9tIG1vZHVsZXMuY3BwX3N0eWxlX3VuaXR0ZXN0IGltcG9ydCAqCiBmcm9tIG1vZHVs ZXMuZGlmZl9wYXJzZXJfdW5pdHRlc3QgaW1wb3J0ICoKIGZyb20gbW9kdWxlcy5sb2dnaW5nX3Vu aXR0ZXN0IGltcG9ydCAqCiBmcm9tIG1vZHVsZXMubXVsdGljb21tYW5kdG9vbF91bml0dGVzdCBp bXBvcnQgKgotZnJvbSBtb2R1bGVzLnNjbV91bml0dGVzdCBpbXBvcnQgKgogZnJvbSBtb2R1bGVz LndlYmtpdHBvcnRfdW5pdHRlc3QgaW1wb3J0ICoKIGZyb20gbW9kdWxlcy53b3JrcXVldWVfdW5p dHRlc3QgaW1wb3J0ICoKIAogaWYgX19uYW1lX18gPT0gIl9fbWFpbl9fIjoKKyAgICBpZiBsZW4o c3lzLmFyZ3YpID4gMSBhbmQgc3lzLmFyZ3ZbMV0gPT0gIi0tYWxsIjoKKyAgICAgICAgc3lzLmFy Z3YgPSBbc3lzLmFyZ3ZbMF1dICsgc3lzLmFyZ3ZbMjpdCisgICAgICAgIGZyb20gbW9kdWxlcy5z Y21fdW5pdHRlc3QgaW1wb3J0ICoKKwogICAgIHVuaXR0ZXN0Lm1haW4oKQo=