31812 2009-11-23 13:50:13 -0800 WebSocket code uses RefPtr::get() where it shouldn't 2009-11-23 13:54:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P4 Trivial --- 1 ap ap ukai oldest_to_newest 165921 0 ap 2009-11-23 13:50:13 -0800 There is no need to get() when comparing RefPtrs. 165923 1 43733 ap 2009-11-23 13:51:31 -0800 Created attachment 43733 proposed patch 165924 2 43733 oliver 2009-11-23 13:52:05 -0800 Comment on attachment 43733 proposed patch r=me! 165926 3 ap 2009-11-23 13:54:34 -0800 Committed revision 51317. 43733 2009-11-23 13:51:31 -0800 2009-11-23 13:52:05 -0800 proposed patch BadGet.txt text/plain 4704 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTMxNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjUgQEAKKzIwMDktMTEtMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBs ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODEyCisgICAgICAgIFdl YlNvY2tldCBjb2RlIHVzZXMgUmVmUHRyOjpnZXQoKSB3aGVyZSBpdCBzaG91bGRuJ3QKKworICAg ICAgICBObyBjaGFuZ2UgaW4gZnVuY2l0b25hbGl0eSwganVzdCBjb2Rpbmcgc3R5bGUgY29ycmVj dGlvbi4KKworICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OldlYlNvY2tldDo6fldlYlNvY2tldCk6CisgICAgICAgICogd2Vic29ja2V0cy9XZWJT b2NrZXRDaGFubmVsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OldlYlNvY2tldENoYW5uZWw6OmNv bm5lY3QpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6c2VuZCk6CisgICAg ICAgIChXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpidWZmZXJlZEFtb3VudCk6CisgICAgICAg IChXZWJDb3JlOjpXZWJTb2NrZXRDaGFubmVsOjpjbG9zZSk6CisgICAgICAgIChXZWJDb3JlOjpX ZWJTb2NrZXRDaGFubmVsOjpkaXNjb25uZWN0KToKKyAgICAgICAgKFdlYkNvcmU6OldlYlNvY2tl dENoYW5uZWw6OmRpZE9wZW4pOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6 ZGlkQ2xvc2UpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2 ZURhdGEpOgorICAgICAgICAoV2ViQ29yZTo6V2ViU29ja2V0Q2hhbm5lbDo6ZGlkRmFpbCk6CisK IDIwMDktMTEtMjMgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEBhcHBsZS5jb20+CiAKSW5kZXg6 IFdlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv d2Vic29ja2V0cy9XZWJTb2NrZXQuY3BwCShyZXZpc2lvbiA1MTMxMykKKysrIFdlYkNvcmUvd2Vi c29ja2V0cy9XZWJTb2NrZXQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTAsNyArMTEwLDcgQEAg V2ViU29ja2V0OjpXZWJTb2NrZXQoU2NyaXB0RXhlY3V0aW9uQ29udAogCiBXZWJTb2NrZXQ6On5X ZWJTb2NrZXQoKQogewotICAgIGlmIChtX2NoYW5uZWwuZ2V0KCkpCisgICAgaWYgKG1fY2hhbm5l bCkKICAgICAgICAgbV9jaGFubmVsLT5kaXNjb25uZWN0KCk7CiB9CiAKSW5kZXg6IFdlYkNvcmUv d2Vic29ja2V0cy9XZWJTb2NrZXRDaGFubmVsLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dl YnNvY2tldHMvV2ViU29ja2V0Q2hhbm5lbC5jcHAJKHJldmlzaW9uIDUxMzEzKQorKysgV2ViQ29y ZS93ZWJzb2NrZXRzL1dlYlNvY2tldENoYW5uZWwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02OSw3 ICs2OSw3IEBAIFdlYlNvY2tldENoYW5uZWw6On5XZWJTb2NrZXRDaGFubmVsKCkKIHZvaWQgV2Vi U29ja2V0Q2hhbm5lbDo6Y29ubmVjdCgpCiB7CiAgICAgTE9HKE5ldHdvcmssICJXZWJTb2NrZXRD aGFubmVsICVwIGNvbm5lY3QiLCB0aGlzKTsKLSAgICBBU1NFUlQoIW1faGFuZGxlLmdldCgpKTsK KyAgICBBU1NFUlQoIW1faGFuZGxlKTsKICAgICBtX2hhbmRzaGFrZS5yZXNldCgpOwogICAgIHJl ZigpOwogICAgIG1faGFuZGxlID0gU29ja2V0U3RyZWFtSGFuZGxlOjpjcmVhdGUobV9oYW5kc2hh a2UudXJsKCksIHRoaXMpOwpAQCAtODIsNyArODIsNyBAQCBib29sIFdlYlNvY2tldENoYW5uZWw6 OnNlbmQoY29uc3QgU3RyaW5nCiAgICAgYnVmLmFwcGVuZCgnXDAnKTsgIC8vIGZyYW1lIHR5cGUK ICAgICBidWYuYXBwZW5kKG1zZy51dGY4KCkuZGF0YSgpLCBtc2cudXRmOCgpLmxlbmd0aCgpKTsK ICAgICBidWYuYXBwZW5kKCdceGZmJyk7ICAvLyBmcmFtZSBlbmQKLSAgICBpZiAoIW1faGFuZGxl LmdldCgpKSB7CisgICAgaWYgKCFtX2hhbmRsZSkgewogICAgICAgICBtX3VuaGFuZGxlZEJ1ZmZl clNpemUgKz0gYnVmLnNpemUoKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KQEAgLTky LDcgKzkyLDcgQEAgYm9vbCBXZWJTb2NrZXRDaGFubmVsOjpzZW5kKGNvbnN0IFN0cmluZwogdW5z aWduZWQgbG9uZyBXZWJTb2NrZXRDaGFubmVsOjpidWZmZXJlZEFtb3VudCgpIGNvbnN0CiB7CiAg ICAgTE9HKE5ldHdvcmssICJXZWJTb2NrZXRDaGFubmVsICVwIGJ1ZmZlcmVkQW1vdW50IiwgdGhp cyk7Ci0gICAgaWYgKCFtX2hhbmRsZS5nZXQoKSkKKyAgICBpZiAoIW1faGFuZGxlKQogICAgICAg ICByZXR1cm4gbV91bmhhbmRsZWRCdWZmZXJTaXplOwogICAgIHJldHVybiBtX2hhbmRsZS0+YnVm ZmVyZWRBbW91bnQoKTsKIH0KQEAgLTEwMCw3ICsxMDAsNyBAQCB1bnNpZ25lZCBsb25nIFdlYlNv Y2tldENoYW5uZWw6OmJ1ZmZlcmVkCiB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmNsb3NlKCkKIHsK ICAgICBMT0coTmV0d29yaywgIldlYlNvY2tldENoYW5uZWwgJXAgY2xvc2UiLCB0aGlzKTsKLSAg ICBpZiAobV9oYW5kbGUuZ2V0KCkpCisgICAgaWYgKG1faGFuZGxlKQogICAgICAgICBtX2hhbmRs ZS0+Y2xvc2UoKTsgIC8vIHdpbGwgY2FsbCBkaWRDbG9zZSgpCiB9CiAKQEAgLTEwOCwxNCArMTA4 LDE0IEBAIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlzY29ubmVjdCgpCiB7CiAgICAgTE9HKE5l dHdvcmssICJXZWJTb2NrZXRDaGFubmVsICVwIGRpc2Nvbm5lY3QiLCB0aGlzKTsKICAgICBtX2Ns aWVudCA9IDA7Ci0gICAgaWYgKG1faGFuZGxlLmdldCgpKQorICAgIGlmIChtX2hhbmRsZSkKICAg ICAgICAgbV9oYW5kbGUtPmNsb3NlKCk7CiB9CiAKIHZvaWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlk T3BlbihTb2NrZXRTdHJlYW1IYW5kbGUqIGhhbmRsZSkKIHsKICAgICBMT0coTmV0d29yaywgIldl YlNvY2tldENoYW5uZWwgJXAgZGlkT3BlbiIsIHRoaXMpOwotICAgIEFTU0VSVChoYW5kbGUgPT0g bV9oYW5kbGUuZ2V0KCkpOworICAgIEFTU0VSVChoYW5kbGUgPT0gbV9oYW5kbGUpOwogICAgIGNv bnN0IENTdHJpbmcmIGhhbmRzaGFrZU1lc3NhZ2UgPSBtX2hhbmRzaGFrZS5jbGllbnRIYW5kc2hh a2VNZXNzYWdlKCk7CiAgICAgaWYgKCFoYW5kbGUtPnNlbmQoaGFuZHNoYWtlTWVzc2FnZS5kYXRh KCksIGhhbmRzaGFrZU1lc3NhZ2UubGVuZ3RoKCkpKSB7CiAgICAgICAgIExPRyhOZXR3b3JrLCAi RXJyb3IgaW4gc2VuZGluZyBoYW5kc2hha2UgbWVzc2FnZS4iKTsKQEAgLTEyNiw4ICsxMjYsOCBA QCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZE9wZW4oU29ja2V0U3RyCiB2b2lkIFdlYlNvY2tl dENoYW5uZWw6OmRpZENsb3NlKFNvY2tldFN0cmVhbUhhbmRsZSogaGFuZGxlKQogewogICAgIExP RyhOZXR3b3JrLCAiV2ViU29ja2V0Q2hhbm5lbCAlcCBkaWRDbG9zZSIsIHRoaXMpOwotICAgIEFT U0VSVChoYW5kbGUgPT0gbV9oYW5kbGUuZ2V0KCkgfHwgIW1faGFuZGxlLmdldCgpKTsKLSAgICBp ZiAobV9oYW5kbGUuZ2V0KCkpIHsKKyAgICBBU1NFUlQoaGFuZGxlID09IG1faGFuZGxlIHx8ICFt X2hhbmRsZSk7CisgICAgaWYgKG1faGFuZGxlKSB7CiAgICAgICAgIG1fdW5oYW5kbGVkQnVmZmVy U2l6ZSA9IGhhbmRsZS0+YnVmZmVyZWRBbW91bnQoKTsKICAgICAgICAgV2ViU29ja2V0Q2hhbm5l bENsaWVudCogY2xpZW50ID0gbV9jbGllbnQ7CiAgICAgICAgIG1fY2xpZW50ID0gMDsKQEAgLTE0 MSw3ICsxNDEsNyBAQCB2b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZENsb3NlKFNvY2tldFN0CiB2 b2lkIFdlYlNvY2tldENoYW5uZWw6OmRpZFJlY2VpdmVEYXRhKFNvY2tldFN0cmVhbUhhbmRsZSog aGFuZGxlLCBjb25zdCBjaGFyKiBkYXRhLCBpbnQgbGVuKQogewogICAgIExPRyhOZXR3b3JrLCAi V2ViU29ja2V0Q2hhbm5lbCAlcCBkaWRSZWNlaXZlRGF0YSAlZCIsIHRoaXMsIGxlbik7Ci0gICAg QVNTRVJUKGhhbmRsZSA9PSBtX2hhbmRsZS5nZXQoKSk7CisgICAgQVNTRVJUKGhhbmRsZSA9PSBt X2hhbmRsZSk7CiAgICAgaWYgKCFhcHBlbmRUb0J1ZmZlcihkYXRhLCBsZW4pKSB7CiAgICAgICAg IGhhbmRsZS0+Y2xvc2UoKTsKICAgICAgICAgcmV0dXJuOwpAQCAtMjE3LDcgKzIxNyw3IEBAIHZv aWQgV2ViU29ja2V0Q2hhbm5lbDo6ZGlkUmVjZWl2ZURhdGEoU28KIHZvaWQgV2ViU29ja2V0Q2hh bm5lbDo6ZGlkRmFpbChTb2NrZXRTdHJlYW1IYW5kbGUqIGhhbmRsZSwgY29uc3QgU29ja2V0U3Ry ZWFtRXJyb3ImKQogewogICAgIExPRyhOZXR3b3JrLCAiV2ViU29ja2V0Q2hhbm5lbCAlcCBkaWRG YWlsIiwgdGhpcyk7Ci0gICAgQVNTRVJUKGhhbmRsZSA9PSBtX2hhbmRsZS5nZXQoKSB8fCAhbV9o YW5kbGUuZ2V0KCkpOworICAgIEFTU0VSVChoYW5kbGUgPT0gbV9oYW5kbGUgfHwgIW1faGFuZGxl KTsKICAgICBoYW5kbGUtPmNsb3NlKCk7CiB9CiAK