31811 2009-11-23 12:53:28 -0800 Accidental calls to EventNames() instead of eventNames() waste CPU cycles 2009-11-23 14:26:07 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Performance P3 Minor --- 1 jens jens oldest_to_newest 165902 0 jens 2009-11-23 12:53:28 -0800 I just discovered five places in WebCore that accidentally call EventNames() when they mean eventNames(). The end result of the call will be the same, but the mistaken call is a constructor that creates about 100 AtomicString instances every time it's called. 165933 1 43734 jens 2009-11-23 14:16:21 -0800 Created attachment 43734 patch 165934 2 43734 ggaren 2009-11-23 14:20:02 -0800 Comment on attachment 43734 patch r=me 165935 3 jens 2009-11-23 14:26:02 -0800 Committed revision 51321. 43734 2009-11-23 14:16:21 -0800 2009-11-23 14:20:02 -0800 patch EventNames.patch text/plain 5318 jens SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTMxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjIgQEAKKzIwMDktMTEtMjMgIEplbnMgQWxma2UgIDxzbmVqQGNocm9taXVtLm9y Zz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDaGFu Z2UgaW5jb3JyZWN0IGNhbGxzIHRvIHRoZSBjb25zdHJ1Y3RvciAiRXZlbnROYW1lcygpIiB0byB0 aGUgY29ycmVjdCBhY2Nlc3NvcgorICAgICAgICAiZXZlbnROYW1lcygpIi4gVGhpcyBzYXZlcyB+ MTAwIEF0b21pY1N0cmluZyBsb29rdXBzIGVhY2ggdGltZS4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODExCisKKyAgICAgICAgKiBkb20vRXZlbnRO YW1lcy5oOiAgTWFrZSBjb25zdHJ1Y3RvciBwcml2YXRlIHRvIHByZXZlbnQgdGhpcyBmcm9tIGhh cHBlbmluZyBhZ2Fpbi4KKyAgICAgICAgKiBoaXN0b3J5L0NhY2hlZEZyYW1lLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNhY2hlZEZyYW1lQmFzZTo6cmVzdG9yZSk6ICBFdmVudE5hbWVzKCkgLS0+ IGV2ZW50TmFtZXMoKQorICAgICAgICAqIGh0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpjaGVja1ZhbGlkaXR5 KTogIEV2ZW50TmFtZXMoKSAtLT4gZXZlbnROYW1lcygpCisgICAgICAgICogbG9hZGVyL0ZyYW1l TG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyOjpzdG9wTG9hZGluZyk6 ICBFdmVudE5hbWVzKCkgLS0+IGV2ZW50TmFtZXMoKQorICAgICAgICAoV2ViQ29yZTo6RnJhbWVM b2FkZXI6OnBhZ2VIaWRkZW4pOiAgRXZlbnROYW1lcygpIC0tPiBldmVudE5hbWVzKCkKKyAgICAg ICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OmRp c3BhdGNoQWxsUGVuZGluZ1VubG9hZEV2ZW50cyk6ICBFdmVudE5hbWVzKCkgLS0+IGV2ZW50TmFt ZXMoKQorCiAyMDA5LTExLTIzICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgog CiAgICAgICAgIEJ1aWxkIGZpeC4KSW5kZXg6IFdlYkNvcmUvZG9tL0V2ZW50TmFtZXMuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9FdmVudE5hbWVzLmgJKHJldmlzaW9uIDUxMjUzKQorKysg V2ViQ29yZS9kb20vRXZlbnROYW1lcy5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDksMTAgKzE0OSwx MSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBjbGFzcyBFdmVudE5hbWVzIDogcHVibGlj IE5vbmNvcHlhYmxlIHsKICAgICAgICAgaW50IGR1bW15OyAvLyBOZWVkZWQgdG8gbWFrZSBpbml0 aWFsaXphdGlvbiBtYWNybyB3b3JrLgotCi0gICAgcHVibGljOgorICAgICAgICAvLyBQcml2YXRl IHRvIHByZXZlbnQgYWNjaWRlbnRhbCBjYWxsIHRvIEV2ZW50TmFtZXMoKSBpbnN0ZWFkIG9mIGV2 ZW50TmFtZXMoKQogICAgICAgICBFdmVudE5hbWVzKCk7CisgICAgICAgIGZyaWVuZCBjbGFzcyBU aHJlYWRHbG9iYWxEYXRhOwogCisgICAgcHVibGljOgogICAgICAgICAjZGVmaW5lIERPTV9FVkVO VF9OQU1FU19ERUNMQVJFKG5hbWUpIEF0b21pY1N0cmluZyBuYW1lIyNFdmVudDsKICAgICAgICAg RE9NX0VWRU5UX05BTUVTX0ZPUl9FQUNIKERPTV9FVkVOVF9OQU1FU19ERUNMQVJFKQogICAgICAg ICAjdW5kZWYgRE9NX0VWRU5UX05BTUVTX0RFQ0xBUkUKSW5kZXg6IFdlYkNvcmUvaGlzdG9yeS9D YWNoZWRGcmFtZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9oaXN0b3J5L0NhY2hlZEZyYW1l LmNwcAkocmV2aXNpb24gNTEyNTMpCisrKyBXZWJDb3JlL2hpc3RvcnkvQ2FjaGVkRnJhbWUuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC05OSw3ICs5OSw3IEBAIHZvaWQgQ2FjaGVkRnJhbWVCYXNlOjpy ZXN0b3JlKCkKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpIDwgbV9jaGlsZEZyYW1lcy5zaXpl KCk7ICsraSkKICAgICAgICAgbV9jaGlsZEZyYW1lc1tpXS0+b3BlbigpOwogCi0gICAgbV9kb2N1 bWVudC0+ZGlzcGF0Y2hXaW5kb3dFdmVudChQYWdlVHJhbnNpdGlvbkV2ZW50OjpjcmVhdGUoRXZl bnROYW1lcygpLnBhZ2VzaG93RXZlbnQsIHRydWUpLCBtX2RvY3VtZW50KTsKKyAgICBtX2RvY3Vt ZW50LT5kaXNwYXRjaFdpbmRvd0V2ZW50KFBhZ2VUcmFuc2l0aW9uRXZlbnQ6OmNyZWF0ZShldmVu dE5hbWVzKCkucGFnZXNob3dFdmVudCwgdHJ1ZSksIG1fZG9jdW1lbnQpOwogfQogCiBDYWNoZWRG cmFtZTo6Q2FjaGVkRnJhbWUoRnJhbWUqIGZyYW1lKQpJbmRleDogV2ViQ29yZS9odG1sL0hUTUxG b3JtQ29udHJvbEVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9IVE1MRm9y bUNvbnRyb2xFbGVtZW50LmNwcAkocmV2aXNpb24gNTEyNTMpCisrKyBXZWJDb3JlL2h0bWwvSFRN TEZvcm1Db250cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTI5Niw3ICsyOTYsNyBA QCBTdHJpbmcgSFRNTEZvcm1Db250cm9sRWxlbWVudDo6dmFsaWRhdGlvCiBib29sIEhUTUxGb3Jt Q29udHJvbEVsZW1lbnQ6OmNoZWNrVmFsaWRpdHkoKQogewogICAgIGlmICh3aWxsVmFsaWRhdGUo KSAmJiAhaXNWYWxpZEZvcm1Db250cm9sRWxlbWVudCgpKSB7Ci0gICAgICAgIGRpc3BhdGNoRXZl bnQoRXZlbnQ6OmNyZWF0ZShFdmVudE5hbWVzKCkuaW52YWxpZEV2ZW50LCBmYWxzZSwgdHJ1ZSkp OworICAgICAgICBkaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLmludmFs aWRFdmVudCwgZmFsc2UsIHRydWUpKTsKICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgIH0KIApJ bmRleDogV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNv cmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAkocmV2aXNpb24gNTEyNTMpCisrKyBXZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTUxMiw3ICs1MTIsNyBAQCB2 b2lkIEZyYW1lTG9hZGVyOjpzdG9wTG9hZGluZyhVbmxvYWRFdmVuCiAgICAgICAgICAgICAgICAg bV91bmxvYWRFdmVudEJlaW5nRGlzcGF0Y2hlZCA9IHRydWU7CiAgICAgICAgICAgICAgICAgaWYg KG1fZnJhbWUtPmRvbVdpbmRvdygpKSB7CiAgICAgICAgICAgICAgICAgICAgIGlmICh1bmxvYWRF dmVudFBvbGljeSA9PSBVbmxvYWRFdmVudFBvbGljeVVubG9hZEFuZFBhZ2VIaWRlKQotICAgICAg ICAgICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9tV2luZG93KCktPmRpc3BhdGNoRXZlbnQoUGFn ZVRyYW5zaXRpb25FdmVudDo6Y3JlYXRlKEV2ZW50TmFtZXMoKS5wYWdlaGlkZUV2ZW50LCBtX2Zy YW1lLT5kb2N1bWVudCgpLT5pblBhZ2VDYWNoZSgpKSwgbV9mcmFtZS0+ZG9jdW1lbnQoKSk7Cisg ICAgICAgICAgICAgICAgICAgICAgICBtX2ZyYW1lLT5kb21XaW5kb3coKS0+ZGlzcGF0Y2hFdmVu dChQYWdlVHJhbnNpdGlvbkV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnBhZ2VoaWRlRXZlbnQs IG1fZnJhbWUtPmRvY3VtZW50KCktPmluUGFnZUNhY2hlKCkpLCBtX2ZyYW1lLT5kb2N1bWVudCgp KTsKICAgICAgICAgICAgICAgICAgICAgaWYgKCFtX2ZyYW1lLT5kb2N1bWVudCgpLT5pblBhZ2VD YWNoZSgpKQogICAgICAgICAgICAgICAgICAgICAgICAgbV9mcmFtZS0+ZG9tV2luZG93KCktPmRp c3BhdGNoRXZlbnQoRXZlbnQ6OmNyZWF0ZShldmVudE5hbWVzKCkudW5sb2FkRXZlbnQsIGZhbHNl LCBmYWxzZSksIG1fZnJhbWUtPmRvbVdpbmRvdygpLT5kb2N1bWVudCgpKTsKICAgICAgICAgICAg ICAgICB9CkBAIC0zNjE2LDcgKzM2MTYsNyBAQCB2b2lkIEZyYW1lTG9hZGVyOjpwYWdlSGlkZGVu KCkKIHsKICAgICBtX3VubG9hZEV2ZW50QmVpbmdEaXNwYXRjaGVkID0gdHJ1ZTsKICAgICBpZiAo bV9mcmFtZS0+ZG9tV2luZG93KCkpCi0gICAgICAgIG1fZnJhbWUtPmRvbVdpbmRvdygpLT5kaXNw YXRjaEV2ZW50KFBhZ2VUcmFuc2l0aW9uRXZlbnQ6OmNyZWF0ZShFdmVudE5hbWVzKCkucGFnZWhp ZGVFdmVudCwgdHJ1ZSksIG1fZnJhbWUtPmRvY3VtZW50KCkpOworICAgICAgICBtX2ZyYW1lLT5k b21XaW5kb3coKS0+ZGlzcGF0Y2hFdmVudChQYWdlVHJhbnNpdGlvbkV2ZW50OjpjcmVhdGUoZXZl bnROYW1lcygpLnBhZ2VoaWRlRXZlbnQsIHRydWUpLCBtX2ZyYW1lLT5kb2N1bWVudCgpKTsKICAg ICBtX3VubG9hZEV2ZW50QmVpbmdEaXNwYXRjaGVkID0gZmFsc2U7CiAKICAgICAvLyBTZW5kIHBh Z2VoaWRlIGV2ZW50IGZvciBzdWJmcmFtZXMgYXMgd2VsbApJbmRleDogV2ViQ29yZS9wYWdlL0RP TVdpbmRvdy5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAJKHJl dmlzaW9uIDUxMjUzKQorKysgV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTI2Myw3ICsyNjMsNyBAQCB2b2lkIERPTVdpbmRvdzo6ZGlzcGF0Y2hBbGxQZW5kaW5n VW5sb2FkCiAgICAgICAgIGlmICghc2V0LmNvbnRhaW5zKHdpbmRvdykpCiAgICAgICAgICAgICBj b250aW51ZTsKIAotICAgICAgICB3aW5kb3ctPmRpc3BhdGNoRXZlbnQoUGFnZVRyYW5zaXRpb25F dmVudDo6Y3JlYXRlKEV2ZW50TmFtZXMoKS5wYWdlaGlkZUV2ZW50LCBmYWxzZSksIHdpbmRvdy0+ ZG9jdW1lbnQoKSk7CisgICAgICAgIHdpbmRvdy0+ZGlzcGF0Y2hFdmVudChQYWdlVHJhbnNpdGlv bkV2ZW50OjpjcmVhdGUoZXZlbnROYW1lcygpLnBhZ2VoaWRlRXZlbnQsIGZhbHNlKSwgd2luZG93 LT5kb2N1bWVudCgpKTsKICAgICAgICAgd2luZG93LT5kaXNwYXRjaEV2ZW50KEV2ZW50OjpjcmVh dGUoZXZlbnROYW1lcygpLnVubG9hZEV2ZW50LCBmYWxzZSwgZmFsc2UpLCB3aW5kb3ctPmRvY3Vt ZW50KCkpOwogICAgIH0KIAo=