31810 2009-11-23 10:45:33 -0800 [Android] Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost 2009-12-11 10:24:55 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 1 steveblock steveblock abarth android-webkit-unforking ap beidson commit-queue eric fishd mjs phanna steveblock oldest_to_newest 165881 0 steveblock 2009-11-23 10:45:33 -0800 Android port requires platform-specific implementation of initializeMaximumHTTPConnectionCountPerHost. 165882 1 43720 steveblock 2009-11-23 10:57:12 -0800 Created attachment 43720 Patch 1 for Bug 31810 165980 2 eric 2009-11-23 20:05:44 -0800 I thought the point of this default was less about what the loader was capable of, and more about "being a good web citizen" or something. Donno. I'm not an expert here. 166490 3 steveblock 2009-11-25 09:38:28 -0800 (In reply to comment #2) > I thought the point of this default was less about what the loader was capable > of, and more about "being a good web citizen" or something. Donno. I'm not an > expert here. The comment in loader.cpp for maxRequestsInFlightPerHost, and the comment in ResourceRequestBase.cpp for initializeMaximumHTTPConnectionCountPerHost both seem to suggest that the objective of this limit is to match the capability of the network layer. Can you point me to an expert who can confirm the intended use? 166491 4 eric 2009-11-25 09:42:04 -0800 Maciej or Bradey should know. 167349 5 abarth 2009-11-30 12:36:37 -0800 style-queue successfully ran check-webkit-style on attachment 43720 without any errors 170802 6 43720 fishd 2009-12-11 10:06:08 -0800 Comment on attachment 43720 Patch 1 for Bug 31810 This patch is fine. Given such a high limit on connection counts per host, you might also consider disabling the REQUEST_MANAGEMENT_ENABLED define in loader.cpp. 170818 7 43720 commit-queue 2009-12-11 10:24:50 -0800 Comment on attachment 43720 Patch 1 for Bug 31810 Clearing flags on attachment: 43720 Committed r52005: <http://trac.webkit.org/changeset/52005> 170819 8 commit-queue 2009-12-11 10:24:55 -0800 All reviewed patches have been landed. Closing bug. 43720 2009-11-23 10:57:12 -0800 2009-12-11 10:24:50 -0800 Patch 1 for Bug 31810 initializeMaximumHTTPConnectionCountPerHost.txt text/plain 3654 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTMxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMjMgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZHMgYW4gQW5kcm9pZC1zcGVjaWZpYyBpbXBsZW1lbnRhdGlvbiBvZiBpbml0aWFsaXplTWF4 aW11bUhUVFBDb25uZWN0aW9uQ291bnRQZXJIb3N0LgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE4MTAKKworICAgICAgICAqIHBsYXRmb3JtL25ldHdv cmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHA6IE1vZGlmaWVkLiBEaXNhYmxlIGRlZmF1bHQgaW1w bGVtZW50YXRpb24KKyAgICAgICAgICAgIG9mIGluaXRpYWxpemVNYXhpbXVtSFRUUENvbm5lY3Rp b25Db3VudFBlckhvc3QgZm9yIEFuZHJvaWQuCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9h bmRyb2lkOiBBZGRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2FuZHJvaWQvUmVzb3Vy Y2VSZXF1ZXN0QW5kcm9pZC5jcHA6IEFkZGVkLgorICAgICAgICAoV2ViQ29yZTo6aW5pdGlhbGl6 ZU1heGltdW1IVFRQQ29ubmVjdGlvbkNvdW50UGVySG9zdCk6IEFuZHJvaWQtc3BlY2lmaWMgaW1w bGVtZW50YXRpb24uCisKIDIwMDktMTEtMjMgIERpcmsgU2NodWx6ZSAgPGtyaXRAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1lcm1hbm4uCkluZGV4OiBXZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VSZXF1ZXN0QmFzZS5jcHAKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlUmVxdWVzdEJhc2UuY3BwCShyZXZp c2lvbiA1MTMxMCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9SZXNvdXJjZVJlcXVlc3RC YXNlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzc4LDcgKzM3OCw3IEBAIHZvaWQgUmVzb3VyY2VS ZXF1ZXN0QmFzZTo6dXBkYXRlUmVzb3VyY2UKICAgICBtX3Jlc291cmNlUmVxdWVzdFVwZGF0ZWQg PSB0cnVlOwogfQogCi0jaWYgIVBMQVRGT1JNKE1BQykgJiYgIVVTRShDRk5FVFdPUkspICYmICFV U0UoU09VUCkgJiYgIVBMQVRGT1JNKENIUk9NSVVNKQorI2lmICFQTEFURk9STShNQUMpICYmICFV U0UoQ0ZORVRXT1JLKSAmJiAhVVNFKFNPVVApICYmICFQTEFURk9STShDSFJPTUlVTSkgJiYgIVBM QVRGT1JNKEFORFJPSUQpCiB1bnNpZ25lZCBpbml0aWFsaXplTWF4aW11bUhUVFBDb25uZWN0aW9u Q291bnRQZXJIb3N0KCkKIHsKICAgICAvLyBUaGlzIGlzIHVzZWQgYnkgdGhlIGxvYWRlciB0byBj b250cm9sIHRoZSBudW1iZXIgb2YgaXNzdWVkIHBhcmFsbGVsIGxvYWQgcmVxdWVzdHMuIApJbmRl eDogV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2FuZHJvaWQvUmVzb3VyY2VSZXF1ZXN0QW5kcm9p ZC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2FuZHJvaWQvUmVz b3VyY2VSZXF1ZXN0QW5kcm9pZC5jcHAJKHJldmlzaW9uIDApCisrKyBXZWJDb3JlL3BsYXRmb3Jt L25ldHdvcmsvYW5kcm9pZC9SZXNvdXJjZVJlcXVlc3RBbmRyb2lkLmNwcAkocmV2aXNpb24gMCkK QEAgLTAsMCArMSwzOSBAQAorLyoKKyAqIENvcHlyaWdodCAyMDA5LCBUaGUgQW5kcm9pZCBPcGVu IFNvdXJjZSBQcm9qZWN0CisgKgorICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2Ug YW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CisgKiBtb2RpZmljYXRpb24sIGFyZSBw ZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMKKyAqIGFyZSBt ZXQ6CisgKiAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhl IGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBh bmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogICogUmVkaXN0cmlidXRpb25zIGluIGJp bmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyAqICAgIG5vdGlj ZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcgZGlzY2xhaW1lciBp biB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRl ZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURF RCBCWSBUSEUgQ09QWVJJR0hUIEhPTERFUlMgYGBBUyBJUycnIEFORCBBTlkKKyAqIEVYUFJFU1Mg T1IgSU1QTElFRCBXQVJSQU5USUVTLCBJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBUTywgVEhF CisgKiBJTVBMSUVEIFdBUlJBTlRJRVMgT0YgTUVSQ0hBTlRBQklMSVRZIEFORCBGSVRORVNTIEZP UiBBIFBBUlRJQ1VMQVIKKyAqIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuICBJTiBOTyBFVkVOVCBT SEFMTCBUSEUgQ09QWVJJR0hUIE9XTkVSIE9SCisgKiBDT05UUklCVVRPUlMgQkUgTElBQkxFIEZP UiBBTlkgRElSRUNULCBJTkRJUkVDVCwgSU5DSURFTlRBTCwgU1BFQ0lBTCwKKyAqIEVYRU1QTEFS WSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QgTElNSVRFRCBU TywKKyAqIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VSVklDRVM7IExPU1Mg T0YgVVNFLCBEQVRBLCBPUgorICogUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5URVJSVVBUSU9OKSBI T1dFVkVSIENBVVNFRCBBTkQgT04gQU5ZIFRIRU9SWQorICogT0YgTElBQklMSVRZLCBXSEVUSEVS IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAoSU5DTFVESU5HIE5F R0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VUIE9GIFRIRSBVU0UK KyAqIE9GIFRISVMgU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUgUE9TU0lCSUxJVFkg T0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgorI2luY2x1ZGUgIlJl c291cmNlUmVxdWVzdC5oIgorCituYW1lc3BhY2UgV2ViQ29yZSB7CisKK3Vuc2lnbmVkIGluaXRp YWxpemVNYXhpbXVtSFRUUENvbm5lY3Rpb25Db3VudFBlckhvc3QoKQoreworICAgIC8vIFRoaXMg aXMgdXNlZCBieSB0aGUgbG9hZGVyIHRvIGNvbnRyb2wgdGhlIG51bWJlciBvZiBwYXJhbGxlbCBs b2FkCisgICAgLy8gcmVxdWVzdHMuIE91ciBqYXZhIGZyYW1ld29yayBoYXMgNCB0aHJlYWRzIHRo YXQgY2FuIGVhY2ggcGlwZWxpbmUgdXAgdG8KKyAgICAvLyA1IHJlcXVlc3RzLiBVc2UgMjAgYXMg YSBtYXhpbXVtIG51bWJlci4KKyAgICByZXR1cm4gMjA7Cit9CisKK30gLy8gbmFtZXNwYWNlIFdl YkNvcmUK