31808 2009-11-23 09:52:57 -0800 createShader() needs better param checking 2009-11-24 19:13:42 -0800 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cmarrin cmarrin eric oliver sam oldest_to_newest 165872 0 cmarrin 2009-11-23 09:52:57 -0800 it will accept any non-FRAGMENT_SHADER value as GL_VERTEX_SHADER 166131 1 43779 cmarrin 2009-11-24 10:05:40 -0800 Created attachment 43779 Patch including test 166166 2 43779 eric 2009-11-24 10:42:44 -0800 Comment on attachment 43779 Patch including test Looks good, but maybe NOT_SUPPORTED_ERR would be better? 166318 3 cmarrin 2009-11-24 17:57:35 -0800 We need to revisit the whole exception model of WebGL. For now we have been using SYNTAX_ERR for bad params, so I'll leave it at that for now. 166339 4 cmarrin 2009-11-24 19:13:42 -0800 Landed in http://trac.webkit.org/changeset/51370 43779 2009-11-24 10:05:40 -0800 2009-11-24 10:42:44 -0800 Patch including test 31808.patch text/plain 5644 cmarrin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1MTM0MSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMDktMTEtMjQgIENocmlzIE1hcnJpbiAgPGNtYXJyaW5AYXBwbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIERv IGVycm9yIGNoZWNraW5nIG9mIHBhcmFtZXRlciB0byBjcmVhdGVTaGFkZXIKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODA4CisKKyAgICAgICAgVGVz dDogZmFzdC9jYW52YXMvd2ViZ2wvaW52YWxpZFBhc3NlZFBhcmFtcy5odG1sCisKKyAgICAgICAg KiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpjcmVhdGVTaGFkZXIpOgorICAgICAgICAqIGh0bWwv Y2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oOgorICAgICAgICAqIGh0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dC5pZGw6CisKIDIwMDktMTEtMjQgIEpvc2VwaCBQZWNvcmFybyAg PGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBQYXZlbCBGZWxkbWFu LgpJbmRleDogV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNw cAkocmV2aXNpb24gNTEzNDApCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5n Q29udGV4dC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5Nyw5ICszOTcsMTMgQEAgUGFzc1JlZlB0 cjxXZWJHTFJlbmRlcmJ1ZmZlcj4gV2ViR0xSZW5kZQogICAgIHJldHVybiBvOwogfQogCi1QYXNz UmVmUHRyPFdlYkdMU2hhZGVyPiBXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmNyZWF0ZVNoYWRlcih1 bnNpZ25lZCBsb25nIHR5cGUpCitQYXNzUmVmUHRyPFdlYkdMU2hhZGVyPiBXZWJHTFJlbmRlcmlu Z0NvbnRleHQ6OmNyZWF0ZVNoYWRlcih1bnNpZ25lZCBsb25nIHR5cGUsIEV4Y2VwdGlvbkNvZGUm IGVjKQogewotICAgIC8vIEZJWE1FOiBOZWVkIHRvIGRvIHBhcmFtIGNoZWNraW5nIGFuZCB0aHJv dyBleGNlcHRpb24gaWYgYW4gaWxsZWdhbCB2YWx1ZSBpcyBwYXNzZWQgaW4KKyAgICBpZiAodHlw ZSAhPSBHcmFwaGljc0NvbnRleHQzRDo6VkVSVEVYX1NIQURFUiAmJiB0eXBlICE9IEdyYXBoaWNz Q29udGV4dDNEOjpGUkFHTUVOVF9TSEFERVIpIHsKKyAgICAgICAgZWMgPSBTWU5UQVhfRVJSOwor ICAgICAgICByZXR1cm4gMDsKKyAgICB9CisgICAgCiAgICAgUmVmUHRyPFdlYkdMU2hhZGVyPiBv ID0gV2ViR0xTaGFkZXI6OmNyZWF0ZSh0aGlzLCBzdGF0aWNfY2FzdDxHcmFwaGljc0NvbnRleHQz RDo6V2ViR0xFbnVtVHlwZT4odHlwZSkpOwogICAgIGFkZE9iamVjdChvLmdldCgpKTsKICAgICBy ZXR1cm4gbzsKSW5kZXg6IFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0 LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRl eHQuaAkocmV2aXNpb24gNTEzNDApCisrKyBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVuZGVy aW5nQ29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC05NSw3ICs5NSw3IEBAIGNsYXNzIFdlYktp dENTU01hdHJpeDsKICAgICAgICAgUGFzc1JlZlB0cjxXZWJHTEZyYW1lYnVmZmVyPiBjcmVhdGVG cmFtZWJ1ZmZlcigpOwogICAgICAgICBQYXNzUmVmUHRyPFdlYkdMUHJvZ3JhbT4gY3JlYXRlUHJv Z3JhbSgpOwogICAgICAgICBQYXNzUmVmUHRyPFdlYkdMUmVuZGVyYnVmZmVyPiBjcmVhdGVSZW5k ZXJidWZmZXIoKTsKLSAgICAgICAgUGFzc1JlZlB0cjxXZWJHTFNoYWRlcj4gY3JlYXRlU2hhZGVy KHVuc2lnbmVkIGxvbmcgdHlwZSk7CisgICAgICAgIFBhc3NSZWZQdHI8V2ViR0xTaGFkZXI+IGNy ZWF0ZVNoYWRlcih1bnNpZ25lZCBsb25nIHR5cGUsIEV4Y2VwdGlvbkNvZGUmKTsKICAgICAgICAg UGFzc1JlZlB0cjxXZWJHTFRleHR1cmU+IGNyZWF0ZVRleHR1cmUoKTsKIAogICAgICAgICB2b2lk IGN1bGxGYWNlKHVuc2lnbmVkIGxvbmcgbW9kZSk7CkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dC5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2Nh bnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaWRsCShyZXZpc2lvbiA1MTM0MCkKKysrIFdlYkNv cmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmlkbAkod29ya2luZyBjb3B5KQpA QCAtNDk5LDcgKzQ5OSw3IEBAIG1vZHVsZSBodG1sIHsKICAgICAgICAgV2ViR0xGcmFtZWJ1ZmZl ciBjcmVhdGVGcmFtZWJ1ZmZlcigpOwogICAgICAgICBXZWJHTFByb2dyYW0gY3JlYXRlUHJvZ3Jh bSgpOwogICAgICAgICBXZWJHTFJlbmRlcmJ1ZmZlciBjcmVhdGVSZW5kZXJidWZmZXIoKTsKLSAg ICAgICAgV2ViR0xTaGFkZXIgY3JlYXRlU2hhZGVyKGluIHVuc2lnbmVkIGxvbmcgdHlwZSk7Cisg ICAgICAgIFdlYkdMU2hhZGVyIGNyZWF0ZVNoYWRlcihpbiB1bnNpZ25lZCBsb25nIHR5cGUpIHJh aXNlcyhET01FeGNlcHRpb24pOwogICAgICAgICBXZWJHTFRleHR1cmUgY3JlYXRlVGV4dHVyZSgp OwogCiAgICAgICAgIHZvaWQgICAgICAgICBjdWxsRmFjZShpbiB1bnNpZ25lZCBsb25nIG1vZGUp OwpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3Rz L0NoYW5nZUxvZwkocmV2aXNpb24gNTEzNDEpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0xMS0yNCAgQ2hyaXMgTWFycmluICA8 Y21hcnJpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgVGVzdCBmb3IgY3JlYXRlU2hhZGVyIHBhcmFtIHBhc3NpbmcKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODA4CisKKyAgICAgICAg VGhpcyB0ZXN0IHdpbGwgZXZlbnR1YWxseSBjb250YWluIG1vcmUgcGFyYW0gcGFzc2luZyB0ZXN0 cyBhcworICAgICAgICB0aGV5IGFyZSBpbXBsZW1lbnRlZC4KKworICAgICAgICAqIGZhc3QvY2Fu dmFzL3dlYmdsL2ludmFsaWRQYXNzZWRQYXJhbXMtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAg ICAgKiBmYXN0L2NhbnZhcy93ZWJnbC9pbnZhbGlkUGFzc2VkUGFyYW1zLmh0bWw6IEFkZGVkLgor CiAyMDA5LTExLTIzICBDaHJpcyBNYXJyaW4gIDxjbWFycmluQGFwcGxlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVudC4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFz L3dlYmdsL2ludmFsaWRQYXNzZWRQYXJhbXMtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExh eW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ludmFsaWRQYXNzZWRQYXJhbXMtZXhwZWN0ZWQu dHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvaW52YWxp ZFBhc3NlZFBhcmFtcy1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTQgQEAK K1Rlc3QgZm9yIGludmFsaWQgcGFzc2VkIHBhcmFtZXRlcnMKKworT24gc3VjY2VzcywgeW91IHdp bGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09N UExFVEUiLgorCitUZXN0IHNoYWRlcnMKK1BBU1Mgc2hhZGVyID0gY29udGV4dC5jcmVhdGVTaGFk ZXIoY29udGV4dC5GUkFHTUVOVF9TSEFERVIpIGlzIHNoYWRlcgorUEFTUyBzaGFkZXIgPSBjb250 ZXh0LmNyZWF0ZVNoYWRlcihjb250ZXh0LlZFUlRFWF9TSEFERVIpIGlzIHNoYWRlcgorUEFTUyBj b250ZXh0LmNyZWF0ZVNoYWRlcigwKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IFNZTlRBWF9FUlI6 IERPTSBFeGNlcHRpb24gMTIuCitQQVNTIGNvbnRleHQuY3JlYXRlU2hhZGVyKGNvbnRleHQuVFJJ QU5HTEVTKSB0aHJldyBleGNlcHRpb24gRXJyb3I6IFNZTlRBWF9FUlI6IERPTSBFeGNlcHRpb24g MTIuCisKK1BBU1Mgc3VjY2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQor CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9pbnZhbGlkUGFzc2VkUGFyYW1z Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wvaW52YWxp ZFBhc3NlZFBhcmFtcy5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52 YXMvd2ViZ2wvaW52YWxpZFBhc3NlZFBhcmFtcy5odG1sCShyZXZpc2lvbiAwKQpAQCAtMCwwICsx LDI5IEBACis8aHRtbD4KKzxoZWFkPgorPGxpbmsgcmVsPSJzdHlsZXNoZWV0IiBocmVmPSIuLi8u Li9qcy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiLz4KKzxzY3JpcHQgc3JjPSIuLi8uLi9q cy9yZXNvdXJjZXMvanMtdGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPHNjcmlwdCBzcmM9InJlc291 cmNlcy93ZWJnbC10ZXN0LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPGRpdiBpZD0i ZGVzY3JpcHRpb24iPjwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CisKKzxzY3JpcHQ+ CitkZXNjcmlwdGlvbigiVGVzdCBmb3IgaW52YWxpZCBwYXNzZWQgcGFyYW1ldGVycyIpOworCit2 YXIgY29udGV4dCA9IGNyZWF0ZTNEQ29udGV4dCgpOworCitkZWJ1ZygiVGVzdCBzaGFkZXJzIik7 Cit2YXIgc2hhZGVyOworc2hvdWxkQmUoInNoYWRlciA9IGNvbnRleHQuY3JlYXRlU2hhZGVyKGNv bnRleHQuRlJBR01FTlRfU0hBREVSKSIsICJzaGFkZXIiKTsKK3Nob3VsZEJlKCJzaGFkZXIgPSBj b250ZXh0LmNyZWF0ZVNoYWRlcihjb250ZXh0LlZFUlRFWF9TSEFERVIpIiwgInNoYWRlciIpOwor c2hvdWxkVGhyb3coImNvbnRleHQuY3JlYXRlU2hhZGVyKDApIik7CitzaG91bGRUaHJvdygiY29u dGV4dC5jcmVhdGVTaGFkZXIoY29udGV4dC5UUklBTkdMRVMpIik7CisKK2RlYnVnKCIiKQorc3Vj Y2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorCis8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ Cg==