31807 2009-11-23 08:44:17 -0800 [Android] Android port lacks platform-specific WTF thread functions 2009-11-25 09:48:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock steveblock android-webkit-unforking ap commit-queue dimich steveblock oldest_to_newest 165863 0 steveblock 2009-11-23 08:44:17 -0800 Android port lacks platform-specific WTF thread functions - initializeMainThreadPlatform() - scheduleDispatchFunctionsOnMainThread() 165866 1 43718 steveblock 2009-11-23 08:54:37 -0800 Created attachment 43718 Patch 1 for Bug 31807 165896 2 43718 dimich 2009-11-23 12:06:33 -0800 Comment on attachment 43718 Patch 1 for Bug 31807 r=me. > +using namespace android; This seems not needed and can be removed on landing... 165940 3 steveblock 2009-11-23 14:38:38 -0800 > > +using namespace android; > This seems not needed and can be removed on landing... JavaSharedClient will be added to WebKit/android and uses namespace android. 165945 4 43718 commit-queue 2009-11-23 14:55:30 -0800 Comment on attachment 43718 Patch 1 for Bug 31807 Clearing flags on attachment: 43718 Committed r51323: <http://trac.webkit.org/changeset/51323> 165946 5 commit-queue 2009-11-23 14:55:35 -0800 All reviewed patches have been landed. Closing bug. 165954 6 ap 2009-11-23 15:52:16 -0800 Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't wait to get rid of layering violations in runThreadWithRegistration(). 166493 7 steveblock 2009-11-25 09:48:34 -0800 (In reply to comment #6) > Should we delete Android-specific code from ThreadingPthreads.cpp now? I can't > wait to get rid of layering violations in runThreadWithRegistration(). No, I'm afraid this is still required. 43718 2009-11-23 08:54:37 -0800 2009-11-23 14:55:30 -0800 Patch 1 for Bug 31807 addMainThreadAndroid.txt text/plain 2830 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDUxMzEwKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMDktMTEtMjMgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgTWFpblRocmVhZEFuZHJvaWQuY3BwIHdpdGggQW5k cm9pZC1zcGVjaWZpYyBXVEYgdGhyZWFkaW5nIGZ1bmN0aW9ucy4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxODA3CisKKyAgICAgICAgKiB3dGYvYW5k cm9pZDogQWRkZWQuCisgICAgICAgICogd3RmL2FuZHJvaWQvTWFpblRocmVhZEFuZHJvaWQuY3Bw OiBBZGRlZC4KKyAgICAgICAgKFdURjo6dGltZW91dEZpcmVkKToKKyAgICAgICAgKFdURjo6aW5p dGlhbGl6ZU1haW5UaHJlYWRQbGF0Zm9ybSk6CisgICAgICAgIChXVEY6OnNjaGVkdWxlRGlzcGF0 Y2hGdW5jdGlvbnNPbk1haW5UaHJlYWQpOgorCiAyMDA5LTExLTIzICBMYXN6bG8gR29tYm9zICA8 bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRo IFJvaGRlIENocmlzdGlhbnNlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9hbmRyb2lkL01h aW5UaHJlYWRBbmRyb2lkLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvYW5k cm9pZC9NYWluVGhyZWFkQW5kcm9pZC5jcHAJKHJldmlzaW9uIDApCisrKyBKYXZhU2NyaXB0Q29y ZS93dGYvYW5kcm9pZC9NYWluVGhyZWFkQW5kcm9pZC5jcHAJKHJldmlzaW9uIDApCkBAIC0wLDAg KzEsNTAgQEAKKy8qCisgKiBDb3B5cmlnaHQgMjAwOSwgVGhlIEFuZHJvaWQgT3BlbiBTb3VyY2Ug UHJvamVjdAorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5h cnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVk IHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICog ICogUmVkaXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBj b3B5cmlnaHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBm b2xsb3dpbmcgZGlzY2xhaW1lci4KKyAqICAqIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9y bSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMg bGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisg KiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0 aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgVEhF IENPUFlSSUdIVCBIT0xERVJTIGBgQVMgSVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJ RUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRQorICogSU1Q TElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJU SUNVTEFSCisgKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQgU0hBTEwgVEhF IENPUFlSSUdIVCBPV05FUiBPUgorICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCisgKiBFWEVNUExBUlksIE9SIENP TlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCisgKiBQ Uk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwg REFUQSwgT1IKKyAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBD QVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKKyAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05U UkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNF IE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgorICovCisKKyNpbmNsdWRlICJjb25maWcuaCIKKyNpbmNsdWRlICJNYWluVGhyZWFk LmgiCisKKyNpbmNsdWRlICJKYXZhU2hhcmVkQ2xpZW50LmgiCisKK3VzaW5nIG5hbWVzcGFjZSBh bmRyb2lkOworCituYW1lc3BhY2UgV1RGIHsKKworLy8gQ2FsbGJhY2sgaW4gdGhlIG1haW4gdGhy ZWFkLgorc3RhdGljIHZvaWQgdGltZW91dEZpcmVkKHZvaWQqKQoreworICAgIGRpc3BhdGNoRnVu Y3Rpb25zRnJvbU1haW5UaHJlYWQoKTsKK30KKwordm9pZCBpbml0aWFsaXplTWFpblRocmVhZFBs YXRmb3JtKCkKK3sKK30KKwordm9pZCBzY2hlZHVsZURpc3BhdGNoRnVuY3Rpb25zT25NYWluVGhy ZWFkKCkKK3sKKyAgICBKYXZhU2hhcmVkQ2xpZW50OjpFbnF1ZXVlRnVuY3Rpb25QdHIodGltZW91 dEZpcmVkLCAwKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV1RGCg==