31789 2009-11-22 11:53:48 -0800 Web Inspector: Introduce sidebar background on timeline panel in order to prevent it from flickering on scroll. 2009-11-22 12:06:06 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 pfeldman pfeldman bweinstein joepeck rik timothy oldest_to_newest 165748 0 pfeldman 2009-11-22 11:53:48 -0800 Will attach patch shortly. 165749 1 43685 pfeldman 2009-11-22 11:55:52 -0800 Created attachment 43685 [PATCH] proposed fix 165750 2 43685 timothy 2009-11-22 11:58:41 -0800 Comment on attachment 43685 [PATCH] proposed fix > - this._refreshTimeout = setTimeout(this._refresh.bind(this), 100); > + this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100); A 0 delay timeout isn't immediate, it will be 10ms in Safari. That matter? 165751 3 pfeldman 2009-11-22 12:04:26 -0800 (In reply to comment #2) > (From update of attachment 43685 [details]) > > > - this._refreshTimeout = setTimeout(this._refresh.bind(this), 100); > > + this._refreshTimeout = setTimeout(this._refresh.bind(this), immediate ? 0 : 100); > > A 0 delay timeout isn't immediate, it will be 10ms in Safari. > > That matter? Not really, I just don't want to wait extra 100ms on scroll since I know i need to redraw and there is no need in coalescing. As a result, 100ms coalescing is only there for window resize (to make it real smooth) and for adding entries (for obvious reasons). Note that I can't invoke refresh on scroller synchronously since it would break the scroller smoothness. Anyway, I think 10ms is good. 165752 4 pfeldman 2009-11-22 12:06:06 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/front-end/TimelinePanel.js M WebCore/inspector/front-end/inspector.css Committed r51297 43685 2009-11-22 11:55:52 -0800 2009-11-22 11:58:41 -0800 [PATCH] proposed fix scroll_bg text/plain 5599 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg OGViNTM2Mi4uODA0MTYwYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMSBAQAogMjAwOS0xMS0yMiAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBJbnRyb2R1Y2Ugc2lkZWJhciBiYWNr Z3JvdW5kIG9uIHRpbWVsaW5lIHBhbmVsIGluIG9yZGVyCisgICAgICAgIHRvIHByZXZlbnQgaXQg ZnJvbSBmbGlja2VyaW5nIG9uIHNjcm9sbC4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE3ODkKKworICAgICAgICAqIGluc3BlY3Rvci9mcm9udC1l bmQvVGltZWxpbmVQYW5lbC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVs KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5UaW1lbGluZVBhbmVsLnByb3RvdHlwZS5zZXRTaWRl YmFyV2lkdGgpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBl Ll9vblNjcm9sbCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90b3R5 cGUuX3NjaGVkdWxlUmVmcmVzaCk6CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNw ZWN0b3IuY3NzOgorCisyMDA5LTExLTIyICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21p dW0ub3JnPgorCiAgICAgICAgIFJldmlld2VkIGJ5IFRpbW90aHkgSGF0Y2hlci4KIAogICAgICAg ICBXZWIgSW5zcGVjdG9yOiBSZWltcGxlbWVudCBUaW1lbGluZVBhbmVsIHRvIG1ha2UgaXQgZmFz dDoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9UaW1lbGluZVBhbmVs LmpzIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVsaW5lUGFuZWwuanMKaW5kZXgg ZjY3NjFiOC4uODE0NTVhMSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5k L1RpbWVsaW5lUGFuZWwuanMKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1RpbWVs aW5lUGFuZWwuanMKQEAgLTM4LDE2ICszOCwxOSBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5l bCA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9vdmVydmlld1BhbmUuYWRkRXZlbnRMaXN0ZW5lcigi ZmlsdGVyIGNoYW5nZWQiLCB0aGlzLl9yZWZyZXNoLCB0aGlzKTsKICAgICB0aGlzLmVsZW1lbnQu YXBwZW5kQ2hpbGQodGhpcy5fb3ZlcnZpZXdQYW5lLmVsZW1lbnQpOwogCisgICAgdGhpcy5fc2lk ZWJhckJhY2tncm91bmRFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7Cisg ICAgdGhpcy5fc2lkZWJhckJhY2tncm91bmRFbGVtZW50LmNsYXNzTmFtZSA9ICJzaWRlYmFyIHRp bWVsaW5lLXNpZGViYXItYmFja2dyb3VuZCI7CisgICAgdGhpcy5lbGVtZW50LmFwcGVuZENoaWxk KHRoaXMuX3NpZGViYXJCYWNrZ3JvdW5kRWxlbWVudCk7CisKICAgICB0aGlzLl9jb250YWluZXJF bGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdGhpcy5fY29udGFp bmVyRWxlbWVudC5pZCA9ICJ0aW1lbGluZS1jb250YWluZXIiOwogICAgIHRoaXMuX2NvbnRhaW5l ckVsZW1lbnQuYWRkRXZlbnRMaXN0ZW5lcigic2Nyb2xsIiwgdGhpcy5fb25TY3JvbGwuYmluZCh0 aGlzKSwgZmFsc2UpOwogICAgIHRoaXMuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9jb250YWlu ZXJFbGVtZW50KTsKIAogICAgIHRoaXMuY3JlYXRlU2lkZWJhcih0aGlzLl9jb250YWluZXJFbGVt ZW50LCB0aGlzLl9jb250YWluZXJFbGVtZW50KTsKLSAgICB0aGlzLnNpZGViYXJFbGVtZW50Lmlk ID0gInRpbWVsaW5lLXNpZGViYXIiOwotICAgIHRoaXMuaXRlbXNUcmVlRWxlbWVudCA9IG5ldyBX ZWJJbnNwZWN0b3IuU2lkZWJhclNlY3Rpb25UcmVlRWxlbWVudChXZWJJbnNwZWN0b3IuVUlTdHJp bmcoIlJFQ09SRFMiKSwge30sIHRydWUpOwotICAgIHRoaXMuaXRlbXNUcmVlRWxlbWVudC5leHBh bmRlZCA9IHRydWU7Ci0gICAgdGhpcy5zaWRlYmFyVHJlZS5hcHBlbmRDaGlsZCh0aGlzLml0ZW1z VHJlZUVsZW1lbnQpOworICAgIHZhciBpdGVtc1RyZWVFbGVtZW50ID0gbmV3IFdlYkluc3BlY3Rv ci5TaWRlYmFyU2VjdGlvblRyZWVFbGVtZW50KFdlYkluc3BlY3Rvci5VSVN0cmluZygiUkVDT1JE UyIpLCB7fSwgdHJ1ZSk7CisgICAgaXRlbXNUcmVlRWxlbWVudC5leHBhbmRlZCA9IHRydWU7Cisg ICAgdGhpcy5zaWRlYmFyVHJlZS5hcHBlbmRDaGlsZChpdGVtc1RyZWVFbGVtZW50KTsKIAogICAg IHRoaXMuX3NpZGViYXJMaXN0RWxlbWVudCA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoImRpdiIp OwogICAgIHRoaXMuc2lkZWJhckVsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fc2lkZWJhckxpc3RF bGVtZW50KTsKQEAgLTU3LDIwICs2MCwyMCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbCA9 IGZ1bmN0aW9uKCkKICAgICB0aGlzLl9jb250YWluZXJFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMu X2NvbnRhaW5lckNvbnRlbnRFbGVtZW50KTsKIAogICAgIHRoaXMuX3RpbWVsaW5lR3JpZCA9IG5l dyBXZWJJbnNwZWN0b3IuVGltZWxpbmVHcmlkKCk7Ci0gICAgdGhpcy5faXRlbXNHcmFwaHNFbGVt ZW50ID0gdGhpcy5fdGltZWxpbmVHcmlkLml0ZW1zR3JhcGhzRWxlbWVudDsKLSAgICB0aGlzLl9p dGVtc0dyYXBoc0VsZW1lbnQuaWQgPSAidGltZWxpbmUtZ3JhcGhzIjsKKyAgICB2YXIgaXRlbXNH cmFwaHNFbGVtZW50ID0gdGhpcy5fdGltZWxpbmVHcmlkLml0ZW1zR3JhcGhzRWxlbWVudDsKKyAg ICBpdGVtc0dyYXBoc0VsZW1lbnQuaWQgPSAidGltZWxpbmUtZ3JhcGhzIjsKICAgICB0aGlzLl9j b250YWluZXJDb250ZW50RWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl90aW1lbGluZUdyaWQuZWxl bWVudCk7CiAKICAgICB0aGlzLl90b3BHYXBFbGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgiZGl2Iik7CiAgICAgdGhpcy5fdG9wR2FwRWxlbWVudC5jbGFzc05hbWUgPSAidGltZWxpbmUt Z2FwIjsKLSAgICB0aGlzLl9pdGVtc0dyYXBoc0VsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fdG9w R2FwRWxlbWVudCk7CisgICAgaXRlbXNHcmFwaHNFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX3Rv cEdhcEVsZW1lbnQpOwogCiAgICAgdGhpcy5fZ3JhcGhSb3dzRWxlbWVudCA9IGRvY3VtZW50LmNy ZWF0ZUVsZW1lbnQoImRpdiIpOwotICAgIHRoaXMuX2l0ZW1zR3JhcGhzRWxlbWVudC5hcHBlbmRD aGlsZCh0aGlzLl9ncmFwaFJvd3NFbGVtZW50KTsKKyAgICBpdGVtc0dyYXBoc0VsZW1lbnQuYXBw ZW5kQ2hpbGQodGhpcy5fZ3JhcGhSb3dzRWxlbWVudCk7CiAKICAgICB0aGlzLl9ib3R0b21HYXBF bGVtZW50ID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiZGl2Iik7CiAgICAgdGhpcy5fYm90dG9t R2FwRWxlbWVudC5jbGFzc05hbWUgPSAidGltZWxpbmUtZ2FwIjsKLSAgICB0aGlzLl9pdGVtc0dy YXBoc0VsZW1lbnQuYXBwZW5kQ2hpbGQodGhpcy5fYm90dG9tR2FwRWxlbWVudCk7CisgICAgaXRl bXNHcmFwaHNFbGVtZW50LmFwcGVuZENoaWxkKHRoaXMuX2JvdHRvbUdhcEVsZW1lbnQpOwogCiAg ICAgdGhpcy5fY3JlYXRlU3RhdHVzYmFyQnV0dG9ucygpOwogCkBAIC0yMzYsNiArMjM5LDcgQEAg V2ViSW5zcGVjdG9yLlRpbWVsaW5lUGFuZWwucHJvdG90eXBlID0gewogICAgIHNldFNpZGViYXJX aWR0aDogZnVuY3Rpb24od2lkdGgpCiAgICAgewogICAgICAgICBXZWJJbnNwZWN0b3IuUGFuZWwu cHJvdG90eXBlLnNldFNpZGViYXJXaWR0aC5jYWxsKHRoaXMsIHdpZHRoKTsKKyAgICAgICAgdGhp cy5fc2lkZWJhckJhY2tncm91bmRFbGVtZW50LnN0eWxlLndpZHRoID0gd2lkdGggKyAicHgiOwog ICAgICAgICB0aGlzLl9vdmVydmlld1BhbmUuc2V0U2lkZWJhcldpZHRoKHdpZHRoKTsKICAgICB9 LAogCkBAIC0yNzIsMTcgKzI3NiwxNyBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVQYW5lbC5wcm90 b3R5cGUgPSB7CiAgICAgICAgIHZhciBzY3JvbGxUb3AgPSB0aGlzLl9jb250YWluZXJFbGVtZW50 LnNjcm9sbFRvcDsKICAgICAgICAgdmFyIGRpdmlkZXJzVG9wID0gTWF0aC5tYXgoMCwgc2Nyb2xs VG9wKTsKICAgICAgICAgdGhpcy5fdGltZWxpbmVHcmlkLnNldFNjcm9sbEFuZERpdmlkZXJUb3Ao c2Nyb2xsVG9wLCBkaXZpZGVyc1RvcCk7Ci0gICAgICAgIHRoaXMuX3NjaGVkdWxlUmVmcmVzaCgp OworICAgICAgICB0aGlzLl9zY2hlZHVsZVJlZnJlc2godHJ1ZSk7CiAgICAgfSwKIAotICAgIF9z Y2hlZHVsZVJlZnJlc2g6IGZ1bmN0aW9uKCkKKyAgICBfc2NoZWR1bGVSZWZyZXNoOiBmdW5jdGlv bihpbW1lZGlhdGUpCiAgICAgewogICAgICAgICBpZiAodGhpcy5fbmVlZHNSZWZyZXNoKQogICAg ICAgICAgICAgcmV0dXJuOwogICAgICAgICB0aGlzLl9uZWVkc1JlZnJlc2ggPSB0cnVlOwogCiAg ICAgICAgIGlmICh0aGlzLnZpc2libGUgJiYgISgiX3JlZnJlc2hUaW1lb3V0IiBpbiB0aGlzKSkK LSAgICAgICAgICAgIHRoaXMuX3JlZnJlc2hUaW1lb3V0ID0gc2V0VGltZW91dCh0aGlzLl9yZWZy ZXNoLmJpbmQodGhpcyksIDEwMCk7CisgICAgICAgICAgICB0aGlzLl9yZWZyZXNoVGltZW91dCA9 IHNldFRpbWVvdXQodGhpcy5fcmVmcmVzaC5iaW5kKHRoaXMpLCBpbW1lZGlhdGUgPyAwIDogMTAw KTsKICAgICB9LAogCiAgICAgX3JlZnJlc2g6IGZ1bmN0aW9uKCkKZGlmZiAtLWdpdCBhL1dlYkNv cmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuY3NzIGIvV2ViQ29yZS9pbnNwZWN0b3Iv ZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKaW5kZXggY2JjNjZhMS4uNDg2OTMwZSAxMDA2NDQKLS0t IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKKysrIGIvV2ViQ29y ZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5jc3MKQEAgLTMyNzUsMTQgKzMyNzUsNiBA QCBib2R5LmluYWN0aXZlIC5zaWRlYmFyLXRyZWUtaXRlbS5zZWxlY3RlZCAuYnViYmxlLnNlYXJj aC1tYXRjaGVzIHsKIAogLyogVGltZWxpbmUgU3R5bGUgKi8KIAotI3RpbWVsaW5lLXN1bW1hcnkg ewotICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKLSAgICB0b3A6IDA7Ci0gICAgbGVmdDogMDsKLSAg ICB3aWR0aDogMDsKLSAgICBoZWlnaHQ6IDA7Ci19Ci0KICN0aW1lbGluZS1vdmVydmlldy1wYW5l bCB7CiAgICAgcG9zaXRpb246IGFic29sdXRlOwogICAgIHRvcDogMDsKQEAgLTMyOTEsNiArMzI4 MywxMSBAQCBib2R5LmluYWN0aXZlIC5zaWRlYmFyLXRyZWUtaXRlbS5zZWxlY3RlZCAuYnViYmxl LnNlYXJjaC1tYXRjaGVzIHsKICAgICBoZWlnaHQ6IDgwcHg7CiB9CiAKKy50aW1lbGluZS1zaWRl YmFyLWJhY2tncm91bmQgeworICAgIHRvcDogOTBweDsKKyAgICBib3R0b206IDA7Cit9CisKICN0 aW1lbGluZS1vdmVydmlldy1zZXBhcmF0b3IgewogICAgIHBvc2l0aW9uOiBhYnNvbHV0ZTsKICAg ICB0b3A6IDgwcHg7Cg==