31787 2009-11-22 10:45:01 -0800 Cookies don't show up in Web Inspector storage tab if website has a port 2009-12-29 08:51:29 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED http://grab.by/Jyn P2 Normal --- 0 charlie webkit-unassigned bweinstein commit-queue dbates joepeck keishi pfeldman pmuellr rik timothy webkit.review.bot oldest_to_newest 165741 0 charlie 2009-11-22 10:45:01 -0800 Cookies for a website are not showing up correctly in Web Inspector's storage tab if the website has a port. I noticed this while developing my Rails application locally at "localhost:3000". Under the "Cookies" section, it says "localhost:3000". I don't think cookies are stored on a per-port basis, so the port should be stripped off the web address before looking for the cookies. 168864 1 pfeldman 2009-12-04 12:02:28 -0800 Before one jumps into fixing this, note that there is a small cookies refactoring in https://bugs.webkit.org/show_bug.cgi?id=32160 under review. 175493 2 45591 apavlov 2009-12-29 04:35:28 -0800 Created attachment 45591 [PATCH] Strip port from cookie domains passed into WebInspector.addCookieDomain() 175494 3 webkit.review.bot 2009-12-29 04:36:32 -0800 style-queue ran check-webkit-style on attachment 45591 without any errors. 175570 4 45591 commit-queue 2009-12-29 08:51:23 -0800 Comment on attachment 45591 [PATCH] Strip port from cookie domains passed into WebInspector.addCookieDomain() Clearing flags on attachment: 45591 Committed r52623: <http://trac.webkit.org/changeset/52623> 175571 5 commit-queue 2009-12-29 08:51:29 -0800 All reviewed patches have been landed. Closing bug. 45591 2009-12-29 04:35:28 -0800 2009-12-29 08:51:23 -0800 [PATCH] Strip port from cookie domains passed into WebInspector.addCookieDomain() fixcookieport.patch text/plain 1559 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NDI1OGJiMS4uMzBlMTM3NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAwOS0xMi0yOSAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERpc2NhcmQgcG9ydCBmcm9tIGNvb2tpZSBkb21haW4gd2hl biBtYXRjaGluZyBjb29raWVzLgorCisgICAgICAgIFdlYktpdCBjb29raWVzIGRvIG5vdCBob2xk IHRoZSBwb3J0IGluZm9ybWF0aW9uLCBzbyB3ZSBzaG91bGQgbWF0Y2ggb25seSBob3N0bmFtZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTc4Nwor CisgICAgICAgICogaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanM6CisgICAgICAgIChX ZWJJbnNwZWN0b3IudXBkYXRlUmVzb3VyY2UpOgorCiAyMDA5LTEyLTI4ICBBbmRyZWkgUG9wZXNj dSAgPGFuZHJlaXBAZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEbWl0cnkgVGl0 b3YuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCA0Nzc1OWVh Li5lNmFlN2ZmIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVj dG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAg LTk4NSw5ICs5ODUsMTIgQEAgV2ViSW5zcGVjdG9yLnVwZGF0ZVJlc291cmNlID0gZnVuY3Rpb24o aWRlbnRpZmllciwgcGF5bG9hZCkKICAgICAgICAgaWYgKHJlc291cmNlLm1haW5SZXNvdXJjZSkK ICAgICAgICAgICAgIHRoaXMubWFpblJlc291cmNlID0gcmVzb3VyY2U7CiAKLSAgICAgICAgdmFy IG1hdGNoID0gcGF5bG9hZC5kb2N1bWVudFVSTC5tYXRjaCgvXihodHRwW3NdP3xmaWxlKTpcL1wv KFtcL10qW15cL10rKS9pKTsKLSAgICAgICAgaWYgKG1hdGNoKQotICAgICAgICAgICAgdGhpcy5h ZGRDb29raWVEb21haW4obWF0Y2hbMV0udG9Mb3dlckNhc2UoKSA9PT0gImZpbGUiID8gIiIgOiBt YXRjaFsyXSk7CisgICAgICAgIHZhciBtYXRjaCA9IHBheWxvYWQuZG9jdW1lbnRVUkwubWF0Y2go V2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7CisgICAgICAgIGlmIChtYXRjaCkgeworICAgICAgICAg ICAgdmFyIHByb3RvY29sID0gbWF0Y2hbMV0udG9Mb3dlckNhc2UoKTsKKyAgICAgICAgICAgIGlm IChwcm90b2NvbC5pbmRleE9mKCJodHRwIikgPT09IDAgfHwgcHJvdG9jb2wgPT09ICJmaWxlIikK KyAgICAgICAgICAgICAgICB0aGlzLmFkZENvb2tpZURvbWFpbihwcm90b2NvbCA9PT0gImZpbGUi ID8gIiIgOiBtYXRjaFsyXSk7CisgICAgICAgIH0KICAgICB9CiAKICAgICBpZiAocGF5bG9hZC5k aWRSZXNwb25zZUNoYW5nZSkgewo=