31783 2009-11-22 04:26:18 -0800 [Qt] DumpRenderTree should explicitly ignore SSL certificate errors 2009-11-22 14:29:23 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 31785 0 jwieczorek webkit-unassigned commit-queue tonikitoo oldest_to_newest 165702 0 jwieczorek 2009-11-22 04:26:18 -0800 Currently all the http/ssl tests are timing out. One of the reasons is that HTTPS errors are not ignored which prevent the tests from proceeding. This is similar to https://bugs.webkit.org/show_bug.cgi?id=31200 and http://trac.webkit.org/changeset/50783. 165703 1 43674 jwieczorek 2009-11-22 04:29:31 -0800 Created attachment 43674 proposed patch 165762 2 tonikitoo 2009-11-22 13:37:01 -0800 should not it be simpler to add an ignoreSslErrors method in the already existent WebPage class ( that inherits QWebPage ). of course, if more stuff are to be added do this NetworkAccessManager class, then lets keep it. /me trying to avoid introducing a new class only for this. not setting CQ+ due to this. 165763 3 jwieczorek 2009-11-22 13:40:22 -0800 (In reply to comment #2) > should not it be simpler to add an ignoreSslErrors method in the already > existent WebPage class ( that inherits QWebPage ). > > of course, if more stuff are to be added do this NetworkAccessManager class, > then lets keep it. Yes, I was going to add support for authentication challenges as well. > > /me trying to avoid introducing a new class only for this. > > not setting CQ+ due to this. 165766 4 43674 commit-queue 2009-11-22 14:29:18 -0800 Comment on attachment 43674 proposed patch Clearing flags on attachment: 43674 Committed r51298: <http://trac.webkit.org/changeset/51298> 165767 5 commit-queue 2009-11-22 14:29:23 -0800 All reviewed patches have been landed. Closing bug. 43674 2009-11-22 04:29:31 -0800 2009-11-22 14:29:18 -0800 proposed patch 0001-Qt-DumpRenderTree-should-explicitly-ignore-any-SSL-c.patch text/plain 5728 jwieczorek RnJvbSBjYzU0MTExYzg5NTJkZTFhMTlkMWViOTMwMGFlMDcxMDcyM2RhMDRhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFN1biwgMjIgTm92IDIwMDkgMTM6MDI6NTQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IER1bXBSZW5kZXJUcmVlIHNob3VsZCBleHBsaWNpdGx5IGlnbm9yZSBhbnkgU1NMIGNlcnRpZmlj YXRlIGVycm9ycwogZm9yIGxvY2FsaG9zdCBhbmQgMTI3LjAuMC4xLgogaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzgzCgpVbnNraXAgdGhlIGh0dHAvdGVzdHMvc3Ns L3ZlcmlmeS1zc2wtZW5hYmxlZC5waHAgdGVzdCwgd2hpY2ggaXMgcGFzc2luZyBub3cuCi0tLQog TGF5b3V0VGVzdHMvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMiAr KysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZCAgICAgICAgICAgICAgICAg IHwgICAgNSArKystCiBXZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgfCAgIDE2ICsrKysrKysrKysrCiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9E dW1wUmVuZGVyVHJlZS5jcHAgfCAgIDMyICsrKysrKysrKysrKysrKysrKysrKysKIFdlYktpdFRv b2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmggICB8ICAgMTYgKysrKysrKysr KysKIDUgZmlsZXMgY2hhbmdlZCwgODAgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cK aW5kZXggOWQ3NGFiMy4uYjFiODE0MiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n CisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDA5LTExLTIy ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRHVtcFJlbmRlclRyZWUgc2hvdWxk IGV4cGxpY2l0bHkgaWdub3JlIGFueSBTU0wgY2VydGlmaWNhdGUgZXJyb3JzCisgICAgICAgIGZv ciBsb2NhbGhvc3QgYW5kIDEyNy4wLjAuMS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxNzgzCisKKyAgICAgICAgVW5za2lwIHRoZSBodHRwL3Rlc3Rz L3NzbC92ZXJpZnktc3NsLWVuYWJsZWQucGhwIHRlc3QsIHdoaWNoIGlzIHBhc3Npbmcgbm93Lgor CisgICAgICAgICogcGxhdGZvcm0vcXQvU2tpcHBlZDoKKwogMjAwOS0xMS0yMCAgQ2hyaXMgRmxl aXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGgg RGFraW4uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5 b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCA2Y2U3NThmLi41OGZmZjk5IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3Rz L3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTM3LDEzICszNywxNiBAQCBodHRwL3Rlc3RzL2luY3Jl bWVudGFsCiBodHRwL3Rlc3RzL21lZGlhCiBodHRwL3Rlc3RzL25hdmlnYXRpb24KIGh0dHAvdGVz dHMvcGx1Z2lucwotaHR0cC90ZXN0cy9zc2wKIGh0dHAvdGVzdHMvd2ViYXJjaGl2ZQogaHR0cC90 ZXN0cy93bWwKIAogIyBGYWlsaW5nIFVSTCB0ZXN0CiBodHRwL3Rlc3RzL3VyaS9lc2NhcGVkLWVu dGl0eS5odG1sCiAKKyMgRmFpbGluZyBIVFRQIFNTTCB0ZXN0cworaHR0cC90ZXN0cy9zc2wvcmVm ZXJlci0zMDEuaHRtbAoraHR0cC90ZXN0cy9zc2wvcmVmZXJlci0zMDMuaHRtbAorCiAjIEZhaWxp bmcgSFRUUCBMb2FkaW5nIHRlc3RzCiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNlcnZlci1zdWJm cmFtZS5odG1sCiBodHRwL3Rlc3RzL2xvYWRpbmcvYmFkLXNjaGVtZS1zdWJmcmFtZS5odG1sCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9DaGFuZ2VMb2cgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cK aW5kZXggNjA5Yjg4Ni4uMzA4NzhkNCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n CisrKyBiL1dlYktpdFRvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDA5LTExLTIy ICBKYWt1YiBXaWVjem9yZWsgIDxmYXcyMTdAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gRHVtcFJlbmRlclRyZWUgc2hvdWxk IGV4cGxpY2l0bHkgaWdub3JlIGFueSBTU0wgY2VydGlmaWNhdGUgZXJyb3JzCisgICAgICAgIGZv ciBsb2NhbGhvc3QgYW5kIDEyNy4wLjAuMS4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTMxNzgzCisKKyAgICAgICAgVW5za2lwIHRoZSBodHRwL3Rlc3Rz L3NzbC92ZXJpZnktc3NsLWVuYWJsZWQucGhwIHRlc3QsIHdoaWNoIGlzIHBhc3Npbmcgbm93Lgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TmV0d29ya0FjY2Vzc01hbmFnZXI6Ok5ldHdvcmtBY2Nlc3NNYW5hZ2VyKToK KyAgICAgICAgKFdlYkNvcmU6Ok5ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpzc2xFcnJvcnNFbmNvdW50 ZXJlZCk6CisgICAgICAgIChXZWJDb3JlOjpXZWJQYWdlOjpXZWJQYWdlKToKKyAgICAgICAgKiBE dW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5oOgorCiAyMDA5LTExLTIwICBBZGFtIEJh cnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlk ZWwuCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVy VHJlZS5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5j cHAKaW5kZXggYjNiNTJiNy4uYzkyMzQ1NyAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5k ZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcApAQCAtNDksNiArNDksOCBAQAogI2luY2x1ZGUg PFFGaWxlSW5mbz4KICNpbmNsdWRlIDxRRm9jdXNFdmVudD4KICNpbmNsdWRlIDxRRm9udERhdGFi YXNlPgorI2luY2x1ZGUgPFFOZXR3b3JrQWNjZXNzTWFuYWdlcj4KKyNpbmNsdWRlIDxRTmV0d29y a1JlcGx5PgogI2luY2x1ZGUgPFFOZXR3b3JrUmVxdWVzdD4KICNpbmNsdWRlIDxRVW5kb1N0YWNr PgogCkBAIC03OSw2ICs4MSwzNSBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiBjb25zdCB1bnNpZ25l ZCBpbnQgbWF4Vmlld1dpZHRoID0gODAwOwogY29uc3QgdW5zaWduZWQgaW50IG1heFZpZXdIZWln aHQgPSA2MDA7CiAKK05ldHdvcmtBY2Nlc3NNYW5hZ2VyOjpOZXR3b3JrQWNjZXNzTWFuYWdlcihR T2JqZWN0KiBwYXJlbnQpCisgICAgOiBRTmV0d29ya0FjY2Vzc01hbmFnZXIocGFyZW50KQorewor I2lmbmRlZiBRVF9OT19TU0wKKyAgICBjb25uZWN0KHRoaXMsIFNJR05BTChzc2xFcnJvcnMoUU5l dHdvcmtSZXBseSosIGNvbnN0IFFMaXN0PFFTc2xFcnJvcj4mKSksCisgICAgICAgICAgICB0aGlz LCBTTE9UKHNzbEVycm9yc0VuY291bnRlcmVkKFFOZXR3b3JrUmVwbHkqLCBjb25zdCBRTGlzdDxR U3NsRXJyb3I+JikpKTsKKyNlbmRpZgorfQorCisjaWZuZGVmIFFUX05PX1NTTAordm9pZCBOZXR3 b3JrQWNjZXNzTWFuYWdlcjo6c3NsRXJyb3JzRW5jb3VudGVyZWQoUU5ldHdvcmtSZXBseSogcmVw bHksIGNvbnN0IFFMaXN0PFFTc2xFcnJvcj4mIGVycm9ycykKK3sKKyAgICBpZiAocmVwbHktPnVy bCgpLmhvc3QoKSA9PSAiMTI3LjAuMC4xIiB8fCByZXBseS0+dXJsKCkuaG9zdCgpID09ICJsb2Nh bGhvc3QiKSB7CisgICAgICAgIGJvb2wgaWdub3JlID0gdHJ1ZTsKKworICAgICAgICAvLyBBY2Nl cHQgYW55IEhUVFBTIGNlcnRpZmljYXRlLgorICAgICAgICBmb3JlYWNoIChjb25zdCBRU3NsRXJy b3ImIGVycm9yLCBlcnJvcnMpIHsKKyAgICAgICAgICAgIGlmIChlcnJvci5lcnJvcigpIDwgUVNz bEVycm9yOjpVbmFibGVUb0dldElzc3VlckNlcnRpZmljYXRlIHx8IGVycm9yLmVycm9yKCkgPiBR U3NsRXJyb3I6Okhvc3ROYW1lTWlzbWF0Y2gpIHsKKyAgICAgICAgICAgICAgICBpZ25vcmUgPSBm YWxzZTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0KKyAgICAgICAgfQor CisgICAgICAgIGlmIChpZ25vcmUpCisgICAgICAgICAgICByZXBseS0+aWdub3JlU3NsRXJyb3Jz KCk7CisgICAgfQorfQorI2VuZGlmCisKIFdlYlBhZ2U6OldlYlBhZ2UoUVdpZGdldCAqcGFyZW50 LCBEdW1wUmVuZGVyVHJlZSAqZHJ0KQogICAgIDogUVdlYlBhZ2UocGFyZW50KQogICAgICwgbV9k cnQoZHJ0KQpAQCAtMTAyLDYgKzEzMyw3IEBAIFdlYlBhZ2U6OldlYlBhZ2UoUVdpZGdldCAqcGFy ZW50LCBEdW1wUmVuZGVyVHJlZSAqZHJ0KQogICAgIGNvbm5lY3QodGhpcywgU0lHTkFMKGdlb21l dHJ5Q2hhbmdlUmVxdWVzdGVkKGNvbnN0IFFSZWN0ICYpKSwKICAgICAgICAgICAgIHRoaXMsIFNM T1Qoc2V0Vmlld0dlb21ldHJ5KGNvbnN0IFFSZWN0ICYgKSkpOwogCisgICAgc2V0TmV0d29ya0Fj Y2Vzc01hbmFnZXIobmV3IE5ldHdvcmtBY2Nlc3NNYW5hZ2VyKHRoaXMpKTsKICAgICBzZXRQbHVn aW5GYWN0b3J5KG5ldyBUZXN0UGx1Z2luKHRoaXMpKTsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViS2l0 VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuaCBiL1dlYktpdFRvb2xzL0R1 bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmgKaW5kZXggODgxMjkwMS4uZjE5YTY3YSAx MDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUu aAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9EdW1wUmVuZGVyVHJlZS5oCkBA IC0zMSwxMCArMzEsMTUgQEAKICNkZWZpbmUgRFVNUFJFTkRFUlRSRUVfSAogCiAjaW5jbHVkZSA8 UUxpc3Q+CisjaW5jbHVkZSA8UU5ldHdvcmtBY2Nlc3NNYW5hZ2VyPgogI2luY2x1ZGUgPFFPYmpl Y3Q+CiAjaW5jbHVkZSA8UVRleHRTdHJlYW0+CiAjaW5jbHVkZSA8UVNvY2tldE5vdGlmaWVyPgog CisjaWZuZGVmIFFUX05PX1NTTAorI2luY2x1ZGUgPFFTc2xFcnJvcj4KKyNlbmRpZgorCiAjaW5j bHVkZSA8cXdlYnBhZ2UuaD4KIAogUVRfQkVHSU5fTkFNRVNQQUNFCkBAIC0xMjEsNiArMTI2LDE3 IEBAIHByaXZhdGU6CiAgICAgYm9vbCBtX2VuYWJsZVRleHRPdXRwdXQ7CiB9OwogCitjbGFzcyBO ZXR3b3JrQWNjZXNzTWFuYWdlciA6IHB1YmxpYyBRTmV0d29ya0FjY2Vzc01hbmFnZXIgeworICAg IFFfT0JKRUNUCitwdWJsaWM6CisgICAgTmV0d29ya0FjY2Vzc01hbmFnZXIoUU9iamVjdCogcGFy ZW50KTsKKworcHJpdmF0ZSBzbG90czoKKyNpZm5kZWYgUVRfTk9fU1NMCisgICAgdm9pZCBzc2xF cnJvcnNFbmNvdW50ZXJlZChRTmV0d29ya1JlcGx5KiwgY29uc3QgUUxpc3Q8UVNzbEVycm9yPiYp OworI2VuZGlmCit9OworCiBjbGFzcyBXZWJQYWdlIDogcHVibGljIFFXZWJQYWdlIHsKICAgICBR X09CSkVDVAogcHVibGljOgotLSAKMS42LjUKCg==