31779 2009-11-21 19:51:08 -0800 QWebPage::findText() does not clear selection when passed empty string 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All CLOSED FIXED Qt, QtTriaged P3 Normal --- 1 markturney webkit-qt-unassigned adawit benjamin commit-queue hausmann jesus kent.hansen markturney pierre.rossi rion4ik webkit.review.bot oldest_to_newest 165687 0 43670 markturney 2009-11-21 19:51:08 -0800 Created attachment 43670 running example of the bug in question The text within the Qt documentation for QWebPage::findText() states that "To clear the selection, just pass an empty string.". When an empty string is passed into this method as demonstrated by the included cpp file, QWebPage::findText() fails to clear the selection. This bug was tested in 4.6-RC1 on Linux64. 180409 1 rion4ik 2010-01-13 14:28:41 -0800 the same for 4.6.0 release. 195780 2 adawit 2010-03-03 15:12:52 -0800 FYI... Clearing of the selection will work correctly for the text highlighted when the HighlightAllOccurrances flag is set so long as you specify this very same flag when you calling the function with an empty string... 196756 3 benjamin 2010-03-05 15:50:15 -0800 Same with trunk. 235447 4 58169 pierre.rossi 2010-06-08 12:50:45 -0700 Created attachment 58169 proposed patch 235452 5 webkit.review.bot 2010-06-08 12:52:40 -0700 Attachment 58169 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/qt/ChangeLog:5: Line contains tab character. [whitespace/tab] [5] WebKit/qt/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] WARNING: File exempt from style guide. Skipping: "WebKit/qt/Api/qwebpage.cpp" WARNING: File exempt from style guide. Skipping: "WebKit/qt/tests/qwebpage/tst_qwebpage.cpp" Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 235458 6 58172 pierre.rossi 2010-06-08 12:57:51 -0700 Created attachment 58172 Argh, my Changelog really had no style at all! 236152 7 58172 commit-queue 2010-06-09 21:39:50 -0700 Comment on attachment 58172 Argh, my Changelog really had no style at all! Clearing flags on attachment: 58172 Committed r60935: <http://trac.webkit.org/changeset/60935> 236153 8 commit-queue 2010-06-09 21:39:59 -0700 All reviewed patches have been landed. Closing bug. 237609 9 hausmann 2010-06-13 14:12:02 -0700 Revision r60935 cherry-picked into qtwebkit-2.0 with commit 0f8941d0dd5f947530e1dc55b859d810bba14764 43670 2009-11-21 19:51:08 -0800 2009-11-21 19:51:08 -0800 running example of the bug in question main.cpp text/x-c++src 708 markturney CiNpbmNsdWRlIDxRdEd1aS9RQXBwbGljYXRpb24+CiNpbmNsdWRlIDxRTWFpbldpbmRvdz4KI2lu Y2x1ZGUgPFFXZWJWaWV3PgojaW5jbHVkZSA8UVRpbWVyPgoKaW50IG1haW4oaW50IGFyZ2MsIGNo YXIgKmFyZ3ZbXSkKewogICAgUUFwcGxpY2F0aW9uIGEoYXJnYywgYXJndik7CiAgICBRTWFpbldp bmRvdyBtYWluX3dpbmRvdzsKICAgIFFXZWJWaWV3ICogd2ViX3ZpZXcgPSBuZXcgUVdlYlZpZXco KTsKICAgIG1haW5fd2luZG93LnNldENlbnRyYWxXaWRnZXQod2ViX3ZpZXcpOwogICAgd2ViX3Zp ZXctPnNldEh0bWwoIjxodG1sPjxib2R5PnRoaXMgaXMgc29tZSB0ZXh0IG9mIGludGVyZXN0PC9i b2R5PjwvaHRtbD4iKTsKICAgIG1haW5fd2luZG93LnNldEdlb21ldHJ5KDMwMCwgMzAwLCAzMDAs IDIwMCk7CgogICAgLy8gVGhpcyBzdGF0ZW1lbnQgY3JlYXRlcyBhIHNlbGVjdGlvbiBhcm91bmQg dGhlIHNwZWNpZmllZCB0ZXh0LgogICAgd2ViX3ZpZXctPnBhZ2UoKS0+ZmluZFRleHQoInNvbSIp OwoKICAgIC8vIEFjY29yZGluZyB0byB0aGUgZG9jdW1lbnRhdGlvbiwgdGhpcyBzdGF0ZW1lbnQg c2hvdWxkIGVyYXNlIHRoZSBleGlzdGluZyBzZWxlY3Rpb24sIGJ1dCBpdCBkb2VzIG5vdC4KICAg IHdlYl92aWV3LT5wYWdlKCktPmZpbmRUZXh0KCIiKTsKCiAgICBtYWluX3dpbmRvdy5zaG93KCk7 CiAgICByZXR1cm4gYS5leGVjKCk7Cn0K 58169 2010-06-08 12:50:45 -0700 2010-06-08 12:57:51 -0700 proposed patch findText_clear_selection.patch text/plain 2722 pierre.rossi ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggODBkZDY2NC4uMDY3OGM1YiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTMw OTksNiArMzA5OSwxNCBAQCBib29sIFFXZWJQYWdlOjpmaW5kVGV4dChjb25zdCBRU3RyaW5nICZz dWJTdHJpbmcsIEZpbmRGbGFncyBvcHRpb25zKQogICAgICAgICB9IGVsc2UKICAgICAgICAgICAg IHJldHVybiBkLT5wYWdlLT5tYXJrQWxsTWF0Y2hlc0ZvclRleHQoc3ViU3RyaW5nLCBjYXNlU2Vu c2l0aXZpdHksIHRydWUsIDApOwogICAgIH0gZWxzZSB7CisgICAgICAgIGlmIChzdWJTdHJpbmcu aXNFbXB0eSgpKSB7CisgICAgICAgICAgICBkLT5wYWdlLT5tYWluRnJhbWUoKS0+c2VsZWN0aW9u KCktPmNsZWFyKCk7CisgICAgICAgICAgICBGcmFtZSogZnJhbWUgPSBkLT5wYWdlLT5tYWluRnJh bWUoKS0+dHJlZSgpLT5maXJzdENoaWxkKCk7CisgICAgICAgICAgICB3aGlsZSAoZnJhbWUpIHsK KyAgICAgICAgICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPmNsZWFyKCk7CisgICAgICAgICAg ICAgICAgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHRXaXRoV3JhcChmYWxzZSk7 CisgICAgICAgICAgICB9CisgICAgICAgIH0KICAgICAgICAgOjpGaW5kRGlyZWN0aW9uIGRpcmVj dGlvbiA9IDo6RmluZERpcmVjdGlvbkZvcndhcmQ7CiAgICAgICAgIGlmIChvcHRpb25zICYgRmlu ZEJhY2t3YXJkKQogICAgICAgICAgICAgZGlyZWN0aW9uID0gOjpGaW5kRGlyZWN0aW9uQmFja3dh cmQ7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwppbmRleCAxYjMyNjBlLi45YzYzZTgyIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wOCAg UGllcnJlIFJvc3NpICA8cGllcnJlLnJvc3NpQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworCVFXZWJQYWdlOjpmaW5kVGV4dCgpIGRvZXMgbm90IGNs ZWFyIHNlbGVjdGlvbiB3aGVuIHBhc3NlZCBlbXB0eSBzdHJpbmcKKwlodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE3NzkKKworICAgICAgICAqIEFwaS9xd2VicGFnZS5j cHA6CisgICAgICAgIChRV2ViUGFnZTo6ZmluZFRleHQpOgorICAgICAgICAqIHRlc3RzL3F3ZWJw YWdlL3RzdF9xd2VicGFnZS5jcHA6CisgICAgICAgICh0c3RfUVdlYlBhZ2U6OmZpbmRUZXh0KToK KwogMjAxMC0wNi0wOCAgQW50b25pbyBHb21lcyAgPHRvbmlraXRvb0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE9qYW4gVmFmYWkgYW5kIERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L3F0L3Rlc3RzL3F3ZWJwYWdlL3RzdF9xd2VicGFnZS5jcHAgYi9XZWJLaXQvcXQv dGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAppbmRleCA2MzBjY2NlLi5iMGY5ZmFmIDEw MDY0NAotLS0gYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcAorKysg Yi9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcApAQCAtMTIzLDYgKzEy Myw3IEBAIHByaXZhdGUgc2xvdHM6CiAgICAgdm9pZCB0ZXN0SlNQcm9tcHQoKTsKICAgICB2b2lk IHNob3dNb2RhbERpYWxvZygpOwogICAgIHZvaWQgdGVzdFN0b3BTY2hlZHVsZWRQYWdlUmVmcmVz aCgpOworICAgIHZvaWQgZmluZFRleHQoKTsKICAgICAKIHByaXZhdGU6CiAgICAgUVdlYlZpZXcq IG1fdmlldzsKQEAgLTIxMTYsNSArMjExNywyMSBAQCB2b2lkIHRzdF9RV2ViUGFnZTo6dGVzdFN0 b3BTY2hlZHVsZWRQYWdlUmVmcmVzaCgpCiAgICAgUUNPTVBBUkUocGFnZTIubWFpbkZyYW1lKCkt PnVybCgpLnRvU3RyaW5nKCksIFFTdHJpbmcoImFib3V0OmJsYW5rIikpOwogfQogCit2b2lkIHRz dF9RV2ViUGFnZTo6ZmluZFRleHQoKQoreworICAgIG1fdmlldy0+c2V0SHRtbChRU3RyaW5nKCI8 aHRtbD48aGVhZD48L2hlYWQ+PGJvZHk+PGRpdj5mb28gYmFyPC9kaXY+PC9ib2R5PjwvaHRtbD4i KSk7CisgICAgbV9wYWdlLT50cmlnZ2VyQWN0aW9uKFFXZWJQYWdlOjpTZWxlY3RBbGwpOworICAg IFFWRVJJRlkoIW1fcGFnZS0+c2VsZWN0ZWRUZXh0KCkuaXNFbXB0eSgpKTsKKyAgICBtX3BhZ2Ut PmZpbmRUZXh0KCIiKTsKKyAgICBRVkVSSUZZKG1fcGFnZS0+c2VsZWN0ZWRUZXh0KCkuaXNFbXB0 eSgpKTsKKyAgICBRU3RyaW5nTGlzdCB3b3JkcyA9IChRU3RyaW5nTGlzdCgpIDw8ICJmb28iIDw8 ICJiYXIiKTsKKyAgICBmb3JlYWNoIChRU3RyaW5nIHN1YlN0cmluZywgd29yZHMpIHsKKyAgICAg ICAgbV9wYWdlLT5maW5kVGV4dChzdWJTdHJpbmcsIFFXZWJQYWdlOjpGaW5kV3JhcHNBcm91bmRE b2N1bWVudCk7CisgICAgICAgIFFDT01QQVJFKG1fcGFnZS0+c2VsZWN0ZWRUZXh0KCksIHN1YlN0 cmluZyk7CisgICAgICAgIG1fcGFnZS0+ZmluZFRleHQoIiIpOworICAgICAgICBRVkVSSUZZKG1f cGFnZS0+c2VsZWN0ZWRUZXh0KCkuaXNFbXB0eSgpKTsKKyAgICB9Cit9CisKIFFURVNUX01BSU4o dHN0X1FXZWJQYWdlKQogI2luY2x1ZGUgInRzdF9xd2VicGFnZS5tb2MiCg== 58172 2010-06-08 12:57:51 -0700 2010-06-09 21:39:50 -0700 Argh, my Changelog really had no style at all! findText_clear_selection.patch text/plain 2736 pierre.rossi ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggODBkZDY2NC4uMDY3OGM1YiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTMw OTksNiArMzA5OSwxNCBAQCBib29sIFFXZWJQYWdlOjpmaW5kVGV4dChjb25zdCBRU3RyaW5nICZz dWJTdHJpbmcsIEZpbmRGbGFncyBvcHRpb25zKQogICAgICAgICB9IGVsc2UKICAgICAgICAgICAg IHJldHVybiBkLT5wYWdlLT5tYXJrQWxsTWF0Y2hlc0ZvclRleHQoc3ViU3RyaW5nLCBjYXNlU2Vu c2l0aXZpdHksIHRydWUsIDApOwogICAgIH0gZWxzZSB7CisgICAgICAgIGlmIChzdWJTdHJpbmcu aXNFbXB0eSgpKSB7CisgICAgICAgICAgICBkLT5wYWdlLT5tYWluRnJhbWUoKS0+c2VsZWN0aW9u KCktPmNsZWFyKCk7CisgICAgICAgICAgICBGcmFtZSogZnJhbWUgPSBkLT5wYWdlLT5tYWluRnJh bWUoKS0+dHJlZSgpLT5maXJzdENoaWxkKCk7CisgICAgICAgICAgICB3aGlsZSAoZnJhbWUpIHsK KyAgICAgICAgICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPmNsZWFyKCk7CisgICAgICAgICAg ICAgICAgZnJhbWUgPSBmcmFtZS0+dHJlZSgpLT50cmF2ZXJzZU5leHRXaXRoV3JhcChmYWxzZSk7 CisgICAgICAgICAgICB9CisgICAgICAgIH0KICAgICAgICAgOjpGaW5kRGlyZWN0aW9uIGRpcmVj dGlvbiA9IDo6RmluZERpcmVjdGlvbkZvcndhcmQ7CiAgICAgICAgIGlmIChvcHRpb25zICYgRmlu ZEJhY2t3YXJkKQogICAgICAgICAgICAgZGlyZWN0aW9uID0gOjpGaW5kRGlyZWN0aW9uQmFja3dh cmQ7CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxv ZwppbmRleCAxYjMyNjBlLi40MmJiMjFiIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9n CisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNi0wOCAg UGllcnJlIFJvc3NpICA8cGllcnJlLnJvc3NpQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBRV2ViUGFnZTo6ZmluZFRleHQoKSBkb2Vz IG5vdCBjbGVhciBzZWxlY3Rpb24gd2hlbiBwYXNzZWQgZW1wdHkgc3RyaW5nCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTc3OQorCisgICAgICAgICog QXBpL3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKFFXZWJQYWdlOjpmaW5kVGV4dCk6CisgICAgICAg ICogdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNwcDoKKyAgICAgICAgKHRzdF9RV2ViUGFn ZTo6ZmluZFRleHQpOgorCiAyMDEwLTA2LTA4ICBBbnRvbmlvIEdvbWVzICA8dG9uaWtpdG9vQHdl YmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgT2phbiBWYWZhaSBhbmQgRGFyaW4gQWRs ZXIuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvdGVzdHMvcXdlYnBhZ2UvdHN0X3F3ZWJwYWdlLmNw cCBiL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3BwCmluZGV4IDYzMGNj Y2UuLmIwZjlmYWYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdl YnBhZ2UuY3BwCisrKyBiL1dlYktpdC9xdC90ZXN0cy9xd2VicGFnZS90c3RfcXdlYnBhZ2UuY3Bw CkBAIC0xMjMsNiArMTIzLDcgQEAgcHJpdmF0ZSBzbG90czoKICAgICB2b2lkIHRlc3RKU1Byb21w dCgpOwogICAgIHZvaWQgc2hvd01vZGFsRGlhbG9nKCk7CiAgICAgdm9pZCB0ZXN0U3RvcFNjaGVk dWxlZFBhZ2VSZWZyZXNoKCk7CisgICAgdm9pZCBmaW5kVGV4dCgpOwogICAgIAogcHJpdmF0ZToK ICAgICBRV2ViVmlldyogbV92aWV3OwpAQCAtMjExNiw1ICsyMTE3LDIxIEBAIHZvaWQgdHN0X1FX ZWJQYWdlOjp0ZXN0U3RvcFNjaGVkdWxlZFBhZ2VSZWZyZXNoKCkKICAgICBRQ09NUEFSRShwYWdl Mi5tYWluRnJhbWUoKS0+dXJsKCkudG9TdHJpbmcoKSwgUVN0cmluZygiYWJvdXQ6YmxhbmsiKSk7 CiB9CiAKK3ZvaWQgdHN0X1FXZWJQYWdlOjpmaW5kVGV4dCgpCit7CisgICAgbV92aWV3LT5zZXRI dG1sKFFTdHJpbmcoIjxodG1sPjxoZWFkPjwvaGVhZD48Ym9keT48ZGl2PmZvbyBiYXI8L2Rpdj48 L2JvZHk+PC9odG1sPiIpKTsKKyAgICBtX3BhZ2UtPnRyaWdnZXJBY3Rpb24oUVdlYlBhZ2U6OlNl bGVjdEFsbCk7CisgICAgUVZFUklGWSghbV9wYWdlLT5zZWxlY3RlZFRleHQoKS5pc0VtcHR5KCkp OworICAgIG1fcGFnZS0+ZmluZFRleHQoIiIpOworICAgIFFWRVJJRlkobV9wYWdlLT5zZWxlY3Rl ZFRleHQoKS5pc0VtcHR5KCkpOworICAgIFFTdHJpbmdMaXN0IHdvcmRzID0gKFFTdHJpbmdMaXN0 KCkgPDwgImZvbyIgPDwgImJhciIpOworICAgIGZvcmVhY2ggKFFTdHJpbmcgc3ViU3RyaW5nLCB3 b3JkcykgeworICAgICAgICBtX3BhZ2UtPmZpbmRUZXh0KHN1YlN0cmluZywgUVdlYlBhZ2U6OkZp bmRXcmFwc0Fyb3VuZERvY3VtZW50KTsKKyAgICAgICAgUUNPTVBBUkUobV9wYWdlLT5zZWxlY3Rl ZFRleHQoKSwgc3ViU3RyaW5nKTsKKyAgICAgICAgbV9wYWdlLT5maW5kVGV4dCgiIik7CisgICAg ICAgIFFWRVJJRlkobV9wYWdlLT5zZWxlY3RlZFRleHQoKS5pc0VtcHR5KCkpOworICAgIH0KK30K KwogUVRFU1RfTUFJTih0c3RfUVdlYlBhZ2UpCiAjaW5jbHVkZSAidHN0X3F3ZWJwYWdlLm1vYyIK