31778 2009-11-21 16:53:33 -0800 Chromium: make rounded borders heavier. 2009-12-04 16:39:39 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All RESOLVED FIXED P2 Minor --- 1 agl webkit-unassigned brettw commit-queue eric jparent oldest_to_newest 165675 0 agl 2009-11-21 16:53:33 -0800 Skia draws its rounded corners differently from the other ports. Whereas they have anti-aliased clipping regions, Skia only has 1-bit regions. (Which is technically more correct, but somewhat unhelpful for us.) Instead, with Skia we use a layer and collect all the clipping paths in effect. When the state is popped, we paint transparency outside the clipping paths and merge the layer down. This appears to cause rounded borders to look a little thin, which is addressed in this patch. This is well covered by existing tests but will require new baselines in the Chromium tree. 165676 1 43668 agl 2009-11-21 16:55:52 -0800 Created attachment 43668 patch (Note: please don't cq+ this patch.) 165983 2 43668 eric 2009-11-23 20:09:07 -0800 Comment on attachment 43668 patch Marking cq- per Adam's note above. 165984 3 43668 eric 2009-11-23 20:10:07 -0800 Comment on attachment 43668 patch LGTM. CC'd brett so he sees this go by. 168960 4 43668 jparent 2009-12-04 15:35:12 -0800 Comment on attachment 43668 patch Setting commit-queue+ as we are ready on Chromium side for this to land. 168981 5 43668 commit-queue 2009-12-04 16:39:34 -0800 Comment on attachment 43668 patch Clearing flags on attachment: 43668 Committed r51722: <http://trac.webkit.org/changeset/51722> 168982 6 commit-queue 2009-12-04 16:39:39 -0800 All reviewed patches have been landed. Closing bug. 43668 2009-11-21 16:55:52 -0800 2009-12-04 16:39:34 -0800 patch patch text/plain 2248 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjYwMjkxNS4uN2ZiMWY5MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNyBAQAorMjAwOS0xMS0yMSAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hyb21pdW06IG1ha2Ugcm91bmRlZCBib3JkZXJzIGhlYXZpZXIuCisKKyAg ICAgICAgU2tpYSBkcmF3cyBpdHMgcm91bmRlZCBjb3JuZXJzIGRpZmZlcmVudGx5IGZyb20gdGhl IG90aGVyIHBvcnRzLgorICAgICAgICBXaGVyZWFzIHRoZXkgaGF2ZSBhbnRpLWFsaWFzZWQgY2xp cHBpbmcgcmVnaW9ucywgU2tpYSBvbmx5IGhhcyAxLWJpdAorICAgICAgICByZWdpb25zLiAoV2hp Y2ggaXMgdGVjaG5pY2FsbHkgbW9yZSBjb3JyZWN0LCBidXQgc29tZXdoYXQgdW5oZWxwZnVsCisg ICAgICAgIGZvciB1cy4pIEluc3RlYWQsIHdpdGggU2tpYSB3ZSB1c2UgYSBsYXllciBhbmQgY29s bGVjdCBhbGwgdGhlCisgICAgICAgIGNsaXBwaW5nIHBhdGhzIGluIGVmZmVjdC4gV2hlbiB0aGUg c3RhdGUgaXMgcG9wcGVkLCB3ZSBwYWludAorICAgICAgICB0cmFuc3BhcmVuY3kgb3V0c2lkZSB0 aGUgY2xpcHBpbmcgcGF0aHMgYW5kIG1lcmdlIHRoZSBsYXllciBkb3duLgorCisgICAgICAgIFRo aXMgYXBwZWFycyB0byBjYXVzZSByb3VuZGVkIGJvcmRlcnMgdG8gbG9vayBhIGxpdHRsZSB0aGlu LCB3aGljaCBpcworICAgICAgICBhZGRyZXNzZWQgaW4gdGhpcyBwYXRjaC4KKworICAgICAgICBU aGlzIGlzIHdlbGwgY292ZXJlZCBieSBleGlzdGluZyB0ZXN0cyBidXQgd2lsbCByZXF1aXJlIG5l dyBiYXNlbGluZXMKKyAgICAgICAgaW4gdGhlIENocm9taXVtIHRyZWUuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzc4CisKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9za2lhL0dyYXBoaWNzQ29udGV4dFNraWEuY3BwOgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0OjphZGRJbm5lclJvdW5kZWRSZWN0Q2xpcCk6CisKIDIw MDktMTEtMjEgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgRGFuIEJlcm5zdGVpbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3Mvc2tpYS9HcmFwaGljc0NvbnRleHRTa2lhLmNwcAppbmRleCAwMTczN2ExLi5m MTUzNmE2IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvR3JhcGhp Y3NDb250ZXh0U2tpYS5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL0dy YXBoaWNzQ29udGV4dFNraWEuY3BwCkBAIC0yOTMsNyArMjkzLDEwIEBAIHZvaWQgR3JhcGhpY3ND b250ZXh0OjphZGRJbm5lclJvdW5kZWRSZWN0Q2xpcChjb25zdCBJbnRSZWN0JiByZWN0LCBpbnQg dGhpY2tuZXNzCiAgICAgcGF0aC5hZGRPdmFsKHIsIFNrUGF0aDo6a0NXX0RpcmVjdGlvbik7CiAg ICAgLy8gb25seSBwZXJmb3JtIHRoZSBpbnNldCBpZiB3ZSB3b24ndCBpbnZlcnQgcgogICAgIGlm ICgyICogdGhpY2tuZXNzIDwgcmVjdC53aWR0aCgpICYmIDIgKiB0aGlja25lc3MgPCByZWN0Lmhl aWdodCgpKSB7Ci0gICAgICAgIHIuaW5zZXQoU2tJbnRUb1NjYWxhcih0aGlja25lc3MpLCBTa0lu dFRvU2NhbGFyKHRoaWNrbmVzcykpOworICAgICAgICAvLyBBZGRpbmcgb25lIHRvIHRoZSB0aGlj a25lc3MgZG9lc24ndCBtYWtlIHRoZSBib3JkZXIgdG9vIHRoaWNrIGFzCisgICAgICAgIC8vIGl0 J3MgcGFpbnRlZCBvdmVyIGFmdGVyd2FyZHMuIEJ1dCB3aXRob3V0IHRoaXMgYWRqdXN0bWVudCB0 aGUKKyAgICAgICAgLy8gYm9yZGVyIGFwcGVhcnMgYSBsaXR0bGUgYW5lbWljIGFmdGVyIGFudGkt YWxpYXNpbmcuCisgICAgICAgIHIuaW5zZXQoU2tJbnRUb1NjYWxhcih0aGlja25lc3MgKyAxKSwg U2tJbnRUb1NjYWxhcih0aGlja25lc3MgKyAxKSk7CiAgICAgICAgIHBhdGguYWRkT3ZhbChyLCBT a1BhdGg6OmtDQ1dfRGlyZWN0aW9uKTsKICAgICB9CiAgICAgcGxhdGZvcm1Db250ZXh0KCktPmNs aXBQYXRoQW50aUFsaWFzZWQocGF0aCk7Cg==