31775 2009-11-21 16:07:34 -0800 [Qt] DRT: dumpBackForwardList() does not work properly with non-file URLs. 2009-11-23 13:48:27 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P3 Normal --- 31638 0 jwieczorek webkit-unassigned commit-queue oldest_to_newest 165665 0 jwieczorek 2009-11-21 16:07:34 -0800 LayoutTestController::dumpBackForwardList() should work with local URLs as well as with normal URLs (in http tests for instance). Currently it does not output the latter properly. 165667 1 43662 jwieczorek 2009-11-21 16:16:43 -0800 Created attachment 43662 proposed patch This change fixes some http/navigation tests: Before: 6 test cases (7%) succeeded 54 test cases (70%) had incorrect layout 12 test cases (15%) were new 2 test cases (2%) timed out 3 test cases (3%) crashed 1 test case (1%) had stderr output After: 32 test cases (41%) succeeded 28 test cases (36%) had incorrect layout 12 test cases (15%) were new 2 test cases (2%) timed out 3 test cases (3%) crashed 1 test case (1%) had stderr output Not setting r? because of the dependency on https://bugs.webkit.org/show_bug.cgi?id=31638 165758 2 43662 jwieczorek 2009-11-22 12:29:57 -0800 Comment on attachment 43662 proposed patch Depends on https://bug-31638-attachments.webkit.org/attachment.cgi?id=43449 165919 3 43662 commit-queue 2009-11-23 13:48:21 -0800 Comment on attachment 43662 proposed patch Clearing flags on attachment: 43662 Committed r51316: <http://trac.webkit.org/changeset/51316> 165920 4 commit-queue 2009-11-23 13:48:27 -0800 All reviewed patches have been landed. Closing bug. 43662 2009-11-21 16:16:43 -0800 2009-11-23 13:48:21 -0800 proposed patch 0001-Qt-DRT-dumpBackForwardList-does-not-work-properly-wi.patch text/plain 6158 jwieczorek RnJvbSBlNjE5NDFiYzNiYzFlZjA5YWJlZTQxMWFjMTgzNTE1OGQ2MWJkMDg3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBKYWt1YiBXaWVjem9yZWsgPGZhdzIxN0BnbWFpbC5jb20+CkRh dGU6IFN1biwgMjIgTm92IDIwMDkgMDE6MTE6MzQgKzAwMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IERSVDogZHVtcEJhY2tGb3J3YXJkTGlzdCgpIGRvZXMgbm90IHdvcmsgcHJvcGVybHkgd2l0aCBu b24tZmlsZSBVUkxzLgogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMx Nzc1CgpMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZHVtcEJhY2tGb3J3YXJkTGlzdCgpIHNob3VsZCB3 b3JrIHdpdGggbG9jYWwgVVJMcwphcyB3ZWxsIGFzIHdpdGggbm9ybWFsIFVSTHMgKGluIGh0dHAg dGVzdHMgZm9yIGluc3RhbmNlKS4KQ3VycmVudGx5IGl0IGRvZXMgbm90IG91dHB1dCB0aGUgbGF0 dGVyIHByb3Blcmx5LgoKRml4IHRoYXQgYW5kIHVuc2tpcCBhIGJ1bmNoIG9mIHBhc3NpbmcgaHR0 cC9uYXZpZ2F0aW9uIHRlc3RzLgotLS0KIExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8ICAgMTUgKysrKysrKwogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQv U2tpcHBlZCAgICAgICAgICAgICAgICAgIHwgICA0OCArKysrKysrKysrKysrKysrKysrKystCiBX ZWJLaXRUb29scy9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE2ICsr KysrKysKIFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcCB8 ICAgIDggKystCiA0IGZpbGVzIGNoYW5nZWQsIDgzIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25z KC0pCgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh bmdlTG9nCmluZGV4IDlkNzRhYjMuLmFiYjYwOGEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAw OS0xMS0yMSAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWlsLmNvbT4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIERSVDogZHVtcEJhY2tG b3J3YXJkTGlzdCgpIGRvZXMgbm90IHdvcmsgcHJvcGVybHkgd2l0aCBub24tZmlsZSBVUkxzLgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE3NzUKKwor ICAgICAgICBMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZHVtcEJhY2tGb3J3YXJkTGlzdCgpIHNob3Vs ZCB3b3JrIHdpdGggbG9jYWwgVVJMcworICAgICAgICBhcyB3ZWxsIGFzIHdpdGggbm9ybWFsIFVS THMgKGluIGh0dHAgdGVzdHMgZm9yIGluc3RhbmNlKS4KKyAgICAgICAgQ3VycmVudGx5IGl0IGRv ZXMgbm90IG91dHB1dCB0aGUgbGF0dGVyIHByb3Blcmx5LgorCisgICAgICAgIFVuc2tpcCBhIGJ1 bmNoIG9mIHBhc3NpbmcgaHR0cC9uYXZpZ2F0aW9uIHRlc3RzLgorCisgICAgICAgICogcGxhdGZv cm0vcXQvU2tpcHBlZDoKKwogMjAwOS0xMS0yMCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hA YXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJldGggRGFraW4uCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v cXQvU2tpcHBlZAppbmRleCA2Y2U3NThmLi5hMGUzNzU4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBw ZWQKQEAgLTM1LDcgKzM1LDYgQEAgaHR0cC90ZXN0cy9nbG9iYWxoaXN0b3J5CiBodHRwL3Rlc3Rz L2hpc3RvcnkKIGh0dHAvdGVzdHMvaW5jcmVtZW50YWwKIGh0dHAvdGVzdHMvbWVkaWEKLWh0dHAv dGVzdHMvbmF2aWdhdGlvbgogaHR0cC90ZXN0cy9wbHVnaW5zCiBodHRwL3Rlc3RzL3NzbAogaHR0 cC90ZXN0cy93ZWJhcmNoaXZlCkBAIC02NSw2ICs2NCw1MyBAQCBodHRwL3Rlc3RzL2xvYWRpbmcv dGV4dC1jb250ZW50LXR5cGUtd2l0aC1iaW5hcnktZXh0ZW5zaW9uLmh0bWwKIGh0dHAvdGVzdHMv bG9jYWwvZHJhZy1vdmVyLXJlbW90ZS1jb250ZW50Lmh0bWwKIGh0dHAvdGVzdHMvbG9jYWwvc2Vu ZC1kcmFnZ2VkLWZpbGUuaHRtbAogCisjIEZhaWxpbmcgbmF2aWdhdGlvbiB0ZXN0cworaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL2FuY2hvci1mcmFtZXMuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9u L2FuY2hvci1zdWJmcmFtZWxvYWQuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2JhY2stdG8t c2xvdy1mcmFtZS5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vY2hhbmdpbmctZnJhbWUtaGll cmFyY2h5LWluLW9ubG9hZC5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vZXJyb3I0MDQtYmFz aWMuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2Vycm9yNDA0LWZyYW1lcy5odG1sCitodHRw L3Rlc3RzL25hdmlnYXRpb24vZXJyb3I0MDQtZ29iYWNrLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdh dGlvbi9lcnJvcjQwNC1zdWJmcmFtZWxvYWQuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2ph dmFzY3JpcHRsaW5rLWJhc2ljLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9qYXZhc2NyaXB0 bGluay1mcmFtZXMuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2phdmFzY3JpcHRsaW5rLWdv YmFjay5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vamF2YXNjcmlwdGxpbmstc3ViZnJhbWVs b2FkLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9sb2NrZWRoaXN0b3J5LWlmcmFtZS5odG1s CitodHRwL3Rlc3RzL25hdmlnYXRpb24vbWV0YXJlZGlyZWN0LWJhc2ljLmh0bWwKK2h0dHAvdGVz dHMvbmF2aWdhdGlvbi9tZXRhcmVkaXJlY3QtZnJhbWVzLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdh dGlvbi9tZXRhcmVkaXJlY3QtZ29iYWNrLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9tZXRh cmVkaXJlY3Qtc3ViZnJhbWVsb2FkLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9uZXctd2lu ZG93LXJlZGlyZWN0LWhpc3RvcnkuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL25vLXJlZmVy cmVyLXJlc2V0Lmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9uby1yZWZlcnJlci10YXJnZXQt YmxhbmsuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL29ubG9hZC1uYXZpZ2F0aW9uLWlmcmFt ZS0yLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9vbmxvYWQtbmF2aWdhdGlvbi1pZnJhbWUt dGltZW91dC5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vb25sb2FkLW5hdmlnYXRpb24taWZy YW1lLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9wb3N0LWJhc2ljLmh0bWwKK2h0dHAvdGVz dHMvbmF2aWdhdGlvbi9wb3N0LWZyYW1lcy5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vcG9z dC1nb2JhY2sxLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9wb3N0LWdvYmFjazIuaHRtbAor aHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3RyZWRpcmVjdC1iYXNpYy5odG1sCitodHRwL3Rlc3Rz L25hdmlnYXRpb24vcG9zdHJlZGlyZWN0LWZyYW1lcy5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRp b24vcG9zdHJlZGlyZWN0LWdvYmFjazEuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Bvc3Ry ZWRpcmVjdC1nb2JhY2syLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWRpcmVjdDMwMi1m cmFtZXMuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3JlZGlyZWN0MzAyLXN1YmZyYW1lbG9h ZC5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vcmVsYXRpdmVhbmNob3ItZnJhbWVzLmh0bWwK K2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxvYWQtc3ViZnJhbWUtb2JqZWN0Lmh0bWwKK2h0dHAv dGVzdHMvbmF2aWdhdGlvbi9zbG93bWV0YXJlZGlyZWN0LWJhc2ljLmh0bWwKK2h0dHAvdGVzdHMv bmF2aWdhdGlvbi9zbG93dGltZXJyZWRpcmVjdC1iYXNpYy5odG1sCitodHRwL3Rlc3RzL25hdmln YXRpb24vc3VjY2VzczIwMC1mcmFtZXMtbG9hZHNhbWUuaHRtbAoraHR0cC90ZXN0cy9uYXZpZ2F0 aW9uL3N1Y2Nlc3MyMDAtZnJhbWVzLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9zdWNjZXNz MjAwLXN1YmZyYW1lbG9hZC5odG1sCitodHRwL3Rlc3RzL25hdmlnYXRpb24vdGFyZ2V0LWZyYW1l LWZyb20td2luZG93Lmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi90aW1lcnJlZGlyZWN0LWJh c2ljLmh0bWwKK2h0dHAvdGVzdHMvbmF2aWdhdGlvbi90aW1lcnJlZGlyZWN0LWZyYW1lcy5odG1s CitodHRwL3Rlc3RzL25hdmlnYXRpb24vdGltZXJyZWRpcmVjdC1nb2JhY2suaHRtbAoraHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3RpbWVycmVkaXJlY3Qtc3ViZnJhbWVsb2FkLmh0bWwKKwogIyBGYWls aW5nIHNlY3VyaXR5IHRlc3RzCiBodHRwL3Rlc3RzL3NlY3VyaXR5L2ZyYW1lLWxvYWRpbmctdmlh LWRvY3VtZW50LXdyaXRlLmh0bWwKIApkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9n IGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGY5YjRkNzEuLjNhMTRjYmQgMTAwNjQ0Ci0t LSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOSBAQAorMjAwOS0xMS0yMSAgSmFrdWIgV2llY3pvcmVrICA8ZmF3MjE3QGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBb UXRdIERSVDogZHVtcEJhY2tGb3J3YXJkTGlzdCgpIGRvZXMgbm90IHdvcmsgcHJvcGVybHkgd2l0 aCBub24tZmlsZSBVUkxzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzE3NzUKKworICAgICAgICBMYXlvdXRUZXN0Q29udHJvbGxlcjo6ZHVtcEJhY2tG b3J3YXJkTGlzdCgpIHNob3VsZCB3b3JrIHdpdGggbG9jYWwgVVJMcworICAgICAgICBhcyB3ZWxs IGFzIHdpdGggbm9ybWFsIFVSTHMgKGluIGh0dHAgdGVzdHMgZm9yIGluc3RhbmNlKS4KKyAgICAg ICAgQ3VycmVudGx5IGl0IGRvZXMgbm90IG91dHB1dCB0aGUgbGF0dGVyIHByb3Blcmx5LgorCisg ICAgICAgIFVuc2tpcCBhIGJ1bmNoIG9mIHBhc3NpbmcgaHR0cC9uYXZpZ2F0aW9uIHRlc3RzLgor CisgICAgICAgICogRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6ZHVtcEhpc3RvcnlJdGVtKToKKwogMjAwOS0xMS0yMCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpk aWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUu Y3BwIGIvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRHVtcFJlbmRlclRyZWUuY3BwCmlu ZGV4IGE5MjE5ODAuLjNkMGZjNDQgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJU cmVlL3F0L0R1bXBSZW5kZXJUcmVlLmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJl ZS9xdC9EdW1wUmVuZGVyVHJlZS5jcHAKQEAgLTQ3OSwxMCArNDc5LDEyIEBAIHN0YXRpYyBRU3Ry aW5nIGR1bXBIaXN0b3J5SXRlbShjb25zdCBRV2ViSGlzdG9yeUl0ZW0mIGl0ZW0sIGludCBpbmRl bnQsIGJvb2wgY3VyCiAKICAgICAgICAgcmVzdWx0LmFwcGVuZChmaWxlVGVzdFN0cmluZyk7CiAg ICAgICAgIHJlc3VsdC5hcHBlbmQocmVzKTsKLQotICAgICAgICAvLyBGSVhNRTogV3JvbmcsIG5l ZWQgKHByaXZhdGU/KSBBUEkgZm9yIGRldGVybWluaW5nIHRoaXMuCi0gICAgICAgIHJlc3VsdC5h cHBlbmQoUUxhdGluMVN0cmluZygiICAqKm5hdiB0YXJnZXQqKiIpKTsKKyAgICB9IGVsc2Ugewor ICAgICAgICByZXN1bHQuYXBwZW5kKHVybCk7CiAgICAgfQorCisgICAgLy8gRklYTUU6IFdyb25n LCBuZWVkIChwcml2YXRlPykgQVBJIGZvciBkZXRlcm1pbmluZyB0aGlzLgorICAgIHJlc3VsdC5h cHBlbmQoUUxhdGluMVN0cmluZygiICAqKm5hdiB0YXJnZXQqKiIpKTsKICAgICByZXN1bHQuYXBw ZW5kKFFMYXRpbjFTdHJpbmcoIlxuIikpOwogCiAgICAgcmV0dXJuIHJlc3VsdDsKLS0gCjEuNi41 Cgo=