31767 2009-11-21 07:01:55 -0800 commit-queue fails to run with "permissions error" due to bad bugzilla-tool path 2009-11-21 07:50:38 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth oldest_to_newest 165600 0 eric 2009-11-21 07:01:55 -0800 commit-queue fails to run with "permissions error" due to bad bugzilla-tool path When we moved the queue commands into queues.py, an important __file__ definition came with, and now the commit-queue is trying to exec queues.py instead of bugzilla-tool when launching land-attachment for the commit-queue. I couldn't think of a useful unit test for this. What we really want to test is that BugzillaToo.path() points to an executable script. However we don't have any way to unit test BugzillaTool itself yet. 165601 1 43647 eric 2009-11-21 07:05:13 -0800 Created attachment 43647 Patch 165610 2 43647 abarth 2009-11-21 07:28:16 -0800 Comment on attachment 43647 Patch Yep. My bad 165616 3 eric 2009-11-21 07:50:38 -0800 Committed r51283: <http://trac.webkit.org/changeset/51283> 43647 2009-11-21 07:05:13 -0800 2009-11-21 07:28:16 -0800 Patch bug-31767-20091121070511.patch text/plain 3812 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MDliODg2Li41MmI5MWQ4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMDktMTEt MjEgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIGNvbW1pdC1xdWV1ZSBmYWlscyB0byBydW4gd2l0 aCAicGVybWlzc2lvbnMgZXJyb3IiIGR1ZSB0byBiYWQgYnVnemlsbGEtdG9vbCBwYXRoCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zMTc2NworCisgICAg ICAgIFdoYXQgd2UgcmVhbGx5IHdhbnQgdG8gdGVzdCBpcyBCdWd6aWxsYVRvb2wucGF0aCgpIGlu c3RlYWQgb2YgVHJpdmlhbFRvb2wucGF0aCgpLgorICAgICAgICBTaW5jZSB3ZSBkb24ndCBoYXZl IGEgZ29vZCB3YXkgdG8gdGVzdCBCdWd6aWxsYVRvb2wgcGllY2VzLCBJJ3ZlCisgICAgICAgIGxl ZnQgb3V0IGEgdGVzdCBmb3Igbm93LgorCisgICAgICAgICogU2NyaXB0cy9idWd6aWxsYS10b29s OgorICAgICAgICAgLSBBZGQgYSBwYXRoKCkgaW1wbGVtZW50YXRpb24gdG8gZXhwb3NlIGJ1Z3pp bGxhLXRvb2wncyBfX2ZpbGVfXyBwYXRoIHRvIGNvbW1pdC1xdWV1ZS4KKyAgICAgICAgKiBTY3Jp cHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5OgorICAgICAgICAgLSBVc2UgdG9vbC5wYXRo KCkgaW5zdGVhZCBvZiBfX2ZpbGVfXy4KKyAgICAgICAgKiBTY3JpcHRzL21vZHVsZXMvbXVsdGlj b21tYW5kdG9vbC5weToKKyAgICAgICAgIC0gQWRkIGEgbmV3IHBhdGgoKSBtZXRob2QgdG8gTXVs dGlDb21hbmRUb29sLgorICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9tdWx0aWNvbW1hbmR0b29s X3VuaXR0ZXN0LnB5OgorICAgICAgICAgLSBQcm92aWRlIGEgcGF0aCgpIG1ldGhvZC4gIExpdHRs ZSBwb2ludCBpbiB0ZXN0aW5nIHRoaXMgbW9jayBpbXBsZW1lbnRhdGlvbi4KKwogMjAwOS0xMS0y MCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10 b29sIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWd6aWxsYS10b29sCmluZGV4IDI3NWUxZjEuLjNh NDhjNWIgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVnemlsbGEtdG9vbAorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL2J1Z3ppbGxhLXRvb2wKQEAgLTcyLDYgKzcyLDkgQEAgY2xh c3MgQnVnemlsbGFUb29sKE11bHRpQ29tbWFuZFRvb2wpOgogCiAgICAgICAgIHJldHVybiBzZWxm LmNhY2hlZF9zY20KIAorICAgIGRlZiBwYXRoKHNlbGYpOgorICAgICAgICByZXR1cm4gX19maWxl X18KKwogICAgIGRlZiBzaG91bGRfc2hvd19jb21tYW5kX2hlbHAoc2VsZiwgY29tbWFuZCk6CiAg ICAgICAgIGlmIGNvbW1hbmQucmVxdWlyZXNfbG9jYWxfY29tbWl0czoKICAgICAgICAgICAgIHJl dHVybiBzZWxmLnNjbSgpLnN1cHBvcnRzX2xvY2FsX2NvbW1pdHMoKQpkaWZmIC0tZ2l0IGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVlcy5weSBiL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9xdWV1ZXMucHkKaW5kZXggMjNmYzA3ZC4uZmVlN2Y2 ZCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL3F1ZXVl cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvY29tbWFuZHMvcXVldWVzLnB5 CkBAIC05NCwxMCArOTQsOCBAQCBjbGFzcyBBYnN0cmFjdFF1ZXVlKENvbW1hbmQsIFdvcmtRdWV1 ZURlbGVnYXRlKToKICAgICBkZWYgaGFuZGxlX3VuZXhwZWN0ZWRfZXJyb3Ioc2VsZiwgd29ya19p dGVtLCBtZXNzYWdlKToKICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNs YXNzZXMgbXVzdCBpbXBsZW1lbnQiCiAKLSAgICBAc3RhdGljbWV0aG9kCi0gICAgZGVmIHJ1bl9i dWd6aWxsYV90b29sKGFyZ3MpOgotICAgICAgICBidWd6aWxsYV90b29sX3BhdGggPSBfX2ZpbGVf XyAjIHJlLWV4ZWN1dGUgdGhpcyBzY3JpcHQKLSAgICAgICAgYnVnemlsbGFfdG9vbF9hcmdzID0g W2J1Z3ppbGxhX3Rvb2xfcGF0aF0gKyBhcmdzCisgICAgZGVmIHJ1bl9idWd6aWxsYV90b29sKHNl bGYsIGFyZ3MpOgorICAgICAgICBidWd6aWxsYV90b29sX2FyZ3MgPSBbdG9vbC5wYXRoKCldICsg YXJncwogICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5ydW5fYW5kX3Rocm93X2lmX2ZhaWwo YnVnemlsbGFfdG9vbF9hcmdzKQogCiAgICAgZGVmIGxvZ19wcm9ncmVzcyhzZWxmLCBwYXRjaF9p ZHMpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL211bHRpY29tbWFu ZHRvb2wucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvbXVsdGljb21tYW5kdG9vbC5w eQppbmRleCBmZTNjMmQ0Li45MDE0OGIyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRz L21vZHVsZXMvbXVsdGljb21tYW5kdG9vbC5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL21v ZHVsZXMvbXVsdGljb21tYW5kdG9vbC5weQpAQCAtMTU0LDEzICsxNTQsMTUgQEAgY2xhc3MgTXVs dGlDb21tYW5kVG9vbChvYmplY3QpOgogICAgICAgICAgICAgICAgIHJldHVybiBjb21tYW5kCiAg ICAgICAgIHJldHVybiBOb25lCiAKKyAgICBkZWYgcGF0aChzZWxmKToKKyAgICAgICAgcmFpc2Ug Tm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCisKICAgICBk ZWYgc2hvdWxkX3Nob3dfY29tbWFuZF9oZWxwKHNlbGYsIGNvbW1hbmQpOgogICAgICAgICByYWlz ZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKIAogICAg IGRlZiBzaG91bGRfZXhlY3V0ZV9jb21tYW5kKHNlbGYsIGNvbW1hbmQpOgogICAgICAgICByYWlz ZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKIAotCiAg ICAgZGVmIG1haW4oc2VsZiwgYXJndj1zeXMuYXJndik6CiAgICAgICAgIChnbG9iYWxfYXJncywg Y29tbWFuZF9uYW1lLCBhcmdzX2FmdGVyX2NvbW1hbmRfbmFtZSkgPSBzZWxmLl9zcGxpdF9hcmdz KGFyZ3ZbMTpdKQogCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL21vZHVsZXMvbXVs dGljb21tYW5kdG9vbF91bml0dGVzdC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9t dWx0aWNvbW1hbmR0b29sX3VuaXR0ZXN0LnB5CmluZGV4IDMzY2ZkZjIuLmRiYWU5MDkgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9tdWx0aWNvbW1hbmR0b29sX3VuaXR0 ZXN0LnB5CisrKyBiL1dlYktpdFRvb2xzL1NjcmlwdHMvbW9kdWxlcy9tdWx0aWNvbW1hbmR0b29s X3VuaXR0ZXN0LnB5CkBAIC01NSw2ICs1NSw5IEBAIGNsYXNzIFRyaXZpYWxUb29sKE11bHRpQ29t bWFuZFRvb2wpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBjb21tYW5kcz1Ob25lKToKICAgICAg ICAgTXVsdGlDb21tYW5kVG9vbC5fX2luaXRfXyhzZWxmLCBjb21tYW5kcykKIAorICAgIGRlZiBw YXRoKCk6CisgICAgICAgIHJldHVybiBfX2ZpbGVfXworCiAgICAgZGVmIHNob3VsZF9zaG93X2Nv bW1hbmRfaGVscChzZWxmLCBjb21tYW5kKToKICAgICAgICAgcmV0dXJuIFRydWUKIAo=