31763 2009-11-20 20:26:54 -0800 Convert check-style to use LandingSequence 2009-11-21 07:29:13 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 165562 0 abarth 2009-11-20 20:26:54 -0800 Instead of manipulating the working copy by hand, we should use the LandingSequence in CheckStyle. 165563 1 43640 abarth 2009-11-20 20:31:52 -0800 Created attachment 43640 Patch 165584 2 43640 eric 2009-11-21 00:44:35 -0800 Comment on attachment 43640 Patch OK. 165611 3 43640 abarth 2009-11-21 07:29:08 -0800 Comment on attachment 43640 Patch Clearing flags on attachment: 43640 Committed r51281: <http://trac.webkit.org/changeset/51281> 165612 4 abarth 2009-11-21 07:29:13 -0800 All reviewed patches have been landed. Closing bug. 43640 2009-11-20 20:31:52 -0800 2009-11-21 07:29:08 -0800 Patch bug-31763-20091120203151.patch text/plain 4038 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA2MDliODg2Li5kZWFlMTVmIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTggQEAKIDIwMDktMTEt MjAgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb252ZXJ0IGNoZWNrLXN0eWxlIHRvIHVzZSBM YW5kaW5nU2VxdWVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTMxNzYzCisKKyAgICAgICAgSW5zdGVhZCBvZiBtYW5pcHVsYXRpbmcgdGhlIHdvcmtp bmcgY29weSBieSBoYW5kLCB3ZSBzaG91bGQgdXNlIHRoZQorICAgICAgICBMYW5kaW5nU2VxdWVu Y2UgaW4gQ2hlY2tTdHlsZS4gIFRoaXMgd2lsbCBtYWtlIHRoaXMgY29kZSBlYWlzZXIgdG8KKyAg ICAgICAgdGVzdC4KKworICAgICAgICAqIFNjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9h ZC5weToKKworMjAwOS0xMS0yMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgorCiAg ICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgogCiAgICAgICAgIFVuaXQgdGVzdCBxdWVy eSBjb21tYW5kcwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1h bmRzL2Rvd25sb2FkLnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9tb2R1bGVzL2NvbW1hbmRzL2Rv d25sb2FkLnB5CmluZGV4IGQ2ZmZkZWIuLjFiODhjZDYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xz L1NjcmlwdHMvbW9kdWxlcy9jb21tYW5kcy9kb3dubG9hZC5weQorKysgYi9XZWJLaXRUb29scy9T Y3JpcHRzL21vZHVsZXMvY29tbWFuZHMvZG93bmxvYWQucHkKQEAgLTU0LDM1ICs1NCw2IEBAIGZy b20gbW9kdWxlcy53ZWJraXRsYW5kaW5nc2NyaXB0cyBpbXBvcnQgV2ViS2l0TGFuZGluZ1Njcmlw dHMsIGNvbW1pdF9tZXNzYWdlX2ZvCiBmcm9tIG1vZHVsZXMud2Via2l0cG9ydCBpbXBvcnQgV2Vi S2l0UG9ydAogZnJvbSBtb2R1bGVzLndvcmtxdWV1ZSBpbXBvcnQgV29ya1F1ZXVlLCBXb3JrUXVl dWVEZWxlZ2F0ZQogCi1jbGFzcyBDaGVja1N0eWxlKENvbW1hbmQpOgotICAgIG5hbWUgPSAiY2hl Y2stc3R5bGUiCi0gICAgZGVmIF9faW5pdF9fKHNlbGYpOgotICAgICAgICBvcHRpb25zID0gV2Vi S2l0TGFuZGluZ1NjcmlwdHMuY2xlYW5pbmdfb3B0aW9ucygpCi0gICAgICAgIENvbW1hbmQuX19p bml0X18oc2VsZiwgIlJ1bnMgY2hlY2std2Via2l0LXN0eWxlIG9uIHRoZSBzcGVjaWZpZWQgYXR0 YWNobWVudCIsICJBVFRBQ0hNRU5UX0lEIiwgb3B0aW9ucz1vcHRpb25zKQotCi0gICAgQGNsYXNz bWV0aG9kCi0gICAgZGVmIGNoZWNrX3N0eWxlKGNscywgcGF0Y2gsIG9wdGlvbnMsIHRvb2wpOgot ICAgICAgICB0b29sLnNjbSgpLnVwZGF0ZV93ZWJraXQoKQotICAgICAgICBsb2coIkNoZWNraW5n IHN0eWxlIGZvciBwYXRjaCAlcyBmcm9tIGJ1ZyAlcy4iICUgKHBhdGNoWyJpZCJdLCBwYXRjaFsi YnVnX2lkIl0pKQotICAgICAgICB0cnk6Ci0gICAgICAgICAgICAjIEZJWE1FOiBjaGVjay13ZWJr aXQtc3R5bGUgc2hvdWxkbid0IHJlYWxseSBoYXZlIHRvIGFwcGx5IHRoZSBwYXRjaCB0byBjaGVj ayB0aGUgc3R5bGUuCi0gICAgICAgICAgICB0b29sLnNjbSgpLmFwcGx5X3BhdGNoKHBhdGNoKQot ICAgICAgICAgICAgV2ViS2l0TGFuZGluZ1NjcmlwdHMucnVuX3dlYmtpdF9zY3JpcHQoImNoZWNr LXdlYmtpdC1zdHlsZSIpCi0gICAgICAgIGV4Y2VwdCBTY3JpcHRFcnJvciwgZToKLSAgICAgICAg ICAgIGxvZygiUGF0Y2ggJXMgZnJvbSBidWcgJXMgZmFpbGVkIHRvIGFwcGx5IGFuZCBjaGVjayBz dHlsZS4iICUgKHBhdGNoWyJpZCJdLCBwYXRjaFsiYnVnX2lkIl0pKQotICAgICAgICAgICAgbG9n KGUub3V0cHV0KQotCi0gICAgICAgICMgVGhpcyBpcyBzYWZlIGJlY2F1c2UgaW4gb3JkZXIgdG8g Z2V0IGhlcmUgdGhlIHdvcmtpbmcgZGlyZWN0b3J5IGhhZCB0byBiZQotICAgICAgICAjIGNsZWFu IGF0IHRoZSBiZWdpbm5pbmcuICBDbGVhbiBpdCBvdXQgYWdhaW4gYmVmb3JlIHdlIGV4aXQuCi0g ICAgICAgIHRvb2wuc2NtKCkuZW5zdXJlX2NsZWFuX3dvcmtpbmdfZGlyZWN0b3J5KGZvcmNlX2Ns ZWFuPVRydWUpCi0KLSAgICBkZWYgZXhlY3V0ZShzZWxmLCBvcHRpb25zLCBhcmdzLCB0b29sKToK LSAgICAgICAgYXR0YWNobWVudF9pZCA9IGFyZ3NbMF0KLSAgICAgICAgYXR0YWNobWVudCA9IHRv b2wuYnVncy5mZXRjaF9hdHRhY2htZW50KGF0dGFjaG1lbnRfaWQpCi0KLSAgICAgICAgV2ViS2l0 TGFuZGluZ1NjcmlwdHMucHJlcGFyZV9jbGVhbl93b3JraW5nX2RpcmVjdG9yeSh0b29sLnNjbSgp LCBvcHRpb25zKQotICAgICAgICBzZWxmLmNoZWNrX3N0eWxlKGF0dGFjaG1lbnQsIG9wdGlvbnMs IHRvb2wpCi0KIAogY2xhc3MgQnVpbGRTZXF1ZW5jZShDb25kaXRpb25hbExhbmRpbmdTZXF1ZW5j ZSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIG9wdGlvbnMsIHRvb2wpOgpAQCAtMjcwLDYgKzI0 MSwzOCBAQCBjbGFzcyBBYnN0cmFjdFBhdGNoUHJvY2Vzc2luZ0NvbW1hbmQoQ29tbWFuZCk6CiAg ICAgICAgICAgICBzZWxmLl9wcm9jZXNzX3BhdGNoKHBhdGNoLCBvcHRpb25zLCBhcmdzLCB0b29s KQogCiAKK2NsYXNzIENoZWNrU3R5bGVTZXF1ZW5jZShMYW5kaW5nU2VxdWVuY2UpOgorICAgIGRl ZiBfX2luaXRfXyhzZWxmLCBwYXRjaCwgb3B0aW9ucywgdG9vbCk6CisgICAgICAgIENvbmRpdGlv bmFsTGFuZGluZ1NlcXVlbmNlLl9faW5pdF9fKHNlbGYsIHBhdGNoLCBvcHRpb25zLCB0b29sKQor CisgICAgZGVmIHJ1bihzZWxmKToKKyAgICAgICAgc2VsZi5jbGVhbigpCisgICAgICAgIHNlbGYu dXBkYXRlKCkKKyAgICAgICAgc2VsZi5hcHBseV9wYXRjaCgpCisgICAgICAgIHNlbGYuYnVpbGQo KQorCisgICAgZGVmIGJ1aWxkKHNlbGYpOgorICAgICAgICAjIEluc3RlYWQgb2YgYnVpbGRpbmcs IHdlIGNoZWNrIHN0eWxlLgorICAgICAgICBXZWJLaXRMYW5kaW5nU2NyaXB0cy5ydW5fd2Via2l0 X3NjcmlwdCgiY2hlY2std2Via2l0LXN0eWxlIikKKworCitjbGFzcyBDaGVja1N0eWxlKEFic3Ry YWN0UGF0Y2hQcm9jZXNzaW5nQ29tbWFuZCk6CisgICAgbmFtZSA9ICJjaGVjay1zdHlsZSIKKyAg ICBkZWYgX19pbml0X18oc2VsZik6CisgICAgICAgIG9wdGlvbnMgPSBXZWJLaXRMYW5kaW5nU2Ny aXB0cy5jbGVhbmluZ19vcHRpb25zKCkKKyAgICAgICAgQWJzdHJhY3RQYXRjaFByb2Nlc3NpbmdD b21tYW5kLl9faW5pdF9fKHNlbGYsICJSdW5zIGNoZWNrLXdlYmtpdC1zdHlsZSBvbiB0aGUgc3Bl Y2lmaWVkIGF0dGFjaG1lbnRzLiIsICJBVFRBQ0hNRU5UX0lEIFtBVFRBQ0hNRU5UX0lEU10iLCBv cHRpb25zKQorCisgICAgZGVmIF9mZXRjaF9saXN0X29mX3BhdGNoZXNfdG9fcHJvY2VzcyhzZWxm LCBvcHRpb25zLCBhcmdzLCB0b29sKToKKyAgICAgICAgcmV0dXJuIG1hcChsYW1iZGEgcGF0Y2hf aWQ6IHRvb2wuYnVncy5mZXRjaF9hdHRhY2htZW50KHBhdGNoX2lkKSwgYXJncykKKworICAgIGRl ZiBfcHJlcGFyZV90b19wcm9jZXNzKHNlbGYsIG9wdGlvbnMsIGFyZ3MsIHRvb2wpOgorICAgICAg ICBwYXNzCisKKyAgICBkZWYgX3Byb2Nlc3NfcGF0Y2goc2VsZiwgcGF0Y2gsIG9wdGlvbnMsIGFy Z3MsIHRvb2wpOgorICAgICAgICBzZXF1ZW5jZSA9IENoZWNrU3R5bGVTZXF1ZW5jZShwYXRjaCwg b3B0aW9ucywgdG9vbCkKKyAgICAgICAgc2VxdWVuY2UucnVuX2FuZF9oYW5kbGVfZXJyb3JzKCkK KworCiBjbGFzcyBCdWlsZEF0dGFjaG1lbnRTZXF1ZW5jZShMYW5kaW5nU2VxdWVuY2UpOgogICAg IGRlZiBfX2luaXRfXyhzZWxmLCBwYXRjaCwgb3B0aW9ucywgdG9vbCk6CiAgICAgICAgIExhbmRp bmdTZXF1ZW5jZS5fX2luaXRfXyhzZWxmLCBwYXRjaCwgb3B0aW9ucywgdG9vbCkK