31747 2009-11-20 14:39:15 -0800 Chromium Linux: Limit the stroke width and mitre limit 2009-11-23 14:13:53 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 agl webkit-unassigned dimich oldest_to_newest 165457 0 agl 2009-11-20 14:39:15 -0800 Chromium Linux: Limit the stroke width and mitre limit that we'll pass into Skia to avoid overflowing Skia's uint16_t glyph widths. 165458 1 43614 agl 2009-11-20 14:40:54 -0800 Created attachment 43614 patch 165570 2 dimich 2009-11-20 22:16:05 -0800 It'd be useful to document in the bug and/or comment why did you use 512 and 256. If this is a random choice, that's fine but it's useful to put it in writing so the next person reading the code does not have to guess if there is some magic meaning behind those. Or if there is magic meaning, it's even more useful to document :-) 165890 3 43723 agl 2009-11-23 11:32:48 -0800 Created attachment 43723 patch Good point about the comment. Have added one. 165895 4 43723 dimich 2009-11-23 11:57:52 -0800 Comment on attachment 43723 patch r=me 165932 5 agl 2009-11-23 14:13:53 -0800 r51319 43614 2009-11-20 14:40:54 -0800 2009-11-23 11:32:48 -0800 patch patch text/plain 2233 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjlkODhlYS4uZTFjODYxZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMS0yMCAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hyb21pdW0gTGludXg6IExpbWl0IHRoZSBzdHJva2Ugd2lkdGggYW5kIG1p dHJlIGxpbWl0LgorCisgICAgICAgIExpbWl0IHRoZSBzdHJva2Ugd2lkdGggYW5kIG1pdHJlIGxp bWl0IHRoYXQgd2UnbGwgcGFzcyBpbnRvIFNraWEgdG8KKyAgICAgICAgYXZvaWQgb3ZlcmZsb3dp bmcgU2tpYSdzIHVpbnQxNl90IGdseXBoIHdpZHRocy4KKworICAgICAgICBodHRwOi8vY29kZS5n b29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0yODI1MAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE3NDcKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChz Y2FsYXJCb3VuZCk6CisgICAgICAgIChQbGF0Zm9ybUNvbnRleHRTa2lhOjpzZXR1cFBhaW50Rm9y U3Ryb2tpbmcpOgorCiAyMDA5LTExLTIwICBZYWVsIEFoYXJvbiAgPHlhZWwuYWhhcm9uQG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4K ZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRl eHRTa2lhLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRl eHRTa2lhLmNwcAppbmRleCBhMDc5ZGEwLi41MGM1ZjBhIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCkBAIC0zNDMs NiArMzQzLDE1IEBAIHZvaWQgUGxhdGZvcm1Db250ZXh0U2tpYTo6c2V0dXBQYWludEZvckZpbGxp bmcoU2tQYWludCogcGFpbnQpIGNvbnN0CiAgICAgcGFpbnQtPnNldFNoYWRlcihtX3N0YXRlLT5t X2ZpbGxTaGFkZXIpOwogfQogCitzdGF0aWMgU2tTY2FsYXIgc2NhbGFyQm91bmQoU2tTY2FsYXIg diwgU2tTY2FsYXIgbWluLCBTa1NjYWxhciBtYXgpCit7CisgICAgaWYgKHYgPCBtaW4pCisgICAg ICAgIHJldHVybiBtaW47CisgICAgaWYgKHYgPiBtYXgpCisgICAgICAgIHJldHVybiBtYXg7Cisg ICAgcmV0dXJuIHY7Cit9CisKIGZsb2F0IFBsYXRmb3JtQ29udGV4dFNraWE6OnNldHVwUGFpbnRG b3JTdHJva2luZyhTa1BhaW50KiBwYWludCwgU2tSZWN0KiByZWN0LCBpbnQgbGVuZ3RoKSBjb25z dAogewogICAgIHNldHVwUGFpbnRDb21tb24ocGFpbnQpOwpAQCAtMzUxLDEwICszNjAsMTAgQEAg ZmxvYXQgUGxhdGZvcm1Db250ZXh0U2tpYTo6c2V0dXBQYWludEZvclN0cm9raW5nKFNrUGFpbnQq IHBhaW50LCBTa1JlY3QqIHJlY3QsIGkKICAgICBwYWludC0+c2V0Q29sb3IobV9zdGF0ZS0+YXBw bHlBbHBoYShtX3N0YXRlLT5tX3N0cm9rZUNvbG9yKSk7CiAgICAgcGFpbnQtPnNldFNoYWRlciht X3N0YXRlLT5tX3N0cm9rZVNoYWRlcik7CiAgICAgcGFpbnQtPnNldFN0eWxlKFNrUGFpbnQ6OmtT dHJva2VfU3R5bGUpOwotICAgIHBhaW50LT5zZXRTdHJva2VXaWR0aChTa0Zsb2F0VG9TY2FsYXIo d2lkdGgpKTsKKyAgICBwYWludC0+c2V0U3Ryb2tlV2lkdGgoc2NhbGFyQm91bmQoU2tGbG9hdFRv U2NhbGFyKHdpZHRoKSwgMCwgNTEyKSk7CiAgICAgcGFpbnQtPnNldFN0cm9rZUNhcChtX3N0YXRl LT5tX2xpbmVDYXApOwogICAgIHBhaW50LT5zZXRTdHJva2VKb2luKG1fc3RhdGUtPm1fbGluZUpv aW4pOwotICAgIHBhaW50LT5zZXRTdHJva2VNaXRlcihTa0Zsb2F0VG9TY2FsYXIobV9zdGF0ZS0+ bV9taXRlckxpbWl0KSk7CisgICAgcGFpbnQtPnNldFN0cm9rZU1pdGVyKHNjYWxhckJvdW5kKFNr RmxvYXRUb1NjYWxhcihtX3N0YXRlLT5tX21pdGVyTGltaXQpLCAwLCAyNTYpKTsKIAogICAgIGlm IChtX3N0YXRlLT5tX2Rhc2gpCiAgICAgICAgIHBhaW50LT5zZXRQYXRoRWZmZWN0KG1fc3RhdGUt Pm1fZGFzaCk7Cg== 43723 2009-11-23 11:32:48 -0800 2009-11-23 11:57:51 -0800 patch patch text/plain 2406 agl ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MjYwMjkxNS4uZGNkMWJmZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAwOS0xMS0yMSAgQWRhbSBMYW5nbGV5 ICA8YWdsQGdvb2dsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQ2hyb21pdW0gTGludXg6IExpbWl0IHRoZSBzdHJva2Ugd2lkdGggYW5kIG1p dHJlIGxpbWl0LgorCisgICAgICAgIExpbWl0IHRoZSBzdHJva2Ugd2lkdGggYW5kIG1pdHJlIGxp bWl0IHRoYXQgd2UnbGwgcGFzcyBpbnRvIFNraWEgdG8KKyAgICAgICAgYXZvaWQgb3ZlcmZsb3dp bmcgU2tpYSdzIHVpbnQxNl90IGdseXBoIHdpZHRocy4KKworICAgICAgICBodHRwOi8vY29kZS5n b29nbGUuY29tL3AvY2hyb21pdW0vaXNzdWVzL2RldGFpbD9pZD0yODI1MAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzE3NDcKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHA6CisgICAgICAgIChz Y2FsYXJCb3VuZCk6CisgICAgICAgIChQbGF0Zm9ybUNvbnRleHRTa2lhOjpzZXR1cFBhaW50Rm9y U3Ryb2tpbmcpOgorCiAyMDA5LTExLTIxICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhbiBCZXJuc3RlaW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvUGxhdGZvcm1Db250ZXh0U2tpYS5jcHAK aW5kZXggYTA3OWRhMC4uZGZmZmEwZCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFw aGljcy9za2lhL1BsYXRmb3JtQ29udGV4dFNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3Mvc2tpYS9QbGF0Zm9ybUNvbnRleHRTa2lhLmNwcApAQCAtMzQzLDYgKzM0MywxNSBA QCB2b2lkIFBsYXRmb3JtQ29udGV4dFNraWE6OnNldHVwUGFpbnRGb3JGaWxsaW5nKFNrUGFpbnQq IHBhaW50KSBjb25zdAogICAgIHBhaW50LT5zZXRTaGFkZXIobV9zdGF0ZS0+bV9maWxsU2hhZGVy KTsKIH0KIAorc3RhdGljIFNrU2NhbGFyIHNjYWxhckJvdW5kKFNrU2NhbGFyIHYsIFNrU2NhbGFy IG1pbiwgU2tTY2FsYXIgbWF4KQoreworICAgIGlmICh2IDwgbWluKQorICAgICAgICByZXR1cm4g bWluOworICAgIGlmICh2ID4gbWF4KQorICAgICAgICByZXR1cm4gbWF4OworICAgIHJldHVybiB2 OworfQorCiBmbG9hdCBQbGF0Zm9ybUNvbnRleHRTa2lhOjpzZXR1cFBhaW50Rm9yU3Ryb2tpbmco U2tQYWludCogcGFpbnQsIFNrUmVjdCogcmVjdCwgaW50IGxlbmd0aCkgY29uc3QKIHsKICAgICBz ZXR1cFBhaW50Q29tbW9uKHBhaW50KTsKQEAgLTM1MSwxMCArMzYwLDEzIEBAIGZsb2F0IFBsYXRm b3JtQ29udGV4dFNraWE6OnNldHVwUGFpbnRGb3JTdHJva2luZyhTa1BhaW50KiBwYWludCwgU2tS ZWN0KiByZWN0LCBpCiAgICAgcGFpbnQtPnNldENvbG9yKG1fc3RhdGUtPmFwcGx5QWxwaGEobV9z dGF0ZS0+bV9zdHJva2VDb2xvcikpOwogICAgIHBhaW50LT5zZXRTaGFkZXIobV9zdGF0ZS0+bV9z dHJva2VTaGFkZXIpOwogICAgIHBhaW50LT5zZXRTdHlsZShTa1BhaW50OjprU3Ryb2tlX1N0eWxl KTsKLSAgICBwYWludC0+c2V0U3Ryb2tlV2lkdGgoU2tGbG9hdFRvU2NhbGFyKHdpZHRoKSk7Cisg ICAgLy8gVGhlIGxpbWl0cyBoZXJlICg1MTIgYW5kIDI1Nikgd2VyZSBtYWRlIHVwIGJ1dCBhcmUg aG9wZWZ1bGx5IGxhcmdlCisgICAgLy8gZW5vdWdoIHRvIGJlIHJlYXNvbmFibGUuIFRoZXkgYXJl LCBlbXBpcmljYWxseSwgc21hbGwgZW5vdWdoIG5vdCB0bworICAgIC8vIGNhdXNlIG92ZXJmbG93 cyBpbiBTa2lhLgorICAgIHBhaW50LT5zZXRTdHJva2VXaWR0aChzY2FsYXJCb3VuZChTa0Zsb2F0 VG9TY2FsYXIod2lkdGgpLCAwLCA1MTIpKTsKICAgICBwYWludC0+c2V0U3Ryb2tlQ2FwKG1fc3Rh dGUtPm1fbGluZUNhcCk7CiAgICAgcGFpbnQtPnNldFN0cm9rZUpvaW4obV9zdGF0ZS0+bV9saW5l Sm9pbik7Ci0gICAgcGFpbnQtPnNldFN0cm9rZU1pdGVyKFNrRmxvYXRUb1NjYWxhcihtX3N0YXRl LT5tX21pdGVyTGltaXQpKTsKKyAgICBwYWludC0+c2V0U3Ryb2tlTWl0ZXIoc2NhbGFyQm91bmQo U2tGbG9hdFRvU2NhbGFyKG1fc3RhdGUtPm1fbWl0ZXJMaW1pdCksIDAsIDI1NikpOwogCiAgICAg aWYgKG1fc3RhdGUtPm1fZGFzaCkKICAgICAgICAgcGFpbnQtPnNldFBhdGhFZmZlY3QobV9zdGF0 ZS0+bV9kYXNoKTsK