31732 2009-11-20 11:26:21 -0800 Web Inspector: Cannot select elements within iframes with the magnifying glass. 2010-04-09 06:45:08 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 jimmy pfeldman bweinstein dbates joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 165376 0 jimmy 2009-11-20 11:26:21 -0800 When you attempt to select a form text input or textarea element with the Web Inspector's magnifying glass tool, it incorrectly selects the body of the page. This behavior does not seem to occur for other form elements like selects and buttons. 210514 1 jimmy 2010-04-08 18:01:56 -0700 I discovered today the the same thing will happen for elements inside iframes. If you activate the magnifying glass tool and hover an element which is inside an iframe, it is correctly highlighted with a blue box, but clicking on it will select the parent frame's body tag in the inspector. 210615 2 52945 pfeldman 2010-04-09 00:42:50 -0700 Created attachment 52945 [PATCH] Proposed fix. 210683 3 52945 yurys 2010-04-09 04:22:41 -0700 Comment on attachment 52945 [PATCH] Proposed fix. > void InspectorController::inspect(Node* node) > { > - if (!canPassNodeToJavaScript(node) || !enabled()) > - return; > - If (!enabled) check should be preserved. r- for that Would be really nice if we started accompanying Web Inspector changes with tests. 210700 4 52952 pfeldman 2010-04-09 06:20:44 -0700 Created attachment 52952 [PATCH] Proposed fix. In fact I needed to fix more to make it work. 210702 5 pfeldman 2010-04-09 06:45:08 -0700 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/inspector/InspectorController.cpp M WebCore/inspector/InspectorController.h M WebCore/page/EventHandler.cpp Committed r57337 52945 2010-04-09 00:42:50 -0700 2010-04-09 06:20:44 -0700 [PATCH] Proposed fix. inspect_iframe text/plain 1655 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjY3NzljMC4uNjQxNzhiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0wOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW5ub3Qgc2VsZWN0IGVsZW1lbnRz IHdpdGhpbiBpZnJhbWVzIHdpdGggdGhlIG1hZ25pZnlpbmcgZ2xhc3MuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzMyCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JDb250cm9sbGVyOjppbnNwZWN0KToKKwogMjAxMC0wNC0wOCAgUGF2ZWwgRmVsZG1hbiAg PHBmZWxkbWFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBZdXJ5IFNlbWlr aGF0c2t5LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxl ci5jcHAgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcAppbmRleCA4 OTMyY2RkLi41MWVkNWMzIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JD b250cm9sbGVyLmNwcAorKysgYi9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250cm9sbGVy LmNwcApAQCAtMjI1LDIyICsyMjUsOCBAQCB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnNldFNl dHRpbmcoY29uc3QgU3RyaW5nJiBrZXksIGNvbnN0IFN0cmluZyYgdmFsdWUpCiAgICAgbV9jbGll bnQtPnN0b3JlU2V0dGluZyhrZXksIHZhbHVlKTsKIH0KIAotLy8gVHJ5aW5nIHRvIGluc3BlY3Qg c29tZXRoaW5nIGluIGEgZnJhbWUgd2l0aCBKYXZhU2NyaXB0IGRpc2FibGVkIHdvdWxkIGxhdGVy IGxlYWQgdG8KLS8vIGNyYXNoZXMgdHJ5aW5nIHRvIGNyZWF0ZSBKYXZhU2NyaXB0IHdyYXBwZXJz LiBTb21lIGRheSB3ZSBjb3VsZCBmaXggdGhpcyBpc3N1ZSwgYnV0Ci0vLyBmb3Igbm93IHByZXZl bnQgY3Jhc2hlcyBoZXJlIGJ5IG5ldmVyIHRhcmdldGluZyBhIG5vZGUgaW4gc3VjaCBhIGZyYW1l Lgotc3RhdGljIGJvb2wgY2FuUGFzc05vZGVUb0phdmFTY3JpcHQoTm9kZSogbm9kZSkKLXsKLSAg ICBpZiAoIW5vZGUpCi0gICAgICAgIHJldHVybiBmYWxzZTsKLSAgICBGcmFtZSogZnJhbWUgPSBu b2RlLT5kb2N1bWVudCgpLT5mcmFtZSgpOwotICAgIHJldHVybiBmcmFtZSAmJiBmcmFtZS0+c2Ny aXB0KCktPmNhbkV4ZWN1dGVTY3JpcHRzKE5vdEFib3V0VG9FeGVjdXRlU2NyaXB0KTsKLX0KLQog dm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjppbnNwZWN0KE5vZGUqIG5vZGUpCiB7Ci0gICAgaWYg KCFjYW5QYXNzTm9kZVRvSmF2YVNjcmlwdChub2RlKSB8fCAhZW5hYmxlZCgpKQotICAgICAgICBy ZXR1cm47Ci0KICAgICBzaG93KCk7CiAKICAgICBpZiAobm9kZS0+bm9kZVR5cGUoKSAhPSBOb2Rl OjpFTEVNRU5UX05PREUgJiYgbm9kZS0+bm9kZVR5cGUoKSAhPSBOb2RlOjpET0NVTUVOVF9OT0RF KQo= 52952 2010-04-09 06:20:44 -0700 2010-04-09 06:24:44 -0700 [PATCH] Proposed fix. inspect_iframe text/plain 3705 pfeldman ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZjY3NzljMC4uMTRlM2I2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0wNC0wOSAgUGF2ZWwgRmVsZG1h biAgPHBmZWxkbWFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBDYW5ub3Qgc2VsZWN0IGVsZW1lbnRz IHdpdGhpbiBpZnJhbWVzIHdpdGggdGhlIG1hZ25pZnlpbmcgZ2xhc3MuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTMxNzMyCisKKyAgICAgICAgKiBp bnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpJbnNw ZWN0b3JDb250cm9sbGVyOjppbnNwZWN0KToKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckNv bnRyb2xsZXI6OmhhbmRsZU1vdXNlUHJlc3MpOgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0 b3JDb250cm9sbGVyLmg6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRsZXIuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6RXZlbnRIYW5kbGVyOjpoYW5kbGVNb3VzZVByZXNzRXZlbnQpOgorCiAyMDEw LTA0LTA4ICBQYXZlbCBGZWxkbWFuICA8cGZlbGRtYW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JDb250cm9sbGVyLmNwcCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3Rv ckNvbnRyb2xsZXIuY3BwCmluZGV4IDg5MzJjZGQuLjNmMDQ5ZjUgMTAwNjQ0Ci0tLSBhL1dlYkNv cmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCisrKyBiL1dlYkNvcmUvaW5zcGVj dG9yL0luc3BlY3RvckNvbnRyb2xsZXIuY3BwCkBAIC0yMjUsMjAgKzIyNSw5IEBAIHZvaWQgSW5z cGVjdG9yQ29udHJvbGxlcjo6c2V0U2V0dGluZyhjb25zdCBTdHJpbmcmIGtleSwgY29uc3QgU3Ry aW5nJiB2YWx1ZSkKICAgICBtX2NsaWVudC0+c3RvcmVTZXR0aW5nKGtleSwgdmFsdWUpOwogfQog Ci0vLyBUcnlpbmcgdG8gaW5zcGVjdCBzb21ldGhpbmcgaW4gYSBmcmFtZSB3aXRoIEphdmFTY3Jp cHQgZGlzYWJsZWQgd291bGQgbGF0ZXIgbGVhZCB0bwotLy8gY3Jhc2hlcyB0cnlpbmcgdG8gY3Jl YXRlIEphdmFTY3JpcHQgd3JhcHBlcnMuIFNvbWUgZGF5IHdlIGNvdWxkIGZpeCB0aGlzIGlzc3Vl LCBidXQKLS8vIGZvciBub3cgcHJldmVudCBjcmFzaGVzIGhlcmUgYnkgbmV2ZXIgdGFyZ2V0aW5n IGEgbm9kZSBpbiBzdWNoIGEgZnJhbWUuCi1zdGF0aWMgYm9vbCBjYW5QYXNzTm9kZVRvSmF2YVNj cmlwdChOb2RlKiBub2RlKQotewotICAgIGlmICghbm9kZSkKLSAgICAgICAgcmV0dXJuIGZhbHNl OwotICAgIEZyYW1lKiBmcmFtZSA9IG5vZGUtPmRvY3VtZW50KCktPmZyYW1lKCk7Ci0gICAgcmV0 dXJuIGZyYW1lICYmIGZyYW1lLT5zY3JpcHQoKS0+Y2FuRXhlY3V0ZVNjcmlwdHMoTm90QWJvdXRU b0V4ZWN1dGVTY3JpcHQpOwotfQotCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6Omluc3BlY3Qo Tm9kZSogbm9kZSkKIHsKLSAgICBpZiAoIWNhblBhc3NOb2RlVG9KYXZhU2NyaXB0KG5vZGUpIHx8 ICFlbmFibGVkKCkpCisgICAgaWYgKCFlbmFibGVkKCkpCiAgICAgICAgIHJldHVybjsKIAogICAg IHNob3coKTsKQEAgLTM4NSwxOCArMzc0LDE4IEBAIHZvaWQgSW5zcGVjdG9yQ29udHJvbGxlcjo6 bW91c2VEaWRNb3ZlT3ZlckVsZW1lbnQoY29uc3QgSGl0VGVzdFJlc3VsdCYgcmVzdWx0LCB1CiAg ICAgICAgIGhpZ2hsaWdodChub2RlKTsKIH0KIAotdm9pZCBJbnNwZWN0b3JDb250cm9sbGVyOjpo YW5kbGVNb3VzZVByZXNzT25Ob2RlKE5vZGUqIG5vZGUpCit2b2lkIEluc3BlY3RvckNvbnRyb2xs ZXI6OmhhbmRsZU1vdXNlUHJlc3MoKQogewogICAgIGlmICghZW5hYmxlZCgpKQogICAgICAgICBy ZXR1cm47CiAKICAgICBBU1NFUlQobV9zZWFyY2hpbmdGb3JOb2RlKTsKLSAgICBBU1NFUlQobm9k ZSk7Ci0gICAgaWYgKCFub2RlKQorICAgIGlmICghbV9oaWdobGlnaHRlZE5vZGUpCiAgICAgICAg IHJldHVybjsKIAorICAgIFJlZlB0cjxOb2RlPiBub2RlID0gbV9oaWdobGlnaHRlZE5vZGU7CiAg ICAgc2V0U2VhcmNoaW5nRm9yTm9kZShmYWxzZSk7Ci0gICAgaW5zcGVjdChub2RlKTsKKyAgICBp bnNwZWN0KG5vZGUuZ2V0KCkpOwogfQogCiB2b2lkIEluc3BlY3RvckNvbnRyb2xsZXI6OnNldElu c3BlY3RvckZyb250ZW5kQ2xpZW50KFBhc3NPd25QdHI8SW5zcGVjdG9yRnJvbnRlbmRDbGllbnQ+ IGNsaWVudCkKZGlmZiAtLWdpdCBhL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xs ZXIuaCBiL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckNvbnRyb2xsZXIuaAppbmRleCA0NGQ4 ODkwLi5mNDdjMDQ0IDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JDb250 cm9sbGVyLmgKKysrIGIvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yQ29udHJvbGxlci5oCkBA IC0xNDMsNyArMTQzLDcgQEAgcHVibGljOgogCiAgICAgYm9vbCBzZWFyY2hpbmdGb3JOb2RlSW5Q YWdlKCkgY29uc3QgeyByZXR1cm4gbV9zZWFyY2hpbmdGb3JOb2RlOyB9CiAgICAgdm9pZCBtb3Vz ZURpZE1vdmVPdmVyRWxlbWVudChjb25zdCBIaXRUZXN0UmVzdWx0JiwgdW5zaWduZWQgbW9kaWZp ZXJGbGFncyk7Ci0gICAgdm9pZCBoYW5kbGVNb3VzZVByZXNzT25Ob2RlKE5vZGUqKTsKKyAgICB2 b2lkIGhhbmRsZU1vdXNlUHJlc3MoKTsKIAogICAgIHZvaWQgc2V0SW5zcGVjdG9yRnJvbnRlbmRD bGllbnQoUGFzc093blB0cjxJbnNwZWN0b3JGcm9udGVuZENsaWVudD4gY2xpZW50KTsKICAgICBi b29sIGhhc0luc3BlY3RvckZyb250ZW5kQ2xpZW50KCkgY29uc3QgeyByZXR1cm4gbV9pbnNwZWN0 b3JGcm9udGVuZENsaWVudDsgfQpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxl ci5jcHAgYi9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAppbmRleCA4NGI2MzE1Li40Mzkz OWI4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAorKysgYi9XZWJD b3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcApAQCAtMTIwNCw3ICsxMjA0LDcgQEAgYm9vbCBFdmVu dEhhbmRsZXI6OmhhbmRsZU1vdXNlUHJlc3NFdmVudChjb25zdCBQbGF0Zm9ybU1vdXNlRXZlbnQm IG1vdXNlRXZlbnQpCiAgICAgaWYgKFBhZ2UqIHBhZ2UgPSBtX2ZyYW1lLT5wYWdlKCkpIHsKICAg ICAgICAgSW5zcGVjdG9yQ29udHJvbGxlciogaW5zcGVjdG9yID0gcGFnZS0+aW5zcGVjdG9yQ29u dHJvbGxlcigpOwogICAgICAgICBpZiAoaW5zcGVjdG9yICYmIGluc3BlY3Rvci0+ZW5hYmxlZCgp ICYmIGluc3BlY3Rvci0+c2VhcmNoaW5nRm9yTm9kZUluUGFnZSgpKSB7Ci0gICAgICAgICAgICBp bnNwZWN0b3ItPmhhbmRsZU1vdXNlUHJlc3NPbk5vZGUobV9tb3VzZVByZXNzTm9kZS5nZXQoKSk7 CisgICAgICAgICAgICBpbnNwZWN0b3ItPmhhbmRsZU1vdXNlUHJlc3MoKTsKICAgICAgICAgICAg IGludmFsaWRhdGVDbGljaygpOwogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAgICAgICAgIH0K